From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: Chaoyong He <chaoyong.he@corigine.com>,
dev@dpdk.org, oss-drivers@corigine.com,
James Hershaw <james.hershaw@corigine.com>
Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header
Date: Wed, 21 Sep 2022 09:19:08 +0200 [thread overview]
Message-ID: <Yyq67COMvEQTh6GA@oden.dyn.berto.se> (raw)
In-Reply-To: <12848fb2-4957-1425-ea4e-0e4f62f13024@xilinx.com>
Hello Ferruh,
On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote:
> Instead of changing the log content and API with same patch, it is
> better to have them separate.
I agree.
>
> I prefer to convert them to proper log API first, and later fix the content
> of the log (to not update a line with wrong call).
> But order of patch preference is a soft one, if somehow other-way around
> (first fix the log content, later the API) makes your life easier, I am OK
> to go with that too (as long as both issues are fixed).
In principle I agree with you here as well. In this case it would make
our life easier if we could do it the other way around. Reason being the
patch to convert the NFP PMD to the log API touch most files in the
driver and is at the tail of the 50+ patches we have in our internal
queue trying to get out.
While it would be somewhat OK to post that patch separately I fear it
would create conflicts with the other patches in our queue. So I thin
either we drop this patch now and we pick it up at the end of our queue,
or we take this as is now. My preference would be to take it now, but
I'm not feeling strongly about it.
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-09-21 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 5:39 Chaoyong He
2022-09-20 9:58 ` Niklas Söderlund
2022-09-20 17:33 ` Ferruh Yigit
2022-09-20 17:51 ` Niklas Söderlund
2022-09-20 18:01 ` Ferruh Yigit
2022-09-21 7:19 ` Niklas Söderlund [this message]
2022-09-21 8:09 ` Ferruh Yigit
2022-09-21 8:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyq67COMvEQTh6GA@oden.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=james.hershaw@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).