From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E689A034C; Wed, 21 Sep 2022 09:19:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DB8F40697; Wed, 21 Sep 2022 09:19:19 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2125.outbound.protection.outlook.com [40.107.96.125]) by mails.dpdk.org (Postfix) with ESMTP id EA0034014F for ; Wed, 21 Sep 2022 09:19:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a46yr09nuVGVTrLHSR3LWjXYWDrOS8wVzt5avmgt53fb1BqDv4vLePGFpcK8ZHDp9B6YbZ53VsW80lh5Z+F3+rbkE+j8tvISE1rTWWsjvMMk1PHj3P1JQostbvSz3788N1fbGRyC3XFs7p3lxSfgLthLRAiqUq6N1BTiNCG5eN5UwekHp3xPrIYQDhLWERhAWNASOboa2FmAcVgMqDIcUzq+fk2/I/hM786mmvxJDkwwqFLLNQuuIRtkikE1q+SOF34xsP6T+KbfnQ0ioMvhaZAF4Tv+SmcNC9KI3AU7jZOCXMFbjsQ6FbS+LdTiBIRCtmGt0BR+lFVddwsqXVd4Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pyJfVTPCC0YbxpKoklhFomr5wu334qnmChG+ErFnCQ8=; b=gvofjjsX5SV2K5LCipepmzzTnLM22yA2NCuNdsVgNGl/6KROdxtgY1EoL1y7Ocsm4f08BulE4XDJHu/wT/i4S0YA4leqVMuGUW9Z4iUWhqGRl0Zhq0A9H7CWcl0tZWICGVDYjvp1y9OZ6XbEnpuL+wP8DKbHKYxItL3bU6xxzLHGe+uMfJePpJ88naTwkA2Q24+eShgWB4Uy4rTRbvtWz97NpTedeVAzf/vX0PwF/v7NuPOsZOt6JaciX4OA9kWFpLN6rqSeD7n67sFSi9f+sUr/wz0zgRBsznwky1qobZdapme+Rn7jraWwM6jL5PaYh5bXip87pSn6tuXIuBeTLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pyJfVTPCC0YbxpKoklhFomr5wu334qnmChG+ErFnCQ8=; b=rEZzIdetuxRVVF18wKWU/lv8tr5by/naZo/qGDHsIXgYpKXSxQ2id8n1AHD6wBmUNtd+18gkz4BEDq1B7qH4tZUVPz8wCmT4eBt1e+A6uiFybX2MGOznod2Iy3Cvi9ubv7ka+2QxDC4k1TRYCTR6tWvnPat8W4XckBUHrJqb56w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by MN2PR13MB3888.namprd13.prod.outlook.com (2603:10b6:208:19e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 07:19:14 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1%5]) with mapi id 15.20.5654.014; Wed, 21 Sep 2022 07:19:14 +0000 Date: Wed, 21 Sep 2022 09:19:08 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Ferruh Yigit Cc: Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, James Hershaw Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header Message-ID: References: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> <12848fb2-4957-1425-ea4e-0e4f62f13024@xilinx.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <12848fb2-4957-1425-ea4e-0e4f62f13024@xilinx.com> X-ClientProxiedBy: GV3P280CA0072.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::7) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR13MB4431:EE_|MN2PR13MB3888:EE_ X-MS-Office365-Filtering-Correlation-Id: e22fe457-5ad8-436d-8186-08da9ba19671 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bxQ6cWZt886d3MwKNveF/18wUiLmPzuj5pMUbImpL4VpYVtJRm7Sfua7qWrf+Nfb5F5WJ8DTNLrH9jcAW9lpW0fb5H5DxayVH0yssTZNMJW/8KaBmJ3VbR/NPJMiQB2NpusdAfy24b674Qf1OL84vQFSryrobI5OpFtHvQgBNIGsYrxXotehrqkC7lFMKx3L77GoClerg8ZZetUKOgFyU9IWwEmTIPgQ3AO5DJZeiiYNLrDCHodhWtKYOiCiZrKzzVIeunoqrrOun11ry6E34IvYPJCaGhgdludDmwHY2h/6Psf2Eiu6Ebx08xa4xqLmNkmXGGDESvNvwey3H8yc60HA71JleYy1pqr2w6xCb/W5V93zVAILaUyI9dBrAencQoVm2qPrDSlSKR/r7pBc8FOLWDOPafF+ugOaPS09c455Ol0B/0ZYMQcpbdhbY0JOF1/4Xyjy+wwhPowSdSjDA7s2qMcyC+OJooAWlna7V+z0sNKaL1uMlmjXvx3TIbjNxiLXw/wZotzgka3dzR+AJK32G618roDOWkhgpbr2ubmv/gNrNSdKIfzrkpazKuDjHBAaMKcpPafsOXRYZag+NHNc00LzAg1h0wTwBclrvjiVgTgq+1VaHiMKxkx2zJV2VzJ0XitDYoFeZgwzGB5yW2f71+jZvor2bI9JLE53tlxBeXkIZRsLgPuiVRhaOMtjJE3w7/xHsPScP6oY60fSmYceTHPvU/yRPJvYPpYFIArezqwK2h7wFEoR8YO/o7ZCU/Qplhh6hmUfAk8MhoItAEreW1nMGT20/eHbOjCYcl+ah+yR9CCDqTDuKZdH4fHH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(366004)(39840400004)(451199015)(83380400001)(2906002)(478600001)(54906003)(8676002)(6916009)(4326008)(66476007)(66556008)(316002)(66946007)(6486002)(5660300002)(41300700001)(6666004)(107886003)(86362001)(8936002)(6506007)(52116002)(53546011)(9686003)(66574015)(26005)(6512007)(186003)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?PtdXcu6GoNI6TZRqNS2WwY3fmvwQ3u/MXQshkc7tlegi4o1kBia00IevrO?= =?iso-8859-1?Q?AVyuRQ45RQaxibJaQ7u64YILcpDwByctBR7LWrhWTY+8iv9xoZ6C1JR9mE?= =?iso-8859-1?Q?d/es30ovKX09ukI5AfQnaPG7OC8mrrJDzqgGicDgew6mbmAXUMNHbKcUrd?= =?iso-8859-1?Q?PMHvfbNigEeeLJC6byv9EzSlYJ5hAdu0thBLv+25oQMatRIiZE4DzdOcte?= =?iso-8859-1?Q?Bm8jR2TN1RgGgF32xkTio9atobrtnk/itDk4QDrZ6x5Vlg0KjJZ9eZONcE?= =?iso-8859-1?Q?3oDx14xaf1yBgspL3LQgGPb8fmSjrCZTDN5U4rc8Q97s6i/0XqPTn2mX/b?= =?iso-8859-1?Q?yKCqCQ2mRIquhWBwc3RxNLeKmRKNSeSXOLnBD1Kv/9ll4EtXx7LdI1gLpX?= =?iso-8859-1?Q?finmOtDQCaXZm0hgrhhZDttNDBG43DBgVaJBkCxySS45cXEAXCKmupTLbq?= =?iso-8859-1?Q?5UIhbKWlwAZmhoFT3WtvumR9Y31iDkmCpPIyF++8WR1Eh/SzPL+R687XGe?= =?iso-8859-1?Q?NyoJuQl8yQufhfr7SqJHNkd9f3HwOTAEUqVGW2EpiiF9gFVdJXrKz7IBNk?= =?iso-8859-1?Q?f6mh3CbhJI/mOZrBpSti3s+i3hItIQTXSYKTLGpNR2KgxEiAgpQcC9UpM7?= =?iso-8859-1?Q?b03QFwQvp0JBVgbbH22uPWG0ZvCQz9JdP3aFgoC8pRwa/a9ilPxxp4BeRm?= =?iso-8859-1?Q?ZHkoB3QJjk5kcYaFS8OD/e8WkmcvSmwkkvFJwAJ2AWjHocFsUjdDfLF2tw?= =?iso-8859-1?Q?gyG9qoWx7LeCOqDk6RDsM/YSg//ee2g+bAp8iUBNS7oM2PSncIrMlHPtZp?= =?iso-8859-1?Q?CJ8nv2gjUK3FH+M5p3gbw09JmjlMLWk6kEhMCW0hK88HkrZ5Xpj9c+47nO?= =?iso-8859-1?Q?Z0OLRFUkhFmRgZxCVcUKa2apPiQfFJKFTl/cafGDssASn/P9VHNNxacZ42?= =?iso-8859-1?Q?Ujmz+LYUwYwAIj16HohqsAxYmQvD9czD1hTKIueZi+/3RuLrNa3yaB4y1s?= =?iso-8859-1?Q?CgaZJ8f3fXorpOdrqgXcFa2+cAgW0+L3VOTy5/RXk6/RDtvsW60VMFDQff?= =?iso-8859-1?Q?dB3Tw2pVJX3mkl9NIsKl3YQ2lnz4m4HLcuQ93PQ74m7FcXMz/aRadqer0N?= =?iso-8859-1?Q?2w08gmOqwlGlMdKSnclk1zej3mUITS5rFIUzgoQGF/aMqHeXJ+jFMOVfP6?= =?iso-8859-1?Q?R2lHeM7mWpHX6l57zwBDUrqd+fw/chO4sGumE4INzsSvDep4YkUiqZAit5?= =?iso-8859-1?Q?95wVKW4gAYmIOXZsG62PqdKNkypfk9LKl75dYznnScPIqxtQ7c9Nc813RR?= =?iso-8859-1?Q?1rtGzW89PI7Mm1ZrGUXF3sGUNt6pY9795kIyiy0JQPU6EQ6SORlegtmCJN?= =?iso-8859-1?Q?YrHjBPULnYCDq9CpRds4Imlia31fSvirXOHKGsStTxR0aiGPGBfT/yeZb1?= =?iso-8859-1?Q?jGFdPEw2u/78Enk8PbETSQzdF4U4uHnj+a5pcU69GxrPy1lc+eZ9EIJEIt?= =?iso-8859-1?Q?U02DSmyj8CJ1ZRq+PQGS9CFMFplBHSrma6/fN5cLrjSv1bRqURCDLn6iRy?= =?iso-8859-1?Q?CIOokm47E0hvvC34O6Q6a16aPSkkrKtBotfHFn5cMH/hDRG4lEB3a2z7e7?= =?iso-8859-1?Q?e8q/vqcpCtG6LZheU2cqHq/JQWBsOuiXcwx0k6SiSic0A49OeeUsnj6g?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: e22fe457-5ad8-436d-8186-08da9ba19671 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 07:19:14.3032 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: amvSnxDM+DdFJ6Gf3xlO3ttUcqZJa/odiDJiP8memETXxVRY8Mk95HP+j7umc/rWgnzBNnV5aEAdC0UkcY9Bc8UlDa94zwKV4bLNLTrZ+k0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3888 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ferruh, On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: > Instead of changing the log content and API with same patch, it is > better to have them separate. I agree. > > I prefer to convert them to proper log API first, and later fix the content > of the log (to not update a line with wrong call). > But order of patch preference is a soft one, if somehow other-way around > (first fix the log content, later the API) makes your life easier, I am OK > to go with that too (as long as both issues are fixed). In principle I agree with you here as well. In this case it would make our life easier if we could do it the other way around. Reason being the patch to convert the NFP PMD to the log API touch most files in the driver and is at the tail of the 50+ patches we have in our internal queue trying to get out. While it would be somewhat OK to post that patch separately I fear it would create conflicts with the other patches in our queue. So I thin either we drop this patch now and we pick it up at the end of our queue, or we take this as is now. My preference would be to take it now, but I'm not feeling strongly about it. -- Kind Regards, Niklas Söderlund