From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66879A0093; Fri, 7 Oct 2022 12:30:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 048CA40687; Fri, 7 Oct 2022 12:30:27 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 58AF840042 for ; Fri, 7 Oct 2022 12:30:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665138625; x=1696674625; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=uPjelsIDcEzNA8CXBlCAYoaUBkRuCQJVEH3kaVJutMs=; b=OfPoyEaBmYq7sKVbjvPyQKi0nZ70FXODGpfCLSLjmTDien0i1+WbkGkN u2o+Vp/6UCiHQUH9AtcpF0mxCZj3T+f5ydwO2O4x2+RIUMm+QLw/HJSNi ip/tkW/IUkMEPhAcA2fDn23pfLGDCi7XWIpqd3sJydJMoXCbWqOjTmHzK JKOojZzoVVhoftAY57pDo0P+W/OxujcyWhPzCzumBZnlNJsOK5lSxvzwz x0kvuig3q6IvAhkDTcb8uCneZIW8O2OGWSy8mYGNzhVPIpvvL2tczUDEB XGIq2Q3FehRRTG2038lThLJp6qwA5BeQTVvP8wexLfDeiRYiWwl+s7ebM g==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="389998190" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="389998190" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 03:30:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="954024264" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="954024264" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 07 Oct 2022 03:30:24 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:30:24 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:30:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 03:30:23 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 03:30:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOOw6iRC5aW7J3pPxzQHuKMvmsgHjZeA+GwOj7EKbwtwc+kEB3GsVpFS97gbZwWGi222VcODqX9jTFHUfTt1jOMCLLCYS65c7RjMiO3daZD3aWSS7FenJCYlpcFQGu0KfmTTBsSINlCHC+Q/q+VCb4ziYT9nOOZuKdJVtqC9B3tlPXpIhl1989cp6tgB772Yq4KTIXfgp4L28vOvuZtTcYIYrobowP+ovgZ0Ka+oSlgul/PE8mq4t7BhYOIr2Ic0NxT3ZhpEoJFi3RLCvquKHwOnZLdmb/lsVlv3BaWh2S3D3nGuWfuDEBuJqCSSR+D17M7agjb9tXDGMozNYoVi8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfzqMDly0miDn3YC4VTTqQgPJQnvcmV1mTkpfCnbpGQ=; b=B0+2sHouOJQDvHZwO7U/GIj1BCKOM52Y5VKT0km7gk3+zY1bYG1cirxzlYe1nnJBbeMYKVxBASQyaxvzPXK8o3DQa+fqWZfH6sT+BIuGgBD0IpkV0yZ3k/LABLh0vT9Qt4RSF7uHd3CWeKl5WpDn/V2vh9P/vDpJqcRqEy36l6BVKf5YBujuWgK+xBdJR1RyIBqDJcSPud4jUaA+nTtckljKHGWvU2Hsc3hS+AQPM2C3LEbgfnArDHbRZ1033RCRLiDZCm7sQnLcrzXT/CDaG3b0wndJoTr1PpexiR0kJdPgtt2R12cZ3d9CmqGcGr7T+fXdvzDK2urDEZZCY7wAuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DS0PR11MB6349.namprd11.prod.outlook.com (2603:10b6:8:ce::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Fri, 7 Oct 2022 10:30:21 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022 10:30:21 +0000 Date: Fri, 7 Oct 2022 11:30:12 +0100 From: Bruce Richardson To: Abdullah =?iso-8859-1?Q?=D6mer_Yama=E7?= CC: , Ferruh Yigit Subject: Re: [PATCH 1/2] drivers: suggestion on meson without version file Message-ID: References: <20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr> X-ClientProxiedBy: LO4P123CA0206.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::13) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DS0PR11MB6349:EE_ X-MS-Office365-Filtering-Correlation-Id: 2823cfed-b3d3-4a93-bbf7-08daa84eef9d X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q9xCTWSp8tXiDtRGsH+QaO3K1ozUXtjR3zFT8Mz2uPJr/2cXxTFnLy7tpbwXLBpo/6vQRZLZSMVS/rp32iaGCX7+htJqWBfk3TSfpKR8k4yBKLzRUI+Nltjsal9RwJJ7Hr98lcIvaz6gOVBL4to1gC4Bbhz+KxfeaTjoVfUUlgqt/3HtrG9CzswHwqKa/k02ZS9ER/e/sRYAPHhaFEhWv7LrS+CyC9WqLScT7jMDquz6W+3v7Pv2bkQOKW8LSvzbZaGZM61RFWqCEWxHBC1Ixk9Vo5NhBQNy6A1oZRvmDNlMtTwX/F14mzkv8fMrLP6a2QL6TYEWQz5ah8TErykyZth0b9maCxO7/QY7iK5Ly2LLRPi1oWIdk859t30UAqutwELZ2m8buEI2fZWgaqyia7bRwysC7edSxI9DzyhQjQuvAv0tPqPNgUNRPHgNcZlvIZZwJZftzHQj2bgyDRLS9lYYPI6HWP/lPuSJat3m8SUHAOk+yKfCDIEx4vyeF/c8fYLSg3TiRfGa4/0VSux0yUQ8Yw21ztjtuX3+nOytXbDL8Yhupn9PA1bhxEhRBfsAm+SdKqaOS5ZYKKVDOvtGMlMO9GgDxxtMpkojJXgQI6/S8IAYhV6NQDBNfIJGXMrLynZUuLOwXh5hxHdK/yKyf1CbZuAye/tyS2KrF2FswRuORLKJiJAvufz4rJP95gD7YhZaEAe/TZ2ygTdQheH0hQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(366004)(39860400002)(376002)(136003)(451199015)(38100700002)(82960400001)(83380400001)(66574015)(86362001)(186003)(2906002)(26005)(6506007)(6666004)(478600001)(41300700001)(6486002)(5660300002)(6512007)(44832011)(6916009)(316002)(66476007)(66556008)(66946007)(4326008)(8936002)(8676002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?IQ1Thv11t4pwpUSzNt13AkNCDpWgWImjsjSVd0ELIYYxT3QrtOqim97qGv?= =?iso-8859-1?Q?azqzL73Vt+/gnAsdbTrEMG7nLy+tZC4CKZUFCSha57wtibIvtuOLxk0THT?= =?iso-8859-1?Q?3gSyiVX8vsZcdNClj7VNwOFvSap3dYpxxrrLYhrRnm08oJF6R04Es2siS4?= =?iso-8859-1?Q?jeSOMwO6PToBp2avVBN4o92p6LiRXjAXIihgC4GGrwaow8E1s6+Vg1hQtX?= =?iso-8859-1?Q?32N1fgnvN6kFWroY1L9wnjUCpoSBMciGZ/3hHiEUnbnCuBN+//8399LLnc?= =?iso-8859-1?Q?DSMOKzyFVoaojJ7EqbuKtXeRUH//b9j2bXNipoMMcH3tpHGuBSsKAshI1B?= =?iso-8859-1?Q?/uBVb47rqVQw52LNLZro5Fpto/3yK7T9P6O64NmQUlFlP+u5ngxNekG3cy?= =?iso-8859-1?Q?GM6DxIZrzQZ2CgnBso8L8lHitoejwAgo+nhx1Wlvp4Ae/RsRlsorUayInk?= =?iso-8859-1?Q?x+8NEcuCN0vbLAU2YX1sfXnhkuDIHtPDqxO8/rmyq8q215Ek5So5PUcnbD?= =?iso-8859-1?Q?mci5HmrbQckw2C5o7+sMmlKxGO5xCtrc/7DTj+Hdm8lZzVi5fQAGMYOeZB?= =?iso-8859-1?Q?SczXkrq8X9E3l3Jv7/OEbX4xbNk5I8pYxKWdUfyxsS9qiLsvWb0MzDK5VJ?= =?iso-8859-1?Q?386feBRFlI5AXSVxFQhYvCvOdFE48K5jgQV/FUHwohMxXv6nQtWO9+ladx?= =?iso-8859-1?Q?ttAatkrn7PdYIknt7hH3L7yZ6/4rHNVz8/MyUfRP3yh30+ePDyx9luYJ+C?= =?iso-8859-1?Q?z4Yp3wsazZ+GEZF6r5IowO+lprnyg/8VCG5Bqt78avatNgLHcpiGXcmviJ?= =?iso-8859-1?Q?MJyHnsKzoH0P8JMVajCpFTRaY3KgT3CTMm89y20jrUIIPxAlFBQKqwHcFO?= =?iso-8859-1?Q?S/sy717KEKR+NH+c7yrhdwlG2v5Hacjk38ChTBkkQCO5RjUL5rwNPz6AC5?= =?iso-8859-1?Q?GbxZjxOrW0nFA9XLCBckRzk3nBCMUMgNVJLHYkRu3jkRTftJV6PHb3olze?= =?iso-8859-1?Q?CpLRZb7bjKOadUmv/62rJsipwM8DeNteNfLqaMMdUoUV2kGwINggXrlrFI?= =?iso-8859-1?Q?DsX8AcrBzIFKqJoARL3XGEw74/lR1dDHr1cPzxh/XwtgkyTbvkLGHUYSPZ?= =?iso-8859-1?Q?yqONX0XiERBA1v5noSONg9CnLXMuIOLlldH2tHuIHf40J/t0cJp6pSpDFV?= =?iso-8859-1?Q?PiEfvSmFMAHWXBTDNXMz5wdQyGsZ7OgImxa0brrK7buMZZZNIHsbjZ7qBB?= =?iso-8859-1?Q?3/VhiKFoJt0hrXxIxnNg4ax7GVTw3PjrWjdU7rruJ5jsTn+z4pchduU7Pu?= =?iso-8859-1?Q?u33yAgsVSveVFgWjyla0IPphEGmrWj8aRlnKYiNhX1Itwhkkp8Ta7nsJrY?= =?iso-8859-1?Q?GqNm0MtsqcwBggMdMuWJCTgUWKZlzSwSp7XYblhVy93Nf8gcgJiF0jDaKO?= =?iso-8859-1?Q?eC3ugjKzl+b5znxoKd+ob9YLvv8w11Gf/nmUCS1ABb+P/QvhjUSLwH4EpJ?= =?iso-8859-1?Q?hjpLadEM6bSKrf8OqWFwEMEBd/kAigE/HjS2ZAq3Rkxdrnb0XOzdf7RR0s?= =?iso-8859-1?Q?24E9WgAaN3SxOEpstZtyZ1lAkNjhZjLRLd30RXUQL0TuBceL3eXiSPqSU+?= =?iso-8859-1?Q?IWt2r2EoPh2KvgI+PAb3eo8iRTn/PIUKhNdVs2/etSymogbYe7S/zdEA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2823cfed-b3d3-4a93-bbf7-08daa84eef9d X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 10:30:21.0478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: THpJbIGAwqEe6igjTR1xBxiCYhYu4BhzxwnJ9XaXTgxgU4F07wHswt2CEBqC8VN/ejpvBtDqlC0bRXFRwKAA62buWruOvqiY2OsuwTyvEdU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6349 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The title of this patch needs an update - I would suggest something like: "build: make version file optional for drivers" More comments inline below. On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yamaç wrote: > Most of the drivers don't have a special version.map file. They just > included due to the compilation issue and needs to be updated for each > release. > > These version.map files include: > DPDK_23 { > local: *; > }; > > In this patch, we removed the necessity of the version files and > you don't need to update these files for each release, you can just > remove them. > > Signed-off-by: Abdullah Ömer Yamaç > Suggested-by: Ferruh Yigit > > --- > Depends on: patch-116222 ("build: increase minimum meson version to 0.53") > --- Thanks for splitting the patch. It is a lot easier to review now, especially if we apply and use "diff -w". For any other reviewers, the "diff -w" for this patch is: --- a/drivers/meson.build +++ b/drivers/meson.build @@ -1,6 +1,8 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017-2019 Intel Corporation +fs = import('fs') + # Defines the order of dependencies evaluation subdirs = [ 'common', @@ -193,6 +195,7 @@ foreach subpath:subdirs version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path) implib = 'lib' + lib_name + '.dll.a' + if fs.is_file(version_map) def_file = custom_target(lib_name + '_def', command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'], input: version_map, @@ -227,6 +230,8 @@ foreach subpath:subdirs endif endif + endif + shared_lib = shared_library(lib_name, sources, objects: objs, include_directories: includes, > drivers/meson.build | 63 ++++++++++++++++++++++++--------------------- > 1 file changed, 34 insertions(+), 29 deletions(-) > > diff --git a/drivers/meson.build b/drivers/meson.build > index f6ba5ba4fb..6ef03e14c7 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -1,6 +1,8 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > +fs = import('fs') > + > # Defines the order of dependencies evaluation > subdirs = [ > 'common', > @@ -193,38 +195,41 @@ foreach subpath:subdirs > version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path) > implib = 'lib' + lib_name + '.dll.a' > > + capture: true, > + input: static_lib, > + output: lib_name + '.sym_chk') > + endif > endif > + > endif > > shared_lib = shared_library(lib_name, sources, Beware that the shared_lib calls use both lk_deps and lk_args parameters, which are only set inside the "if" block you added. This will cause problems in that: 1. If the first driver doesn't have a version.map file, these variables will be undefined and you'll get a build error. 2. For any subsequent drivers that don't have a version.map file, the old values of the variables from the previous driver will be used. Therefore, at the start of processing each driver, you need to assign empty values to these variable. Regards, /Bruce