From: Olivier Matz <olivier.matz@6wind.com>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@xilinx.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v5] usertools: rewrite pmdinfo
Date: Mon, 26 Sep 2022 13:55:07 +0200 [thread overview]
Message-ID: <YzGTGzmwtjOCx4di@platinum> (raw)
In-Reply-To: <20220922115802.32744-1-rjarry@redhat.com>
On Thu, Sep 22, 2022 at 01:58:02PM +0200, Robin Jarry wrote:
> dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag
> merely prints multiple independent JSON lines which cannot be fed
> directly to any JSON parser. Moreover, the script complexity is rather
> high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF
> sections. Rewrite it so that it can produce valid JSON.
>
> Remove the PCI database parsing for PCI-ID to Vendor-Device names
> conversion. This should be done by external scripts (if really needed).
>
> The script passes flake8, black, isort and pylint checks.
>
> I have tested this with a matrix of python/pyelftools versions:
>
> pyelftools
> 0.22 0.23 0.24 0.25 0.26 0.27 0.28 0.29
> 3.6 ok ok ok ok ok ok ok ok
> 3.7 ok ok ok ok ok ok ok ok
> Python 3.8 ok ok ok ok ok ok ok ok
> 3.9 ok ok ok ok ok ok ok ok
> 3.10 fail fail fail fail ok ok ok ok
>
> All failures with python 3.10 are related to the same issue:
>
> File "elftools/construct/lib/container.py", line 5, in <module>
> from collections import MutableMapping
> ImportError: cannot import name 'MutableMapping' from 'collections'
>
> Python 3.10 support is only available since pyelftools 0.26. The script
> will only work with Python 3.6 and later. Update the minimal system
> requirements, docs and release notes.
>
> Cc: Olivier Matz <olivier.matz@6wind.com>
> Cc: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
Tested-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2022-09-26 11:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:58 [PATCH] " Robin Jarry
2022-09-13 11:29 ` Ferruh Yigit
2022-09-13 11:49 ` Robin Jarry
2022-09-13 13:50 ` Ferruh Yigit
2022-09-13 13:59 ` Robin Jarry
2022-09-13 14:17 ` Ferruh Yigit
2022-09-13 14:17 ` Bruce Richardson
2022-09-13 19:42 ` [PATCH v2] " Robin Jarry
2022-09-13 20:54 ` Ferruh Yigit
2022-09-13 21:22 ` Robin Jarry
2022-09-14 11:46 ` Ferruh Yigit
2022-09-15 9:18 ` Robin Jarry
2022-09-20 9:08 ` [PATCH v3] " Robin Jarry
2022-09-20 10:10 ` Ferruh Yigit
2022-09-20 10:12 ` Robin Jarry
2022-09-20 10:42 ` [PATCH v4] " Robin Jarry
2022-09-20 14:08 ` Olivier Matz
2022-09-20 17:48 ` Ferruh Yigit
2022-09-20 17:50 ` Ferruh Yigit
2022-09-21 7:27 ` Thomas Monjalon
2022-09-21 8:02 ` Ferruh Yigit
2022-09-20 19:15 ` Robin Jarry
2022-09-21 7:58 ` Ferruh Yigit
2022-09-21 9:57 ` Ferruh Yigit
2022-09-22 11:58 ` [PATCH v5] " Robin Jarry
2022-09-22 12:03 ` Bruce Richardson
2022-09-22 15:12 ` Ferruh Yigit
2022-09-26 11:55 ` Olivier Matz [this message]
2022-09-26 12:52 ` Robin Jarry
2022-09-26 13:44 ` [PATCH v6] " Robin Jarry
2022-09-26 15:17 ` Bruce Richardson
2022-09-28 6:51 ` Robin Jarry
2022-09-28 10:53 ` Bruce Richardson
2022-09-28 11:12 ` Robin Jarry
2022-10-04 19:29 ` [PATCH v7] " Robin Jarry
2022-10-10 22:44 ` Thomas Monjalon
2022-10-12 15:16 ` Olivier Matz
2022-10-12 16:16 ` Thomas Monjalon
2022-10-12 16:30 ` Robin Jarry
2022-10-12 16:44 ` Thomas Monjalon
2022-10-12 16:48 ` Robin Jarry
2022-10-12 20:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGTGzmwtjOCx4di@platinum \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=rjarry@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).