From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E07C6A0093; Mon, 3 Oct 2022 11:19:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C410540695; Mon, 3 Oct 2022 11:19:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C157D40693 for ; Mon, 3 Oct 2022 11:19:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664788785; x=1696324785; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=L8x0ibk1onRVd65KxLmcgmwHT9g5slfuzb42cMVvLkM=; b=OayhqAyWXIseb+jpGUY0JUkbAMljQdwhrDksXJzTDIf4eqPDUvOqngED mMWwMuo/NCnKWBiCUDsXtsTWA6a1lixx48Wd4mkvPMvJlpaizaEdf0PCV SIm17IiOh0YAgiRuRj5TRDK13id0Uijs5awB0QSH48SEbl5roSSg6x/iR Z8YAziDu3l/0hWuJrJKzM2EKXV08q/FUV6aadIrx4XSoj2TreGHEKu+To lwYu9snTdxRM81Wdav8RcNaVLTn07zVdO/veabV+6ARs7dO25CnPYY2Wy 1Kn697+sTsOmTPl4Sw0seVRTjaQaCdPvg184utI0FWf36EZRdO6PE4tqF Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10488"; a="282298450" X-IronPort-AV: E=Sophos;i="5.93,365,1654585200"; d="scan'208";a="282298450" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 02:19:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10488"; a="952269857" X-IronPort-AV: E=Sophos;i="5.93,365,1654585200"; d="scan'208";a="952269857" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 03 Oct 2022 02:19:35 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 3 Oct 2022 02:19:34 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 3 Oct 2022 02:19:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 3 Oct 2022 02:19:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 3 Oct 2022 02:19:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4w63TIuBttTJ6ChwUOBorTN7mPYJs/XbhrYKkvuHXquisH+l13SuAiLETQvkASsaB/lg1dnNmBNep1ElCAJGQrCQOWeEQIuk+lHTZQEmoj/uv2uqppyK4mhVqbSRwPezQd0QIdM+Ws/f5XJcw9CqzVP/xZ90ci74tcY/61GArbXq+Puge5Gy7g3irljvIQvhnfQ1bpFLZJGXX0AuOE7PHjicifGUIFCUktJiz2vqWlON3QTQVXy+t+vU2dvyZaBCh+nTtTqtkTfohupEGZtIpXAqTy6E5cFb7X0TNE/AB3YQ5CAMg+AiwoyLk1rO6j6s5NjN+2cAmdDIz5smUhO2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4wTVCQ6Cc7QfyddoUirg/gidOMmOPsqmqyeFFFoki7A=; b=iCFRq/RXLiqtzmLxJ11J13jH/DndyyhQIm9uptbm3lMtC8gNs7bEi040Qgpg9KhlZczsn0pBRePczPXSGX4uO0lFUAZIo4tEiBnrrDplTzr7bkdAEdJ/B0PA73Jv0DXUIgJdbc0zWiuzduf/aJf09CNNRqEbQ0nUUut5U2CT7WLGSgw2/agWQNuawZ7+qhzokjs3Zt2iYd2q20F3UZ74a3PytCItRSYjRlboOZg04VGfNiYcTIoFl89V6KuUIU6a0cNEIkVGJseH3N+JpBnyNIe4kC04bt5B3nIK1UhbjZ+4JJJr9oVUw/N9c6oTSK1NDKb8KqojacjcxqtOxs16+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by BL3PR11MB6435.namprd11.prod.outlook.com (2603:10b6:208:3bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 3 Oct 2022 09:19:31 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.024; Mon, 3 Oct 2022 09:19:31 +0000 Date: Mon, 3 Oct 2022 10:19:25 +0100 From: Bruce Richardson To: Abdullah =?iso-8859-1?Q?=D6mer_Yama=E7?= CC: , Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files Message-ID: References: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> X-ClientProxiedBy: LO2P265CA0043.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::31) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|BL3PR11MB6435:EE_ X-MS-Office365-Filtering-Correlation-Id: ab35d5b2-0a44-41cd-1a13-08daa5206126 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VsV8PlJSrAu2UJR2yQYyocWWxmRP0bCnQCdBx/YAn7meGwAcUzqsyTE26cnotGAtq35AlgCUr3/1tZvsY78XPuxm1qW95oEWX+O9/27AjRg7NaFiRsNKlCG9RfDO8mFOowCYcoNGV8sho5aq4SV87BxP884X84qTi9xugVOFKn3Wha1dnH0QfShCVeuBzl07yk+ZitCa/p54jVRcv+9VDqp4pFstzuO78k2sFgLO5RV+0E4zETc9xDGqOP7iRUxid8iv0nYu74DJhHOMGkjtJKazZIzDHVd15Fqkt2urrtx5DKX0+TOdO0TnX78ZZnhSfB+Sr82wrD8ux1J8FLjnF/qS7XGnOx7Btw3LO/TA4ebZqMzYj1V0CjGing3qlpwS3yuLQ7WkNFb72d2+t29WMJ9inWVl2uesPrCSYgZXzV8bdpUIqQL50Xkm5Mub+fUqWgeWp+5VoB8KVCL9pciEHSXUCdEfKrdA2zwNCjFg1BsAJFS/Mw+pSbHVR3/U3vAzxwigG+lNHY6q3rCitD06hG6HqmDhkhveLil8eW3vIbUHpuryzLx9khvFYkWdfhaOs9Qtgt33+1JN8YpwvJYvVou2o0akcAJFrGTXIQ8XKye0c0LIk+IRk3/GfZm6Zs0qMFMYuKxunFEU7tXfHDUKxXppxRjoq858qAgvg3Ry3kaUjh8ijd0Ep+MxTeWoJiZ6Oj1gmykRrFz81/cgn2zeb7axSF0O2EE0h/yIUWdUJ4yR983f2RM5fnsoHInhDCZt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(346002)(396003)(366004)(39860400002)(451199015)(186003)(478600001)(6486002)(2906002)(6666004)(6506007)(26005)(6512007)(6916009)(86362001)(82960400001)(38100700002)(5660300002)(44832011)(4744005)(4326008)(66476007)(8676002)(66556008)(66946007)(316002)(41300700001)(8936002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?weREX3WUe1mrhOtwRsNyuXphsQiqPrFLTn8jIc7YDMXOqz8/kJGtYXNdsg?= =?iso-8859-1?Q?FilFH1Ex/8SjzGYx9aAimoC37NU7tpdyKx6WbWJHadsBchR88y/GdHVFyr?= =?iso-8859-1?Q?rKExOna+VQqoBtN3u0DerKkrtNPSx99HLUElFxIlPawaV9Z8P7UJWGk/H7?= =?iso-8859-1?Q?jGnpqGkhWVG8kqgqth1yOL4ErPG9tWMGICbEhimXx9k/op86yd2bsCPm8v?= =?iso-8859-1?Q?Dpn66+uxgJVjovJlAQz3BrUILAmIcTw8yqBW02i5XZAPu4efwc3DcwIIQ/?= =?iso-8859-1?Q?qzoGrb7u/5wa/R7sDIMp/aA8evw7veL4MjjaHS1jZDvsSvZ0o7JUMopFvx?= =?iso-8859-1?Q?nNDKgDen1iTg+z5rQbVJSeUG4gEaqEFNYIgjAMWe42c3UutS0iabEdIJDr?= =?iso-8859-1?Q?GDS9Yf5q+tPkuetqolZpEFVG6JGfKbWrPqjSP0HGr6wQ3UeQ+kMKd3l1XE?= =?iso-8859-1?Q?jezjwHEWbKB2hnWahZHTj+0XoSwxOcLpcmQlICItr4dsKQc77okcR9llVl?= =?iso-8859-1?Q?bIGJ4twY8E++C114RJXqN2zw8Y0ouIt9oUDzBLACLoFXfIK+obwzWa9JE5?= =?iso-8859-1?Q?mQBQiPNYxvWyPt8UECeJVEUjtv9dHCQPmRxd6nTtO6DEaXa8p0XNDDytRs?= =?iso-8859-1?Q?rj8RTILCr9Aph7Hh6BANFyyWQ2iZ2dLJTxpZ7oCHP1o9m9oNv6WnQbmeou?= =?iso-8859-1?Q?KMbpt/A70+qNEYt1ilpjjkGA2sq0UiglajcEhD5grj3aAxEsL6iJhD9DXG?= =?iso-8859-1?Q?aPEhYt4DCrHeIahvq6LER0/SgIxn0U+aeWQT6wcj7XmOphX3mE2nFF3Ygx?= =?iso-8859-1?Q?zFxlMlGfTRiNb196aU8lMFzFAqQBlLB9OUYFNyuuFqW8LubKXv/cXOUMHR?= =?iso-8859-1?Q?q8VWWpsL2nKcYBIt0C3CTnXREUOmxJWeNQbfR0VBi9MR16f8RL7Z7/wjfW?= =?iso-8859-1?Q?nXevXxaaDM2jbXDCT3rNBMZ0ltdcJt6iuA2ViSPgQEWn87WnOxoo00kWBq?= =?iso-8859-1?Q?ACqV2KgOYcpGmwPSkjvBJ+2O8hXzhqSh/pl5xN1hkW/frkqzd5TcLAOu02?= =?iso-8859-1?Q?2ORWnvwYZJuxnWk5zOuRNrXjfPbR+4fMrKB5KTnmq5DrLf4AcRbvlZr5Ko?= =?iso-8859-1?Q?wgLv2drsHjl9j75VP3HjMmhvvNf4V8Uye/JOn4jlvoEwvqfStpIAv10zj+?= =?iso-8859-1?Q?For/lowysiBaoOrNODX4svAGJTsM2+uJ+p6823q43n6LQQ2Ccqqdh03uQC?= =?iso-8859-1?Q?amscdpfhhkBtgft7qBTCQ0n+HtSIvTEFycslCOMVoQuf2dGen8tIVEOGcU?= =?iso-8859-1?Q?IIIO+NMNt83xe49mIqbzcAGx3O/LLdIcUIhNVca/EfJBLmzwtzGjYl0QHq?= =?iso-8859-1?Q?mwCg3qPwIfsyWpIVt/KTTCRrRlUdxzoiSKKW2pPw5PgpoO1MBNL53ebkK9?= =?iso-8859-1?Q?49hAWOZtLQV/qz1tfe1G9bo7UZt5aFw2H23RH+v19pJGcZZ72IQ5efCFsW?= =?iso-8859-1?Q?7V4Y/2NBHrDydJgFS7ozKfOzBnGModtV8wJZuFejZtzOwY8koFm/GviLAA?= =?iso-8859-1?Q?XnX+5eZaVbyh/BbfTbcuEYhLjuk8WIUIiSnPEbsMZJUTDz1GPJJswjE2ao?= =?iso-8859-1?Q?z1wDeDjqFCwCYmDV3DVWzSbEDxjFsayBzyHnt26VtELwc86vJHg4bonA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ab35d5b2-0a44-41cd-1a13-08daa5206126 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 09:19:31.5332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3T8GXYpV9lccbkZM3oOtecsaOOXaN38YW3yXUL4jCoiOskuN2cRZqeOFNMIUEgpoiSRi4uS8kdNxito13DCPG9bNhP4gQIpKlPLIr1UNoJI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6435 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > In this patch, we remove all version.map files which include > only the below part: > `DPDK_23 { > local: *; > };` > > Then we modify the meson.build to be able to compile without version.map > > Signed-off-by: Abdullah Ömer Yamaç > Suggested-by: Ferruh Yigit > --- I think you need to flag this as depending on us bumping the meson version requirement up to 0.53 as has been proposed. This doesn't work with 0.4x versions. One other suggestion is to split this into 2 patches. Have the first patch just with the meson changes to support this, and the second patch then doing the actual removal. That would make this a lot easier to review since the code needing the review will all be in the first patch. Otherwise, good idea! Regards, /Bruce