From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE658A00C3; Mon, 3 Oct 2022 16:02:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6543940DFB; Mon, 3 Oct 2022 16:02:09 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id CDF8E40695 for ; Mon, 3 Oct 2022 16:02:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664805727; x=1696341727; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=uVAotBnOtJBcik6CE/swe0B68/Ma9+l1D/WzsOKF784=; b=Oh9Gh4O22ZsclQIj41JHoUrCP2ccwHcLZdrG3EXD7gPv+umbTMC0scuN L/9NusAGbpL8g0KKC9AzwlQHdpeOs2ehepB1r71MQbMgVPUHrsI3Bq8Br 2VXSxfEkP1Y/k2VhF5DW1Xa5P7jszUX09Jqa31Yog5NZbYf6eraQw2sAg S+Eqs6zKG0AHptdITGU9HhVt+O0hpZ7JXXD8nL1lZs8UGXV2AvqH1cxJE Wealgn68j20ffqvuQt2twfNFH7ZlTkf1vnxUzdP3d+Ix7gsDJPbFTijOS UVX3hsEbYUVBkhaJX88FR2uluHmTKTtRp4xXKDFRN4z6JBaHK9BeSYjJN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="283007293" X-IronPort-AV: E=Sophos;i="5.93,365,1654585200"; d="scan'208";a="283007293" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 07:01:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="601225703" X-IronPort-AV: E=Sophos;i="5.93,365,1654585200"; d="scan'208";a="601225703" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 03 Oct 2022 07:01:56 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 3 Oct 2022 07:01:56 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 3 Oct 2022 07:01:56 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 3 Oct 2022 07:01:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 3 Oct 2022 07:01:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ay8n6P7jzyywnv5S8JX2rh5FyEdC4WsJ8jLdOss//hu3nRs2YRa4fAmoZiUj7AIlG5cj+35VWidujvJEGtXL5nLIGPDN03NP+9j7F+y7WfVRBIceoA6ym2dqrZ//Y2sSiA9DEnpIW1gpA3HvF1RCrlXgPcGWz8C6N03y5StrFQnLkmeykVA2NovgjppmsOZg5z3m6vU1c17HppnOq7A0CfZYL5G7xlnjNkJ4zmNyNPeK29v7vGA+X08vVL7hB1FDbCtYWxzuZIlLN21x4Oivfa3/rN/jBLuGa4WMS9cLC8+f2ei9yLEwp8vLi28h6ikTuPHyW7h3ycERFfg9hiqLRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ciVmABnrOe953gFaDqO4qUndIBCldrFsLhxzsm7iM1Y=; b=jiwIlArN9nGynakdUVpuWav+XQsWtd/HeGSJUwplZILPdhmamGVew5aJPL1/xNSVVLLp0CGReuilp7X+kM5XtDjInWk0nEsESGWZdKJmucLs+wBqfr8ENDYhaZN/jMOnzNYHd2R+iUH/giEnM+BHdt9dm6dy95WzZ434ZiR+pwx7dY/Fq8wnoKk5CGU4xleIN6P0pKPnnNYFJ8n4CdZIKmWJdkMYC6ZkbYMQOS9LwXXx47HSmv6co+BTTUvz8iqXTz1o4uttnFMnbOSZoz+p+QCHWhylLojR+nE6Ndq2Bo+iu7LbhFsyFeY7CGbGNI5QKu6zehJV5PTrHXRV80gKMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SA2PR11MB4940.namprd11.prod.outlook.com (2603:10b6:806:fa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 3 Oct 2022 14:01:53 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.024; Mon, 3 Oct 2022 14:01:53 +0000 Date: Mon, 3 Oct 2022 15:01:47 +0100 From: Bruce Richardson To: Omer Yamac CC: , Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files Message-ID: References: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> <10e1b3c74bbaba4bcca8fadcddf8a7a4@ceng.metu.edu.tr> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10e1b3c74bbaba4bcca8fadcddf8a7a4@ceng.metu.edu.tr> X-ClientProxiedBy: LO4P265CA0039.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::18) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|SA2PR11MB4940:EE_ X-MS-Office365-Filtering-Correlation-Id: e4446e9e-8f17-4653-90b7-08daa547d35e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g74dZD7+de1qH+VUqChAe8aXI0GuvwOlauTd+AK/GqU1MnBnLf5ty0OD1Z5m/c0/J/UHhhNhk3yX8hfyyALvxDMM4rn0TxktzlEysuGu5oORlPCnxWUKjU0fbjL1aAzxxA8Peer/ymRJ5BTfqFOXT4d+zyFYvPCbkCy8TQjEHsDx5XcWHBFTNidghYs1rjub+DOtcLpkykV2AdTbvZECpw1AObPWV6uIK49BlcR993a1+KRnBExaUps3iYSQLdJEi27rZi7SeYFug5ra1Bj+Xpmh/WUO8gyFmCCALNzWEV2mRjNMiVMRjFFHyt4Rh05SLa90/8mlhlZZkFU+jTb8WzBPEH9JcXV5byS3R9gesEn0eLlPA4DrrN1wj13WIYyNPSSktssuftW9cniIG3Bri9bRvXCaZN/sakpWQmggTNSShYWJp7PG33GU94sPj5VqtwbMOasZw0RGCrbSQKoY/AVJU2ciDC6azjxcKHL29ZrUTTl5ix7DYjgkOpf8/OTp+9t7YOxAiCiG8zcEyta0NFbjilVvDj6teMmFptQGAvdF2o9k3fp5q/p0XyAIrGob9QsGO3d1+NMithC5SwtaDkAfJgZQ6guRcCtRdRWdl2Tjpj2DVXMMpuaBzKaX9KW9TgMZz4c0mpSNC1WPGQXE/yeXOwfMQY9lrftVFuyihm0JoZGvm9nzZKiqPqrEg1vmZkMiuP1yizo8cG6Nor2OGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199015)(66556008)(66476007)(66946007)(8676002)(2906002)(4326008)(186003)(83380400001)(41300700001)(6512007)(26005)(82960400001)(6486002)(478600001)(38100700002)(53546011)(86362001)(6666004)(6916009)(6506007)(316002)(44832011)(8936002)(5660300002)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?P+A1ePkJJIjohbxlqH25CfOdHywG+7EXHMcK3e8sUkkzkrqDvINfEVYDX0?= =?iso-8859-1?Q?Qg/+dYLtY9TIayL5WiOewIqW8zqGd3YmzpuiKTYzvCSxuquYtmCkUDeaSk?= =?iso-8859-1?Q?YjXoFprF1y813whmUovsYV8P5lf9KHakLpiuFITtI4ZxawKzOnKhiEokIp?= =?iso-8859-1?Q?zT5u3isoB1lwczVqufm1YbJ67EC78l01TJ7P229RjX6w3BYZVkkQZk1/1I?= =?iso-8859-1?Q?l5CfBCeJVzxUFVk/YS8kghvdRBMSwI+71VuNi1b9N8q9Xa7P/il36FGOKf?= =?iso-8859-1?Q?51M12qHxtChAoNjS+/Jm89Pkk+eAXKWiAhbazlyHxldHjrqwQKZQXe2Xve?= =?iso-8859-1?Q?JpfJrGFNeAbL+OkFpuVWpYuN5UfnCWtOf2afxUVEG7CCzl/bEzMgDoNJfi?= =?iso-8859-1?Q?VvdOYRoEEKP/QYN+W5TOqtCcoF5Viu9+uPiVT5U1mTpeToRcSucOgTPN4C?= =?iso-8859-1?Q?GrCAIcQOA9wSCOj1bW9ZmBfcrOWWSug3idY97pRTFy5u4KVWFuUlipdY+m?= =?iso-8859-1?Q?UyAzQ9S8Sccma8HtBdrX27iqio/yPXlGIKHtHVmgo0yXZRwpgrdLHG4GbZ?= =?iso-8859-1?Q?fTa30MoxWuL2yP1xn4pWjtE0y0oZsFMqyMYcAmVKZTQPMPlOxeIK3JYTcj?= =?iso-8859-1?Q?fx42fD8ismPeirTDK/bSgtW2x3J0y+aJvYAk1IoEIWHXVqACi0UDNOjvZl?= =?iso-8859-1?Q?kcz9yVBlmroNxXC7ArRI0HSy/ZMiMOHI6v6Zt4UqenCIHzqwJn3H8jepre?= =?iso-8859-1?Q?AFgHLALz0aWDmiudTNpEFqvUpcu9MYOMoRJ2JKjmILry+apHW6b8o/2hRU?= =?iso-8859-1?Q?BT0dV/jTP8pYuSAmNS78T4W27nCeV8O3HOKNHZMRpTzrlSESdRTBf/rcTD?= =?iso-8859-1?Q?8tPWoKVBNh0dzE5/bP0dQYj97pJ/9P6WyponE5UXS8jemt6YmIehtxycWO?= =?iso-8859-1?Q?24MqIH6TuuBDJ7Xg7i8VcjL7HIHEpsZ/wxdPSb/8e8q+6SfyuNGVSHV+wo?= =?iso-8859-1?Q?nOw0Ecf9cjbnJGsl/5YgncQelYe4AZ9kLOn+tMQc2Jnw4Rs+285DNb2e3s?= =?iso-8859-1?Q?SUTx4nuDcpQr1HuOxR/G0SQQt8OStMlFEa6qgBu9U6EzEsOl0hVr7chxe8?= =?iso-8859-1?Q?mCAWXOb6Pq74f/1lVy4HWvAU/9cj6g1NIwx4Vqq7PQdChN2hrd8RKVt95k?= =?iso-8859-1?Q?ZYiVTtFiNmyOJZ+arL3YlfRuspHGWM+61YGleT+DM+1b1G3EzD7ptPphZg?= =?iso-8859-1?Q?GuIXW91k/yyBTOT/F2n09PORkdhI9vAhQdiSjdi+uAGS09/4iEYfOKdxNq?= =?iso-8859-1?Q?9D+LAhKV48kwMCAuy48wye8CFRc/Ck3RvULKnjDPWkkUa+I93y3cxR87ag?= =?iso-8859-1?Q?sg7sBChznit9UzgrS/UT/Xh+MQJo7g+a4ttAtKLVtf8D50TZxPyPhWuD++?= =?iso-8859-1?Q?mSm3/yL44fHFMvm1mrhTebxcVDo8Ss1GJihr2CyoU2HeFYJKYazc9XOhyW?= =?iso-8859-1?Q?cQmWvoY57nmACD9YgMVrGvLALxp9D88Uaum8lT506hcSi265/Ros+IkUfJ?= =?iso-8859-1?Q?6bJRBGsY9w/TjlIKsXNBbBsqmCbWTB59IqLac3ZqyaP/ThcZehGcxAveXS?= =?iso-8859-1?Q?qFFV2u3AXrJg4h0dmoNY+MgsWR7EZRwn0mOBKtVc+S7WAZo3kUvu4CrA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4446e9e-8f17-4653-90b7-08daa547d35e X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 14:01:53.6453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jZqcO/O4lGDK5vxEHYJCA0tzTaccOKEqkk+CWhryd8WawLyeOn/1STSWzMXsSqtVVXv+50Z/H0Jz6Vye7tzgX2W8Rc6QUWE14dY7PA3g9QQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4940 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: > > > On 03.10.2022 12:19, Bruce Richardson wrote: > > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > > > In this patch, we remove all version.map files which include > > > only the below part: > > > `DPDK_23 { > > > local: *; > > > };` > > > > > > Then we modify the meson.build to be able to compile without > > > version.map > > > > > > Signed-off-by: Abdullah Ömer Yamaç > > > Suggested-by: Ferruh Yigit > > > --- > > > > I think you need to flag this as depending on us bumping the meson > > version > > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x > > versions. > > > Thanks for your warnings. > Instead of using fs module, I will use python script that checks file exist > or not. > If it is okay, I will resubmit the patch. I'd rather not go down that road unless we really need to. Right now the empty version.map files are pretty much harmless, so there is no compelling need to change. Therefore, I'd rather wait to have the meson version bumped to 0.53 and then have this patch applied, without having to worry about using script fallbacks. /Bruce