Re: [PATCH 04/10] net/intel: use common base code build handling

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Apr 02, 2025 at 03:05:07PM +0200, David Marchand wrote:
> On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > diff --git a/drivers/net/intel/ice/base/meson.build b/drivers/net/intel/ice/base/meson.build
> > index e7ba9c34bc..f453005a1d 100644
> > --- a/drivers/net/intel/ice/base/meson.build
> > +++ b/drivers/net/intel/ice/base/meson.build
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2018-2021 Intel Corporation
> >
> > -sources = [
> > +base_sources = files(
> >          'ice_controlq.c',
> >          'ice_common.c',
> >          'ice_sched.c',
> > @@ -29,7 +29,7 @@ sources = [
> >          'ice_ddp.c',
> >          'ice_fwlog.c',
> >          'ice_vf_mbx.c',
> > -]
> > +)
> >
> >  if is_ms_compiler
> >      error_cflags = [
> > @@ -41,22 +41,14 @@ else
> >              '-Wno-unused-but-set-variable',
> >              '-Wno-unused-parameter',
> >      ]
> > +    # Bugzilla ID: 678
> > +    #if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> > +    #    error_cflags += ['-Wno-array-bounds']
> > +    #endif
> 
> Why keep it commented?
> 
> 
This was an accidental change added in. In my testing with gcc 14, I
discovered that the warning flag was not necessary. However, I assume it is
still necessary for GCC 11 as originally added. I have not tested with a
range of GCC versions to be sure. Therefore, I'll just drop this diff in
next patch revision.

/Bruce