Re: [PATCH 00/10] centralise base code handling for drivers

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Apr 02, 2025 at 03:08:45PM +0200, David Marchand wrote:
> On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Many DPDK drivers use the same pattern for base code handling, having
> > a meson.build file in the base code directory which optionally defines
> > some custom cflags for the base code build, then builds the code as a
> > static library and extracts the objects from it. (The reason behind this
> > is that, in meson, cflags apply per-object, so we need to have a
> > separate build object for the base code to use custom flags)
> >
> > This patchset deduplicates this logic by putting it into the
> > drivers/meson.build file, and allowing individual drivers to then just
> > specify values for "base_sources" and "base_cflags".
> 
> In general, this series lgtm.
> 
> > Depends-on: Series-34946 ("net/intel: clean up base code build")
> 
> This dependency is a bit problematic, as this series is already merged
> in next-net-intel.
> There will be some merge conflict to resolve.
> Instead, it would have been better if next-net-intel relied on this new series.
> 

Maybe so, however, this was the order in which the work was done, and when
doing the next-net work I wasn't sure I'd be doing this set in this
release!

> 
> After this series, the only remaining special case is for SVE stuff in
> net/hns3 and we would have all source compiling handled by
> drivers/meson.build.
> Do you plan to clean it too?
> 
I wasn't aware of it, but I can take a look, hopefully soon.

/Bruce