DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <thomas@monjalon.net>, <dev@dpdk.org>,
	<andremue@linux.microsoft.com>,
	dpdk-techboard <techboard@dpdk.org>
Subject: Re: [RFC v4 0/8] Symbol versioning and export rework
Date: Wed, 26 Mar 2025 14:16:46 +0000	[thread overview]
Message-ID: <Z-QMTmiT5y6QJdd1@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zQqVFz8ChfgY8MKsy-dBJJEtxHs2vTmvB1L7CDMOkyTg@mail.gmail.com>

On Wed, Mar 26, 2025 at 02:54:32PM +0100, David Marchand wrote:
> On Wed, Mar 26, 2025 2:37 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > - I am considering making rte_function_versioning.h a non exported
> > > header (precisely, moving it to buildtools/ and maybe renaming it).
> > >
> > > This header contains macros not prefixed with RTE_.
> > > Using it requires some build trick (see use_function_versioning).
> > > And I don't see symbol versioning as a MUST infrastructure that DPDK
> > > needs to provide to datapath applications.
> > >
> > > Yet technically, this change would be an API breakage if some
> > > applications indeed relied on it.
> > >
> >
> > Is it not needed for exporting if an exported library header had versioned
> > symbols is in?
> 
> That could be, though we don't expose such versionned symbols atm (and
> I don't think we ever did in DPDK).
> The only public symbol is always the symbol implemented for the latest
> ABI for newly compiled applications.
>

Ok, that's good. Looking through code and code history I do indeed see that
the use of function versioning in the past seems to have all been done
through the C file. Therefore, no issues with making the header
internal-only and not exported.

/Bruce
 

  reply	other threads:[~2025-03-26 14:17 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 21:23 [RFC] eal: add new function versioning macros David Marchand
2025-03-06  2:57 ` Patrick Robb
2025-03-06 10:23 ` Bruce Richardson
2025-03-06 12:50 ` [RFC v2 1/2] " David Marchand
2025-03-06 12:50   ` [RFC v2 2/2] build: generate symbol maps David Marchand
2025-03-06 15:45   ` [RFC v2 1/2] eal: add new function versioning macros Andre Muezerie
2025-03-11  9:55 ` [RFC v3 0/8] Symbol versioning and export rework David Marchand
2025-03-11  9:55   ` [RFC v3 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-11  9:56   ` [RFC v3 2/8] drivers: " David Marchand
2025-03-11  9:56   ` [RFC v3 3/8] eal: rework function versioning macros David Marchand
2025-03-13 16:53     ` Bruce Richardson
2025-03-13 17:09       ` David Marchand
2025-03-11  9:56   ` [RFC v3 4/8] buildtools: display version when listing symbols David Marchand
2025-03-11  9:56   ` [RFC v3 5/8] build: generate symbol maps David Marchand
2025-03-13 17:26     ` Bruce Richardson
2025-03-14 15:38       ` David Marchand
2025-03-14 14:24     ` Thomas Monjalon
2025-03-14 15:38       ` David Marchand
2025-03-14 15:27     ` Andre Muezerie
2025-03-14 15:51       ` David Marchand
2025-03-11  9:56   ` [RFC v3 6/8] build: mark exported symbols David Marchand
2025-03-13 17:30     ` Bruce Richardson
2025-03-14 16:14       ` David Marchand
2025-03-14 16:23         ` Bruce Richardson
2025-03-14 16:53           ` David Marchand
2025-03-14 17:21             ` David Marchand
2025-03-14 17:28             ` Bruce Richardson
2025-03-14 17:39               ` David Marchand
2025-03-14 17:51                 ` Bruce Richardson
2025-03-11  9:56   ` [RFC v3 7/8] build: use dynamically generated version maps David Marchand
2025-03-11  9:56   ` [RFC v3 8/8] build: remove static " David Marchand
2025-03-11 10:18   ` [RFC v3 0/8] Symbol versioning and export rework Morten Brørup
2025-03-11 13:43     ` David Marchand
2025-03-17 15:42 ` [RFC v4 " David Marchand
2025-03-17 15:42   ` [RFC v4 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-17 15:42   ` [RFC v4 2/8] drivers: " David Marchand
2025-03-17 15:42   ` [RFC v4 3/8] eal: rework function versioning macros David Marchand
2025-03-17 15:43   ` [RFC v4 4/8] buildtools: display version when listing symbols David Marchand
2025-03-17 15:43   ` [RFC v4 5/8] build: generate symbol maps David Marchand
2025-03-19 16:19     ` Stephen Hemminger
2025-03-19 17:12       ` David Marchand
2025-03-20 15:06         ` Andre Muezerie
2025-03-17 15:43   ` [RFC v4 6/8] build: mark exported symbols David Marchand
2025-03-17 15:43   ` [RFC v4 7/8] build: use dynamically generated version maps David Marchand
2025-03-17 15:43   ` [RFC v4 8/8] build: remove static " David Marchand
2025-03-18  8:19   ` [RFC v4 0/8] Symbol versioning and export rework David Marchand
2025-03-26 12:02   ` David Marchand
2025-03-26 12:26     ` Morten Brørup
2025-03-26 13:07     ` Bruce Richardson
2025-03-26 13:36     ` Bruce Richardson
2025-03-26 13:54       ` David Marchand
2025-03-26 14:16         ` Bruce Richardson [this message]
2025-03-27 13:36 ` [PATCH v5 " David Marchand
2025-03-27 13:36   ` [PATCH v5 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-27 13:36   ` [PATCH v5 2/8] drivers: " David Marchand
2025-03-27 13:36   ` [PATCH v5 3/8] buildtools: display version when listing symbols David Marchand
2025-03-27 13:36   ` [PATCH v5 4/8] build: generate symbol maps David Marchand
2025-03-27 13:36   ` [PATCH v5 5/8] build: mark exported symbols David Marchand
2025-03-27 18:21     ` David Marchand
2025-03-27 13:36   ` [PATCH v5 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:19     ` Aaron Conole
2025-03-27 13:36   ` [PATCH v5 7/8] build: remove static " David Marchand
2025-03-27 13:36   ` [PATCH v5 8/8] eal: rework function versioning macros David Marchand
2025-03-27 18:22   ` [PATCH v5 0/8] Symbol versioning and export rework David Marchand
2025-03-28 10:52 ` [PATCH v6 " David Marchand
2025-03-28 10:52   ` [PATCH v6 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 2/8] drivers: " David Marchand
2025-03-28 10:52   ` [PATCH v6 3/8] buildtools: display version when listing symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 4/8] build: generate symbol maps David Marchand
2025-03-28 10:52   ` [PATCH v6 5/8] build: mark exported symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:20     ` Aaron Conole
2025-03-28 10:52   ` [PATCH v6 7/8] build: remove static " David Marchand
2025-03-28 10:52   ` [PATCH v6 8/8] eal: rework function versioning macros David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-QMTmiT5y6QJdd1@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=andremue@linux.microsoft.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).