From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <bluca@debian.org>, <stable@dpdk.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
David Christensen <drc@linux.ibm.com>,
Wathsala Vithanage <wathsala.vithanage@arm.com>
Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
Date: Thu, 27 Mar 2025 18:06:41 +0000 [thread overview]
Message-ID: <Z-WTsS31MSnmXMU4@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250326103928.1189243-1-david.marchand@redhat.com>
On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> Caught in OBS for Fedora Rawhide on aarch64:
>
> [ 198s] In file included from ../lib/acl/acl_run_neon.h:7,
> [ 198s] from ../lib/acl/acl_run_neon.c:5:
> [ 198s] In function ‘alloc_completion’,
> [ 198s] inlined from ‘acl_start_next_trie’ at
> ../lib/acl/acl_run.h:140:24,
> [ 198s] inlined from ‘search_neon_4.isra’ at
> ../lib/acl/acl_run_neon.h:239:20:
> [ 198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> uninitialized [-Werror=maybe-uninitialized]
> [ 198s] 93 | if (p[n].count == 0) {
> [ 198s] | ~~~~^~~~~~
> [ 198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> [ 198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> [ 198s] 230 | struct completion cmplt[4];
> [ 198s] | ^~~~~
>
> The code was resetting sequentially cmpl[].count at the exact index that
> later call to alloc_completion uses.
> While this code seems correct, GCC 15 does not understand this (probably
> when applying some optimisations).
>
> Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> various vectorized implementations accordingly.
>
> Bugzilla ID: 1678
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2025-03-27 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 10:39 David Marchand
2025-03-27 8:17 ` David Marchand
2025-03-27 8:55 ` Bruce Richardson
2025-03-27 10:36 ` David Marchand
2025-03-27 10:39 ` Konstantin Ananyev
2025-03-27 10:51 ` Bruce Richardson
2025-03-27 11:17 ` Morten Brørup
2025-03-27 12:10 ` Konstantin Ananyev
2025-03-27 12:24 ` Bruce Richardson
2025-03-27 12:43 ` Konstantin Ananyev
2025-03-27 12:30 ` Morten Brørup
2025-03-27 10:30 ` Konstantin Ananyev
2025-03-27 18:06 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-WTsS31MSnmXMU4@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.ibm.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=stable@dpdk.org \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).