From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6D54545D6E;
Fri, 22 Nov 2024 09:54:56 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 55424402E3;
Fri, 22 Nov 2024 09:54:56 +0100 (CET)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12])
by mails.dpdk.org (Postfix) with ESMTP id 9FB4040270;
Fri, 22 Nov 2024 09:54:54 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1732265695; x=1763801695;
h=date:from:to:cc:subject:message-id:references:
in-reply-to:mime-version;
bh=vdGPTCPaj3LxfEM1pNFd4YQmjaTFXlyATB0vR+uRlP4=;
b=nu3Hyl9WoK+ImXSrv6sX4WLl6XPQKBwQjFmcgpjnapTRH4QAri/BxRSi
5c6lUVLHNkO6pTrnc+KDpq5ZY//xfLzAECDoKZuAM63iuaYXrN5soVEem
s+HHgwM71ci181eAhNvARvP4j5hYqVvxdpUuhYXyfJdOW49cxkJgBRhNb
cuEnmbo4MaBDmz3hjpMkNHdZvJm6Yw/uWYS5vf35jCZDULpOgWr3rkvEw
xIZNLiC3Fz6BSPXfuh6TBwTOd12ODaFc9EZZ9UBnTYGdj+pCGb0GZbHDq
Vdt+9+InXi592RumkN47F791YISsghYK9E2IrEP7m55AyXyFfxacSZvxi w==;
X-CSE-ConnectionGUID: MwbZXgKhRbqrx0dzRzHa3Q==
X-CSE-MsgGUID: nn0MMvSrTgy1FOXtugjQIA==
X-IronPort-AV: E=McAfee;i="6700,10204,11263"; a="43793714"
X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="43793714"
Received: from orviesa007.jf.intel.com ([10.64.159.147])
by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Nov 2024 00:54:53 -0800
X-CSE-ConnectionGUID: Fz0/nQJySgCYAm0v7goj8A==
X-CSE-MsgGUID: 7B40QHCpSjO+XeZ3oepRdA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="90936389"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
22 Nov 2024 00:54:53 -0800
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39; Fri, 22 Nov 2024 00:54:53 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39 via Frontend Transport; Fri, 22 Nov 2024 00:54:53 -0800
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172)
by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Fri, 22 Nov 2024 00:54:52 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=J3hMRE9lYWFbjwivRG1jsyw+axQdJdbmG4LQHw0WBChBJ4HW9CSSKnYgACpUshY8TmO4v1SJd62mKXiQxFZKNj04nnJtGZLWSA7SF/rNHqlM15uBjl8enVy1aUtTElELWCZZnOD2PAPgTorzHHJ3G7KFVSfNWvF+KPypoLTT3OYZm6n73EzWM0NEGwfkoZfEFw+v36vLPHDebu7iwLu46/QuWirl+0aQnhnccRoRpKHgbDQzG/GKOxtL3He8BVOYkpHrCjlFHC2R9iYZHO1aphoeY9p1SQ9DqXy+G9RgdanV7YBsjiuEE1kHYMwBSB+ZeBbRIY6iE8NjXuN5c4qTdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=dRMaz0c9j3wS/uTC/Qtc8LIDeuXxxEXgNfKEpxf4B+A=;
b=pCFtP4+pJSyHyZRv7TO1pMLA3DmMqLcbRnPsYy+tf0i0H3NeoNiw40sFhZMdPwNtXWTWt7/4TFshnUgz24DCs5I4w41DcO1iec4EBEZj3OJdNljY8RvvxCeQiYsXfy8Am3viz7FKTOIiXirfHgYoIfFQLPrTEQuPFlYtnOhUdFymclvwSblWL5e5IYMt8pwcaT58xStDohZtSIWVPXS0l4oTlYj3gmU8p03cU4Z3ZntAtS5dcP1/4NoacIr3Wzl6+QJ0eryQgMYen8z60BRaJmkuyEhmf3iYMYf9iq61Pam3J21YvgD/5glKGseDy03Q7ErBXCvy/jQy0Os/oQ0ezA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)
by LV8PR11MB8748.namprd11.prod.outlook.com (2603:10b6:408:200::21) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.23; Fri, 22 Nov
2024 08:54:50 +0000
Received: from DS0PR11MB7309.namprd11.prod.outlook.com
([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com
([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 22 Nov 2024
08:54:50 +0000
Date: Fri, 22 Nov 2024 08:54:44 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <dev@dpdk.org>, <declan.doherty@intel.com>, <stable@dpdk.org>, "Chas
Williams" <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>, "Pablo de
Lara" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v4 2/9] app/test: fix typo in address compare
Message-ID: <Z0BG1GYzFG0LwA1u@bricha3-mobl1.ger.corp.intel.com>
References: <20241114001403.147609-1-stephen@networkplumber.org>
<20241121182443.68025-1-stephen@networkplumber.org>
<20241121182443.68025-3-stephen@networkplumber.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20241121182443.68025-3-stephen@networkplumber.org>
X-ClientProxiedBy: WA0P291CA0001.POLP291.PROD.OUTLOOK.COM
(2603:10a6:1d0:1::27) To DS0PR11MB7309.namprd11.prod.outlook.com
(2603:10b6:8:13e::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8748:EE_
X-MS-Office365-Filtering-Correlation-Id: 3d57c132-55bb-4bc5-a452-08dd0ad352da
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?K7oFBzKszTXFgE6PniYyBmzjK7bYwjnaOWZ8TP/8XTELowWhzLcOg4PfX+K6?=
=?us-ascii?Q?EoHG12+W3UUCqc8hSbLgEtD5VZoA/wesnMrf/gpz7Hc7Y0O5DsVxRahHmbsd?=
=?us-ascii?Q?M4v++eO/6zRO6owy5VvqsaKVQu1vw2fFILByrkaAJ9ptMT/lqBoelHhS+9MH?=
=?us-ascii?Q?ruLNsZcSL0q4LT4eRxOCYCXkgGXIx5SXGI7OBiymabRIo2iNp/nQURQI5QfN?=
=?us-ascii?Q?9F22MtukVYDWirzNoal3WmQ+5/DLCFTCoGzSpA7JcDHF5oEQnaDv++HvKDf8?=
=?us-ascii?Q?M6AdxKkoLDoLZYpQ0xa86VJIl0f8YKMwIIlsvKRwg4cGFB0fv6GHxz52pexr?=
=?us-ascii?Q?N+rQlZbgvQtmo5WRmHdS1DBo1+tXPur+ISvsfg8i7+2c7fqiCW7UGfYS/Moz?=
=?us-ascii?Q?2l1duWfM7e/AIBAiSkXtCg7L45rVw9rHbbLSLOqcIbaDa2XD0iybp+RpHe9v?=
=?us-ascii?Q?oUWHHpNtKkSd0tIaWsMuXRQRpGJE52BAeSIn/NveyC98M2qJOXuaw0ARohea?=
=?us-ascii?Q?LBa8Oxf69gIGj8p9SBJWPpu4lShWg4CZRuF7yh0yZlBbmpmTGqqahBNBgegt?=
=?us-ascii?Q?kluX5PxWRVsR3m3c7wM4U4GPl1YWhoSKvTNmQ+DkdLo9YQ87iPopO/BzdIRa?=
=?us-ascii?Q?UJlqmJqCecIbovEF+0bXzOa4tiHFUH3FV26QHzn4NAQOyqC6byQ4ELH9H01c?=
=?us-ascii?Q?Bm5pUEOSAru45T2zbhM03A7+xwvNWBwjHmsbY8JyzIpa5b2p2YhisudqzD/t?=
=?us-ascii?Q?ABXmxxwfuo9ycT7H96lKfxAJsdPYlGkrUeii4V8J8vCwz4zPONdy25lmAWJ8?=
=?us-ascii?Q?9WtvswP85bsYVzmgIFrDTPICyifPdZvbP3SCct3DoILVhlD9WaKzngtstGwT?=
=?us-ascii?Q?tuZW3quMKF6WTrwvqRqchEs/w0sUYyeHoEmh1Q1VfOZSvHRHfMPCBGbWFOCi?=
=?us-ascii?Q?jJVvmmdI1uYSuOOzEzpuZJQenVnZHfjVm00hzbOZJzcFnkx2yrxe7LkffxCx?=
=?us-ascii?Q?4UmVBj3HxSlRgGlqxtTaqQot6S+YQGRAZBW9qOSymqUrCdINv6lUH8Ofz7FE?=
=?us-ascii?Q?sqqLN9h9mYfJkiWJaW5OkrN0bkPK/ITPdslyUGaCq3zQHDHoPEHsAVJSG5R3?=
=?us-ascii?Q?nD44GRk2Ps7lL34Bjb6UyYEeQ42ZGgqGeRyubFFjqbuuXYbMhpJSCvWw4+Gu?=
=?us-ascii?Q?b5O6iDHbvGFntD2J+Cin5aDGSP0C1Lglns5LJqPe9dZLuD8xhoOOeWir8PdA?=
=?us-ascii?Q?5pgkh3QHqrMsTWC2TDzq?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(366016)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oqFFeqBdFhI1GsPxaIf7PbIhTgpbYjXfrVK5EjBeifB4t/ER9XGVHlJ8bOAI?=
=?us-ascii?Q?8wxhHFdILm9cBetccB+Sz7KU6ZJGXqd1VkjAgDYKW6Lv1tTAtxi/nHIXoUdo?=
=?us-ascii?Q?JJ0OkcgRuVhVSRYT7uOfkFP9e1DVeiZNaEd6mTNVCgCofJFVHtOCUc7ZpAor?=
=?us-ascii?Q?d8hThZ1Y9WJfh6H5qJxk9p3HkwierWiO4R4NmPP5/6BwrfD7renFJZBgAtRq?=
=?us-ascii?Q?oyhJ5ar4NurOSLitn1v9Zu8q16eBtlsCO98C+Gzdj6djPAyuJmEr55P8sOTO?=
=?us-ascii?Q?MPb+LTyDGjsAMxL4RCYQyFJ2lX347mpwCzsxFLtF/RnCoTHafUkr+Sj8iIoG?=
=?us-ascii?Q?VbAfv3/9kiaNcYzRTxEThn/DfUnxkKdS5Eme2XmliVtiVVR1jPl7c1AawjVh?=
=?us-ascii?Q?iHDr85V8Qr5ckndZ2BK98HZiYYGm/hXa+whS+IUstziYBM46dRX7jNsjEzUo?=
=?us-ascii?Q?8auyFVD2K3zIYvMKjdmzJ2rhw6pFHaQGr7rVmMP15A19unbm16jESYcDS11z?=
=?us-ascii?Q?val34JX74enuHPFt2FYllOXpVwI4vybulA6Y8Ck3zXMdjKoMhsIj/QxA/NAv?=
=?us-ascii?Q?1LAzFAPKlj7vIOVDq8KH6Ws7jY2cVygp8eBfze+/h0ZL9DlReA413a7z3YA1?=
=?us-ascii?Q?ENdjgsf6SENEpolY3kTxUVtjj3GH8yVv2e8PzRTqUkxPjP6+0i10LhqFlaOO?=
=?us-ascii?Q?NNJOOuadN7DFqLIkkZRrwdChrzYtKulZKlAUa2Bwu/19vxMbBY10itbYVZw2?=
=?us-ascii?Q?T+j6qt8Stnjce+qxlMlouCEPmYdwRWefxkTixhF1u/R87yOcBzyI4u6essNn?=
=?us-ascii?Q?h0YdXZhIe/dKfnhtypr7LUX3Un6lUJzGmP4+Z67d6V8evjBFAwarVyecaV82?=
=?us-ascii?Q?Z13jV6P9oVL6SdDzBt51uExz8EPNzj9f49hYpbaOOxNqeXVQWppe3mDJtTCY?=
=?us-ascii?Q?a+e31pyvvxtJS046GljFmUSrzGfLb98OPL4x5qkdACJJL8lIgcygjbZdEPIY?=
=?us-ascii?Q?Od1BtpVeNUnhKXykSe1PSXh0NI/ElJi/3zk4hDIx5DYGrZBfHkgzcpNOKcXz?=
=?us-ascii?Q?Yqni4ReCjj7CCJPPTlVM3Ilk6MsJgGLfmS20fcXhosoKXrCYK6w7MVHcbx+B?=
=?us-ascii?Q?3lAqX/NWgp6HNrv8BrKCf1J24MeN2SbC8mij+ZQ2nRaIniTkPXZK1b91UbAQ?=
=?us-ascii?Q?BL+VosbqGTEcZxZ+xLmkQZ8vfmJUt+7jUlDdlnfCbOdaLqRiiIeLxcHOgwjT?=
=?us-ascii?Q?qyizZCBctrPbZtTieR2gR1fn5x5QDMff1okiuwRKf7y7TF3RjfJtlMxkg6Li?=
=?us-ascii?Q?Ra+i0sXBjQmK9GH0lPYOklkxeO7/TyAjqkWt8Yt9e8dGfIole8URmoI9dDld?=
=?us-ascii?Q?jCapEApdyGD0edc/NjEOYRpICYxft+pRUWQpjUlFUZuuyteBAL7MxZxZUcT4?=
=?us-ascii?Q?WzwalItoOqVelcvN+tWG10DLFe76wDctAYl6Th8eFzKFcjyHSahIISqVXJdx?=
=?us-ascii?Q?C0bWWWVwDMW1q87XHYn/wPa9Mlam5xO8V3rEqt6nBOJa+5aGJN8TB0iMac0c?=
=?us-ascii?Q?l1RF8iX1WCR20K9d4rHWwkqnS0frE9pcpv4Y6+V/4mIji+mUAO1Zv4BzaM1a?=
=?us-ascii?Q?bw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d57c132-55bb-4bc5-a452-08dd0ad352da
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2024 08:54:50.3327 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v3SCvlLVb6FkmiGjm7ksqWMSv0e1wJgzkl1uYb4LxUanFvDeyKK/rxWu9Ppn1Z7Nn1OO6DOyRyge/O63F3CBDxkhwotgwOpgvImt1Nze3ic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8748
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, Nov 21, 2024 at 10:23:23AM -0800, Stephen Hemminger wrote:
> The first argument of 'memcmp' function was equal to the second argument.
> Therefore ASSERT would always be true.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: declan.doherty@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> app/test/test_link_bonding.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 805613d7dd..b752a5ecbf 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -792,7 +792,7 @@ test_set_primary_member(void)
> &read_mac_addr),
> "Failed to get mac address (port %d)",
> test_params->bonding_port_id);
> - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr,
> + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr,
> sizeof(read_mac_addr)),
> "bonding port mac address not set to that of primary port\n");
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>