From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5357C460A4; Thu, 16 Jan 2025 18:20:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B4E040B91; Thu, 16 Jan 2025 18:20:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 3ADD4402D6 for <dev@dpdk.org>; Thu, 16 Jan 2025 18:20:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737048016; x=1768584016; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=B9lE8xbYgMtuzqVhl3TJGvZF1J+1SFhvISVxU5oZP54=; b=lDKl0ZYqQPXpGJhMMOi9An5OY9nwU7cKLqgPi/F1hzZzgGKIlfZnlvPm 1u7sksbqiBtJ1FayTikHBLVUO2pzt7HsQeoxS1fylYjMRBxdhyT9+0sU4 cmJzwfB/1caU64eRFiNHsAOgp6BiaTVRJaPJc8slT/VTA3dmqRWmJAVes S3ytaW+1yfJqlLiq0vSUUzWFGBpVqzoh23Q2WqRXwx7wI7NPlyzkqE57t p97fe6rR3Uqjbxxby4XSDcU2z4DZS3Ilq13YInpkXCG+XLNsGOGKbcFeL /l1EhwYri0tU30IryB8mX67rE81NWubzFEtFhlhhoCsLct+7Y37KR0PKd g==; X-CSE-ConnectionGUID: obMg2W92Tzm1eClf0bfJrA== X-CSE-MsgGUID: mhZen1fATmWfQ0jX8HzAsQ== X-IronPort-AV: E=McAfee;i="6700,10204,11317"; a="47941669" X-IronPort-AV: E=Sophos;i="6.13,210,1732608000"; d="scan'208";a="47941669" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 09:20:14 -0800 X-CSE-ConnectionGUID: MyhyL2EjRyuDdxPXOqdyfg== X-CSE-MsgGUID: oHvmf4PHQ9eVA4goBhHPPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,210,1732608000"; d="scan'208";a="106095614" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Jan 2025 09:20:13 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 16 Jan 2025 09:20:12 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 16 Jan 2025 09:20:12 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 16 Jan 2025 09:20:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RUC4ZKV2ym8TxFkVAYDdXXJAtgbHOxEibfwakAsSqaiTCFpRuY+5OjfevaAy6UxF8XGg2ao1PD0dfZM4Ne+W9nTV2CXr8xtk39lj32ou2wWW3B0+zJtb0oc7MECd0KFdyIyggyUO8UVLc4LoCYEjpm8ZCOqMYV7aUAGis3cMyuaHdN0FOrBz8rmx5TjYZwBoDCrgaSMjnzb6+Lu8OuRQM5Oe4Xb9Tgt0Gri38TNQB1dWNCmyTeD57QrkNta0lxbS5K46kNxxTFQ9FwsNgcgkbLHitxl7amkgW47gsvKuhxb+iw0IJMGYH/wJTpbwQkYuGnfD2DY60QsJXIBFh7BDGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jRE40KEJVts3Pyhd3CWo52F4fUQb5tL+SYsX3BaBCv4=; b=wt8tQ4r25ZM/JNz4ZcengiYCVGhciJku8TzPTxaJP5hfbjLGWm/yiY3A74VUesMaHOZI7dg6AGZvqmc2unj7daaYwQ5ysfrtXAp1cIeAUfz92U/jLZHomwlLHD4+QsknEWRJSSAsbuerpQOKlOeOPnEVwjqevMdzqMgEyx1xte+5Us/8NGzevydVqKNUM5zlTXay7w89JXWbD8Fvtsi1Lx4CcCmV5luWxvHFrMW5xQ4Ug7p2NtoT57/AdaI/EmwCO129iPHoBRtcCICkUvA+qnBe8+3Zkaj/yE00/mQmw5xySsCAIZ7QbbaklRYmnnavEgNUaJc2NcyNKliiJUdsOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7412.namprd11.prod.outlook.com (2603:10b6:8:152::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Thu, 16 Jan 2025 17:19:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.014; Thu, 16 Jan 2025 17:19:53 +0000 Date: Thu, 16 Jan 2025 17:19:48 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: <dev@dpdk.org> Subject: Re: [PATCH v4 00/24] Reduce code duplication across Intel NIC drivers Message-ID: <Z4k_tEX_1bXIiHVW@bricha3-mobl1.ger.corp.intel.com> References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20241220143925.609044-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241220143925.609044-1-bruce.richardson@intel.com> X-ClientProxiedBy: DUZPR01CA0054.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7412:EE_ X-MS-Office365-Filtering-Correlation-Id: bb62f2d0-4abd-435b-159d-08dd3651fd79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hIW2r7cD8dnt4xPC7AIfHw0DQNAhpxSlYrCU+smI2IIvY8uRBuuVNdhadmKg?= =?us-ascii?Q?p9H4BjeRqdXpezvCIuZBnjCBdW/lfrsCTRkwQjrHx5mv7fRZMZNBwv3yihrZ?= =?us-ascii?Q?DxZn8osTXG8aE8otKFgiXsRvKL8RetSA2J74sAprD/KOwhcLtz2cnfAqksFS?= =?us-ascii?Q?Aubwh3CbyvQlCXe0T5VRPQHFmSNkO8qgorPUEA5EVYXLd5B0ryAOGruEx2AP?= =?us-ascii?Q?vlseBdi6Cx3ResZDGt77kQS8X2NUpOMcuDUQNEeK4hvM1pFp/aBP1hdR0QiJ?= =?us-ascii?Q?lxY3WH79AuIOaFwhyiJsUvjtNmopaFIrMyhlA9t7+NGQBtrFx+GempsuofKh?= =?us-ascii?Q?+0ylVBnDmbu2eIHz/n2bErGnNQjhbHAGhRVJ4ix9Le5Ou9AVJl4HR7SozfQt?= =?us-ascii?Q?EIBm9wVRnz0v1QCvvLGV1YSmkYAdbaICLo5ZFbfMARNnklfatW5f1QuJyVpj?= =?us-ascii?Q?2pD34jDKScd92aUX+VENgI1Iqhr2NhXn4UW/O8J7e1/CFN873erZNmMQaCpN?= =?us-ascii?Q?YTFnqBOl5rjDiou8lea9fxVul6iEhsZkOQh45gHLmwWfQy9VhwPk2NZ/mrU6?= =?us-ascii?Q?6WR6s193J7ZKnzcqRzaNb6Xebr73IHDudgMkmULczr590nLnzZHXGaOo2D5c?= =?us-ascii?Q?t8FlXcXm+l+Hwmd+CLHlJO9HgLFxAV/b8/OZ7jXkpGRstUj3xwSrLbdQ7Jz/?= =?us-ascii?Q?OPfnejwNJMg7rQw+B78DL7Vaf3zaJrSC/B7wvCO5W4BUuRzXb3aU92ybHYX5?= =?us-ascii?Q?Ka6MiYAIHFmYYBYQCYNltynp2NQCjo0fqu4G/9zuom72iJH/6V0mb1Lsz4i8?= =?us-ascii?Q?+QgpdDMQteJNsoadBheCGhpzSg7aTzXNsyAX6w7umjcWrEKUrjCl+JXE+MvG?= =?us-ascii?Q?Hw9BEUyKd+SD9vakzbkihEST//jN0ACkeBqsqSSEmwpTVNxOc6UXao2ZwlsN?= =?us-ascii?Q?c+olfg4jJSgEDhI3dbjkaLpLEL5DB6uZ/1WjUqIHDk9nCR2e5ZQkJyHW9hOh?= =?us-ascii?Q?+5KYMlisjMqFWicv7qZtM/UTx18TaCRmIJSg9sBimuQ+GuVTg7dnr+UEHmAd?= =?us-ascii?Q?Zhx5cdwRNnyJ2oRCCkuhNRu6GEV2mEOQ4UyyK98h2Nb4HCl0kLHAV2vDiBvB?= =?us-ascii?Q?h494ythD+678D/+r9xu4Z8mVaLOSMujkrXqWj9zpYKCg76FB3gtgJJ7VIOiU?= =?us-ascii?Q?ar+OCHhqKUwk3CecxZexGljF8HUfVZHmM5ykNSr3DSJfPDAb3VaiV8lkGpXk?= =?us-ascii?Q?+xn98SsLbt05yMjI0e+azV78PGnM2uZ4CFzqeN5iejo1wiFyBVUM1krhl9M/?= =?us-ascii?Q?o3ODQZ8hQJiYQ/Uauii7dSm4tSHAoUs0k/60PGePmgipA2ehtEkUr/zIwNqA?= =?us-ascii?Q?oMysAPD1Jh26rqhfWJEP6gbZd+Y1?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4vttHic6HMOoT+wzIkOEE4o0ikt9WtCUonFb+9tCJQhoz9huUzKXThd2vLCs?= =?us-ascii?Q?aSGviFQU56v1ctmi5zQpr8De3u7lubA2FhMBAH3meGNyZnSihI6DsX4dvi89?= =?us-ascii?Q?1LFXZn/qe8Mijhmuh8hK3poqVAOmlwlrTx210MwCR+rkaFbyWsPUYYs+Atq5?= =?us-ascii?Q?xMoAWWXEF0xxfTqxoT+Prp0dvpKJ9Tpj5iUi+UO+lNuqr3/bd2egi+UJQ5YN?= =?us-ascii?Q?d8NEvQ+wV3D3DlrcvmN8QQCxnGqtZVR7bN1gepn/V5BVq4kSfWck/XvvS5PD?= =?us-ascii?Q?Yio3a/3suSFRSHXlPdIrpDaPVGBWpMVgNmb+VI4I09v2rqh49onOqDRjioAN?= =?us-ascii?Q?/LmozrUlg+EkVhNvR4UQD7nQSBzQo+Ara589S+sFmFVQjoKYGvaC43qXpAqz?= =?us-ascii?Q?yLD4N5vZhjKEWrjKw2qj+uccdvkJlMCiLjwi3wNAdtGPw6RnMe8YqYie1+ZH?= =?us-ascii?Q?BzLoIbrfdM6xveVzF49DSXFwdpaN/tAYvMKzYzXom2UPdhJX/IKOP1MEjSkd?= =?us-ascii?Q?zfr/Kb4oEo0DnB5dmVya97iZVJybhkbbSmLGmQeCwxTO88iOO617RyYtCvfU?= =?us-ascii?Q?dPLAbt51dwbYm9Qov/FvuVXbr0wdk6g8u4GZ2MTzceL8Ip67EiZ2wOkEI08T?= =?us-ascii?Q?hGbmli7Q6DvIobryaP3sAPW7trnBXnmhOg4KZp4qfvAG9gcj8JA9uyzhvIIv?= =?us-ascii?Q?zythy1CAKEpZnt2NCE6eDF1fy2h2wK4yC9BRzrWptkF0EjBySinbNYiUDfcc?= =?us-ascii?Q?sfkIpcZqO+UbsXvMD/UZ7CEUbjFFs9SIDr6w0j3M3qUYN+jRZo6NLl6T2abq?= =?us-ascii?Q?M0BsWJhUrx36lx5uDJ6f3eetU42QbL09l7EsF1bZTbcUFI/FxLJeEc03MFjZ?= =?us-ascii?Q?wm3SDR+ggxTqwRFDQORstBc9pg1cIjVEkWylZmdCrJLKVcPjXTRmNechShPM?= =?us-ascii?Q?XXW74MiSCrHmomBEQpHPlfJN8CEwwlrUjjRS/TdYylP1m7QrrkK3mngy+taB?= =?us-ascii?Q?7mCBbpQjT1dn70LuvAmZJAagDkpV/h+hOvikztrinLkTuZel01+UZ1IvhZGS?= =?us-ascii?Q?d73i1Py9gZfiUivVRT9VrlPGbPeUuNldgQojCSvJ2U6SLB04V1f4OEGHAgMb?= =?us-ascii?Q?bGKHYcDwM3NvjP2Si3/c8MA7cWpmT727lMSy/N3s224u6sj3MWkfA7aNnWB8?= =?us-ascii?Q?WtggKguEZKGjV8isnXM+6d6Qjp6zstNppC6ZXl5Ecpqqq6YcDQH/p9L3nraZ?= =?us-ascii?Q?A3KqJ725YyMAw7p6qWwc8Gep5/exuigxaa6yBLrpxHKtJ6gpRz2nTOCpcQ2D?= =?us-ascii?Q?RRARoxtY3INL0ICkH0tf5uN2bhvocBeoAffKzuqWywIuoHLY8mCC0N+MvnCa?= =?us-ascii?Q?ji9gplP59VLN/OoQiBrfBjDut4d/b5nYQ4x2hNlxMVaIaasaApOYcihisKrH?= =?us-ascii?Q?R1/6o7zGG/ykhJNzXRnAv6WJRSO+oKcSLwRK7ojopeJfPohGJMQDKhNkPTxj?= =?us-ascii?Q?/4Mifnxnz2xHuOVwZIKM/71hVfGz+cCEMV4p0chiahl1KJhAXHmPp04tcbjZ?= =?us-ascii?Q?zheLRitjnWmgbA2/gcHCc0Wu1QIa8tMc7JIZmB6RohKtTSGYMxOJARhN7zPw?= =?us-ascii?Q?oQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bb62f2d0-4abd-435b-159d-08dd3651fd79 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2025 17:19:53.0803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9ISWRU5/OuxeB11B/CYUSFGJeFnHZwWZZj4zKuSDpZLFBcRQeg0TZQuod5grNltQ1rme6iSTnvlj1JZgCe6t5lchduY6+Rk7kc8ijVkNqyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7412 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Dec 20, 2024 at 02:38:57PM +0000, Bruce Richardson wrote: > This RFC attempts to reduce the amount of code duplication across a > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > > The first patch extract a function from the Rx side, otherwise the > majority of the changes are on the Tx side, leading to a converged Tx > queue structure across the 4 drivers, and a large number of common > functions. > When considering the changes in this patchset, I'm still not entirely satisfied with where to place the common code in the repo. Using the "drivers/common" seems wrong to me, as it's for code common across devices, and having a "_common_intel" (or common_intel) folder inside drivers/net seems a bit ugly to me. What would people think of me taking a leaf out of the kernel directory structure playbook, and moving the intel drivers into a separate subdirectory "drivers/net/intel"? I've done up a prototype RFC patch for this (which I will send out on this thread), and the changes to support that are very small. That then allows us to have a drivers/net/intel/common folder which seems rather neat to me. It also shortens the list of drivers directly in drivers/net by quite a bit, since there are quite a few intel drivers accumulated over the years. :-) Thoughts, comments or objections? /Bruce