From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2 0/6] fix the handling of deferred start in ethdev
Date: Mon, 17 Feb 2025 17:13:09 +0000 [thread overview]
Message-ID: <Z7NuJV-4DfhCee8O@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250214174224.79142-1-stephen@networkplumber.org>
On Fri, Feb 14, 2025 at 09:38:53AM -0800, Stephen Hemminger wrote:
> There is a inconsistency and lack of documentation around the deferred
> start configuration flag. The queue deferred start only makes sense if
> the driver has a way to start the queue later via ethdev ops.
> Therefore move the check into the ethdev queue configuration handling.
> Fix the driver documentation where the support of deferred start
> does not match what the driver implements.
>
> Stephen Hemminger (6):
> ethdev: check that device supports deferred start
> doc: fix feature flags for queue start/stop
> net/dpaa: remove unnecessary deferred start check
> net/dpaa2: remove unneeded deferred start check
> net/enetfec: remove unneeded deferred start check
> net/virtio: remove unneeded deferred start check
>
> v2 - rebase and cleanup wording
>
This seems a good idea to do.
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
> doc/guides/nics/features.rst | 1 +
> doc/guides/nics/features/gve.ini | 1 +
> doc/guides/nics/features/mana.ini | 1 -
> doc/guides/nics/features/netvsc.ini | 1 -
> doc/guides/nics/features/virtio.ini | 1 -
> doc/guides/nics/features/vmxnet3.ini | 1 -
> drivers/net/dpaa/dpaa_ethdev.c | 10 ----------
> drivers/net/dpaa2/dpaa2_ethdev.c | 14 --------------
> drivers/net/enetfec/enet_ethdev.c | 16 ++--------------
> drivers/net/virtio/virtio_rxtx.c | 10 ----------
> lib/ethdev/rte_ethdev.c | 14 ++++++++++++++
> 11 files changed, 18 insertions(+), 52 deletions(-)
>
> --
> 2.47.2
>
prev parent reply other threads:[~2025-02-17 17:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 21:48 [PATCH 0/5] centralize deferred start checks Stephen Hemminger
2024-12-13 21:48 ` [PATCH 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-13 21:48 ` [PATCH 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-13 21:48 ` [PATCH 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 4/5] net/enetfec: " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 5/5] net/virtio: " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 0/5] add check for deferred start to ethdev Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-15 8:56 ` Andrew Rybchenko
2024-12-16 18:58 ` Stephen Hemminger
2024-12-17 6:07 ` Andrew Rybchenko
2024-12-14 18:07 ` [PATCH v2 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 4/5] net/enetfec: " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 5/5] net/virtio: " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 2/6] doc: fix feature flags for queue start/stop Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 5/6] net/enetfec: " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 6/6] net/virtio: " Stephen Hemminger
2025-01-28 21:03 ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 0/6] fix the handling of deferred start in ethdev Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2025-02-17 17:12 ` Bruce Richardson
2025-02-14 17:38 ` [PATCH v2 2/6] doc: fix feature flags for queue start/stop Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 5/6] net/enetfec: " Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 6/6] net/virtio: " Stephen Hemminger
2025-02-17 17:13 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7NuJV-4DfhCee8O@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).