Re: [PATCH v2 10/10] app: enable app directory to be compiled with MSVC

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Feb 18, 2025 at 08:32:09AM -0800, Andre Muezerie wrote:
> Enabled "app" directory to be compiled with MSVC along with all its
> contents.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  app/meson.build          | 4 ----
>  app/test-pmd/meson.build | 4 +++-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index e2db888ae1..1798db3ae4 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -1,10 +1,6 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017-2019 Intel Corporation
>  
> -if is_ms_compiler
> -    subdir_done()
> -endif
> -
>  disable_apps = ',' + get_option('disable_apps')
>  disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split()
>  
> diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
> index f1c36529b4..8e8863812a 100644
> --- a/app/test-pmd/meson.build
> +++ b/app/test-pmd/meson.build
> @@ -3,7 +3,9 @@
>  
>  # override default name to drop the hyphen
>  name = 'testpmd'
> -cflags += '-Wno-deprecated-declarations'
> +if cc.has_argument('-Wno-deprecated-declarations')
> +    cflags += '-Wno-deprecated-declarations'
> +endif
>  sources = files(
>          '5tswap.c',
>          'cmdline.c',
> -- 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>