From: Bruce Richardson <bruce.richardson@intel.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: <dev@dpdk.org>, <sameh.gobriel@intel.com>,
<vladimir.medvedkin@intel.com>, <yipeng1.wang@intel.com>
Subject: Re: [PATCH v2 1/2] lib/hash: initialize __m128i data type in a portable way
Date: Wed, 5 Mar 2025 09:13:07 +0000 [thread overview]
Message-ID: <Z8gVo97PpW2ijyZa@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1741125199-1217-1-git-send-email-andremue@linux.microsoft.com>
On Tue, Mar 04, 2025 at 01:53:18PM -0800, Andre Muezerie wrote:
> The mechanism used to initialize an __m128i data type in rte_thash.h is
> non-portable and MSVC does not like it. It clearly is not doing what
> is desired:
>
> ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
> truncation from 'unsigned __int64' to 'char'
> ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
> truncation from 'unsigned __int64' to 'char'
>
> A more portable approach is to use compiler intrinsics to perform the
> initialization. This patch uses a single compiler intrinsic to
> initialize the data.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> lib/hash/rte_thash.h | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
Much simpler fix, thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2025-03-05 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 22:57 [PATCH " Andre Muezerie
2024-11-27 22:57 ` [PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic Andre Muezerie
2025-03-03 22:29 ` Andre Muezerie
2025-03-03 22:27 ` [PATCH 1/2] lib/hash: initialize __m128i data type in a portable way Andre Muezerie
2025-03-04 10:46 ` Bruce Richardson
2025-03-04 21:53 ` [PATCH v2 " Andre Muezerie
2025-03-04 21:53 ` [PATCH v2 2/2] app/test: add test_init_m128i using compiler intrinsic Andre Muezerie
2025-03-05 9:20 ` Bruce Richardson
2025-03-05 14:50 ` Andre Muezerie
2025-03-05 9:13 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8gVo97PpW2ijyZa@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).