Re: [PATCH v3 07/11] acl: use common AVX build handling

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Mar 19, 2025 at 11:16:09AM +0100, David Marchand wrote:
> On Tue, Mar 18, 2025 at 6:35 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > remove custom logic for building AVX2 and AVX-512 files.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  lib/acl/meson.build | 54 ++++-----------------------------------------
> >  1 file changed, 4 insertions(+), 50 deletions(-)
> >
> > diff --git a/lib/acl/meson.build b/lib/acl/meson.build
> > index a80c172812..87e9f25f8e 100644
> > --- a/lib/acl/meson.build
> > +++ b/lib/acl/meson.build
> > @@ -15,57 +15,11 @@ headers = files('rte_acl.h', 'rte_acl_osdep.h')
> >
> >  if dpdk_conf.has('RTE_ARCH_X86')
> >      sources += files('acl_run_sse.c')
> > -
> > -    avx2_tmplib = static_library('avx2_tmp',
> > -            'acl_run_avx2.c',
> > -            dependencies: static_rte_eal,
> > -            c_args: [cflags, cc_avx2_flags])
> > -    objs += avx2_tmplib.extract_objects('acl_run_avx2.c')
> > -
> > -    # compile AVX512 version if:
> > -    # we are building 64-bit binary AND binutils can generate proper code
> > -
> > -    if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok
> > -
> > -        # compile AVX512 version if either:
> > -        # a. we have AVX512 supported in minimum instruction set
> > -        #    baseline
> > -        # b. it's not minimum instruction set, but supported by
> > -        #    compiler
> > -        #
> > -        # in former case, just add avx512 C file to files list
> > -        # in latter case, compile c file to static lib, using correct
> > -        # compiler flags, and then have the .o file from static lib
> > -        # linked into main lib.
> > -
> > -        # check if all required flags already enabled (variant a).
> > -        acl_avx512_flags = ['__AVX512F__', '__AVX512VL__',
> > -            '__AVX512CD__', '__AVX512BW__']
> 
> Not sure it is an issue.. CD is not part of common cc_avx512_flags.
> 
It is since bce754b5d942 ("config/x86: add more flags in common AVX512 flags set")
See: https://github.com/DPDK/dpdk/blob/main/config/x86/meson.build#L68 

/Bruce