From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4846141D3D; Thu, 2 Mar 2023 10:34:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E755C40E09; Thu, 2 Mar 2023 10:34:44 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C0A4840DFB for ; Thu, 2 Mar 2023 10:34:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677749683; x=1709285683; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=puZpFI6AhgY4NxPxn7hGOhikwRQTSGOMMBSTCTFD3tU=; b=CE6QQaOyivjHxlPgke36kQpTnYNsfY+Pk//yV8gw+ETNjTyXoioDooam +vZSP3G5+Zs3E5G2eSSqJvrG4UjWktUqpDdztO+xSnH4kgybn5M/H6+GA 2Aw9RH2jh6L5tl3sD22mzu8ahO5YJ4vL9vKP7MXi0XuU2fI631J0MhQvu jpiT7zJlY2WphcGCsrAW790ZdvszMSRQb3YfNKUgED4WBTHak2j/3oZp5 DIU/qm3pglseZEkw4I3b56HTwQDJrkYAWPb6NasVnMm6VYYy/g17cN/UX 8F/RxPHB5uzFcxodo7RGtsjafHe6avlqjdvatZHt+9FtI0MEoH2giFmIo A==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="322949844" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="322949844" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 01:34:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="624872113" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="624872113" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 02 Mar 2023 01:34:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 01:34:37 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 01:34:36 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 2 Mar 2023 01:34:36 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 2 Mar 2023 01:34:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WcYpvrN2vW7pUIupDIGhp1dhZjCcdW/RpY1epo7va4c8HaZz8zGKgSyclVavxDsH1KUsmmr6y5kPuEduaZXYE5g8SxsMZn34mkjYGhCycuYi6Lw3tZXbk1V4ZeJXYtZ3i1h3qErYQJBhc4EHjlv3yzr1JBC4zRB7IrneS6GxBVY0e27zRgp7zE+TDQwnRY3jTffkHBJx7b4TfJF+EpCJzbDdaXfMSSrFGlRW6C+E98nJpSWAj7i8avoC+iBqoZ2J5etQdxDgYsHv9sbabXSNCyjbvM94N0LlVgh8f65SgmLvrExHyRIK+a9EX2YUGDhxw7PWUWTBwkEQtAKofn2GmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZzWwKtqc8HANDRWpJRwSM4BoGhsMQYcYvhpGkQiJua4=; b=DUDtk2j5nrd5qiQrw0YJz9fk1bRPEzdyLQJvIg4rgTL/fGQcpB0yXZh3jsRmoWXY/8s5FtjAgaSQVb5bzGbvBxWAYolPI1SYvfOWjym2+6XfCJsJ5KFQdMBZuCLsRbX0GidCcrtN6vImZi4fGKKGb9piPv/o7STlrk7Z+T5v51fgjdLjlWpNblD7wu5WcS8LOmmRMrgpRyBLjr9jAGeCKza9yabjWEm8yxh5zH0yxsXnw4+0GN+nL5O6IWglZiP0PnysgXjs2TU/+bRIJgFkt3Slu04hCaDr2Vh7WaDyDPAlkCvEFHfYwUEyV/NhFCdBkBKDsATh9GXx9ZJ38mdD9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN6PR11MB8171.namprd11.prod.outlook.com (2603:10b6:208:471::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Thu, 2 Mar 2023 09:34:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%9]) with mapi id 15.20.6134.030; Thu, 2 Mar 2023 09:34:35 +0000 Date: Thu, 2 Mar 2023 09:34:29 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , , Subject: Re: [PATCH 02/17] telemetry: use previous value atomic fetch operations Message-ID: References: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> <1677718068-2412-3-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1677718068-2412-3-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: LNXP265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::27) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN6PR11MB8171:EE_ X-MS-Office365-Filtering-Correlation-Id: 3942f439-355c-4070-1763-08db1b015595 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /C3/rYET8UMRvIVHt/8meh4Ghc0MTFXSkRCXwDtbxoSyCzbZdYn2tgYhcBjIDwGzSSbW26+pCN75SFnbUOD97H4fmIuAvH9U/KLEyRvmbe7tFIe/7BH+QsPakLJnG8se7yHpFpYMdiOubOfRjn7BOqi72J667AxnQcn0o5ev2ksiLS5CvqexSWl8IRrxJgsGICgUt8svxDb8SxUHA8FJlQiB2cco17uEsobAt2hyHklt3HBGPmzSdQCMQHV2B6CS5QW2zEJptM1O8DkWgo2keqqEr2JwIxIWOd1crI4ur4hQzAiDGTMySFodKPfl2HO2SL1ukXcWo7FUm0gsJhg7gA9hnsOQwk3c0dnwLifKoEV/ps/grm1p4L3Q2xo+byDl+FvS63Ayg+4UQeSuGZ4rfJ3dUfdoa2E3MxTnQtw5bH6colm8xtNrDNT5OrGUAvHmxvR+J5Cra0zRE/LknswxYJXR4G+qfueSNYDYRUiSu0YBUhhP3VSJd+dbyfRHp+bypsos3t+vQekQhS7T7GoANu+Xy+nh8WlkXwG4sQo7uPZSGcZjxcnUXZHpaeVIPokPHXm6IdZnjeJF/zA1mdM8B9UuixMlHWmfiWqCY3PPuFdiAzD50YIs5R3UV8Lr7a94RFZRfNUMP/l0aNTGzmzkhw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199018)(83380400001)(6666004)(38100700002)(5660300002)(478600001)(8936002)(82960400001)(66946007)(86362001)(26005)(186003)(6512007)(6506007)(6486002)(66476007)(66556008)(2906002)(4744005)(44832011)(8676002)(316002)(6916009)(41300700001)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4owzHwhAdJ7AH8iUYy//qWCoIGpb3edZzY0VWBqZHdTGwnVbbCYlQ4ejADMW?= =?us-ascii?Q?bLZRLz4XYxFWS1y5yOW3zOnMMZFRikj9U1TyiJk0Og418kDoTL0B0e4Exke7?= =?us-ascii?Q?qn4mPXe3vBn/vsI96h120VniDitbhGxjQmQnavnNJNtLpCJ7XmN7Ec6KPcGC?= =?us-ascii?Q?+rq+D2tLk2iY2Ok06Sqm/s/U9jZsOlSiTltofPOdhrR3QRqEFvFXwXS3cNBl?= =?us-ascii?Q?0q7XEaoXyVESqxir3VwlGF7AqqDzJJ203uSNl70R31YuKiOJg3XOm8tLvlIQ?= =?us-ascii?Q?zUguzPJBnXvyiUI/rrS8COdGUjcNm6LdMLo2s8ZSdGTZxoccSHd3KuLz1ovy?= =?us-ascii?Q?MfjtLwBc+/xuhA/4+YXgtf2xxUptHfJBGZW/INBj5yqJSXjgFlpyKSg0P6nD?= =?us-ascii?Q?iqQnV6FttHG9L7y19aBud0BpHAQBkwPzrzjA4dniz+nuWj4iUM76A6TOKrY7?= =?us-ascii?Q?BwhIRAveHO5bYWbJKZxzcpdQc/4EkxU1MSN8QVxISqD551l+MsptlCXGkKxO?= =?us-ascii?Q?KDqRhfkK3U3y1Wm8n4IdV5zhV9audCfCPq6eeBYyfUK4k+d0wVaDN3fhpTt7?= =?us-ascii?Q?aHBXG/mbcbVNMlD16ealLccjruyF+nakkCuLl7vT6ZUTtJeNOEx3q44m3ZKE?= =?us-ascii?Q?2LM8x0+ENGCltxlMfD1oZCp/yGkKgstPT9rg1rg208C0/iYThe3wwAxkr8fI?= =?us-ascii?Q?MeKO2aYBTy8+m5cz9mIZmv3FzYyOJjP/Ngg23+ASml+p19nBCTtC+GlG0VCb?= =?us-ascii?Q?b+oXfiRGgxbl7Nhz1KU/hugXdbgjVGqEw8Q7OQyRxedArL15m6xeU1iKAJ7P?= =?us-ascii?Q?We0H18IUx1lpx2eUuSLlsybgbJfl5YS4d69Ik3cBEh8+mNSXSN2pnkSDDfpI?= =?us-ascii?Q?O2zfHeQ2ZKaenQUkQekeSK+u9aPt72qjdy08Acgd0uM1ADMX/b0ChAxhSpGI?= =?us-ascii?Q?7VwqYseE209qARz9ddLTqrzMiyqSXcB1xWe5I02h7x0r4R6CdDJTySyh+fGD?= =?us-ascii?Q?XjxVcQ+tFnPx3QqyWx52HMLXnnnwYJcZ6tTP659pDkBXvSauERc1mP0BLVQK?= =?us-ascii?Q?nK1f/ouozfWg16SfpK75PzD/epLUVrNdES9Zffapwa19yhwTgOdtmlFDKVkq?= =?us-ascii?Q?mh0kVGGJH0Vzbe4D/LGhNaxQVf7k5p6qRnTyuy3yphdc83oZ5fkJ4RYhLWf9?= =?us-ascii?Q?KHvwe2nrzzK70poou9NHRE86y3YLGbxL+GGN2hDwNtNWgvt5FC8WAzhWAUOF?= =?us-ascii?Q?OPyJKwu4VdSM5XbnetBtu/nb+5S2wPq8Ll0YeB802BDyDROB2CAFl6P8+jZc?= =?us-ascii?Q?qJmb5k1NvDuWPGBKAxdGLTGEP9FQPXZf7xXiKz2LcgGjLEK7IpA+vL6Gaj3o?= =?us-ascii?Q?tft/fHp+CugMmzEDGB0wCaJDC9hRWfZbzJCp+uoYpJWvJUL4OmKKFv7nc+sn?= =?us-ascii?Q?w/GQKDaGhGOm+HzxyFGFPwVPMuU3nLAAxxJGU6dDtzRMicts8e/nYDVyDgNA?= =?us-ascii?Q?dYZ1GCdRfZnoh8FBYtFaWmuROAArTOpdT0jNpm0UQqbEhKTpwSvA5wkAHI4w?= =?us-ascii?Q?7AR44WiWOw8P+3+UhnIADO7C0m0//JAYtFgOKgJeI7Kec4DZM4dM5TFUNzsd?= =?us-ascii?Q?1g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3942f439-355c-4070-1763-08db1b015595 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 09:34:34.9058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zcKhtDKeCMZy5bWlYfibZUsUMLibA31lHOLKVKzj0qudW0dhl8TCMSRYTApNaDXDcHoxCw6ZzYhtJ6IAU953zi7qNMdlacxdbTskn4uhJLI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8171 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 01, 2023 at 04:47:33PM -0800, Tyler Retzlaff wrote: > Use __atomic_fetch_{add,and,or,sub,xor} instead of > __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the > result of the operation. > > Reduces unnecessary codegen that provided the result of the atomic > operation that was not used. > > Change brings closer alignment with atomics available in C11 standard > and will reduce review effort when they are integrated. > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Bruce Richardson