From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6748F41DCD; Mon, 6 Mar 2023 17:39:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E4E740EDB; Mon, 6 Mar 2023 17:39:36 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 45EFF40A8A for ; Mon, 6 Mar 2023 17:39:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678120775; x=1709656775; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=pHHFUpYfY01UKUtXvA2dQyA7btElwrQDEgxsEKXEG/g=; b=cboWXugrxMJ5zeK2Lv3NE/BrQYG/cBCNQbGUst77vTu9wtCy1JnDjvHK /p6qpfxJnQq4OVLm7y1PfU4OfNaXrkvFq3BJMBL2uXOwztUfAksxZqVdZ DQWD8ufxSOy5/0hvxZNEAiUOzK7XUwlYAMC0QBQGI+r6Sl3tolTo3hldD /luSEdqBqeaD7f+b7nuONfXwCP+Cjhxey8o3XssZthgjyAapsJC13rTZF 6jEfi4f6Ttcb2mU//onytqDn9J5Xyk+JYf4ZYvYueXSKaACl3iSHdWTdz AUU+R7uc4TYjKYSIIBBYSQbXtwg9pGqe4b4C1qwtW0cWD0eO2uHH+Tjwh w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333076461" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333076461" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 08:39:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="765277100" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="765277100" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 06 Mar 2023 08:39:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 08:39:22 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 6 Mar 2023 08:39:22 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 6 Mar 2023 08:39:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVS6N2hcYNv4F9bAXCKXPDgFv67qnlRzVfvj8uAiaYVfhVyTlzdzb6+gp3ij1wqqY/nPjmOlsnDregZ7LBIkIPkthYEGSq5b3lWirfp2QDp7WIpDQofHcX5bHVOCrW8BcJbYsN/8jNrRFVwOjA0VInhYO2I+Cc+qx8ajj78MM1gbPftCdW7iOopuqdNeW7MUl/ATGAAjTS5Ta4WU9CsQ30gOl1IGCx4lynhZ/zei/SvPzJlaWZ5637johCqfHauFidkrmEsM4hfr7tNGfUsxn7ktAVr73Q84i5m9VasKrMfa7M4y0MXsCk+3k/+Qvq6QgSw7horfB335cAEpEFrvww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GjlbtdJTFkfdZVEfsoFwrzIzYkph8JA1+ndUWofJKrU=; b=CTXPJJQWi1rCZ2H5Bzjw9smVutMrS6Kv5CY3DMiEh+E8yHH7QoeqrkPQ4HG6GXNgSaWKIBt69PX1Lc3+KuMntRFMCONpcCCpBogsJ4DtY0N+PaItU4FCuwSCuNDnumZiHTxLpfj4zlDZNDt/imO6ngKM8Uy2Na1MmJVjmuaGRexda5ODX3TbWrvW3Lqx74mXeh0UHmzOP/oF2bqbxtjm14eHVO/i1ikTgym2XuFyBR+nuXICrAREtwzQ3CB0H0CYl/KpegnwZ7o3nlberdaCQL47+fZ1Q6DBXqKKssea6cGOnRNpElu+R4lZnTDJXGPv6kv/knht0uaLqf1L0z9iTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5147.namprd11.prod.outlook.com (2603:10b6:806:118::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Mon, 6 Mar 2023 16:39:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%9]) with mapi id 15.20.6156.027; Mon, 6 Mar 2023 16:39:19 +0000 Date: Mon, 6 Mar 2023 16:39:07 +0000 From: Bruce Richardson To: Thomas Monjalon CC: , David Marchand , Qi Zhang , Morten =?iso-8859-1?Q?Br=F8rup?= , Shijith Thotton , "Olivier Matz" , Ruifeng Wang , "Nithin Dabilpuram" , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jingjing Wu , Beilei Xing , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Kai Ji , Pablo de Lara , "Radha Mohan Chintakuntla" , Veerasenareddy Burru , Chengwen Feng , Kevin Laatz , Pavan Nikhilesh , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Liang Ma , Peter Mccarthy , "Jerin Jacob" , Harry van Haaren , "Artem V. Andreev" , Andrew Rybchenko , Ashwin Sekhar T K , "John W. Linville" , Ciara Loftus , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Dongdong Liu , Yisen Zhuang , "Konstantin Ananyev" , Qiming Yang , Jakub Grajciar , Tetsuya Mukawa , Jakub Palider , Tomasz Duszynski , Sachin Saxena , "Hemant Agrawal" Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf Message-ID: References: <20230219115529.3260580-1-thomas@monjalon.net> <20230306161328.3802696-1-thomas@monjalon.net> <20230306161328.3802696-2-thomas@monjalon.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230306161328.3802696-2-thomas@monjalon.net> X-ClientProxiedBy: LO6P123CA0037.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5147:EE_ X-MS-Office365-Filtering-Correlation-Id: 962e8c7f-8e98-448f-f10c-08db1e61548b X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SOtW1iU2+LFA8V5YyKn4s4byM8S9f9CnMaCsWSgx/DLg3CT8v1ny748ejiZXqylYl74C92QseFloNsddXpavImFC5QfZCbFoJKI1iSZ2cCNgPn71snVjkU/rIvnaHJ9A5eNznHbyNtl+fcnt27gTCAkdJQZ3zHRlFbbh1Gd76pa81vka7W28hMITqgSa/gaGt80lXSRaHrCgdWeA+xZLI0x13PkfOvLh54TtBSJDhDNwTdKgBaSfo6tgQCdDwKyH0n704swkQifJu7nitoSW6xryDEntT3oBi1o31VFlh9DDLFwD6u7CgZZncyZilD79SlRYec5f4jTReD2NxZ+MVrOW56IGxwram+4k1vDAjPxSolMvbmvWYHS5R31UMWfFMVv6CI4mLALx/RpcwWKRIIneWkyHogZ5bxMTwVFqwqoY3cKR/Bi1X6VScG+90bL8yhbIvjqPQS6cfQyXrD6GAObgR7lOYx33oizdFUydomC1CSaEF7K2xY9x3sro3JvaOmSYB5GRlBBCTADyXUW19o7fLsEhL9IQoNtfe9Kqb45uijPk8ssu3ZNQDwbd+oTlOVvMBCcQlJA0qNYzpVac+5fx+40gBYoOS211B3165lqmGjxNi2fdMLQVSqWpFgJRJeR70YppyheSJOVI/rji8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(366004)(136003)(39860400002)(376002)(396003)(451199018)(4326008)(66556008)(41300700001)(8676002)(8936002)(6916009)(7416002)(44832011)(2906002)(5660300002)(7406005)(66946007)(86362001)(82960400001)(66476007)(38100700002)(6666004)(6486002)(478600001)(54906003)(316002)(6512007)(83380400001)(6506007)(186003)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zZxbTuSPBFQJB1yHCS4OCKbiBgquf4+KBP3yGeqFoCtwwm7RcXFLs/UcZGEh?= =?us-ascii?Q?uqt0QiJ0q82HdKuvIyW7SO0fA0Ioo1OtiG8EVxVulmqffdGJv943US9lEuP0?= =?us-ascii?Q?BTNf33o0yNW7xs85y1QtqKFVigaAoZnZM7+8Ijl6FqPsHxkWvMtWSJswndxj?= =?us-ascii?Q?pMAUju/+aovc4B2lkzMSv3dV1mQOriDyH4JsK0DW/cEyW01w2Im7wDgPLfG5?= =?us-ascii?Q?QWOBtBUHXmO0Adjm3RIu3gPm5U4S3ZiXujvgGCb2It4Kb+LTXmfK+MfA0Nhc?= =?us-ascii?Q?EYl0RWdfishJZfPXVwnCX7RIWg8sFO5MmQCpSqVHR2cE7keBjeJESWAgI3G6?= =?us-ascii?Q?No7QreDOXQvRoezVyn5d52Tk7kBfqplxgIp3WDCUkXFoLj+Xj5AmaV8oHQBv?= =?us-ascii?Q?JlkmS0qzlTOjbN24KRqxRwuph0rCoQQ+JGxShofgVuhY2CgHoEax7x+Moppy?= =?us-ascii?Q?tlpnZ4TDuitR03QOixjXNR+loXw5vRZz7VbHek9kdOsGcsr0DrBPFHhSws8y?= =?us-ascii?Q?iN6R0fs+38hpdxLn6kDH1SaP/wVJ8sY4B5IWySZwGH467WvZtALU0avzP93v?= =?us-ascii?Q?iqR5ZpA7m/cdJfGrCpD/7Nr8x49qsYLxk/VuPHcoZXHSC0Habaxz6/gPZ0O8?= =?us-ascii?Q?sGop7VQHA5ZKrf6GGbbMxMXmg9pNF/5kyTq2/4zPYOsnIuLWzeUCgwkYcOUr?= =?us-ascii?Q?BljAKnrlHGzJmOvJPk7l427GLtaKIHTbGy0kcEEGMZLnr5K34VyecQRg9V3z?= =?us-ascii?Q?PAi8e9QjMjyBkvbKMryWQ8AU6mOBG0N18xAiIAFi+wL1Rwzqjx0Opfsn4/Zn?= =?us-ascii?Q?9AqBaEPsjVBf5ygv6MoFEJe+u/0QiZnrVN3HrvJs8BRNe7ma9px4ErKSvEic?= =?us-ascii?Q?zj5OMQGYER+tChfTNqYGeScuspzqSu5B7m9DrPZYUwkrThbPIFzIDw1Zd0Wp?= =?us-ascii?Q?GpdT6f55YqEtBP5TVthFZJimGzz2lDvuH1iL85ISimVEHyX1cwxF6EPn+/b9?= =?us-ascii?Q?HFwfO8cBrXw2kvzCo3oARQUcVPvsp1N/AMWN6XAEmcVOsxWGEFZbcR6Bx9Pd?= =?us-ascii?Q?DYN8hCX/gqL4ZsvI0LTXwbVhGLOLYN/dkrdXmvFyI2ap48FvoDJRaV07bRTe?= =?us-ascii?Q?foLOckNcOGVNbDU/jSUyl4j1By/YWqlymloOFzb21ikttxDhSCndYSqHMrjV?= =?us-ascii?Q?V4cxXhLxVuQOrsc6US4xXVhQ8vzJQQ7+y22/fwvtJcd9wECwas/ZHpu5Ughc?= =?us-ascii?Q?nIrKTc/EG+KDVYv8A6POGW7POv77ujphkyrKJi3oGNI6Oh+Ez7aM4pPV48BA?= =?us-ascii?Q?DheSz34aisv+FjA66JpfjZWWQQcSqiIThUU3/W71cT+1gw4+nFr6L4PQJUaa?= =?us-ascii?Q?KWTc5rjlz3q5L1HY7vu+CVbJU48M3+L0vlUKl+OI5RX2oyg3gXsonbGJ18Zk?= =?us-ascii?Q?eJEBlr+Glu7cRKNrWKbonX7hjq+BG0D+ZpbZ29q8Xc6+wAJU/SQDaTnc0VWJ?= =?us-ascii?Q?a77fNpJEc/jMncQCEEs86ppP5a/DtKQP3Gn1H6MI5gjySTH9mtZQPv/GetZK?= =?us-ascii?Q?tnBP1gWDp/VeQ0fXyhosVK1SPu7ARc6j0iiUcUyXq/ElD2qzEHL2Xy6/gTfU?= =?us-ascii?Q?Rg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 962e8c7f-8e98-448f-f10c-08db1e61548b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 16:39:18.6082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vFISaLcl8EXHsTay2CMdH6j3d14zbYFUMqSEnM8dV/jCyOZ8mF0NRiqH+vFjC0x+o87w2eakhpXYSQCc2Qam7R9cvmLXCTlGYK3epcoel28= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5147 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 06, 2023 at 05:13:27PM +0100, Thomas Monjalon wrote: > The impact of the option "enable_iova_as_pa" is explained for users. > > Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF" > in order to be more accurate (IOVA mode is decided at runtime), > and more readable in the code. > > Similarly the drivers are using the variable "require_iova_in_mbuf" > instead of "pmd_supports_disable_iova_as_pa" with an opposite meaning. > By default, it is assumed that drivers require the IOVA field in mbuf. > The drivers which support removing this field have to declare themselves. > > If the option "enable_iova_as_pa" is disabled, the unsupported drivers > will be listed with the new reason text "requires IOVA in mbuf". > > Suggested-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- Reviewed-by: Bruce Richardson Couple of comments inline below. > app/test/test_mbuf.c | 2 +- > @@ -127,9 +127,9 @@ foreach subpath:subdirs > # pull in driver directory which should update all the local variables > subdir(drv_path) > > - if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path) > + if not get_option('enable_iova_as_pa') and require_iova_in_mbuf and not always_enable.contains(drv_path) I don't particularly like the always_enable check at the end. If a driver is set to always-enable and it doesn't support the configured mode, we should throw an error immediately IMHO, rather than silently continuing to build the driver. > build = false > - reason = 'driver does not support disabling IOVA as PA mode' > + reason = 'requires IOVA in mbuf' > endif I think the reason given is more accurate, but for those users not familiar with the internals of DPDK builds it could be confusing. I think the message needs to reference the 'enable_iova_as_pa' option. How about? reason = 'requires IOVA in mbuf (set enable_iova_as_pa option)' /Bruce