From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C2C141DFF; Tue, 7 Mar 2023 10:12:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AB18410F9; Tue, 7 Mar 2023 10:12:15 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 659C24067E for ; Tue, 7 Mar 2023 10:12:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678180333; x=1709716333; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=eJDVy2OyLa8rYOgwDgRb8XCIfv77KmyhifFNY8kTwM8=; b=hrrABE6Go41oShMG+q5bsfHejTZES91zlK8BETLAXYuQMrSG24vxy7Pd 72rQGm7+ai1VJYvtDdFs1Qg4s1zy4WSHUxY64caEELbOyWCM0UFXw+aKm FAwE4A6DOys8En4uf9x7pjmITvm6yF38dRSaWM1XDbW7kufJ4KcVi0f2o 8VFP5xS+LtiLp+koN7d4yA8AOGl4UcelqLRhVn/jHSVsjogcmJz2f3PKw nvLAOAu+nWz8HQ0Bpu8St2BBPj8rldgpjvEP24Q+VuBqbFecZ4RLLCYtI i5nS3LoCIHoNWxvCFThWoDoyYh+xaUj7DgY/xOKYUjmvpH8nSdvrVS/iY g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333275185" X-IronPort-AV: E=Sophos;i="5.98,240,1673942400"; d="scan'208";a="333275185" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 01:12:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745393476" X-IronPort-AV: E=Sophos;i="5.98,240,1673942400"; d="scan'208";a="745393476" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 07 Mar 2023 01:12:12 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 7 Mar 2023 01:12:12 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 7 Mar 2023 01:12:12 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 7 Mar 2023 01:12:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIiuxsZ5MZiqhIJ1vUmKdVcQizA5gve4wFL7sfd/PMWhmL9qq3Q1e0nPDIKe9YHMLoi/tHpvIdOYkXfE4tY9cWHQnMkjPpfeSPVnagDqzWGUOZgariEnC5PC0+8YuJT5Pv0of9U4YzbFpNV4jwAyVb2GDbbBCQY11L4zffmtrwdShdIaxhMX2Ng6pAd7/nHTV9ncOPJzPoAKSJV9qXrjZPACk0h1GeO7xJYVJDr59Pbz7bUDcobZZHutHegYoYRkFLIP5tmBAykekkzKTGks6sM7zL/ppdifwQvcIZPiu70TBnTh9r8zQxgghvd/kmD653CTTl447ndLmJeDyG6Crg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HwHbCsl41vjyVDqHyOUZv4a19rwWyGBauKWwXsWaHlY=; b=J8CbwxhuyWcfuSjuRP+AWzq/bEanu0Uk14V3SSEHC9c38YQ5GwXKEVx2EDKq4eUDhoalplvrsha5CQkoVszcGofROXLsypbry8iJAq+FbFysMnvPyDF5Dkzf5zOTotd3PVf2gV7jjsxkmLyN4FU67fUnRHopti7zpyOy8x2WvRYGwEc32zC3xmF31+H0DkGi8BXGm/8UWsxbCelD8Xjr4d5hPxHr8Fw63GxoPRucZsSe3oEyXGVjwhxYYWdax1cWSb4TF4Ze9fpoMKZgpHgG74C6eZKhOPpGWlNFzQNDCFZDg0tve/iO+W5+6hdheXvT4rEzRMNd2OtHSFTp7AuLAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by DS0PR11MB7787.namprd11.prod.outlook.com (2603:10b6:8:de::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Tue, 7 Mar 2023 09:12:10 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::c8cb:dd5b:784c:8415]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::c8cb:dd5b:784c:8415%8]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 09:12:10 +0000 Date: Tue, 7 Mar 2023 09:12:03 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Stephen Hemminger , Subject: Re: [PATCH v3 0/2] Add option to timestamp console log Message-ID: References: <20200814173441.23086-1-stephen@networkplumber.org> <20230306192810.106154-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35D877C1@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D877C1@smartserver.smartshare.dk> X-ClientProxiedBy: LO2P265CA0396.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::24) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|DS0PR11MB7787:EE_ X-MS-Office365-Filtering-Correlation-Id: f0a09d5c-76c7-4f54-4381-08db1eec080f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FRNOrsHN90upy8zyZQ2bVQbHm2y/3gT6NEohCOceYOQEyVoElQNVVcyMcsADz4CgZjLxoBuC/wSxkXv/BFOaAR8crOhDT6X7ydnyrx3hcp2SsxP8ziAzz6aSwE3RnE03ntZI2zExf5gOm+I1t7WuNAA0p5tqgx9Bhs2IrKCpzNgT0R+oKRnwxSoNzp0Sf9z2f0hxlpEtb2txV3srzxyISCzIupxRHmSCplSTi7bN7oZK2R5IO4ZXdyTCXeuB0FtbVU0hJ91YZ55koHeDSXT5Hv2g665w5rTLeRgFnHnTDuxNgUa+A9EEuWuBtfxonUkVECvdN857DgRRCwndD0bPO0bjdYgDsVZaeemCrw5SyTRxkFBdzIs3qks8VYPN86SrcIr1s414+gIusS7l0+Samb+KiSAPZ9e5kwEb1RtmpaOXDyFJVYAPsqVpivhw6+BcrqNnlSKKP354DgY0ROFfHyjO27KmFHs7HmGDi/pJN4I4ZZlKiE1pMnOdPpavCo25WZyuHVfuV0KG6A9G3sKSlzzory/FZEESJjMUZCqPn1Lg/MIBtJA+o1XyjyF7zk+mzOUUDejWmpVXsOqYH79740J3yldZQqZgT9UYEIvh/jCbe0b0GP9LVvaJ9Nd/JkhY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199018)(4326008)(66946007)(66556008)(8936002)(41300700001)(6916009)(66476007)(8676002)(44832011)(2906002)(5660300002)(86362001)(82960400001)(38100700002)(6666004)(26005)(6486002)(966005)(478600001)(316002)(6506007)(83380400001)(66574015)(6512007)(186003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?YG8pXM5yEKSR+7Va3AqJTTHxuyE4Y96sNI3kzJvGAxon7jxuhUW9GARmwF?= =?iso-8859-1?Q?BLTenzOpSDv5qu3uawnLvJR5vzkdP2h7kxexxYOZkafxEg6Kdn0zBTh9Ik?= =?iso-8859-1?Q?iErkFCLzHNaxvGSweCaGdwO0GqNPbI8s1EzjoBN69V+tcBIsQ9WPggvH/s?= =?iso-8859-1?Q?wuyhgoShieMtcsU8VHMBnh7NL3rxYzOfoFIU+lPlZelgMPHBT1Wlx1Zcdz?= =?iso-8859-1?Q?7TRhknCgjIGlDRNU3fAQFAlP3vKGyMDWz3JCAiGeLyaUGUk7tLVjHFUDh1?= =?iso-8859-1?Q?KQu7XDtZEY2bWhChdsMhb5hpood/rd0D8Vlraxkiy7sRmlMeB88q+4VZHX?= =?iso-8859-1?Q?mDuom9ggV60EK2nVBJWko+VV0XavDA5mVUwWxipf8CccizT+K6Vl35RWTK?= =?iso-8859-1?Q?IW7XnpxtAXENn9AjZUJNrTjgt13QbAp/J+cYC3uW1GgWSmNpY0CMDN9RXB?= =?iso-8859-1?Q?zZ35RWVb7+zZpNnAmMk+SGBBP7tnQ5eW0axZf8rQyHcw9gerAwP+svOJag?= =?iso-8859-1?Q?FfEiVK19H+2nPekTQvIM/qhPBw9TEjSO6tCPb52mf+NLuhbAMgOEVjETr+?= =?iso-8859-1?Q?gAOz44kgIEDkZ6oONfiMi7Y4GZdkCXBK550GCO6LeZtpkUvklnxpn92ECK?= =?iso-8859-1?Q?Mf1rRqd2mtDsH6GCfJzdDF9HgwuKt4UsRVSPcNwMIueyeibGTzBUNKCx/r?= =?iso-8859-1?Q?hrp0RsKblnrsDAlnLtwksYWvESGUv9C4kIpbnbFwniuGHBBJ3943fSUv/J?= =?iso-8859-1?Q?Dn9UTHGJr5UPQKRFuKE3/tAuX66/2E2laMk5jhpcajkKGE7orPi4xlAw/V?= =?iso-8859-1?Q?0QCWOQ587pZXvE3qZxh/AEoZ8uoou/fiYY5OdeHGwim9FSEIyqLCqjk179?= =?iso-8859-1?Q?98sE6fKB7YLhMhCMBehKm1saQJVJzPptYZevKeWQT/pg4C74izGq1v16eW?= =?iso-8859-1?Q?BcOghaQxB1addL0oVZ8r6nGPYggw5IXi7mPja+tN7+B4QMyXu1xcY1klT1?= =?iso-8859-1?Q?N1YFUd28wTY3iokuHvUXr1TyPaIlQhbEKtWeIHuqgv7BZ+e/SM4DIWCBjm?= =?iso-8859-1?Q?VrEk98S4mlkWM3s8f+LcQ560OGGJZ/3S6zMnezYdo9YzQQ66WMsHttszZ8?= =?iso-8859-1?Q?NMWPveraeXkHkhFYtsB7fiT3MyW99iPzaPZvUrL3djoy6uPpc6JXxryROA?= =?iso-8859-1?Q?/+E/EThQwALNP1hrNmpTpZKZYkLC12siXxBbVuogU36RJZwYeFM7GX8+2P?= =?iso-8859-1?Q?A0F+/oV98C2HJcmD4frKH8sHpKplJvKgPnaClrvL1mkLhtWeB6HJcQ5cIS?= =?iso-8859-1?Q?4kBo1cYtN1ggRGsZh5L+Fo/jijzCrVqMO40wme27l0fFNJclybUawi4BLz?= =?iso-8859-1?Q?c8CMCSjUBSqskNEMiD1VmU3VMgslwQxtwONGYmSNqC+sA3e9rQRzVFx8x0?= =?iso-8859-1?Q?pquEeN2k47KBf0jrNYXzRDXBps4b1aizc+ygIcSH+GNGxIgaFqJWhA6uGB?= =?iso-8859-1?Q?StErDc+INhRHYquz2Yr1xkZCW9NswRnXGYQTgOvF9gpE3yFARqjRZO+Jeb?= =?iso-8859-1?Q?d6JcXzrOtC9tNtYLL7qXzud9Uxx28EIKsXgfW0Nl7vwmSJE4ycbrIwoICI?= =?iso-8859-1?Q?d8kR2FGeQ4e/AdIwyZfgjuOAc0IbP9WJdIp0E12nOBJI8f0PQwRpgLXQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0a09d5c-76c7-4f54-4381-08db1eec080f X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 09:12:10.2203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l0FKUrbzukJYEvCxI1oELSg+TjrFr7+DehM03603F4iYVWot8L22d0yOmeIobLPBRPXwKH4JRJ+cSDOrFhuDbahmghu7ZfGCIeiQCQcz4CY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7787 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 07, 2023 at 08:33:17AM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, 6 March 2023 20.28 > > > > This is a reprise of earlier patch to add timestamp to console > > messages. > > > > Example: > > # dpdk-testpmd -l 1-4 -n 4 --vdev net_null0 --log-timestamp -- -i > > EAL: Detected CPU lcores: 16 > > EAL: Detected NUMA nodes: 1 > > EAL: Detected static linkage of DPDK > > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > > EAL: Selected IOVA mode 'VA' > > Interactive-mode selected > > [ 0.191407] testpmd: create a new mbuf pool : n=171456, > > size=2176, socket=0 > > [ 0.191510] testpmd: preferred mempool ops selected: ring_mp_mc > > This is useful. > > Here's some feature creep: Since the timestamp output is configurable, there is no need to settle on one specific timestamp format. The option could allow a choice between MONOTONIC and REALTIME, with an option for REALTIME to include the date in ISO 8601 format (YYYY-MM-DD). And REALTIME could be UTC or local time. You could consider taking a format string for strftime(), with the extension that %f expands to 6 digit microseconds like in Python [1]. > > [1]: https://docs.python.org/3/library/datetime.html#strftime-and-strptime-format-codes > > With or without feature creep, > > Series-acked-by: Morten Brørup > Missed the fact there was already a v3 when I acked v2, so repeating here. Series-acked-by: Bruce Richardson I'd rather not have the feature creep on it though - at least not yet!