From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Chaoyong He <chaoyong.he@corigine.com>,
dev@dpdk.org, oss-drivers@corigine.com,
Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org
Subject: Re: [PATCH] net/nfp: fix MTU configuration order
Date: Wed, 8 Mar 2023 09:19:27 +0100 [thread overview]
Message-ID: <ZAhFD41HCK843tB2@oden.dyn.berto.se> (raw)
In-Reply-To: <20230307184409.46daaefb@hermes.local>
Hi Stephen,
Thanks for your feedback.
On 2023-03-07 18:44:09 -0800, Stephen Hemminger wrote:
> On Wed, 8 Mar 2023 10:33:18 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
>
> > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
> > index 5922bfea8e..5d92b476e2 100644
> > --- a/drivers/net/nfp/nfp_common.c
> > +++ b/drivers/net/nfp/nfp_common.c
> > @@ -1126,9 +1126,9 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> > return -EBUSY;
> > }
> >
> > - /* MTU larger then current mbufsize not supported */
> > + /* MTU larger than current mbufsize not supported */
> > if (mtu > hw->flbufsz) {
> > - PMD_DRV_LOG(ERR, "MTU (%u) larger then current mbufsize (%u) not supported",
> > + PMD_DRV_LOG(ERR, "MTU (%u) larger than current mbufsize (%u) not supported",
> > mtu, hw->flbufsz);
> > return -ERANGE;
> > }
>
> Patch looks good but this looks like unrelated whitespace change.
It's a tad unrelated, but not a whitespace change. It fixes a spelling
mistake related to setting the MTU,
s/then/than/g
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2023-03-08 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 2:33 Chaoyong He
2023-03-08 2:44 ` Stephen Hemminger
2023-03-08 8:19 ` Niklas Söderlund [this message]
2023-03-08 15:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAhFD41HCK843tB2@oden.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).