From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA40941E09; Thu, 9 Mar 2023 14:10:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF2FC40ED7; Thu, 9 Mar 2023 14:10:35 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 55ED0400D7 for ; Thu, 9 Mar 2023 14:10:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678367434; x=1709903434; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=59o4PTlDgxm3EZIt//6yvTWtAQOaizocsSouwSVzdeI=; b=eoh9zJQ7ZeXUEaZCUk3o3rcr5s+9ex1uIpwpTEFBuzUtumJfGJCMtEKL sASgxqvvi8twD53t0mw2BxTBePn0UwX7UMT15hGFpE2mUmUO6Q48MSFwg fRGdHBIUb+yJOITwfvUXlq6fw4vlIAFh8+VwO8ipoBdYOWP9cdk8yWyYC SD+AZccugeNlpt6oMWmGdyqPrjeU4VyP+PpAWVtedLxoSlQYBriQztNaG XHzIb7mosOObwSfRGzbaOfR7UarHOrkGXAuQxRIhU0hzaxjEdOPKBQPV5 hl6rwCNxU3DtFArjE49QlhSrZt4oMQMaOkKhJAoKCQJkTDqiXE3UhRcLy w==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="337966570" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="337966570" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 05:10:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="801170327" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="801170327" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 09 Mar 2023 05:10:32 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 05:10:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 9 Mar 2023 05:10:31 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 9 Mar 2023 05:10:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3e9bsMVW5VpQDmkqRZgSsjdIeu8VilmJYXSMVyfUiVpdB2tg8HuJGYA0etQ45wpruT3cM5+HlI6BsPBoeBgfMGAXtNyTiOOt19iTba9A2tfLitSPKmWwth+qWq4u4Cm1HOoSFZa1rmS2q3DVdnUQQddYI6hH09ra593aPax1TWQTmjpZcB1Q5jCc0RhpGK1hWW686VDN8bcYkE0oezoy79K/KQz/1CP3Sl2SUX3Ts524oti+JRe5djcmY/h5zeU1TmnAI5fZZw7RbT22B+9qIV5ZANtR7cOMMGFB54fC0j8N+WLxRW55xeWMuxpfRlFkzfYNRlwDdTPBKLRo8/zgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bGBxJ8GWtVXPmk5Dy1sX9UVEWluRqdqLEex3ju8GIhM=; b=agjmeR2fuP0AaxMa2FlcltMvBJS8UVTUEoWYKNUWnzHD/tMMGWuDhJGHGLD4+FvAJithkT8jKdoYSMfC9oyy44dDftiZgABMz7Ec2J2CnbbvyDKxAyAOUDcwR+/eBpwzSiRNq7VD8fq+lAhJW2Lt5o/PfayU428paJz2/rvQbTJ76by8jHfvUcYWnM+PhfdvQm94dCmDKa/MHGXOV+aFnCOBgcgIAUJy26Gn5PfztFXJ6QRdDCjnqR/abNXh00iR4Q7pNR5HMD+kSYo5V1pupM73YiMHMXEzUjsyVPA7zYFlUgmhio/rHcMirh0wpSCmSyJe0h5Va8+m5STezzMHZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5153.namprd11.prod.outlook.com (2603:10b6:303:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17; Thu, 9 Mar 2023 13:10:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%9]) with mapi id 15.20.6156.029; Thu, 9 Mar 2023 13:10:28 +0000 Date: Thu, 9 Mar 2023 13:10:12 +0000 From: Bruce Richardson To: Thomas Monjalon CC: fengchengwen , , David Marchand , Qi Zhang , Morten =?iso-8859-1?Q?Br=F8rup?= , Shijith Thotton , Olivier Matz , Ruifeng Wang , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao , Jingjing Wu , Beilei Xing , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Kai Ji , Pablo de Lara , Radha Mohan Chintakuntla , Veerasenareddy Burru , Kevin Laatz , Pavan Nikhilesh , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Liang Ma , "Peter Mccarthy" , Jerin Jacob , "Harry van Haaren" , "Artem V. Andreev" , Andrew Rybchenko , Ashwin Sekhar T K , "John W. Linville" , Ciara Loftus , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Dongdong Liu , Yisen Zhuang , "Konstantin Ananyev" , Qiming Yang , Jakub Grajciar , Tetsuya Mukawa , Jakub Palider , Tomasz Duszynski , Sachin Saxena , "Hemant Agrawal" Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf Message-ID: References: <20230219115529.3260580-1-thomas@monjalon.net> <1921837.PYKUYFuaPT@thomas> <4250554.ejJDZkT8p0@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4250554.ejJDZkT8p0@thomas> X-ClientProxiedBy: LO2P123CA0086.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5153:EE_ X-MS-Office365-Filtering-Correlation-Id: d51ff0ad-a00f-40a7-d9f1-08db209fa703 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bVRtSNQL9C+6xNO1ZJCsp4kK/Nw3fka1thsKfFzjONvSYjtKo6X1f9gC1raUKvwtcgVY/41kWiI5z0v/VIlTegxuj9WKgy7wpLtIRVrYpvt9RXu+sW2hqZuk8rPevwADMLme/UQsH/yu6LBIHv4M8poRr+uQmD78OxJPNPI5rUlySMOhbjRHvk6gKcOU4A5YGwVz59oTFd9eaHhErlfA9zraoVwf9jf9rDrqyeufuDeeU3fFUPVNqGA9QlMdeVN6VExGps5ISP3zwVJQc7ehNBEMvEvV913ABFEZ5LIVf52V1DYtqGiLqgHIBP8aSEfIAIrY8eAmoMu03ai/njdmxwqiRDBSATNheYOcf8qYjVuAh8BnVx4wMqHoFjjRFSnVWKUeAw5t+CeiJwUDsZaBPT3umVZt7JF04w/J6nsTATFDeKaJZF3VlYnXy/dfKUI0dEX6FpfAB0XhutVBEycBeXexp3DCNjtFIaLCatuQMeMm3V+EcSsJ7P7fLV5Vtx6cdobGMmGveOHS7A8h+ijHh3oKTYx2VLifoKwl5GPJZiIKO+Z9aLQqznW2RPMn/BPw0Ev7qIepcEwNaeanp/BNQetQONz8tRw/NJfNkEmpaiJ4qnOQTodGvO/A5Wp9OqrZcKDcqpQqfXgwUjSQbNby3A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199018)(478600001)(44832011)(7406005)(186003)(7416002)(6512007)(5660300002)(53546011)(26005)(83380400001)(6506007)(86362001)(6486002)(6666004)(2906002)(316002)(41300700001)(8676002)(82960400001)(4326008)(66476007)(6916009)(66946007)(66556008)(38100700002)(54906003)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I5Rk2KWd4IL6NcaCTynlAt+DbFZ9DBLEb4zQHAWj5a5G3URZ0romvv+99ikf?= =?us-ascii?Q?goOSYDiKg0GvaqylVUhseqHQYx0dkN0MjIAdLgESd6jxxOf2EwGpw/Oi5Gd+?= =?us-ascii?Q?xXi9PcJLbabw6TSHs1GTEwX5oKFm0RPH2qfl7jHb8D++A1+7II6hIMo+nk4v?= =?us-ascii?Q?HTBeYdNCxE0tdSBZju3X2tJNQhmxiGRTlG1QCFbK4zyuLdKwyji8BO4y/9uK?= =?us-ascii?Q?2I0dWhPO6/nRHvBePczJ62dTgFE8ohhh1YZMWDssKsDGIHWmCrSOROXzmFn9?= =?us-ascii?Q?pLnj2bjLtEKYMJt32XaFY3kMAgTiMA0ELKEF+5+3fmpoB2GxoQF0AGMpQRZ8?= =?us-ascii?Q?yDhZR6Bf38QAhPUFObso1Fhq9BYk18wIcH/k/lJN/vGiRGz1gLUNXL9SlQsK?= =?us-ascii?Q?nJwe+kNJT/vQgv5EIlPEI7Jq9K14/pW18aOuNicrwjVwbAAs5cMCcT1vEBTt?= =?us-ascii?Q?bLRSZbFbLjWmu0vyZF4bDNYkLY72fqUKc4IrZvGG8gY9AvtRLQBhTWcAuQTt?= =?us-ascii?Q?hb4Hw37p7tMNreCzX+YXNUfvYlcAfj/eYrv9DpDsLCc67UIS3SozQG/pQTkn?= =?us-ascii?Q?Ri/myF8jiNZBAFshzi7zXbrBpyPhJx88t9eDU9WIqNiW429MKTVSAce98Rsb?= =?us-ascii?Q?8VVmoyVsaSISJWd2GVh6KS0lq9G6RS8Xx69mgz1GzAXBQubx3/Bu7EBMK/+l?= =?us-ascii?Q?X4fGsFtthmZgHkcr9bAEvGZ/s5hPRHwthV+DCi6yscEMA+uxOzPqHOKhifxU?= =?us-ascii?Q?z1qK5ucGyvIbJ5CNdGXQD1E2K2TM2byQeAImhPX3wHsCMLF9dkv/pbRCgs8A?= =?us-ascii?Q?1M5mNzKPVIJ7Aj3Y60Xo+g8C1gV0LVETcHL+iu69Nqn+STGOZVw6vOPunXnb?= =?us-ascii?Q?SwTbrBEs1elfk7FGe0U9XjrPnKMv4Sbpn0wn+iel6IU531pxdxtJXn2fNkhh?= =?us-ascii?Q?1iw7Z1veqjXP2spl/FNcAwVXIt6WGbolQvE2hJZw4hbQcSp3gwyHw4q6YcMd?= =?us-ascii?Q?bPcEkcCBHPUrmhyVI/qlmhGrZVqy21TId9loGVAiUkSpdlpHb+SB9lW5YAx/?= =?us-ascii?Q?U6/vbsb1vl9eCy5S7hm8J561B9mTMhLtwaShbYsHmJdk+dxekFcOwqmIidkL?= =?us-ascii?Q?5qL4uieAS9ORb0SH/vKRFOAOqBw9FFkZoZ0nYK8sJcDXaF0wQxxSj+HE8jO8?= =?us-ascii?Q?DRhdU68BKd4y+9GgzP2nIJGjiCTUGMAcng0KFiQeOWDczOujQVA5HTiw/3LL?= =?us-ascii?Q?0A+4XolVKSkwkVwC4yO6CZY++o26w8k7/v2cBVoiXvE9vvVNMMT5tJH5zqiK?= =?us-ascii?Q?x4gfvSASU5c8TeWitLf96GOT0rn+bwrM+i5n0PBSnv7KgcIbB95d3afr/tWk?= =?us-ascii?Q?TqqyWpjgO8IjimAHF/c5WSneMQXn886Jzk7J+FHjho0rHGsz0xhculn/2jKI?= =?us-ascii?Q?jc8qEKp72hgrBicMiX361qlUtXLBb7QD5SCMVtTs8OQ7ofjFYd89Pk1ZvmdO?= =?us-ascii?Q?tgMLKm6fufFmOBWS5/uNqFOJ5G/STbukURSxaBFUdDxCQ2tSeK4JJTLYB3TN?= =?us-ascii?Q?V+DKTqp4Pf9sa6Malyi36tqzMCkAwEjO9jtn5UD43QeEOqP8dJMykGGkuRSA?= =?us-ascii?Q?OQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d51ff0ad-a00f-40a7-d9f1-08db209fa703 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 13:10:28.2619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FbkHtSrIIt03UZx22Ms1VmCaNZphOKEMdMchFY43TTC3+9UjfrGHGbDA/iqm7A0ACUWc4NNIABuNoHWvk37tbd84E+4trej5zDtL15d3INA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5153 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 09, 2023 at 01:12:51PM +0100, Thomas Monjalon wrote: > 09/03/2023 12:23, fengchengwen: > > On 2023/3/9 15:29, Thomas Monjalon wrote: > > > 09/03/2023 02:43, fengchengwen: > > >> On 2023/3/7 0:13, Thomas Monjalon wrote: > > >>> --- a/doc/guides/rel_notes/release_22_11.rst > > >>> +++ b/doc/guides/rel_notes/release_22_11.rst > > >>> @@ -504,7 +504,7 @@ ABI Changes > > >>> ``rte-worker-`` so that DPDK can accommodate lcores higher than 99. > > >>> > > >>> * mbuf: Replaced ``buf_iova`` field with ``next`` field and added a new field > > >>> - ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_AS_PA`` is 0. > > >>> + ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_IN_MBUF`` is 0. > > >> > > >> Should add to release 23.03 rst. > > > > > > Yes we could add a note in API changes. > > > > > >> The original 22.11 still have RTE_IOVA_AS_PA definition. > > > > > > Yes it was not a good idea to rename in the release notes. > > > > > >>> -if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 > > >>> - build = false > > >>> - reason = 'driver does not support disabling IOVA as PA mode' > > >>> +if not get_option('enable_iova_as_pa') > > >>> subdir_done() > > >>> endif > > >> > > >> Suggest keep original, and replace RTE_IOVA_AS_PA with RTE_IOVA_IN_MBUF: > > >> if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0 > > >> subdir_done() > > >> endif > > > > > > Why testing the C macro in Meson? > > > It looks simpler to check the Meson option in Meson. > > > > The macro was create in meson.build: config/meson.build:319:dpdk_conf.set10('RTE_IOVA_AS_PA', get_option('enable_iova_as_pa')) > > It can be regarded as alias of enable_iova_as_pa. > > It is not strictly an alias, because it can be overriden via CFLAGS. > > > This commit was mainly used to improve comprehensibility. so we should limit the 'enable_iova_as_pa' usage scope. > > and the 'if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0' is more comprehensibility than 'if not get_option('enable_iova_as_pa')' > > To me, using Meson option in Meson files is more obvious. > > Bruce, what do you think? > I'm not sure it matters much! However, I think of the two, using the reference to IOVA_IN_MBUF is clearer. It also allows the same terminology to be used in meson and C files. If we don't want to do a dpdk_conf lookup, we can always assign the option to a meson variable called iova_in_mbuf. /Bruce