From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DD9942863; Wed, 29 Mar 2023 12:21:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0B35410DD; Wed, 29 Mar 2023 12:21:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 27D1C410DD for ; Wed, 29 Mar 2023 12:21:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680085261; x=1711621261; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lXOWwhUcys8fWMD8vXNfylXWrQMNy5WDYxKxr7vQb5E=; b=evYHOaWkJvGg+SYz+Z3A+kyjYTMaQyjaxdPQgcRcYZahsQTJPhQ3xzbH 3+ql5Dlf0ZhfEdW0nWfx512rCCLW0+zCjztdSqexM4MiJryqL7NAnZtgp i/y00gZajhfeR29T+uJJhO1TLxUvhM97Wv7JBSQTzxZFw+pUsLbKrQDYM 1GnYKDacyhlTAsO6vuk+FbIE3djDtDPPqzTqS/cu17Fk2eN87nUMfZfnL txCgOr/snIpor86jc6QrSwy8RGT1OVrwN54OF838AjqIgIGYUWOlH07XZ KJnJ344kgZ7y9Lk3Hy2JgQkn5XEHuNpk9RWPTtGVuaJ5nzmE1F5Ub23rq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="339562159" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="339562159" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 03:21:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="634419796" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="634419796" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 29 Mar 2023 03:21:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 29 Mar 2023 03:21:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 29 Mar 2023 03:20:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 29 Mar 2023 03:20:59 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 29 Mar 2023 03:20:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KB9d+Tu9xrXQLuMrL0wYZN8vzi43/zn7AdRS07GLEO2fGvCsZacjFyDOX3EOKub1Vt4JOiPIGtpDfITPyoW6xSUIW5VszxQk8hLdFRoqYk4UMOQXNYab8+dmASGLgd/KBduTyES7Lhw7iDDURVsxJxmpgd8e4M+2t9Yf7IwMafe2nav/ECQ7xYR0Da0K6vWMF1qtr0a/5XzkdR+2Iv+uc6ZiaVtztJCViytZQw+1fiPKRXcSbixs/UOYB4kOsVhCPcI2hp+gdru4WG4cYc/9nurlXwE60QUDz/oQeCdR5egdyUn3TmygiURKT+6bYUGjJ/aKhcRYhDx266UsZd/HNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UpTwGfyFHGmXXS+sMBG5c8cWAWn0flvkmT0webfGWpo=; b=LOPxIYp6Q5ZIlZuKwIsUFZ43eQK2U3yBmNR6YC0HiIcp5vnNqrXFL+BibypGgpHxLfOhXhrb0RS3+y3h3hAD8VOBqPWwrfNBhvx720pwdrQSDB/CfaU+Jo+BDyjhSyPoOgBMmf4zNiP+En62ImScFFCZQnnwkYdJEiwc6ULo9HW1iMwuolXhtAwoTQz9aAueNbIVlATXVgUxYuE2RHGZynSWtNKZ7H/AAmU8Le5UmRkxh9Kud9w5ftNYOSJvNOv9LDKNefRFKJdrvFV3jrHSsug8xarJUwbFYXpz6BMMJiKJjupxg+YZhKX/Krb7bxG7rkeZ5HgFNJKzdFmS/XrerQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4588.namprd11.prod.outlook.com (2603:10b6:303:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.30; Wed, 29 Mar 2023 10:20:58 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%8]) with mapi id 15.20.6222.035; Wed, 29 Mar 2023 10:20:58 +0000 Date: Wed, 29 Mar 2023 11:20:51 +0100 From: Bruce Richardson To: Leyi Rong CC: , Subject: Re: [PATCH] eal/x86: remove redundant round to improve performance Message-ID: References: <20230329091658.1599349-1-leyi.rong@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230329091658.1599349-1-leyi.rong@intel.com> X-ClientProxiedBy: LO6P123CA0041.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4588:EE_ X-MS-Office365-Filtering-Correlation-Id: 06d76695-10bb-4df0-ea42-08db303f4980 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iCZlCtnvFmCt/zMZSJLU4rJF4WLoBW4tPx3frRDHehrxBPQyJS20hbajGyqfATqNMMQmGPd8GxsjEZBJmqcJEFVzQNLoU1qimkv88iHSo9bJ7w8eVCTR7Tg2s2GGyQktPzE8uDeVetoWhSo0SNE5t6eczISGprBpWXShS9EYFWm4cy7jtxCqJeP3C0biHdZXfuTdJ3c9ff2TG0De1G649bupS7+M08lB2euuPpvVqfXb3Rz2sAtqtxQgAQLdIGe19IMPHO0utvUFr+CcFEWk/M04gKRnlGBnOHYmuz37Bt/sWaWdVDWZtm+0UaFR2XCEXh4IG4kSw122LOLXV1DkcQEhdz+bkWzwqVC0e8JEk3O6YCKsnXmrrhClwlThP+k5MSLAAoMrRdS3U5jTF4sVNb7OXk2WEGvLJPRsRzrJu+YtyMZG3FcugkpAxB5pucQtTHwTDxmJeMgbh5fwYNMFAstO+H88IrTij5jUmRDiwQPZa1yxbLsB4jwhZKrmFMIANrkqrXjxZH7boKU9a5LRBXtvInxwIgqW+G8LN30M9TQus59bJGgT80pC0FxrTCmf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199021)(316002)(6636002)(66946007)(478600001)(5660300002)(6862004)(8936002)(86362001)(2906002)(38100700002)(4326008)(66476007)(8676002)(44832011)(4744005)(82960400001)(66556008)(41300700001)(6666004)(186003)(6512007)(6506007)(26005)(83380400001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?bDLJL6BheApwkb8D3tJZUqJlBFiucis4oIsEpTAvbMceHZb22IR6uzQ0sv?= =?iso-8859-1?Q?skKJG6hoj7BGFifBBXBzyQnE+899rOPeyubPSE2c02rSX0Z94QItEgipK/?= =?iso-8859-1?Q?6TESSsPztdKVsKlaW8edvsbCOy7C2Rymh5O3WIvykIWZO92/U+DyjdiZaW?= =?iso-8859-1?Q?yyw8Z7DLqi6MkMe5PCBdloQPKkOKBYaCbv3r/gDbN88JBWtUdg9jkN/0xn?= =?iso-8859-1?Q?QcrkJsYszq1pHqX3XYN9P1Y2k0FrAznvkcNHZrgNfJsrnC8FAM0KTb59hE?= =?iso-8859-1?Q?cZ8QiO2UFU6tvW2ataRFbguu/UG7waam7MeMtEIDRX/1kYek5UF0k7g3Vi?= =?iso-8859-1?Q?FuxS+0kMc/7tNJxNzivImKSVBiYMgVaLsRndm8WEFCwnT/xWPH1qHrhvst?= =?iso-8859-1?Q?xC43X83JUYqn+L7uAqcFBxb9gLnzF43Q0pcnwq/zvSV0xFRorHlJhtx+X/?= =?iso-8859-1?Q?4af3K4MIYxhnMdqSMMF+Yo83bUMOH8HdqCKd8hgRKym4GhsAeXiVMmqYMW?= =?iso-8859-1?Q?OTqeUIreWRdGnn02Q0k0DNNcZnG1r89UHCun6lDpTgyTQJ+enaVKlpPmKT?= =?iso-8859-1?Q?IFsx/6EReyG1YD/qMvfM8OJr+UruHHl7K5jX7Xv0FUh+tbePerSWtLa5Tv?= =?iso-8859-1?Q?/2HSH2FP1pLJUh2nk4Vo0JHIbVFwqYDSyZgTlk3n5sZnSoP3+4mrOu+wlq?= =?iso-8859-1?Q?fODaKOiG39/j2F10cVTEjB0M3JriInULxq7ofTvcrCMj4OucwD8n+5ruTZ?= =?iso-8859-1?Q?YXAgSJ6el3ZIepWFZio7su2dYKsxKaFN+A0TAIRCNVO+oz8HFYJ4kaRT73?= =?iso-8859-1?Q?WoaRBqpJu3lSvhnzHphC6MIv+qlM057OPWoAbEZl9Ax+r88K+qt7ov4ucy?= =?iso-8859-1?Q?ciihd94YXJcGOT0G1OA89lxvdktzjKD4o3eMTUs96KkV0DoG0D8tfpKU3C?= =?iso-8859-1?Q?ylrF3hhuBBHgGVH2+MwEZwMsDgrvJGWTuuDd029hyPmagScpaQmx8jaoSQ?= =?iso-8859-1?Q?27mSHiarSMzeGVn+ex09dEYy/64JCMUJ7N5F3P1HFb0NEnxYdBH1WVGDqH?= =?iso-8859-1?Q?JFdQ6C0gmhitS1sASFHDV7LrlHkFtatzt50poIewET9o2R7hSMb/o7POGA?= =?iso-8859-1?Q?BMgcHxvKiqn5TJnTMKP449mEbUKyduNC3lcrZgJmxyO7C0qfkATJrk3YnS?= =?iso-8859-1?Q?2QpPw8FMa4a9mdboaC+iHhd93dt3/NkrJQxFcqhKo8cjX7u/NpaatVTHtx?= =?iso-8859-1?Q?gcPNdBUTKiDw0iAUhyMsuRpvAEVlgIGDRvAzdV4Avpvnw0Zy7+FeJpVr3r?= =?iso-8859-1?Q?Qi8CNQswFhIGD+sj4PHTYeikzotApgEMXacoCYohZkAB8ltgWn3eP1e8Ck?= =?iso-8859-1?Q?T7vxspEGtPHjBXwWYfZyLyZFufZ6O6KXQPd9I69GlNKPnVdeG5yBJAUclh?= =?iso-8859-1?Q?djeyoVwNXnOraG9xiTU0F1UNaUArYnwZ6rRgjZMjwbXUpkcwD2p2Cqs4lf?= =?iso-8859-1?Q?mdGomdphICqHuJ44PLkVqLzGQyQRFBFU4We5wwd6jbTD7f+qnNgvS09Rcp?= =?iso-8859-1?Q?mHb1t4/Nqu0mzUhYIu0kT8oZgDT9ACByvMqoFLsYHErrv6hlNS4vJZ9Hqr?= =?iso-8859-1?Q?df4WRlUXzKDMCNuV4XQ7siETTiA3OP+sTNtOypRkcPKLtdoj7lgdPytg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 06d76695-10bb-4df0-ea42-08db303f4980 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 10:20:57.8968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wJxolsgXdpGnetNxiVDFFKb343PCtbaCyhIQpqcmmN2aQkjDJkjnBajlf/OJ6zoIJnrNiNgknkA16ROVqvaMHtEbM8187o5DxYnhsNAgk/A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4588 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 29, 2023 at 05:16:58PM +0800, Leyi Rong wrote: > In rte_memcpy_aligned(), one redundant round is taken in the 64 bytes > block copy loops if the size is a multiple of 64. So, let the catch-up > copy the last 64 bytes in this case. > > Suggested-by: Morten Brørup > Signed-off-by: Leyi Rong > --- Acked-by: Bruce Richardson Thanks for doing the fix for this.