From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0DA24297B; Tue, 18 Apr 2023 11:22:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0AEE40EDF; Tue, 18 Apr 2023 11:22:36 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id E9FE240698 for ; Tue, 18 Apr 2023 11:22:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681809755; x=1713345755; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=k4Dy9vykwX2L9yF0X2jmXNkLTzhbDOqQSkO6SaoZHsw=; b=VKeLx+yG/8GaOWiaiA0u3SRnZwRQohoO982wOudzUt5vLxbaYkqjVYqd TVBeoWKTks97OzkpjfOvIR2QOD3cgoCMbtaY7GW+zu640HVKnThUcH/Pk 31uX3xEBdqTuFjW5jNo+9rul8pJK38TadrK2vKtMlUouI4OezkW4CL1JR Fgt8U/CwRW092tFrv4wR3CPDV4oqFbtsUUCjTjsVk5HzvCvfv7spFKxDM ZmOfLRYD2QAGvAgevoLL3uKtstrrKEtEK+Vz0dPH6esLZXD3CNhC/hTLq oF4FD7DDlFR9wzOUzPVt4Dku3f7b6ADIHB0gtYxg+vatE7TGqeHAmbr5u g==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="408020264" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="408020264" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 02:22:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="865310416" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="865310416" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 18 Apr 2023 02:22:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 02:22:33 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 02:22:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 18 Apr 2023 02:22:33 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 18 Apr 2023 02:22:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKcDa++JGuZUQ0Gsv9gTN6NHyHocS4JJ3WPGggQ48lLxlpQFLRq360tsYF/c0e72nZDm5HwrXA4Ex9wJrXxTyYy5ZEBS+3jrB2mvqTgbCoA0ks9Mifz/KnTusHq6T6gEZdIluc912etQfhWUrCh+mNTzKYWCILziMj9mn+DuasBk5bdqB/ZsA/oqbg9Z/rrLKg0/G8vY8QQp11AvMRzI1xEsoCfekO+MGzAy9AHsKThQQm/BPnrdKWE/6I0L/qgIM63c/2JuPlQk0OlucNUML49S6tWLaRTlwLZE1jETKYoAtCGw0oIdwL/D4pPlGZWPAbLqg0YpAG6tlSeNKqO3FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IM1daXtqfzhHIEHanRxG8rJHzdclPf7AYAWCz2py/Hw=; b=GwOuCI2Gkr5Y41xKBLEj6JNyTOV1xjKqNlCmKtTvqxi5QdJ6fjK18l6E9GxkNYyviAyFnF0xHw9qBTubFrjlNjlKYM3e5/y14lLRIZGja3GMMAulik3Rps1UzUtXNXsJiQHTJi4pjRzwgF8/7uFr4QG9ow6JfwcCQn3QHy9p1o9HHgjyLasiT6JjEUklXuPNafLHgMJ8z8ZNRiwfpwdp8z0MryOKjzaP/R+o2eSShqXNVtV9uRpZu33BFLECiSHCIK3ADg4rtlvzfJ7z0tIHzT4LfQV+hBL6V724MtMTV+4KtIDxKAw5nBM6vd5WXER2j0NkWPLm6lKSvmg5MCuJHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4828.namprd11.prod.outlook.com (2603:10b6:806:110::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 09:22:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69%4]) with mapi id 15.20.6298.030; Tue, 18 Apr 2023 09:22:31 +0000 Date: Tue, 18 Apr 2023 10:22:24 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Sivaprasad Tummala , , , , Thomas Monjalon Subject: Re: [PATCH v4 1/4] doc: announce new cpu flag added to rte_cpu_flag_t Message-ID: References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> <20230418082529.544777-2-sivaprasad.tummala@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0209.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4828:EE_ X-MS-Office365-Filtering-Correlation-Id: b3e57c02-5285-48f0-0e3c-08db3fee6fbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DjTtaBggkv9StxUIjtOcGrh2lVxrEWNmj4qLasvL2OJ12LyQDE8y20NPv46zIt/L0gtmQLTsR/4jgO2wBTyJnEIWmN2EocQ7sEzHpjgJsaceTvYJFpGnSd0+1GuJbr5doo7C4rH1WcdKFyjWzA7GwC/jFSe3ONZRusiVHnDuOY1lrx68kj94LIh0fYSWxyQEZSBs4ZjW9Cnf0qjeaySmbTcIhADuiSXyh4h+eq7H1gxJhI359QFT2/sBd3RMWAQ78ZbdOhmF/0BmW7h5G4WBUhSqvDbKNDpj6oO08OWmz3inKD/P2XbILp9swtHbbHafEcyTSQ/aTElDfudT+PbI9qJd1y7B7w6ZIAKNrZgc7LhUK6SF/gBNGvNdv2/4g1yknPjpFX3sGrRXqNbv+vqeYpLIniuSVdEsDxeh25ZDyH5jvT4RCfV6FQMhw5EBvDGR3uefEHdybrGzBNL4b6snkTkxqUGZjRWc1Z8ZZ0T9EBAu54R/VO6kAZNjGEPDQHwVepJVTkLQlmyZKC4gwlhb2I8iX5aDCJ+Zd2Kegp8CECDpFo5OspYo3WxYsnPnyuaU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199021)(478600001)(6666004)(38100700002)(8936002)(8676002)(316002)(82960400001)(41300700001)(6916009)(4326008)(66556008)(66946007)(54906003)(66476007)(186003)(2906002)(53546011)(6512007)(26005)(6506007)(86362001)(83380400001)(5660300002)(6486002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LAkXA4nFahkOQQjRzqzhjGT5359SnODDmcShlZh2hyRxvLNwotrFzdCuKL9G?= =?us-ascii?Q?nGQ1Jl50iVSZgUuRdutovQFLd/Uqsxi9AubGNbZjHaPsH4YGt9ygl5nbkAuc?= =?us-ascii?Q?roqesANwD/f1QKSRaVEC1otiN4/iTNayjz3zxLYo/uQ9opc0NIdFFWm99Op0?= =?us-ascii?Q?7/sbh0e8K50BkBr5uJnAey4bybz6EaU1F8a3ExCw16R6r4ryU1Vub2T4GhHL?= =?us-ascii?Q?g/LveirekkM0RGmj6+faiVikz62OoFLq4ueJ3TVJEoGvKLDrfnyUd/1aFDZ5?= =?us-ascii?Q?6NqMe1VJyhbefb+niQJyzs8NpcoBYwh+JwP4OfC0f8Rk8OMWSHw/rQ6djxww?= =?us-ascii?Q?jK5OVh9Fx5uc44ysOA0t/e+dFG9HmnMrtM7TgRsA2l8BQMeTwSSzyPsNQBCe?= =?us-ascii?Q?ZDVhrUsS5eNqf2AWBgrjNTgBxvsmzucyRg34HH6KQLLFIeRly2xiBlf+htyw?= =?us-ascii?Q?3vWRfjv7ZCsCRi4+8VuGftFmiUwWvcbvvdElGQP34sdJ9ozHYuNiDTth5rvv?= =?us-ascii?Q?a+EZZCwoJXa/gyeXbIEPiptjGm3LICyQD3DuS8fBSG0GA9w0csAgI5/l35Ws?= =?us-ascii?Q?KGBVE8YsjTx00+k9U6RZLmdN4Vaw/Zu98/qFSclArQBTGIn/EEO6U2lOYNlP?= =?us-ascii?Q?aEKU7eS5xKvh097SP1moFshxcjQkTjIiZ5VLUSWwyc38PM+5OTNwz/1HqHHc?= =?us-ascii?Q?wWnF2zUU6TXH+esJQmuOtmvjUV/8NL0f4uq4LVTwGdjHkEsWN15y57CVzAIf?= =?us-ascii?Q?WFJ0dP6DW32z/QbQfKqH21VQjtrjxoOuANTFjNZPpRuUAhDle35c4f0rCuVK?= =?us-ascii?Q?eUQwhl/6Uy+VAOVaKuve+OqPvrvzAv54x6TvsPT88jVhNSdgYl/mNtFlDEcI?= =?us-ascii?Q?/KUGNJYBOCUDExlqWm0kfhYZaFQLUKfE9iHAWcvEPEHwKtcvLVAuITv7F/il?= =?us-ascii?Q?3wznxr8qLguslQbKfWPR+eT/NZJ6qqkEaRDUV2eAXc3iITkVWj675lhIQPsL?= =?us-ascii?Q?3fxJgrMeZpzRUhNRwmAoEgQ0Vpq8jisdLfvB03scwq2MKUddqxpicngZwRGz?= =?us-ascii?Q?3mYPfdeJ6RsK/YodVnOymN79MoD2QYjN5LKX8Bf6VBMe8aqThsGXR6NlEZ6G?= =?us-ascii?Q?REoxSZrD+ku81falaq/7/jbs3R7C8NvU/3i+tg94JzEert5UBWcCsVa8jjaP?= =?us-ascii?Q?QFfeHKeJ+f6ZYpCaVPJyfXXDk6ACbFsLaRxv99tWTeWxyCIl4YMgVyt9B0yk?= =?us-ascii?Q?5WX7xq+GSrux2Ek+79pAIyx6l8O5nSeEy/EhM+fdSTUg9DDdEaCKf/Ray+E3?= =?us-ascii?Q?S3DMGhgTPrcAOdw5AWe59J24rMxS4NL8BL9B4H5tJ1D7bfFJJEL1BEY9/On4?= =?us-ascii?Q?t6UfkbL2NvfTF2QjHl7WZJG2FjDYGAWyXK/usDZ3lBJY+9zEeOCJWnrcfj1x?= =?us-ascii?Q?dnnCIhr+MujFb8fu60Go8R3+LR4KVkUVcg6TjvT6SmZCdKxDV3j81hogQq2C?= =?us-ascii?Q?Gw9Blly5n5rBzc+O0HCIzw0kWZqg1+aSrKTt+IZK40bWXIt1TjoVJiBcUoHR?= =?us-ascii?Q?ccJ2SK4lqj7F0SkR440MUVTABci9dqWv86+DvMjRWY8I8oMWQ4Xl02zaTLmq?= =?us-ascii?Q?Ow=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3e57c02-5285-48f0-0e3c-08db3fee6fbd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 09:22:31.5898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i2Z46eetlbptxAGP+V+p6qbwOlvxvn1nBPisq3ZIyIqzghVy61yPajB1JBJLPUijiay9lnYfomvPKxfGJW9ZqNmrX6BVzo0okuax+6/qVcs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4828 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 18, 2023 at 09:52:49AM +0100, Ferruh Yigit wrote: > On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > > DPDK 23.07 release to support monitorx instruction on EPYC processors. > > This results in ABI breakage for legacy apps. > > > > Signed-off-by: Sivaprasad Tummala > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index dcc1ca1696..831713983f 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -163,3 +163,6 @@ Deprecation Notices > > The new port library API (functions rte_swx_port_*) > > will gradually transition from experimental to stable status > > starting with DPDK 23.07 release. > > + > > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. > > > OK to add new CPU flag, > Acked-by: Ferruh Yigit > > > But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is > added, should we hide CPU flags better? > > Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow > appending new flags to the end although this may lead enum become more > messy by time. +1 top drop the NUMFLAGS value. We should not break ABI each time we need a new flag.