From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1EF04291B; Tue, 11 Apr 2023 10:44:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BD67410F9; Tue, 11 Apr 2023 10:44:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 5444D40A8B; Tue, 11 Apr 2023 10:43:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681202637; x=1712738637; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=E2tB/m9GlI920LyBUPtVr55y81F1vFwzIs5P8IRD4Vw=; b=KSSnZ/k+vSICatH8EED44PvDlIa4eXZ9OGYH/Fgv4Wsi9wEB9SExOLjC CLrT8YP/keo6Mx/vKaK6Kbb3/OHonZMocbGcgRw9V5euGpSKbvkVTyoQZ Y8OLwNdHS/9zn6OZflU/hZvx/IQSY5jfw6CKLYs7XyMiohL+9WQ1H88q0 7jGSVmV/qRYx0738R/Hr9QyYauTqZg8ORMT/n9HvYumBaWW1W2doOfz75 0EJjqA5vBy8YXLXfd3atVI5tJG5u0DGwOL/4dKK3dU/yTpo4GX4A1Qr5A OMjoxqdGmmRZjUSC95nO4xQihdl6QMGsbATeHx5UQCg1SaEr50HK4NcW3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="323192995" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="323192995" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 01:43:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="757741170" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="757741170" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 11 Apr 2023 01:43:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 01:43:52 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Apr 2023 01:43:52 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 11 Apr 2023 01:43:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeCVmd6rxodhHiucG3qYY/sR10wzFbQjeVoxYFarQZbnwP/AyBQ0z6YLuWhyu7RgejMpTmI3vppbnUJtDgWTG567Ca4z/RZUaicMymR0P8TWbS9hq/N85MXpExfHNOQfreIQY9vG+aeVH0F/oyncC+hgXh3OqVyp1TR+8qf8cgT3ahwabMEOzF2EHZW/wvZEv/6fWth4fTvsMPKPAP98kIxhKPbXXhV9MZ5/YmmZE+2pkIbfTawE7OKGpZE+2j/0Smp4FIqt1q+2xkGMiRTxhjOWo12SbtxgmLRaV+Kj+dGcw4+iRHLKk1HKqKtn/qzgnIwzqxIqxiGVlSYQkHtqYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fOplmQfOVQc7jFADAsRQI1X7lSSjGluruD6U5EIG9+o=; b=CFnsQIXsP693U+q+NYjnyFeRP45+5G0w2pl09SeGjtxiK/LVjZX+RstQPcu9b0Fm0LhJTc9ptb5hoggPYmqHXxwo75Zfgh6u0Vao2WAqXGhnMqxX0b78yl4Bs9FCfo2tPJ2RY988GTBlCb8g/HNDJ5G3SuA9xYb0ZtkTevhRmPhTdH0lPk+WAtVj8Y2kQS7Wg8zsbIeUDqSaAFFu13pjB1KGqKlqPyY5r/QcZ9MYWhOEUWETe+C5UKuo1wtPgNWCXwN5iv/S9PedCkLLHdNhidn2tK+u4GPfYHvC4LC3pFTSRlDSqs8XdiHyfiZ/ORGmr6iZZut8WVktY9FMlJklew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5380.namprd11.prod.outlook.com (2603:10b6:610:bb::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 08:43:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69%4]) with mapi id 15.20.6277.038; Tue, 11 Apr 2023 08:43:50 +0000 Date: Tue, 11 Apr 2023 09:43:44 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , , Subject: Re: [PATCH v2 1/5] telemetry: fix autotest failures on Alpine Message-ID: References: <20230310181836.162336-1-bruce.richardson@intel.com> <20230405154414.183915-1-bruce.richardson@intel.com> <20230405154414.183915-2-bruce.richardson@intel.com> <20230407192116.GA3014@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230407192116.GA3014@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5380:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cd45dbe-9a6e-48a7-17e9-08db3a68df36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tbZzNHg0oCEqm3kAgAZdIoDK2edV5IbFSOoqkProq7QS4GwaqGZxMtIkI5Os0XQ0hNGFd1bu3/gAN3nYWRTeYb2nF1oz6LoDJts9X1s/55hby3ykeb1Jkm1POqnUHXJ+F4SMv71ClMWW25bkcO80XfasIakSfBbs/SLGaeOEBKNEq+VlObLsXCPTpIIu0EfvNXKIhlMOerwyqmd3GnBHusXG72Xg5aVXB5APKzJcEi7ClIqSwxgfKxhEm5QFzwjcqi4w25F02XgzD0r6snznrT9ZKjxDQ/fUVLNBqXILBhiwaPAcT0/lM+betA+AzurTksqU047NpG28TAJzH9AEBUCW4YF47ij703pgPtURIluPjwDAop1BoeX3ItchZlDLUfzLCnNW1tTK2XTSryUC221Ek0gBD3hWl0TkwbvMLMOKCWHJMZ2hsJ70sfUtX4ExD5RzmmnKexeIaNtYWDOonaNsx59c9LjawKfeErcx2a6Z9DMaFRGUAslHhF2Lgb1hR4cbcvR4gZtTBB+iGgZdn4bj87UgjczNbab8zAT26s8eKYPKJNoHU/AVvLD01iGR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199021)(186003)(478600001)(6486002)(6666004)(6506007)(26005)(6512007)(2906002)(44832011)(38100700002)(5660300002)(4326008)(66946007)(66476007)(6916009)(82960400001)(41300700001)(66556008)(8676002)(316002)(86362001)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MVR3Ltow/SWnsWV1jDe3WutNt5Mc16XWfcjOiUUb3CMA/ei1qzCAHXAkDKA/?= =?us-ascii?Q?AiQYtoms44iudI5gb2DCn3h0fWx98TfFD106N/A+tbiEVwPtcCQYN789euA+?= =?us-ascii?Q?ic1AJi0hLyYtPEgpw+bbwK0HcAMyW2yeXVlVlUkoWn7PZL7y23Tf/BV5yK4H?= =?us-ascii?Q?x1y3R6KAgfGC4a1rbzKqTSqMQAaH17NxQDXKM8lnS6LN4CxbeDCe9COT+tJz?= =?us-ascii?Q?aSc/UpWJd5uBHihUkM/aY26YGqQkieTsXJdm9QZpD82xcon0JRxTIG53aS9Q?= =?us-ascii?Q?yKAjF4jhDh1KSfPyzE/ZguCjuiwV2DcrUyrNHkuzTVU8nlGLcXJXfrXV7EcT?= =?us-ascii?Q?LeZTSJKIh6v9HIv+NHx6Lt30bHkf5CunfVCZIKU4RdEcw/puy7JZjxuMs+j+?= =?us-ascii?Q?RuJ8UC2XNT8SuDqEnLTJfDZkLb/ITKPwbX97/L9T8eMrMveLas1TPaw0rXBd?= =?us-ascii?Q?kkKhHrbeSWg6SJxNHDC1ANHzdukDKvOlem3efZ7YgLql1o42BnbbZ5gbgoZ/?= =?us-ascii?Q?CKGCA+N8TW6rTHHRP/VzKwa65C1dKMNOjchchP79QrwJ7M6gnCnULvvjfBee?= =?us-ascii?Q?GaIb4lq7ASetiWCp9B+RmXIBRgdiWM1Ls0F0I2FVE0b85lj9BBErqqoiXq67?= =?us-ascii?Q?tL8F8xsBLEcWDLrifNEFXzLHFTjfHvMEUc/79kuti2xOw/CKAhXpcWdU7MKw?= =?us-ascii?Q?ZObkGCSomh/XWQY1z/wicW65t7BXVmZGwkWRVnKUnC8bBTde3vtCRO5OZTKF?= =?us-ascii?Q?8YNFUZVwb+5SIrp7J3lYcYOQ/20NxGsEpD7f+z7SoRVqa2oaZ4zEQI06iktZ?= =?us-ascii?Q?83jUJbuYkACcNiao3DZW7Nrr40YFhZZGSpECBO+/mUP7Ve+hjILkwDU/Tc9C?= =?us-ascii?Q?aRXlC9KwTEhdZQrC93V/DO+iGjmOFK18xiZ6xrgtok0xkjZc/VMXyNEU7tey?= =?us-ascii?Q?IkcqMA8zV4UxRyIbqccvqHC+dL8vnTA8p+QZhFau+SN/GMgwnCjQolGm2qMp?= =?us-ascii?Q?OG/03LHDso92coX/FW/M+SiKeMnqmtJJtnt7tfn54rRs5IRrqzHPZVuN7Of6?= =?us-ascii?Q?wk92vd31PpkaRClNHj5Y0BPjRAhzdcJyJ6lk2nDyvAuY0fAKwSzvRz643v0w?= =?us-ascii?Q?bkiLaiqlK8T72RVJ3vzgEDVkzB8jIG4l5T6g9ecICaBoLaQQzMWVpGz0JXvw?= =?us-ascii?Q?hoMkvg1sw0QMm24CltrBPDg0Aft9v3TG1wyPN2G6CIBcfC33+jDTPTPZQFz9?= =?us-ascii?Q?1jwq+H83aQ4bzNcELwrQj/PvN65F/EXlatv0PZtZypKV5d1xIWLL9VgZcAwd?= =?us-ascii?Q?3oqRdEX/vEtlmLxF9/SPJrUrNXcZU22hfDKSps9E3hQOUe4+0u0vBbG8pwmx?= =?us-ascii?Q?7DnsTCLpSGvPpP5UfZ8aJhls4RnCfCk/9+mGUC27DpTYC+LvH9XKyWVWRr8U?= =?us-ascii?Q?tlTO9QP+w/OLvRugviNxIYK29r7g2MRQvKkDCmmIXXnZuf+iJ97Ym1j7JtE4?= =?us-ascii?Q?ArMHiq3XJq/gstVeXGgbhCO5PPjLp6WyfZ9sAP1e4qwJinPZ4yYOvnWrhTrc?= =?us-ascii?Q?fe5OicLIXRz5n1uLSsNRvjMuTqdZ6YBUADG/ls7LqjwgSyHMBWzHV6MF8Ugu?= =?us-ascii?Q?zw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd45dbe-9a6e-48a7-17e9-08db3a68df36 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 08:43:50.1913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aI5Y+KG8dDbsCFNHYPWxTguuJS7EwyGqsQ3mSJEvKBPLlV8LIUKqLZaARoEwt34v4b61QOWx2pRgA/5nnbkgwHXmTKRfzNbjR9vmAGjPTSU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5380 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 07, 2023 at 12:21:16PM -0700, Tyler Retzlaff wrote: > On Wed, Apr 05, 2023 at 04:44:10PM +0100, Bruce Richardson wrote: > > On Alpine linux, the telemetry_data_autotest was failing for the > > test where we had dictionaries embedded in other dictionaries up > > to three levels deep. Indications are that this issue is due to > > excess data being stored on the stack, so replace stack-allocated > > buffer data with dynamically allocated data in the case where we > > are doing recursive processing of telemetry data structures into > > json. > > > > Bugzilla ID: 1177 > > Fixes: c933bb5177ca ("telemetry: support array values in data object") > > Fixes: d2671e642a8e ("telemetry: support dict of dicts") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > > > --- > Acked-by: Tyler Retzlaff > > (one observation below) > > > V2: > > set '\0' in newly malloc'ed buffer to ensure it always has valid > > string data. > > --- > > @@ -286,6 +295,7 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s) > > v->name, temp); > > if (!cont->keep) > > rte_tel_data_free(cont->data); > > + free(temp); > > not expressing a preference just noticing that when > RTE_TEL_CONTAINER cases are the last case in the switch sometimes there > is an explicit break; and sometimes not. > I won't do a new patch revision just for that, but if I end up doing one for other reasons I'll try and remember to make it more consistent. thanks, /Bruce