From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 975C342925; Wed, 12 Apr 2023 11:53:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87BB241141; Wed, 12 Apr 2023 11:53:08 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 834B14067B for ; Wed, 12 Apr 2023 11:53:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681293186; x=1712829186; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WiYzvZAWa/sCA50bPlODUjs3QFU5ngXg8JL2+SVFkiM=; b=eORIDHQLzqE7on7OAZx0K9PH/Q86/hvY76bplUvLlTyeWxeEv65Whn9y L5PIXrKIYwaEZP6H5GFkwQpXmN2YFjWJgdEfokKJgcGmRCYLEPh2q3K1c pzBk2D1nAljbbGK4N2mLF8kQtqZUcq9acvsi6YUl8P4ugKO/RYmky/2F1 JfFiBndb3XX5EM4cxQb28gK9PH6TcKu9Zjo9tYFFA2m3voJWqZAeN3NxY 7cEH8JJ3+NIXeURXZFq6S7SI5mMRzvJNU/3BR+H2HHgqUfLrfvHYo1KcB olhcJ/mbbwszgJgFPR9yk6rFgA9VWl6ltkH+1d5sVCa1fQBrqE7ocrEIb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="341341385" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="341341385" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 02:53:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="758174656" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="758174656" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 12 Apr 2023 02:53:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 02:53:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 02:53:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 02:53:04 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 02:53:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXsSTsiZyfgnxUnrry9oGHHPnR9sKOaujrN5ux+567gf/nx5tYaoVeDCPAz8gAFBlar0bPDwnRtNH/m3FlvjS1SFEjoh/4FY6IG07NUO/52bdW/xS3GAzmQewB9FpfSCqo/8pbfgBFW6xWTeiBBNcTl5sjV52+kdJmgay/3YP6QSru3MQPyV1sBT25Zq1cM+4y7oz8ANwSamLjrP/29CKUJOp0ditFSvjzh9ZYT/nfg5Zyx5p8OJSaOh2KlxactYdjhiQzRRI9qeZyeTMfpAuJsQ2I32ZmnzCWXefbtmbEZgBRFw/udHkyIHhK6swKD+DLWoLRFhxqAVxH0v6YWk5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dvppepAR8PcqUrOox6NS9jiuhCNJ9caWVKywJ8NLa4I=; b=XU0XdbrF+RluDmld3XWz4igSWRe6ZGUtjJparSLw9fEP068rygwOyzExREgaub3Y5RksGXV7ysAaoO1x7U0wQiV3ZNshgT7boQFlpR0MAqYP9bQXcdDAKGX/w/5er+pEfFQlPminfgvEU7oeO9JPrAasPtUHvzI5sEelwJsG++qD0eUJpkpOmLCYfasTQYsZ/Oy1nR/9Oz/2GI9tYmA1ugAMCbPfOT7y92WjJWyg5XVTunklJ9zPYlMjQMvI6Wx3YQS0ypxNGzhWigjr+QaHVfonqvOPuwt7Wz6BMuKaLsIqkcDLGdZ81Q1K5ETN6PctUC3m0XWuKnCRXQEPDB0wJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB8374.namprd11.prod.outlook.com (2603:10b6:806:385::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Wed, 12 Apr 2023 09:52:57 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69%4]) with mapi id 15.20.6298.030; Wed, 12 Apr 2023 09:52:56 +0000 Date: Wed, 12 Apr 2023 10:52:49 +0100 From: Bruce Richardson To: Chengwen Feng CC: , Kevin Laatz , Subject: Re: [PATCH] dmadev: add tracepoints Message-ID: References: <20230412024808.41339-1-fengchengwen@huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230412024808.41339-1-fengchengwen@huawei.com> X-ClientProxiedBy: LO4P123CA0186.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB8374:EE_ X-MS-Office365-Filtering-Correlation-Id: 016d69ff-d0dd-4d50-7483-08db3b3bb0a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kpvpt5+g6M6dL9tJ45h8hh6FP7cONjjiLRpYc8LutskUQIcsuWND7OxzzuW5Jj2fOSBKthGJjRLgiDaUCCkmjPGPxEEBhGzza/SeGYu1ESzFZqo1mgMmSLRUJpxmJLSC03n1KPopNlIG35otLYn+5wIEwGpfyvAq9zJK48QT0j0QAKftIa0qnuXNRDI1pX2GaMWv6hNEwSW+cJjzjvZmY7aKuXZKtUqaP67ZRxeurhrc0xvEc3fMlO+8Y8raB279sww/4WXop4/Iw84DUN40e9cr2O2F76F/4u7kNe7IxgMFAJJs4rQpWKMmuKdEvz1knJC4OFFwtr9kZEaK7LgF9jK4l72/0UGj6Lk/CLXJ0zAjJJ3aFSm3v8KuWTnXVjvnSEIwjnn5eh5FWxQfZ2fMhDvz6RLDIBnOoIcDLdPz6AAUKi8tJP5DNk5bTF/oz6vqidab0FAJ2CzhxytjQhebCHjffHaWV3gjgNxzv2zsaJgY4PxEY7VHrCNUqbsO7uyBmd7J7lWwztAMbx95ASPG24jb1xfrag+fjDeb/zgW4mNhII7Vz34KLHjPorU9+K2h X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199021)(82960400001)(6506007)(6512007)(26005)(38100700002)(83380400001)(186003)(8936002)(44832011)(316002)(41300700001)(4326008)(6486002)(6916009)(8676002)(5660300002)(86362001)(6666004)(2906002)(66556008)(66946007)(66476007)(478600001)(4744005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rTlLLl1EEV1i+2iJ4bGXfY3FSzVj7/1Gs2bE76S5l7OyWgsOx5epjpiMKiZL?= =?us-ascii?Q?Bshg0BrJ1Z3SelC3TELkPfsO7wMa1fcDurZBjAYry/jTmeIH4nP/tJk6pJHj?= =?us-ascii?Q?duAg5bbGgIBDlKBji+hCCTSlPJ59b+7PJYosCSa9OjmKhgu8XP7YBG7mrjxM?= =?us-ascii?Q?z1vHDs3BkcX1jXoUCHmfR/mRTGqoQ7H4jiZIbEr12gW5DNfsTKZXVPABd+ev?= =?us-ascii?Q?peJW8BbWqq1p8yNYfI8bvzvTWhyRHaBGd1/diBGB2GjmcHGOzW/14yBxrg9Z?= =?us-ascii?Q?7vpVdoiioDeqPfKlxLp30rvBgePOHc+P13XkYpBdWi5PcO9yN3CKS+udb/6U?= =?us-ascii?Q?SyqZ774MofM+OjDwk8nfr9QIsUdxWo3rmQs5x4Kot+Z4bEA4XbOowTXZa7yK?= =?us-ascii?Q?IAy856HquUrlGfezMrjhCrg7YMVin4SF2keYHj8O+m4ncZgHuJUgIm1aCTLy?= =?us-ascii?Q?9t7Gt5t2EfKZ/eGCVVqJ9+OT9f1ICo3meqJjZOQO8PNneNiMMasETTLl//Cv?= =?us-ascii?Q?xbluv+nG4J6WF5eW/jPhvAOQplgDTJH20xWGPz0ol3wq+9vH8pnWVmqA28t4?= =?us-ascii?Q?R9rS1khDF5RVsx7AvfsY1aoobIyA9nW0kt36FLifxhSkcYpkvtDVozNOEkjo?= =?us-ascii?Q?NPAsZTUfLn8KlWD6yIJ/2jWSnoNePJoQKOZFcQuOWi7mxm57thlMg2Nf/icX?= =?us-ascii?Q?ZqmtJmoVbIH0hU9G0yi39XX6YB4+Knwtc2z8YIzEuL7nuwrND7N2qDTEQRcE?= =?us-ascii?Q?hpyMLYz3+mB/lx5egkLKh5r3O9LTcYgT5bybzsug/Yzumm0L9SVWu0gtD9Bi?= =?us-ascii?Q?QuFgUyQeUBZTroKWjhgQFpUUgGkJD5USMk5IgrAnYkX6RgUl+y7XY4K8pl2y?= =?us-ascii?Q?EzQn8TFQJmaXjSn3+kk/ApcquiuRFPdesgLVCUf5va7PtZyHdheQ2dfvtPq7?= =?us-ascii?Q?H4u4iV2yt3RQoRvNwQiWDSkoJ1+SeYcYXrf+LBPxT1LdCm+IW9qIOOnmD3SR?= =?us-ascii?Q?qJpJumTXj3PVxzH0jdFVqBloAIYdft3Gvhb/RPMug1i32Cx2jG9gHGupVh1o?= =?us-ascii?Q?Qp9AvH2akPcTLn2GP12FDInAnbKfupkLopjRs767v9cqwNWfl5VXV2Q6k/3+?= =?us-ascii?Q?SwcvPqTB9JGs9B1p32oBtTiWDp7RE1lzOlKy/mL9c7EccpaUKIUPAMjrsA6e?= =?us-ascii?Q?8LDFCakYlvOjdYk8tGSLzUjqomZzEh2b06TdVeGBFvuukuWHiK0s2qTgwXiS?= =?us-ascii?Q?QTi5o2j6asJKIS7YoDCcAB9C4RNFJLlfSe8NQbARFD+J9r/J/FtzouL6W7Wp?= =?us-ascii?Q?H3VUWGrOvNlGL6zw2o+OnZRAMKQoQhJVKEbKVgP9s7XNdjWuvBJ0+HHiE96M?= =?us-ascii?Q?n46AoaM2Ib6KOmLQtGFjx9vw9fliMXWqijnt7+hGEw/rQ83PJdyQfCRjJ0u1?= =?us-ascii?Q?+WOA+ZmNtjmTN0+1rp6QoI55LXD+dl797mO41NlZzckSyliF9sOTpOkWsLyM?= =?us-ascii?Q?MVZca6XkiHax+kwmGYCjGzkeCe+DOr3c521vWR3JAXurGz5uvO8JM+p8nSJL?= =?us-ascii?Q?ff+U0Vt7obi9KYRRlxtLiwDjnFKahHZqpdaobqzt0fL9utv3h7xKcvGwe6SQ?= =?us-ascii?Q?9A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 016d69ff-d0dd-4d50-7483-08db3b3bb0a0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 09:52:55.7039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EEPgnost0RCmWtqIYk4GwfowQmrDMZZ01s5k/vQ6kg05MphLqB3THFYBBJRM5cn9NaabWbwyksG11rWdNiDciZ+mx+Kko7Zu2hdfj7gM+Vk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8374 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 12, 2023 at 02:48:08AM +0000, Chengwen Feng wrote: > Add tracepoints at important APIs for tracing support. > > Signed-off-by: Chengwen Feng > --- > lib/dmadev/meson.build | 2 +- > lib/dmadev/rte_dmadev.c | 39 ++++++-- > lib/dmadev/rte_dmadev.h | 56 ++++++++--- > lib/dmadev/rte_dmadev_trace.h | 133 +++++++++++++++++++++++++++ > lib/dmadev/rte_dmadev_trace_fp.h | 113 +++++++++++++++++++++++ > lib/dmadev/rte_dmadev_trace_points.c | 59 ++++++++++++ > lib/dmadev/version.map | 10 ++ > 7 files changed, 391 insertions(+), 21 deletions(-) > create mode 100644 lib/dmadev/rte_dmadev_trace.h > create mode 100644 lib/dmadev/rte_dmadev_trace_fp.h > create mode 100644 lib/dmadev/rte_dmadev_trace_points.c > For completeness, do you have any numbers for the performance impact (if any) to the DMA dataplane APIs with this tracing added? /Bruce