From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BB7942ABD; Tue, 9 May 2023 15:35:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 695DC42D31; Tue, 9 May 2023 15:35:18 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2104.outbound.protection.outlook.com [40.107.94.104]) by mails.dpdk.org (Postfix) with ESMTP id 6BD7D41151 for ; Tue, 9 May 2023 15:35:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5WndzEghWaYNYVzhgbQir+cdrIHnozemeIErZIlgUx+9jDB6Qm+rfWs9mTwXlptqEEFvubQGHErT/pVNC62fagaiVASXOGR9WrBAyv9Mck5epT6rGIyjzKc+PWtQvSmQMnwfKBzOx5WovV6yNVLPdlo7+DhfLrYG1QlWucds71SPxTOmeZCzaUW0Y6mLZbdvfwU+alOWQzDzsceife+8JoQv7c0Xj0cfP/oHSnUJXDTE79FXcJP1uNryfi9SX9jXagve64it2K4hJON4dF4QYyClah6sGPwR+fslzIM4pdDKBoBJuLqQJZ4YmZXSopQcqUVhi8zXBocuMU8HC8FSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oBxhC6yVf9VgDzHS6ag1kAWxzq+Fb4YGDhVG2LzxZVo=; b=knrq/i0vVJU4nr0WpPjz7FMeUvCADjKFdCLIuQPGFvqgbdpDU+e2eGkgwnT8VkwBog68wHJFhr5t2jD55DFdPHZSX2/69i7lgaQ8qD6tCVgfNkiJf9eT+/TjqerPtOQX8WAzYuhZhrlNbxpAA1UBc0dCwgvQ19V5sgOwKI3A+a0HcjIdokzplKv+6RkNpTOK8E6Bs4dJZ/ii9Um1VJj26liH/2kyboPb+OZFmaksCJ7m79wIhX/GKfzSf9w3pGK9BLlHLDR2XRWMyxEQxnuEfGuLJ10ZTKGDqaQ1fiNdrKviAzMogW0bucNkKLecLxtsdsiI9r9FPjuxE5SbiEsFtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oBxhC6yVf9VgDzHS6ag1kAWxzq+Fb4YGDhVG2LzxZVo=; b=Xv2vE1PDhTG2rT6emxViugQPmCNsbbOlUo5pL4A7L7N1Z5rw7u8JocuLjx+GhcxlRSF5yvnaP/etNgHxPM7LhcKe2iYknKRvXlZB3vV9AkGIwEcSQaieFRF8762Iq1nggrD2PgZBIZbqiGYZIJLEX2NCqOoEl5PzZZJn31AyAvA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) by SA1PR13MB5467.namprd13.prod.outlook.com (2603:10b6:806:232::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Tue, 9 May 2023 13:35:13 +0000 Received: from BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8bfb:3fbb:241f:e41]) by BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8bfb:3fbb:241f:e41%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023 13:35:13 +0000 Date: Tue, 9 May 2023 15:35:05 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Stephen Hemminger Cc: dev@dpdk.org, Chaoyong He Subject: Re: [PATCH v2 07/14] net/nfp: use rte_pktmbuf_mtod_offset Message-ID: References: <20230505174813.133894-1-stephen@networkplumber.org> <20230506160404.7423-1-stephen@networkplumber.org> <20230506160404.7423-8-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230506160404.7423-8-stephen@networkplumber.org> X-ClientProxiedBy: GV3P280CA0070.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::25) To BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4804:EE_|SA1PR13MB5467:EE_ X-MS-Office365-Filtering-Correlation-Id: f98b2959-ed60-4912-144b-08db50923782 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0DOYlswrtzZKQtVQ7m39ImtJZXKJOOSKkrMdo5NYqZpRz/IT3MTvGjVnW3lU0xCTs0ZilgZw478E7nNyLuoYklBBDk1BDcb54ZlcwQJ+Oxxr1Oq5gKp/pgVTey6OKM20L4vL9j0VOw1LH393FcYfz5jAcK9d3xSNLSNcYAEu/zQEeya9rzMxJpfXIUsFCH3UoB4IECzvVMbLsXFJmhg3M/d4amn6V9oALf1WlhUJLSFIuVuNmL7FWvmtebzakMs6LQq5b6auetRrCq/svIPeTl66b2J/6X1M5+O11Y0uuimZ4eNhHPOhUha5YrX4caZ18x7w8Szk72ew5R41b61uGr1S/1z7nsQrRcKa8X06GwIn71DC1znAO+dDUNegCVC9ueJkZPLDJhR3HPJIl47kYSCoH4fk4gpOX38STmtXTH98JtauBNkKjpRpvyWf0sev+eCcXr0J1MTzpp2m1OyKBEt0V56ivGp6hDB1PhogI4O+90jMfv7ZuWTG4ZWnX95pMca3iRNd0uRQ/itf2IzMGWSpTIqawxnNxVpvSdQQoy027nwJILe3gAG5iYyt6em/nJHEoWSWlopNrwdJQ/wC6A69M4H1zP2pKG6VVjpVS+HXWleTmEc14ty5ioPrgvRn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(366004)(39830400003)(346002)(136003)(451199021)(6486002)(52116002)(6666004)(83380400001)(38100700002)(38350700002)(6512007)(186003)(9686003)(53546011)(8936002)(41300700001)(478600001)(107886003)(316002)(86362001)(6916009)(4326008)(5660300002)(2906002)(26005)(66946007)(6506007)(66556008)(8676002)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3R3NHVMSGtUaFlSdmx2OS8zUVJubXVJVWlncEF5bkllSUMvVmFqc2MxcGlq?= =?utf-8?B?T2kwYzNGOFptVWhrT2F6OVh3VlY5MHBnNjVwcjErQlpwVEVnekowOGREWnA1?= =?utf-8?B?OFhZMGpmTisvTVJZdDF2SGt1MG4wVlY5eXB4aG9YbmdYSW5iZUxsVjNHaE1o?= =?utf-8?B?cjBhT2tMUGxWMm12TUl3cWFiK1lzS3hjdFhhWU95UmI4aG1ZbzN3eWtqSnQ3?= =?utf-8?B?TGlrTmF6WkRKQk0xaW9VeGZrcGNOMWh5aUErMWRzckNFR0F3eksra2hwMWEr?= =?utf-8?B?NWQ0WWcrWWV3RytsUnArTWZsbll6TTNPd2t5Z3Myc3dmNTZTWml1OFgybWdQ?= =?utf-8?B?TjJaZldTYWNoeC8rNVJWQVpCdmZ1Q0JLUTRkeWJDU1Q2SXV4Z1QzOXJDZk9i?= =?utf-8?B?SHVpQSs0LzhhTzkzVXBlanEyWEFIRmh1WHlqd0dTT2dtMFVRQTNPTVhOUW5C?= =?utf-8?B?aEhFK2trVGhGeDZta1FnM0trRmVGRWJVeHoyaGpralV6OWpFT25PSTlZaEha?= =?utf-8?B?Sm9raHZNWGhEQUFkdUVON0lDWnd4ZzEvVW0xRElrRmxKbFlPTWFHQThIQngv?= =?utf-8?B?ZnAyYm52blJTWFYvd0NXOWlhMHFXLzZIM045QW54aE5uYmFaYWwvK3ZGVWRv?= =?utf-8?B?UmV3RU5pbGNobkNrN0F6RW1qS0o4VnNNRGk4eGh1dENpT2tVWG16ZGZxcmRr?= =?utf-8?B?bVN3My9JN25FMEtsZE81QmRMcWhhY0crbFlPWjZQcjJtV0M3YldRYmpiWCtm?= =?utf-8?B?QlRqemhCQ1o1ZktPK1I2dzRoczhvNGJkVER2ejA0Rzl5cW9tNEE1V3ZuUkRk?= =?utf-8?B?dHNxNCsybVprc1FOTFpRK3dQMkkwdGR3QnplSlZoZk1rVXdhZWFWS0JubWc0?= =?utf-8?B?a29kbDFGcGpTMzBoM0YxWHNFc2YxdGFySFIyek5lL3drdU5CcGI4RWZIZkJk?= =?utf-8?B?YWFnNXlhOXA3bXRBNWlOSmhRZUkyOU5idWFXZWRGUmpYemszSS9Va0tiRERP?= =?utf-8?B?WDhIb2piTjRWbGVDdlcrSVBVeUtQaDE5M2s1ZkdLOEtSNURrV09DN3g1L0ND?= =?utf-8?B?YkNGOTVDbURaMGNpVmZCNFZxeUdubzlrN3JYOUpieFFJVHpGRlVBcERJdWQ5?= =?utf-8?B?RUhmRVppTmthY0tXTFU1L01vQktyUzZoUXdpbGVJM0FCZ1k2akFJK0szRjAz?= =?utf-8?B?R05JcThQWC9JVVhoSldLK3VJbkNpRk5WUlNDNFVBUXRpWEJ3U1ZjbFhWT2FE?= =?utf-8?B?Vit0aGxYbFR2R0w4M2U2VkgxWUhaVm9NN0V0TzlyaEU5TXFFMFJUaEJHUzBT?= =?utf-8?B?YUdiZ2YxUFlkN0NNMmtrV29CekZKV0ZSNllGRGxrWnFGbUF1VlhPRDVhNWY3?= =?utf-8?B?V3Nkd2xwRnZ1eGR1Y0JYbGpvZnpQTkpmVDNWcHM2bkR5bWMxQ0szbDJBeTNi?= =?utf-8?B?cUF3bFFjWURLL0kyTm1EVVFsWmZya1JqMHB2UXdTWTdvT01tNVpSd0lzc3ZO?= =?utf-8?B?eWlBTUFUN3JQcXMrM1A1aTN4Y2ErTjdzN3Q0dlF3d2NXcnJ4cnh5U3oxd2V4?= =?utf-8?B?bXFQZEx5L05uTW1Ra3JKTGYrKzZMbDZXdEljdDVMbU9wY1FEck4zaXAyRWRj?= =?utf-8?B?SDZtYXAzWGlSTENNRXhpbkVnYm83Qjl2VU5LM1B1V3hzQXJxWFRMUzVkdzQy?= =?utf-8?B?UmxYWVRRVm1McGRkdERqR2J2UWxWQm13bVQ0VXRJbGM2eEkwd3kvbE9LczQw?= =?utf-8?B?MENwUWRWd0dGZUtXcjJkd2xXSVh4YXF6ZWZBZ25LUjAxZjN3VHVLNWRxYWx0?= =?utf-8?B?WlZaWmw3NHUzUUFraDk5TWNQZHQrR09XUWV5b2lnUUpFRkF1YjdDb2E3MHpp?= =?utf-8?B?aitPUE1QTFZSdWpWdHdna3RmTS9lZzY0bGJScWFtVi9HTmhqY2d1ZVd0OGxY?= =?utf-8?B?T0F6WE5UaTNZMmVxaFd5dzAzM1p0dzU4alBSTXc3K1VjTmM5RTZsYzZNMXIy?= =?utf-8?B?UlNVVU4renpCdnlyaWZzVHJLZEc2WjZWZFhwUEFmUDlnVG5IWTk4ODdBek90?= =?utf-8?B?RmhRKzE0OWM5L1ZDdXJYbDFXVXhMYTU2aXpzdFpJckpEUGdYQ1p2YTFaMGlq?= =?utf-8?B?QXd6dDk3bDM0S1BZRlptcVh0V1JPc0NvSTFpZFRCWFRJVzZ0ZEFaandjdHc5?= =?utf-8?B?bHc9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: f98b2959-ed60-4912-144b-08db50923782 X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4804.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 13:35:13.2732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r0cR+8avIzEo7SmsGAPVaDl2va1RAOg0/uter4Nuv8ZOwMm6+mKtTwM+6XVqSHRiUj3VafYd+yp8SYMJFFcSEBYh5HC8uDIz0TqSkpnT2Vc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5467 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, Thanks for your work. On 2023-05-06 09:03:56 -0700, Stephen Hemminger wrote: > Automatically generated by cocci/mtod-offset.cocci. > > Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/flower/nfp_flower_cmsg.h | 3 ++- > drivers/net/nfp/flower/nfp_flower_ctrl.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.h b/drivers/net/nfp/flower/nfp_flower_cmsg.h > index 96e080a8e956..5ae0e8be1d67 100644 > --- a/drivers/net/nfp/flower/nfp_flower_cmsg.h > +++ b/drivers/net/nfp/flower/nfp_flower_cmsg.h > @@ -380,7 +380,8 @@ enum nfp_flower_cmsg_port_vnic_type { > static inline char* > nfp_flower_cmsg_get_data(struct rte_mbuf *m) > { > - return rte_pktmbuf_mtod(m, char *) + 4 + 4 + NFP_FLOWER_CMSG_HLEN; > + return rte_pktmbuf_mtod_offset(m, char *, > + 4 + 4 + NFP_FLOWER_CMSG_HLEN); > } > > /* > diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c b/drivers/net/nfp/flower/nfp_flower_ctrl.c > index 3e083d948edf..9a8e464a1d18 100644 > --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c > +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c > @@ -234,7 +234,7 @@ nfp_flower_cmsg_rx_stats(struct nfp_flow_priv *flow_priv, > uint32_t ctx_id; > struct nfp_flower_stats_frame *stats; > > - msg = rte_pktmbuf_mtod(mbuf, char *) + NFP_FLOWER_CMSG_HLEN; > + msg = rte_pktmbuf_mtod_offset(mbuf, char *, NFP_FLOWER_CMSG_HLEN); > msg_len = mbuf->data_len - NFP_FLOWER_CMSG_HLEN; > count = msg_len / sizeof(struct nfp_flower_stats_frame); > > @@ -257,7 +257,7 @@ nfp_flower_cmsg_rx_qos_stats(struct nfp_mtr_priv *mtr_priv, > struct nfp_mtr *mtr; > struct nfp_mtr_stats_reply *mtr_stats; > > - msg = rte_pktmbuf_mtod(mbuf, char *) + NFP_FLOWER_CMSG_HLEN; > + msg = rte_pktmbuf_mtod_offset(mbuf, char *, NFP_FLOWER_CMSG_HLEN); > > mtr_stats = (struct nfp_mtr_stats_reply *)msg; > profile_id = rte_be_to_cpu_32(mtr_stats->head.profile_id); > -- > 2.39.2 > -- Kind Regards, Niklas Söderlund