From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32A9A42B98; Thu, 25 May 2023 10:30:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BA2840DDB; Thu, 25 May 2023 10:30:59 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B2DC640A82 for ; Thu, 25 May 2023 10:30:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685003457; x=1716539457; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9rhE/wDfJ6bMgUmLLc9ffvLSyi/koZdC69GyZIiQ7n4=; b=hDeTRt7g4/iL99m3bJLYdk9vJEliKei9hKaV5Tk6qXQP9bMkWsv+nH/7 7KIhTD7kRp6eLkXJJdEmvhccy2SIFpFMyAlI6GS/Hj46XC6OkoG4LOhvC AuSIR0fW7snNRcJGGkWkOF50/EnhGCm7qbxX2cpvHcsXi9HPE2NhEJBws KIocJWi9dug/einssueOuUdFNq+SCLVMeFOTiAyENlMRlNITvW/y/r2H4 TMqfM3Lv/G7qy5yh00r8QDkqNAFzgWhzksovZXAn3ZkcmO2RGOxNpZOb9 QhnbeJiLwOBoYh+E6vNE9LC5Kr2IQFQSeS5xvh/1UMmlS2TINW79+6r1O w==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="382075336" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="382075336" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 01:30:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="769794009" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="769794009" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 25 May 2023 01:30:56 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 01:30:55 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 01:30:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 25 May 2023 01:30:55 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 25 May 2023 01:30:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=evOREI15+VMMyQmR9FS3qN6Z1V+j9Xffy+ZHTWWAuWDWLNz+QuK6xkYJZicd9hJyF1OU+OK4SA8EWtyxZnS0BgZ2tcko6IbJIcyGXuv4K9X3i1a0cJWKEluAZ8zLHNNh3BQmNQZoyZI+p0uCsvXe3hPh1u6ooSSY+cuATsdj1oVJXRPqHv2JEyyvscP2moKxWHSEhxinYSNBnE7y++n4Gh+jItd5TbJNdAlBWoj3PEVZPjb3FWoLM8rge8P8G8gfy5WU54e/ZUz1H6CqlFX0qUR1A4tSO9czFgc5LkNLnNXSTf8wl0RY5PmxrsHC33X5gfQSVJ13jdM+w4BX7x0Zrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1eHyNYN+XWmspge4KAgwcJVRY3dVvZjf9dzZnJVManM=; b=SDD/Jg868+EGYhQPYSNJ3LXiS3xbPxpbcqk9tHZEudH/vFHfie0mCVy/Glr8FVgOKXL/p98EiyR7AyqItXuDk+9M0Pg3iW6PRJIOvHRy1yflxzkXAtduuF62jGJT0xJuXrk5rme2jzHmq3YQsVs4Tx4DmoruysT0gsLy0W80vHmkYK+nQMHH4VABNX9JOiv6uq3jl8xkpD+mW+GizOzrHx+i5P+ojhkJn7FV8Vh8JP/mqVZfc0bdMyq/F1v2jBRrEerIQSIlKYa48Jgo9S4GGnQWei9oujrDrU50kAFG4ZnQM1ms1lOjBjCwloxNIwPYwG+pridkbK9zWxzREtIzGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5495.namprd11.prod.outlook.com (2603:10b6:208:317::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May 2023 08:30:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%7]) with mapi id 15.20.6433.017; Thu, 25 May 2023 08:30:53 +0000 Date: Thu, 25 May 2023 09:30:46 +0100 From: Bruce Richardson To: David Marchand CC: , , Ciara Power , Tyler Retzlaff Subject: Re: [PATCH] telemetry: fix JSON string formatter Message-ID: References: <20230525072035.2512566-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230525072035.2512566-1-david.marchand@redhat.com> X-ClientProxiedBy: LO4P123CA0374.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5495:EE_ X-MS-Office365-Filtering-Correlation-Id: 33823cfb-ce33-4bdd-012b-08db5cfa5a10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UIfSoUjJG9AF3Nu/RQqhswU1fdpEcXYyzvCaYYDjX110XgWC9X8fqqt+7TqVzH7uJu0EEmaB3gaPUSUHQ+OjmxwsaQzQGf0FfO3DMiUHwkNACMpPsDAzGSb9WhW6tbeCy0MhgWaZ7p/djSVkBJf1CQpka7cXbR36PyFlkF1AmlxaE+8ChlLmDz20BsmbE2DmCrYmYEvMRxCHtaBN+pM92Xf5blxajBA+UREThCXD/F8/bGUcnyEOawbsIqEDFrUEFO+//OhRyPXTbg71uvbdhEmGidEyNZtx0l9VBwockm7Vj9OyZxjMeQ/zZs8OeWsECL/vdnFG/tbabfu29piuowLbUAVj2Cr/wzEZNs9zttDk4VBe/0+jKqcAsLf3kzEZLi9lGGIn7XQF7uQBHD1+w8dMI7QtIlzXzX+AEKvwVbiFCLiNHRGpJ3Udwgc2uLgzerr8HMT0kg3ettZTluxBaisScUVTYMl810TVekX1j8M/lK/s0d70FC2LJVJ+4SSEMrJhyNRkaH539SZ76VmcSzdMJ+eSbQnA7/D8LfMIPA173ACSdnho9pBfSHUZ8jmo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199021)(54906003)(2906002)(4744005)(5660300002)(8936002)(44832011)(8676002)(6486002)(41300700001)(316002)(66476007)(4326008)(66556008)(478600001)(66946007)(6666004)(6916009)(186003)(6506007)(6512007)(38100700002)(86362001)(26005)(83380400001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?acV5PSTadqhmN3tdFBa0rAf1JMY9ssgBl6kSx7w6rOp15tBQ6e5rtkppQqY6?= =?us-ascii?Q?8QEVhD+XpW9MjeBcbeAZAlxB/XmrE+nvIiSOFh8v6YQOhcPfsSVyLL0xddcw?= =?us-ascii?Q?uCWBzLxL5H8rENXIMGMaPPt7TcuPwo+YIZEG1b72K3YgeqgZtfKCF5uS8LiG?= =?us-ascii?Q?9qoNemkYw08PRRYwQbTYYyICcB/doCnx/yLeE/1EwbSvbt8WsEPczOsv/vm3?= =?us-ascii?Q?21/9VPncJJtKbSdjagGiyvu2QvF6SZDGqwqvAz0ZyFtgW48QiCPei8nF9aYF?= =?us-ascii?Q?lkR87cgN1XBZTqaFYJVq3VI1KTdtmZX+quN/ExCnv6+9qZLT9i7sqk4ZRucT?= =?us-ascii?Q?6VrHsfUnbhsHcr+HhjcmjotcP+Eqg2A72/2rRgQZsTliMX/GUn6vcgrh5zU2?= =?us-ascii?Q?7b+pgxOE7+4scr4v+L8S87mqddxQxcWbMbzATMHBgjJenJ0ZUPpbuZ9+mtyB?= =?us-ascii?Q?09eq1LFeKb8OSBgz8pOqkorY7sfZLHtfcmX++MQu5eiAd7LHF0lPM5hb0uwS?= =?us-ascii?Q?eDOt5VDK4Gb4G1C5M8eHQVB7gG7JQLQKv4//MdBYHI9shsvrVINDXYU42eoC?= =?us-ascii?Q?7iszuQS6nlw7KmsjoQoXcWtyiPkqsC2MpiLHok+M1Zub0jU4CHurRpl+azWx?= =?us-ascii?Q?ymf/1rLSQlC2G2AL2C8jZEasDvSpmludaA6Q3H0Bs3OqLxxpMHMXNBGEkNTT?= =?us-ascii?Q?+kxQUUcXBSJxEssQBpu0oFzpjEfG0pbC7NMm7kbhDaDmEqzdnEfiFqcCA7xy?= =?us-ascii?Q?HWI/tOMsHnNGeQozBuXN8CztICrTtn9VB5JelETFnYzMEVNjk091D+NoacST?= =?us-ascii?Q?6ZzR2wUzWRYapaNaIgpyUiHQGLTN93af9zIwMMMM6dhRXVYslMjWjij+dhN+?= =?us-ascii?Q?OksDyFev9nRqh+PMDcx6N5B39PLKqzCCngk7KVfc0l23B69hF1Chrfoalhe8?= =?us-ascii?Q?Lr71iv6uF5bhyYaJwbakJOoKmmWupJCy62HwqSPEuMbSS5m7fmVYzVOUPbPI?= =?us-ascii?Q?iKQacOaKcXBUIgUdEJJ8LvXZJumOC6Doul5V/Vo6zAd+pMWnDEWC48ONLrL8?= =?us-ascii?Q?zO4juWfTVnp2p9ZLLKD8rsn59ECa77rxNGc/xp0ESRym3grKJIc4VP3uNMmM?= =?us-ascii?Q?U056uZUcv56GStRXZUQINboFdmdceqHJjBJBGfZutILtHgNz6tXjJw+s9Y/l?= =?us-ascii?Q?HzV3auyS5s3qjoYNbxeCkPGdtJV/ObBM2kTWz+ZNKRjsEubz/3UhL+psyrNx?= =?us-ascii?Q?aXccAaMXke0azuMGwFR9wR1klT+/RooEVn7FtlgJQWA3rc0GKbDbWcICXwl+?= =?us-ascii?Q?DcJulsYCcQx4uX29JKEYC/1jE3Lr35/Zm6dGLfS8hse6+9ayxFFBtOM96Tig?= =?us-ascii?Q?KLP8mhibsDApNuzCGgJrafUOQOdiIQjk/NFUGtOranNzE2lyMIgp09UN6c/I?= =?us-ascii?Q?GSBKHHCYqJ4RK6q+ZwwEak8IFVLVOCxfym0qBgCvje2lkT4X5nkJYrjp9yzI?= =?us-ascii?Q?K8CDrCecJZKeUvOLe7+1qCtomzxj7qAoSjBgtbro8VinD+d9x5GVOhMql3IP?= =?us-ascii?Q?Cjyn1wWVYR/PFdGbWFGIzm0MAnc0iRDv3PLbjvAkG+hfDBOdS94eBKgbCgD0?= =?us-ascii?Q?LA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 33823cfb-ce33-4bdd-012b-08db5cfa5a10 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 08:30:52.8236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /LUIOLzzh8yQA/PmIcJwkcEwI1aVVdUErr6hef5QJ1FqX3XV3rx7vHrBV/jFY7sKQfQ3Uo0DBDC1nECw5hM9ILWjAQgh95iS3kO+H0axd6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5495 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 25, 2023 at 09:20:35AM +0200, David Marchand wrote: > For large strings, we were incorrectly copying uninitialised data to the > output buffer. > Restore previous code. > > Fixes: a515b7204e28 ("telemetry: remove VLA in JSON string formatter") > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson