From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BA8042BA9; Fri, 26 May 2023 10:15:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23A1940DDA; Fri, 26 May 2023 10:15:28 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A105540A89 for ; Fri, 26 May 2023 10:15:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685088925; x=1716624925; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ctS28VnWjZ4jta8KnDWh5AASPgA53pBcrcQAd2nFqH4=; b=iNTbYEIaoq9FUM91i3r4T0lxufsnmHaOPLlfOhoVTXkuEiFZSg+BCwjb 2cbejD1liJI4XvP3b+2Fldbk49lqoqeMRS3uW7yuDjnTZA+fG2LD6YHCN owo9B/qBrX1KVOuZcmvWMziDxUv5+TqJA47+dZNY26ktvfQ3tFxdCThEz uqnoWQYOZM9rClAaGevADMnA27dz3Vm4WN7kgZdWwFX2JxYm3WatIg0fZ 0h6ANkr5HCYKp20sO7ahJeV5PV7o3pixVBECqPjQJVmp2fRfbRA+wG8ra TTMO9EfZSKOqUXUpAjJrNRDEV4p1en2ajIiBEXztlqg2wOxIIAuAxUBGX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="354165234" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="354165234" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2023 01:15:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="879471157" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="879471157" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 26 May 2023 01:15:24 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 01:15:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 01:15:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 26 May 2023 01:15:23 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 26 May 2023 01:15:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bPILC60z9vkSEty/2lttGCgDlNLPwaJ/F5807zfFAqqR1mrSqvuRwMw/3oqwZSXHlwkKScaM/N8ySGUdZdUaTtMHsu3Vm42rHon3Vv2FSy+cKLMbnW0g6lmeg1IXoAS8vWbR1MbVGO8kgJQaALMGkD42wT29+wKH+b3ECO2jhQAfDi4rJw75bBN598hn4NaT9iduigPMr7eUvAZ6nJ11rnq526k64gea6BVlgCL8mw5sE+58RdSvbVpKPjfQIWc8JmiMWjnlMvt9vCXTt2Gi0BGzTh+ICjiTaOUz0+S3e1hkOpBMT6K0hm3Gz7itjMOVPeEoJNQtvk/iIosl6QiKcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pd2iLIh8ucBGG8i3/JHDHQa48YQWBTaDEJwPhT3vBq4=; b=S/qORGK2+5eX2xb4lzLA5pJGnszwvd/oXtVlfZ+Ti0RT51kpgYh5/8hEbsiTYfH5UUUIDS5+MMdvDzDjIw+RUCDKxyqsOSOGwl4+o/pNUk4BZYCcvAx/wlNYCptAyrAW62dvHLUENRv8pRL/GQQdhfyCoEIM+7yL3CUt6jtfQ155dnLqfKFV5YvuuTN3lWKlDswhqLtESrs4GOVz6J5r4Of/oIDsKMtWGIDSXZ1zMmjwDALmeQJt4JuAkOALuVgMsUonEUTb2Gonz6rK6LBgPgdzJ+Oxoj1yEQhcnV9dszQmJZgp19qsmfRyV0f6J+8rKWFw733E5y1+1rLF5xVhIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4702.namprd11.prod.outlook.com (2603:10b6:806:92::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.18; Fri, 26 May 2023 08:15:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%7]) with mapi id 15.20.6433.017; Fri, 26 May 2023 08:15:21 +0000 Date: Fri, 26 May 2023 09:15:14 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH] ethdev: validate reserved fields Message-ID: References: <20230525203942.129413-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230525203942.129413-1-stephen@networkplumber.org> X-ClientProxiedBy: LO4P265CA0010.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4702:EE_ X-MS-Office365-Filtering-Correlation-Id: b7ea2808-4d63-4183-cb80-08db5dc1594c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EJf2/bDmpzmnlA4WhiN1Selhn7PiF4TX1X+tBs7cNg78+DIagTcaW5FFYm/z3D5AM+DOB6qowwFODfvTGccyZnc5ldpdx1lN1rPAmry2LpozIQybKh2KAVc1AsaVpIZn8ijfkwSSj8NK/4YsrLxzh4L1fGw9CuVN/C6hcMDpKzGJUTxXGYQKUC3JK//6QtL6cugG5mECWjX8ptaDhGd1I+BNDrTfnwCT9oUXnm2O6WBV9RV46LEss7VgAF90Q4G1pfXA+vsfDBKK6GmSm6t344dmYtGN0Qs7Ij2HCIZ2dpsya8u9ewu0FPJpwm8//OTQ4JeKbYealRKDYt42IaC57Kd+R5gvgegZi86ioX75ne+QzO3Jt1Y3Qh6vh8Ks32gBqeGyzkk7xSYKthY4tVjy86Q1tbxev7Kfq055X5EZ1cGvRHbORl2DFKy/gXIUDB6O9ZpL/8iK+nMVgaOmet+yRiESbuetXB6cB7ZZomrDKy4H4N1dlrIydya3jUiQXGZhGg67a/ZpqpsMcuNTPhu1dmU3PPDxTTVftA296Eko8XDg5IYZxPcueuRTiIBhp37V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(136003)(376002)(39860400002)(396003)(451199021)(478600001)(66556008)(66476007)(66946007)(6916009)(4326008)(54906003)(82960400001)(316002)(6486002)(41300700001)(38100700002)(6666004)(6512007)(6506007)(26005)(44832011)(8676002)(8936002)(5660300002)(2906002)(4744005)(186003)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?07SsSpPjtcVYFqYggRySLxdZ9pARxVQP7AZT4fkXvwcxkiY0qX3ulTbT/9DE?= =?us-ascii?Q?j1NTHXMALHumt2wN/qTFZxAAL58e/rErHD4PTysc7ZUPC9kigvF5x71P2q7o?= =?us-ascii?Q?bcCEFm2T54TkgS/Cw48rSKQg+x59m6hXydLHjkPFG+u4avLBPG0zf3MbKKNL?= =?us-ascii?Q?xy/lxKm1DahXur98se0ner2mYykKRyZz8h7X23g3iKCTf9LYTLHVLqmQEO3P?= =?us-ascii?Q?Y6cKS4Jw38njpvwVUGzKpVlYkKaVMle95+xMr5H3qBfm18Z+DYoEchIjKkRC?= =?us-ascii?Q?Q3Gh6Tksuc6yQoXhG6oVXCn2LPPcLecMen5AGa2EdSqIj/pJoXnKdDPqbMjL?= =?us-ascii?Q?+e0KCadiYzd5u6EcmFKH9UD915mxg6XWfuDT++A/6+OxAhXzhMsXOqIAUyZg?= =?us-ascii?Q?4j1jr/Sr9RqKCmlnvfbbu9YzP2udLRF87As7LzV9BQSgPkpF9xBAK6x5cWfN?= =?us-ascii?Q?x03VFNF1tf1qKyHREpfnCb6sCintTLYzWgnIPZjEmmhxZrrjYDPfU+EqfvL+?= =?us-ascii?Q?Tjobcv/HtMNstKHa6/SGwqGd8Qnc8zdtHCrK8WVDLX3Xw4rCH0sxdrHUasse?= =?us-ascii?Q?S+ekvcAZUmhbVn3b94jT5cBRk5tMXZ0ir2XshKKJSFpHlrYywNEh4wxRaMUw?= =?us-ascii?Q?9OzQauVZSbdQ4OvaJ7hhWWVPFGfr6W7h0B/zh2w5jbkp82QSMvWP/Ur2XTYp?= =?us-ascii?Q?tgKWAGPre6EevREG8vIdKCv5XcmsBCckDTVUuqLOowU7DuvkTDbHDAcRrj2a?= =?us-ascii?Q?IZXtdFQKKHnYCcxla4WJ+XIPMalOc73rfYPisnmku3XCC9aqvgYvhpMXswDx?= =?us-ascii?Q?lb3VYG2fD6ad37BH+SxmPynBaPtllof6crZMdeMreNhH8/nIXlKPvLoExbUK?= =?us-ascii?Q?lq4fRbfEgCd2yvqSVHiSAMNxRWzDfNS52MPRaEqXlrNxSrRnsF0rtbemDI1v?= =?us-ascii?Q?2y52fMrTdmdBYEs0xoTqgw/XRH/z0CSP/RRS2f9T30az3V+Tik8K7l8Aay0N?= =?us-ascii?Q?WgVXPqmUmG9vSm2uvab6A9/z3s83EuEMTRVyTTKnRuVUfAdzzG8lW3dCLCyT?= =?us-ascii?Q?AptVHy9lmseX1XeaO76xL9VW9YPbI6ueap5QhD7jMNckRHUP6UosZqVPscCU?= =?us-ascii?Q?kfK7xlJ9fiUB6C8A79oUyhT/ANaEqFhhCY7k2IdlsM7EbAaJOQyjC5XKbSeW?= =?us-ascii?Q?foUCQ10UPwlKUTRALuuy7EIBKMTcSohzHPhcAzicUXR64h3x8SZC9UgxwQQz?= =?us-ascii?Q?v8ip3IaDUthpGblg3l900zPnCdvDDpH6CmpxzPYRJrOSeEpR3T12VLvPsat0?= =?us-ascii?Q?iksEMX2K/nTVFs8wTsQhXicFUWBU/YlL1dkCcJHrTFSayNERR4yrM7jGrv6I?= =?us-ascii?Q?lJwXSK2Bd39r+yc2U2YLECTN/z6UZcgC2/0p3oNWfCUgHB/4DOjWNYTGdRWZ?= =?us-ascii?Q?YuiTjuRPZqjGv+5Y3UoCt1QoLF2s4u4XVa2gTtLcqiK2dgPiIJ9WCcX6ITVB?= =?us-ascii?Q?QYPcB5MS89jtIwdXsPadc4UPhbDNQXNgPaSOe1DLL8+wwwxX3cShoN12iZVw?= =?us-ascii?Q?FueuY3w/Mu7bMMwbkIxHjsKMCQ5h+QcqW+LYLoKbzM/xTynNn1XLcqttw5Ko?= =?us-ascii?Q?jw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b7ea2808-4d63-4183-cb80-08db5dc1594c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 08:15:21.4229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FDr/wGdwKXsKkPQbyhhMoS4PGawU2Z8UovJUFnzyKm+SjIL/VTdG+R/xnrvm9j8O4ncZqGurSatIWqicmxoWNZnSl9VkXKx98KHvjBvBM+0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4702 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 25, 2023 at 01:39:42PM -0700, Stephen Hemminger wrote: > The various reserved fields added to ethdev could not be > safely used for future extensions because they were never > checked on input. Therefore ABI would be broken if these > fields were added in a future DPDK release. > > Fixes: 436b3a6b6e62 ("ethdev: reserve space in main structs for extension") > Cc: thomas@monjalon.net > Signed-off-by: Stephen Hemminger > --- > lib/ethdev/rte_ethdev.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > Acked-by: Bruce Richardson