From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 0/2] cleanup use of rte_strlcpy
Date: Thu, 1 Jun 2023 11:18:52 +0100 [thread overview]
Message-ID: <ZHhwjFTSou428xNt@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230531220533.29910-1-stephen@networkplumber.org>
On Wed, May 31, 2023 at 03:05:31PM -0700, Stephen Hemminger wrote:
> In DPDK API's rte_strlcpy() is not intended to be used directly.
> It was introduced as a replacement for when operating system
> libraries were missing strlcpy(). Over time it appears several
> drivers and subsystems started using it directly, which is
> inefficient since the wrapper uses snprintf().
>
> This series makes sure that the only usage of rte_strlcpy()
> is in rte_string_fns.h where it is needed.
>
> Perhaps checkpatch should warn about other uses?
>
> Stephen Hemminger (2):
> lib: replace rte_strlcpy() with strlcpy()
> drivers: don't use rte_strlcpy
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2023-06-01 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 22:05 Stephen Hemminger
2023-05-31 22:05 ` [PATCH 1/2] lib: replace rte_strlcpy() with strlcpy() Stephen Hemminger
2023-05-31 22:05 ` [PATCH 2/2] drivers: don't use rte_strlcpy Stephen Hemminger
2023-06-01 10:18 ` Bruce Richardson [this message]
2023-06-02 21:46 ` [PATCH 0/2] cleanup use of rte_strlcpy Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHhwjFTSou428xNt@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).