From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 440CC42C02; Thu, 1 Jun 2023 12:19:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30312406B3; Thu, 1 Jun 2023 12:19:05 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 4283A406A2 for ; Thu, 1 Jun 2023 12:19:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685614743; x=1717150743; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=S1+vHDCPNTYBYdm0MCrb9kIA8484DCCPv/8h0dnNTpo=; b=ON0gcokCN7gqk/cOrxUxC2FouOzhQ1QbajzwGoWHpp1VCOQXnYIWqIJB PFFpEMy4LXq0m8pLlwp+soQ1YvNjwWKScTtBstTmt+imXNMCFZvALeiK7 o0rmirK7XHSmw9geVFSyRuWL00d7SIlzrQy2tKcTg52JMcUowgJ0jS2dR OFRhCWJmYB6YagvkSkvjfAw3p0hVL37xswxveBFt5u7XNemS5cAEa106a ED25Q5UXdeUJ/wlf70jeFJN5WnFpSFxJ/jzA0hWWz0OJubU1MvQROcS7i 6aXXDl7Ugve42THViZUjAxhM4WZ4ZqEqtMfeFKt0wnlIqQQTLgQfs0U2b g==; X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="335866613" X-IronPort-AV: E=Sophos;i="6.00,209,1681196400"; d="scan'208";a="335866613" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 03:19:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="797084860" X-IronPort-AV: E=Sophos;i="6.00,209,1681196400"; d="scan'208";a="797084860" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2023 03:19:02 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 03:19:01 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 03:19:01 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 03:19:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 03:19:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pd6/S5QZ2/ccmq6lTrvxNGis5UJAHO7Z11uEqQ0awS9vReAEymEO+8eiqzBL7McFSi3XP3/q2mrTmMbCKtJU6vUceFDyzjf4kTmh8SjgSEA4w0U//4XVodcwBc2yjGvwO25HMjg5K+h3oeTTxxqlHjTYzElzJbUXbCGKngJSPsy8F3HBkpILAujqMIO0kTqyI1sRT2frhgaE+6P8Rc1FD442SNo7hRBZrvq+f8LEuGs2zkg4J5y7xGf4ttY9pbcdU9OeHgFOxGHQsSsRaDHFqpqddE8+oDE/svDmMmgkmhRH11YgrxFDtrB5vmc3CDU+UwEefun7feAMnsQZvqL3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oRlELAcDMYgiYODShGwWbzYUAIRQWMHXD09UROCZMj8=; b=IBr3RVRTiHyo8D7e+oCfoboFhI2udzPw7VSfPlYCPeFMweQdXXXXPhTk6SGpgaJ4UbywCFXPlma3NIPmOXE8do2rL/9ZzQW9qWKFLN0BB6QNmRzg1mIlGbN/AG0WJb15U9z24dqvsvxjOz/0TLb9h6eOUY36fSXQ1vShHplGs4+zyt/hZQYAH0WP8h1gyyL6LX3gVxb+Xl6gal9VOUFbc7eB7MulanHRRcOZvLCe5vop2PbQOkaxxZft6O9IeWD+DcqRInRFVGL7UaHwpG4Dxn3Lz06JmzsBireiiMfAVGrqx05j8Tcs4rMFlOjCzjBkFPhn/AqXkk2OmmLOJWcxjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Thu, 1 Jun 2023 10:19:00 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%7]) with mapi id 15.20.6433.025; Thu, 1 Jun 2023 10:18:59 +0000 Date: Thu, 1 Jun 2023 11:18:52 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH 0/2] cleanup use of rte_strlcpy Message-ID: References: <20230531220533.29910-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230531220533.29910-1-stephen@networkplumber.org> X-ClientProxiedBy: LO4P123CA0538.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: 7758ea81-da75-4b9e-5854-08db62899d05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: umi+WYIhIAJCADwQyhzfL1XoGJ3phoissOVyxUI+zYH823ugqzd+MU8szRn5trKKKJisiBwXOoWxmFbk4W9VrbmyjZrjVxHZDVB0WUs9zcmUnSP4cfCrhUsH1qDFDD5wwNHg5GdJJWad4oI6hgWDCUK3yP1NIcvfgpscN2TcuQoT46qFympUtZSWsrdKZoO45ei7V7+5lT8PaglOKQXrlROQydxHF6xsldv9/bormQao44CB48LpgJdK/2cfb0sh60RmTX+YnNUQv5ojb/LL+imILiYmW23045vS392c7QeUV9wmZpPT6hniODxrgT2RwBlpAvtrsSFMfayMZft8BgT6t6miVtz4RpwKjs0Os93Jsq6/5899kJpUMyQknsqVfxzLF9IxLTXm+VBe5UyAfCiuKQ9DfZDmPhlCIgzs9CbausNYLhF0i/RvU9emDYIZFxSphlNoX07PieNOd7aUyMBezvRjgM1HLMQsRAmpQR/jKWZs0gtt/KK/Vt1IHazaj6AtbCMUlBMDfYXKHuqsesadjBOg5FpD9bzXbbBwjumjmPVULj305rj2RN0aJkCm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199021)(82960400001)(38100700002)(86362001)(8676002)(41300700001)(44832011)(6506007)(5660300002)(6512007)(26005)(8936002)(4744005)(186003)(316002)(6666004)(66946007)(66476007)(6486002)(66556008)(478600001)(4326008)(6916009)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1WEzOLoE9/nCJSURU/sAm6U0IQmcTdv75dzD5aagmnUbjfW77b/PcSfqNceW?= =?us-ascii?Q?KOsotvxuzkU899xV8+4NXdOZVjFvhvQxRsnHZqEiuH4hk52L2du2WvVuf2i3?= =?us-ascii?Q?ubmQX99C+9Z09YUzsZMZlWJ6HRrSWpFlsgXVl5YKG2FwFrO6fAc9omv2wIQM?= =?us-ascii?Q?WKcuGTci4FACP5o5IMUDtKYFoyFk0TE7PIivN2KpDMoUFby8bZAqvWMb9Y2x?= =?us-ascii?Q?bSYHKIrLflKUyoROLOMUhxsw0BXfsDf7IgLkUjtyyP9ZOSIcuFJgMonoPitd?= =?us-ascii?Q?GiaQcpr0gBbh6X0NFT33TeZqb2PI1815mOcmz5tAFOoYQkJnDOeTZQihVZfv?= =?us-ascii?Q?U3I0PrTeXZSO7pAbagJ3xOqqfIxiaQdRl6ysdiPfN/dpEYNIweKr300FDoz7?= =?us-ascii?Q?WzGx8qgIt7lrJWkVwieyIPnoO6S5hKlWmPig7gaDsXPI9K49PgKJ0Du2MzXN?= =?us-ascii?Q?/j1qVXNBz2fhHetQZG/OIcz8GmcMMXYvgWo8qZgEruglZKF69iHCDmjjfK2J?= =?us-ascii?Q?SxrpF/TKSUKcAPoxjKlxNEAsv5v/sk59xxbjA7Arh1M01jSIRa24/kYmK4IF?= =?us-ascii?Q?5c+yRB5RGH2oKeldRo1lNnnKAfsYqCY9DmSaVstalYTRPeLPXZSeCh1SiAcy?= =?us-ascii?Q?hdELk5QKUWs3N0tvwgHW8U+vjIRX/+pBg/D3TvvGtvOO2IaJrYvnTWCH2pJf?= =?us-ascii?Q?xIxKc8ToWOwtN4XFF7hvh0Hr+sRYaaSkWJoE9SFohQd7vJ464kH1Vk7Y+elf?= =?us-ascii?Q?5jaHuCIAfnyg1nDRZgor46ZWos+b+AuCJ8gI5f1YaQlzdEt99N/IO50Twv/r?= =?us-ascii?Q?Ox2iYK3ybHgqdEesgH8OGCrISQPoVIDGnhfeMZE1BuVof8ktPR+Lzd0WJLoL?= =?us-ascii?Q?dgGJPwcGzNj1mdO6gqG9JcXf6p4Bgx3wo9Ztr3+xFMPLV3MSeIsTLg/AYWhx?= =?us-ascii?Q?Yxp8IkJaVdavPn5O23hNEcXS+T+X/E7fW4EVaF27dRXfTMJga8l+OJnB5XAb?= =?us-ascii?Q?WD6HAwr1cTbMoLY2OMhHBB4oCoIDkgTezR3DwP4RFFDvUKA6NHyGoDTyNkWM?= =?us-ascii?Q?LNjcuNKK6mAMe9A048wYg2vuZTVJ/eIRLBimq2PMXBe0WMJedLfzxmqKCDom?= =?us-ascii?Q?buYb4hzZRjipj3/BK+Zpic+nonh5Y4OMWePu7dK6K6k6ZhEWb4Si7gCFNis8?= =?us-ascii?Q?YOq2XVidFAOU+WXO2t0FgiEecIxxtp9o+vSK1j8IGRx1kjNq98bjViTdWI/7?= =?us-ascii?Q?T/+48KNBLFg0CSWsehatANSzFvw+vSj4OrbMp4CxPDAQhAPtVSYBdpblvQF/?= =?us-ascii?Q?03aBeibUb4KYcX/OxL0WE02T/qb9aNoq4h6j/2MxOyu+KCdISl/Moe2PQgx2?= =?us-ascii?Q?UMVtwLwWCzOEXjY90SBWaj2wVBjN04TdN1gv7VjufE0G5mpV7mCokyTH1V3W?= =?us-ascii?Q?1vbu9289JPhDOgOWtOkKnI7RdqSojumxHaGkVNoND0O2GrzIYFJn6h3OM+Ny?= =?us-ascii?Q?4nOn3Xf+e4klM3qwh2OMy06bAh4qfefJVWwOzxhPkZ1mHN9BHvKGUaDK8AVX?= =?us-ascii?Q?Jsu34DwmxZMjGOBvyRehV/qVqkbEGqstjb/n7WQ+bwnor3gos4k99JqO7dFj?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7758ea81-da75-4b9e-5854-08db62899d05 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 10:18:58.9376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dHFqpEabicMQQTioxKRUGquC4sYMt4eL1aXOytCgktOQSaVQcsHfDm5CpYZH7N4H2d+JNdpOo30Fc5X7LnqXunuPmpQYZMHBWfr8nndNRNE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7648 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 31, 2023 at 03:05:31PM -0700, Stephen Hemminger wrote: > In DPDK API's rte_strlcpy() is not intended to be used directly. > It was introduced as a replacement for when operating system > libraries were missing strlcpy(). Over time it appears several > drivers and subsystems started using it directly, which is > inefficient since the wrapper uses snprintf(). > > This series makes sure that the only usage of rte_strlcpy() > is in rte_string_fns.h where it is needed. > > Perhaps checkpatch should warn about other uses? > > Stephen Hemminger (2): > lib: replace rte_strlcpy() with strlcpy() > drivers: don't use rte_strlcpy > Acked-by: Bruce Richardson