From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DA0D42CC4; Thu, 15 Jun 2023 10:43:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FA1D40DDA; Thu, 15 Jun 2023 10:43:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id EE39740A84 for ; Thu, 15 Jun 2023 10:43:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686818591; x=1718354591; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=MxgBJnkWKYeGL39KCZEUtcYVdICV33tLjJvEh3/kSEE=; b=ASlxPklQS6b+InxR2oOWFs+BYIHHPup2uiVYD8NLCHeibocvjmWCATqL lvM6wfMosFZ/9Ez0d85noli4Uw66DoTzDauC1CqY2FFp+tn1H4NP42Xz9 Lxbg9wMa88xsCCQNMc3N/ZSWCcYHynvr87ln69U7WlZWAAMXJL+o8k1RB ysUURRck2KtduGslguiom7nseHXxhwz0r1VbbOkt2Y5Jzqf1Q1SO3vlvB LhVFTP31EJY/3Mh/HHpq0LWCtDREVINBHIuFITH4y3LodgT6lNofOyX8i PS0asviai0AtwL0c4PdYymf7tJHdF3E7n63dh7UllIkvqbjdi4rWBlFIC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="343554770" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="343554770" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 01:43:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="782439825" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="782439825" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 15 Jun 2023 01:43:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:43:09 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:43:08 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 01:43:08 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 01:43:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbI5zP1W18xTyBJVbOx5je3oFNVmLZlKNvl+p5c6TiCPNq/5lTFy/+gLjSR2DXZFvRIFWl6JqWzbWOLgSQpteGvaBExMM/wAYe8QoEmM705wL498vnKID0pKXP1zQ4Nte+ox/XFgCcEGjc4ZADURvTUzZtOg93HccPhKK+G4Auw7irPa8/aOY5sdIh5BfVxbofsBG+Qfzpz3RELkuiCRIepstgd30BoFKMIVynkYCBQHncpfnF3UI+Uq/3BFKxTh9JpgYxbN5XV6ii7Td+5HdNmRHkDRpp4D0bWk2+EjAKvU1ojDpqdQywT7wsx0r80citwzdTo2Q0Hd8aFL9/fQYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JlUqw9/JYC4SosEoIM9mS5Ry9Tmo/taIwJqhf7pR0Rs=; b=SNGkkWUrVEhb9guKXoU+a14hLJkPeVdQ3rvVINq2yZmxt1OMB+/0xS9j4ikf/w0lwkiuZmgtt1ebj0aQ0Nx7NaBZOY3fYep5aOCxxbvEYOlybweBt5zzhaaBVJVojXT6bQZZjviFMiQLu2Xc2MpqXFQa0tKpOfnmMiZdSfpPk/T1lB+OM1AIabA2XrUOzWlw0+HR+dYSDHyr2mhcA+rC14n7QjW+D2Vu5rXIfcJaX8TqPZCs/g0NQto5LVUKrxU54C95/tJ25O/jzxBnTeMGfceOTBYBDRpSCUuOxRscAbSPZON74ATlj6prG2vn/iuUC3vl2JdXJUfkT+FklYrXdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB7120.namprd11.prod.outlook.com (2603:10b6:510:214::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Thu, 15 Jun 2023 08:43:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 08:43:06 +0000 Date: Thu, 15 Jun 2023 09:42:58 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Mohammed Hawari , Subject: Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs Message-ID: References: <20200918084924.31784-1-mohammed@hawari.fr> <20200918084924.31784-2-mohammed@hawari.fr> <20200918114329.GA1589@bricha3-MOBL.ger.corp.intel.com> <33FE1BDE-C31E-4879-836B-DA22C850B829@hawari.fr> <20200918135750.GA1592@bricha3-MOBL.ger.corp.intel.com> <20230614120945.3e386d16@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230614120945.3e386d16@hermes.local> X-ClientProxiedBy: LO4P123CA0675.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB7120:EE_ X-MS-Office365-Filtering-Correlation-Id: 09c83334-6cae-4914-acdc-08db6d7c89e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X9JcNGnml2Yb1iH5pt3H+iDdcZmVfRVlTGLs0GfKW95q/GCXnR/0FHc80jATiK9z88rYtvVOR3WMAQe4x9rfKMch/Ylw/Skd2/7OYqDcdnL77IjwDtX2gaZy7RlnvfLNFhOZKyCESPh0HnXMJXPaGEHW+70HiwgJoLYAvC3BDMj4yHHZ6nLxe5y/tiq9ZKGrQioQHHOJTt+hcmliGD/OQRzwmFUP6y5nK+nj3V9/OKkZGnxnIpvvCbHp8UYO5Iw2GAD+rgjN7FJpBePMFu1ndWLMx8R/MoTDOreHrR3ROwP3GH9vt1MC0tr4PVUyr3es/WZC1E0lHVAGSmbAo4B2TrROFpDD31DG0EVYdcOjsVOxhf2+J3+gcPx/0THz9QvUIIb0mbdxfX981BDxSajW4DaA2q3UCQC0teGFSmay66WxBvZIu/WXeL50G9uMWLVmNvelbSeSQ/sjWsU6k314a5eT0CI7i7htUpowBf6n8FDZ37FKZOjDOKxAkUDP/ojVAjLMx70eVKELJa+Knx5Adv6LOgmeaXMUC5BlwA46/bE7jIy1QhajEe0J5tYdbHKf8TfkvSQ4hmgpXGaLvu+PgDD/hrNPk20LhxYZW6zDvsE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199021)(478600001)(6486002)(6666004)(82960400001)(38100700002)(83380400001)(186003)(6512007)(26005)(6506007)(53546011)(316002)(41300700001)(66476007)(66556008)(66946007)(6916009)(4326008)(44832011)(86362001)(2906002)(5660300002)(8936002)(8676002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dXyrWOx33uORdUI6EA8kBQHsO5YzFd6eDLDJdJEk9SYulr53pW/tKnfmfBtW?= =?us-ascii?Q?eavzP5DlQN6eeUTShgAAsnSR8fncxCDIbTybOpXjj0JYrB1JBAw1HXyBoPi4?= =?us-ascii?Q?cBR9RfFEInCeKm+WVwTzzA6v2aC5wJIzTBNeEr6/GQQ9nhPc9ZFA22H+S3xL?= =?us-ascii?Q?621HT0iS9rtKAY0Y3N+aXocCqVSwZvYUqEeyBBjl9Xw3cBzsrPMidJgIMra9?= =?us-ascii?Q?EVKswYxtQ70vYdVDpYY1/SETL1DD3mgnwPeD3DRFrJLKZfMIN0VDvAbVj6s5?= =?us-ascii?Q?8MSDC6p0pX0BtVGoXmDbGNx+8BXiHxHU+4um0uk5bhFpU0dXEGnACDNCSU93?= =?us-ascii?Q?Gl0x0z1xWCQNRzDx/2mWM/HkkQnXbwGhLHPlnNWEoFfySNqVru+D3FdSzBIa?= =?us-ascii?Q?85wLqYJgs70Oa4Dk6UN+m4Ao73oyaDTzaLa0ToBjDqf+ELsviHgTqPYdbpt7?= =?us-ascii?Q?ginv9PW4258ItgT451W+D87aVSTcTf/gP2fSe9dYYxAHs5bbhf+eacbsVARo?= =?us-ascii?Q?Lrktp87u0V6XCsqF6l61ZEkUv+2DAQbVvvaM3kU1DeQMjHSuui2+aNQqlif8?= =?us-ascii?Q?9YnmH0WPdBf1uddQ6tKb+bye+ZGrF6OK5gGPgX0S4nCWHWpcOF64QG1ypelX?= =?us-ascii?Q?NkJ23DsYjasBRYpQQXWJrFOooY6zFOfjl1KLMpQqFoSDW8T0xkT+5JiZFAOJ?= =?us-ascii?Q?en8srM9XFo3Chl9RIi8OY9bcmHqweU4uvjhB7iNqbIk147ZTAHPDIQ/o060Y?= =?us-ascii?Q?OIwyLzor3MUt93j4C21U7gutPbNTRy/me762EZb5aR9wjjqTQ8t1TUejCMl+?= =?us-ascii?Q?Hd50GqdbAVSiEawTPm/v69gGkNc+bT1jlKTHELwY3A9Fi82TY4tN95HGpedV?= =?us-ascii?Q?IrdXKGKogqgM9ZDIuecJjBnaDmFDWDN2FCThsjLGY8Hwoy9ki4yiZzEDXEO+?= =?us-ascii?Q?ZKo2ErDnRHikSWvFGCSa+6tFIcV/xkhc6buFof1XqS9fROomP9c96p/nXWoF?= =?us-ascii?Q?fFrbwtj8yIkQmlRqD8YjGD4SoNzrpyuuVeG03OTOQkypodwV7xvvqqV8jVZn?= =?us-ascii?Q?yDUYamtlyjV9A5sZSqY8DhFlEuaaD3/yVOmAks7h0jN75LSJNwH8n6WOVxoi?= =?us-ascii?Q?alkNNpFaw/SoViH4zXzLPRnHonO2r/6omEFJvY01A6R8jcYatPeCYeRFUB3T?= =?us-ascii?Q?sqYs4UHvYx2wQJ7dsgkdv6kLMDTV5c+zpdtv7soJ74B/44JT4tmx20LKKDB4?= =?us-ascii?Q?3ojJyMwkkaeAeVoCRnx3/qM+eNjSzqlM9piemXQZg4i7XuGmYJ+CdrhlkXEV?= =?us-ascii?Q?UqvJETGWlM4BKEn1LrU/Pk/8deeZwJgrk3kqmOOFQc1mrrT/UvomUdol6CaU?= =?us-ascii?Q?qfdxUROPwWt7Pqh5QROdoMkdI2OmphBo8pNj1CX56oXMO4a8yRDQooZqx8JJ?= =?us-ascii?Q?Y+3WOTPWB24Qp/NbgEQ1cqSh8sIwRhTWQ/KR472jH9S8NYVRrnsoIWayrwLc?= =?us-ascii?Q?5XDfrztrPT/2Zb//mO5Hc1eRNzsyB1Fu+CXcJklHL8VvaozxeM4Um6RB7zN6?= =?us-ascii?Q?zbyEBAMIA3dc8tJ2ynUSPPhTAYAt4Bn1mXovmn6oRhPc11Xcpx1mpGfGZI2y?= =?us-ascii?Q?lA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 09c83334-6cae-4914-acdc-08db6d7c89e7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 08:43:06.2284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aVKSR5//gtYUv2D90bxQ5j7BQv1ILKl2g7pNCxi3Hoc3l9y6415I5jY2LlNtftm87vk4ZvZ4rnIgWbuJie8tO8KO4dsDMeYQZ32kmD39iHI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7120 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 12:09:51PM -0700, Stephen Hemminger wrote: > On Fri, 18 Sep 2020 14:57:50 +0100 > Bruce Richardson wrote: > > > On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote: > > > Hello Bruce, > > > > > > Thanks for the quick response, see inline > > > > > > Best regards, > > > > > > Mohammed > > > > > > > On 18 Sep 2020, at 13:43, Bruce Richardson wrote: > > > > > > > > On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: > > > >> Similarly to the disable_drivers option, the disable_libs option is > > > >> introduced. This allows to selectively disable the build of elements > > > >> in libs to speed-up the build process. > > > >> > > > >> Signed-off-by: Mohammed Hawari > > > >> --- > > > > > > > > While I don't particularly like allowing libs to be enabled and disabled > > > > since it complicates the build, I can see why it's necessary. This is an > > > > area that does need some discussion, as I believe others have some opinions > > > > in this area too. > > > > > > > > However, for now, some additional thoughts, both on this patch and in > > > > general: > > > > > > > > 1. I see you included disabling apps if their required libs are not > > > > available. What about the drivers though? > > > To my understanding, in the current code, the drivers/meson.build file already > > > does that check with: > > > > > > foreach d:deps > > > if not is_variable('shared_rte_' + d) > > > build = false > > > > > > > Yes, my mistake, I forgot that that was added as one driver could depend > > upon another. :-( > > > > > > 2. A bigger issue is whether this is really what we want to do, guarantee a > > > > passing build even if vast chunks of DPDK are actually enabled? I'd tend > > > > towards "no" in this case, and I'd rather see disabling of libs more > > > > constrained. > > > > 3. To this end, I think I'd rather see us maintain a set of libs which are > > > > allowed to be disabled, and prevent the rest from being so. For example, > > > > it makes no sense in DPDK to disable the EAL or mempool libs, since nothing > > > > will build, while the bitrate_stats or latency_stats libs could likely > > > > be disabled with little or no impact. > > > I tend to agree with that more structured approach, but I am going to wait until > > > we get some more thoughts from the community before starting that work. > > > > > > > That seems a wise approach. If there is no consensus after a while here, it > > probably needs to go to the technical board. > > > Marking current patch as "Changes requested". > Assume that if someone wants to go further then and propose a more > targeted build setting. Something like minimal?? The more targetted approach has been implemented and can constantly be improved upon. We can already disable a set of libraries, with only those validated as being ok to disable on that list. Therefore, I think this patch can just be rejected as obsolete. Any additional work in this area should be: * increasing list of optional libs * looking again at adding an "enable_libs" flag. I was against this previously, but now think it's time may have come! /Bruce