From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A62A742CC8; Thu, 15 Jun 2023 18:13:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9494040E0F; Thu, 15 Jun 2023 18:13:59 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D4FD440A8B for ; Thu, 15 Jun 2023 18:13:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686845638; x=1718381638; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=PEUm6YAvsjDfdRG5IHvyqJ5tnvQpe2pyFZMvelMwqjs=; b=AkqXS9dZZmBmQNIj8yNfMp3Kfyrc4VKpX3sGYp81INEjtfkV9qjxSu4P RmowcyOroZk/6or/nV47bG7ymrekICu443AfToxiiUGYOcGVRR73+gUV8 3kRBSDxWZjFvJeRj4XzAFeg3ZZ7ox2H88d6rD/7MZ87DqnwB+Px1IRkyG OhrvNie9fyMiRaC/ihtty2ATmJf4CF0oOkhcRIWSItBkruNPZWg0FcuGz GeqchSkwz2sAkYSPCUZIFWC5hN6/y9lJmhLIDVFIKR1Bx/7cAeOKhexmB IV07OBFfQS5fNOTbkVX69YkKQ1t02O4uFLuIfUa6K7f5r4Vg8fTguuPTE w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="338588965" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="338588965" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 09:09:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="777737562" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="777737562" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 15 Jun 2023 09:07:24 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 09:07:24 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 09:07:24 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 09:07:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UK90cqwmj3fHsdIXs2PIGCYH/fDiiUNexhzRvUeiU4jHd4723JfpxkCyTyTFg/1Qda6hjwf605j9Hg2K/CMtVMYz7Xf+IOPgXdbL4yoT9b5DIvgku7ZiL8r3l4Pa1zkFTEk/jhYz5zKdKYYNdegkUzOaL8a5ErJrotm795HfDCXg6Aszrj7Zd0OjaCC7jqgeYAxvZ8l72s9Jpz22Xq7LgQqyd7X6lhH1GyKt5I6uDBbLqpx9iIBU1MB2okX7apcUv+DecTBg6/rgb8vGPRMHiqb4F7BS4KAqn9QLvLOmwvs66UjjPiCeC67B7OVeFvZNDlOZOjGGQxoCKU4pzKGfAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ape9f92hDPdsLt+l++38XPGMe9cpDGLAPzYSikx3nMM=; b=A+TH94IqxNgArb26mwGK560Ef8djyQHiFg3cetvFPHuT1q0mjRrpVyYAde881PvkQ4xR0ua8cua5H9kOkqzPzmPw/+aUDvz7XppzsxKRK2atJCCzxtuc7HoAb2LIscFQIF5hFnoFv+AuRkeCa8J9XquxEeWYVnLtA0XQbwTEljCuF17ED6uygO41E/UMpO1Y7jlytJuQRDL6ULRs2nXRNs+Zk7mt0V1MwEDq5sPlHiXlm4hv+u0cnmqQ0xuOa5K9FixT9O1NgQ34/TfWHp2k8pj/lpOaYgW+F0M16tXzXG2m+pM8CuCxE13KA6v/HRMkS1qEA6Zv1UKIeGWgYMCBBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6293.namprd11.prod.outlook.com (2603:10b6:8:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 16:07:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 16:07:21 +0000 Date: Thu, 15 Jun 2023 17:07:15 +0100 From: Bruce Richardson To: David Marchand CC: Stephen Hemminger , Mohammed Hawari , Subject: Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs Message-ID: References: <20200918084924.31784-1-mohammed@hawari.fr> <20200918084924.31784-2-mohammed@hawari.fr> <20200918114329.GA1589@bricha3-MOBL.ger.corp.intel.com> <33FE1BDE-C31E-4879-836B-DA22C850B829@hawari.fr> <20200918135750.GA1592@bricha3-MOBL.ger.corp.intel.com> <20230614120945.3e386d16@hermes.local> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0058.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6293:EE_ X-MS-Office365-Filtering-Correlation-Id: 2631d149-2984-4c0b-50af-08db6dba9999 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +vMPzkcPNeqt9WHK9EvV8Y8vFEKf5BbAvRYMqyIehj7/ccpHL9gl18v503fVZjUSOm7cLY5qLn5nD04LAwOoKKoQqNdnd3wejQ7CHBesvL3pNoYkhNIW3rgcwnh84a78XPnvu6M1qGc05BVeBv/5EpsYAmHFHejsgkLeQx8AqO+JM9//ihvRtGbuSs+qHm+24SMBFNsZXSoH1nYPYhA1b/sT5UodOJy+R/BZTN7yOWRFYAQN0eOIHOwsA+fRT+by511Y1MQ1NVVVKgR/N4TO7yvJc3o4pnruLOeV8TMHH1gstPOH4qmn45DOX0qSvOiTRROM/HDELBjexZUJEKr9CeCu9MCuiIUT+eMc2qcRg+GEP3VqWw+ym28cgq2So1YWoRUI9z8y7sJoi89fl1UGIPJLeovW7nyrtXnE6cTCvJU/iD14Uorg5ozLY684Zp+mIHARYOWlEJVHPJNVF8YrRrSDXH2UekKZ6s76NJiJdzEsU5Jj2wZ7zO67eJfOHROctapIk3Uc1clofGJNTtGobEmsCJKITvyX5b0PdcmGmcgJCjDCrM1Bs998TJcK5BkG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199021)(82960400001)(6486002)(38100700002)(478600001)(6666004)(54906003)(316002)(44832011)(41300700001)(5660300002)(8676002)(8936002)(66476007)(6916009)(66946007)(2906002)(66556008)(4326008)(83380400001)(6512007)(26005)(186003)(53546011)(6506007)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WENmYy9IWnNQTHJmZ2dxVDczUUJJZnRDOTUvQVlVVDhCMXQ2QlBnK1pSMGZl?= =?utf-8?B?RCtpK054WHd4U0pjdTBBcXhzNTcwOTUvK2ZYU0wwaXR5TkVrdU43WXRSekZE?= =?utf-8?B?eHh3RzFpWVVMUkxGUVNDQVRkZnZucXFadEFMZXlLTWdYOHJYRmVoUENHWGZl?= =?utf-8?B?RHdPWlU3TG9SektBVTJ6eTdqQStlT1pCZVFJOWd5VkdVckM3eVJlRCtDUEd6?= =?utf-8?B?R1A5UEhiaWt6VjlCWXZlN2hBMnZyUG40ejJMZFVpVkE5bnhLbHdhazJhNmVO?= =?utf-8?B?RnZScXR0UmFmQ2xMWXE5QWZxK0NFM0JacVVvWkgrc0R3UHJUNjFZbEJOV1Np?= =?utf-8?B?ZVJRVDJJWVRQemdZNElueUYxMkliVjN3YVlCWVF4UGFCNlE2REFIemhIS2V0?= =?utf-8?B?dkhFM3B5TCt1b3NEWXZUYkxPT0QvRElRZi9TRk5JZWd4N0hwUERWR3hCdUlr?= =?utf-8?B?My8rNE1laDBFc210THoxcXk0OGx6MnFIaGxFSlkxREVDTUc4cGNmRW5xU0N5?= =?utf-8?B?dkRJQUpablU2aGI1MFJwOHJ6TlN2WGlLdm04M2JQeGtxTnNMTDB5U2N2aEFn?= =?utf-8?B?d1FRMEtYN0JxdjV5TlVhaGRIbC8vd1diWEcwT2FyMEZ5TlpCbTdYQUdxb1d0?= =?utf-8?B?QTFBeUJCSU9MTk9kb0dhVTRDWjNUMmVVQURLTVBxUUxkU3dIWHJhVTRxS0Rq?= =?utf-8?B?R2k4aWFETjg3TGY1SzZZbW9Ra0VmOHBsWk9NTjgySGxxVW4yclpaMkhJUWtj?= =?utf-8?B?T3NSNmtCd3E5V01tQkVzeUtVSUZqZ2VQdTZMZ2kzblJlY1dMVHBCMVlPOXFt?= =?utf-8?B?cmVwNHF2N2tDVmMvaEFXUzhjdUgyWkdHUFVPRWlBNkNoY083UGpERVpYbTZn?= =?utf-8?B?SVc0RU4xZ3lXUjlMcWZ2Q2FWMUdKUG9uWk5uVFBCTUhQWGdMcUhiNi9xVWFm?= =?utf-8?B?aGUwUmV6WGEzS01wZi9uTHVRUkVHY2tTN3hEL2FMUFZyMzFnV0J3emJuL245?= =?utf-8?B?S0tibWQvS0pDMU9sajBxbEdMNm1vaEdGNGdJTXZKRmpjeDhXdWtCUHN1dEdO?= =?utf-8?B?dklkUlhXUmlGVktKMVRnM3htdnNTejVNQUpqVzV5S08xU1pXT3VTenRpTGc5?= =?utf-8?B?TVEvL05jd2tuWUt4MnM2SUM5TEdnM0RpdWZLV1RITGc1cXFsUll3L0paWDVQ?= =?utf-8?B?WWJpNitTMys1ZG15cTdjaUZUOXcyQ3RRaXpRUjRyMEhrVTRhdmFPRWtrS2xr?= =?utf-8?B?Q2RSR3J0cDBtOTlJOUFPcVA5VnZEbWVpNGVuckUvNXZCdUQweTNwMG9iN3do?= =?utf-8?B?V0NhMTlGdlpobDJ2Zk9FcHVVMmtvbUdySE5EZ0EzQ2pxTWZkaDBBMTVVM04z?= =?utf-8?B?Z1Y1N0YvcDRQeTFOeFRYSHhoblNQcnFZeFVBcENZb2theTNjZndEU0x2N0o1?= =?utf-8?B?elYrK2ZCT3pJelN6clBtT3hUS3dyQnBtRWgwS2lCdmpTYUNPOWNNdDVBV1Ir?= =?utf-8?B?dUVqcnJNeE1Femx4enV1N25YZVlYaEZSVWFPOUNGcHJWVVZmM0lDVm5GcE92?= =?utf-8?B?Z2hBcFRJekUxc1VJenpPMFUvT0xQRWdkbmxuaUxKUDFSTUdZRUc4R3dld05s?= =?utf-8?B?WFIrZkYyT09ydzdQZmswTmpHWFcyS09lSFB4ZWxKY0s3NVB4bmhZSFJpdTFG?= =?utf-8?B?M2ZoNGk4YWxoaVVrK3lYcGRiMEwvaFY0Ly9wRWlEWTA0dGtHTVNsQWxucHRM?= =?utf-8?B?K2ZkWUtWYjN3U0ZpYTdOU0VuRTluWGEvT0pTUVhjNGdjYkVmR2NIOVNGaG41?= =?utf-8?B?WC9tU3pCa1NMcVVvcTBRSVA4bHU3Y2ovSldFN3JEYW9acHYrVnlicGwyMW5Y?= =?utf-8?B?dG84eHZ0MTBUM3JaaG41RTlMT0s2bmRmOG1hSjAxQ2xpUThuY0lla3pGU3M3?= =?utf-8?B?OVRFZmh2OHdsbFBJR29qTldqbWdVQ09acXd5UWpnS21hMm9QM1pkWXh2cjJn?= =?utf-8?B?WkFYcHJZWFFwK1VJUkx0OWF3SlBjV3NMemdRVkZLN3FmQitESkUyZGI2RG1T?= =?utf-8?B?M1VjR1hYVHZUbHhaRmhXOG1IZTdBT3djemcweTBWeTM2N0F3M21ocXVvYXk5?= =?utf-8?B?Q09HR2FiS1JiOWMzOWdqVW1ibk44M2RFai9JQ3hDM2FSK1U5R3JGTElVbkhT?= =?utf-8?B?QUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2631d149-2984-4c0b-50af-08db6dba9999 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 16:07:21.3627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NpYZsTTZoPiGAQQEmS7sQm8na6cx+wpZ1rffrQzsj78eSlwH6kMPRjYblhunQGrp/xWQglmbfq641sJyEqSTYwMxqich7Kefuvxf52d6m6o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6293 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 15, 2023 at 05:43:56PM +0200, David Marchand wrote: > On Thu, Jun 15, 2023 at 10:43 AM Bruce Richardson > wrote: > > > > On Wed, Jun 14, 2023 at 12:09:51PM -0700, Stephen Hemminger wrote: > > > On Fri, 18 Sep 2020 14:57:50 +0100 > > > Bruce Richardson wrote: > > > > > > > On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote: > > > > > Hello Bruce, > > > > > > > > > > Thanks for the quick response, see inline > > > > > > > > > > Best regards, > > > > > > > > > > Mohammed > > > > > > > > > > > On 18 Sep 2020, at 13:43, Bruce Richardson wrote: > > > > > > > > > > > > On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: > > > > > >> Similarly to the disable_drivers option, the disable_libs option is > > > > > >> introduced. This allows to selectively disable the build of elements > > > > > >> in libs to speed-up the build process. > > > > > >> > > > > > >> Signed-off-by: Mohammed Hawari > > > > > >> --- > > > > > > > > > > > > While I don't particularly like allowing libs to be enabled and disabled > > > > > > since it complicates the build, I can see why it's necessary. This is an > > > > > > area that does need some discussion, as I believe others have some opinions > > > > > > in this area too. > > > > > > > > > > > > However, for now, some additional thoughts, both on this patch and in > > > > > > general: > > > > > > > > > > > > 1. I see you included disabling apps if their required libs are not > > > > > > available. What about the drivers though? > > > > > To my understanding, in the current code, the drivers/meson.build file already > > > > > does that check with: > > > > > > > > > > foreach d:deps > > > > > if not is_variable('shared_rte_' + d) > > > > > build = false > > > > > > > > > > > > > Yes, my mistake, I forgot that that was added as one driver could depend > > > > upon another. :-( > > > > > > > > > > 2. A bigger issue is whether this is really what we want to do, guarantee a > > > > > > passing build even if vast chunks of DPDK are actually enabled? I'd tend > > > > > > towards "no" in this case, and I'd rather see disabling of libs more > > > > > > constrained. > > > > > > 3. To this end, I think I'd rather see us maintain a set of libs which are > > > > > > allowed to be disabled, and prevent the rest from being so. For example, > > > > > > it makes no sense in DPDK to disable the EAL or mempool libs, since nothing > > > > > > will build, while the bitrate_stats or latency_stats libs could likely > > > > > > be disabled with little or no impact. > > > > > I tend to agree with that more structured approach, but I am going to wait until > > > > > we get some more thoughts from the community before starting that work. > > > > > > > > > > > > > That seems a wise approach. If there is no consensus after a while here, it > > > > probably needs to go to the technical board. > > > > > > > > > Marking current patch as "Changes requested". > > > Assume that if someone wants to go further then and propose a more > > > targeted build setting. Something like minimal?? > > > > The more targetted approach has been implemented and can constantly be > > improved upon. We can already disable a set of libraries, with only those > > validated as being ok to disable on that list. Therefore, I think this > > patch can just be rejected as obsolete. Any additional work in this area > > should be: > > * increasing list of optional libs > > * looking again at adding an "enable_libs" flag. I was against this > > previously, but now think it's time may have come! > > I still have my patch on enable_libs that I rebased not too long ago > (around the time the iova va build option was touched by Thomas). > I could retest it and post it if it helps. > Probably worth another look at some point. I'm happy to relook at it whenever you have a version to post. /Bruce