From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22C4342CFB; Mon, 19 Jun 2023 16:20:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3D1340E0F; Mon, 19 Jun 2023 16:20:08 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B403740DF8; Mon, 19 Jun 2023 16:20:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687184407; x=1718720407; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mbcOfJt4uXKOKGGeFTbx9qLaOarzSKydK0UxmzDjU4U=; b=mcAaZYYEjqzt2rP2m7wa92guX8rxRNfSsa4fYi91K+Scp5zpqXrc9Dmi KReJl2Q8i4uvbaqRLehoc3Rr7rMCfe7Lqgg9cAuFQXfinVtgp4ZvDrV1F npo5n1izVaHINXpSZMvYmd72FGc7+vNi/WxqHHrXIbf70iUGXg64Xm2wi QJtADFcbwRevvDUdweLW15sjAC3SMc9Hw2tPBdTOfCJi7QTwgA512bsSx UbSwgaUbyCcHu0l7ethYVpS1V/qDYpu69vE63eKEnhkCVGc09YZwJ3Tfp 4bjQuRGK+rJFokUojYbtTY2jIfAfI8weArEStzAxnFo1PvTtPbuoS316j A==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="362180341" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="362180341" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:20:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="779059072" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="779059072" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 19 Jun 2023 07:20:05 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 19 Jun 2023 07:20:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 19 Jun 2023 07:20:04 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 19 Jun 2023 07:20:04 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 19 Jun 2023 07:20:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6FfPBN4QZ/ew2Vi757sGZ/SUg+amAJN3weEMoE24N3Du7HOpOKujg78Yxxu6Tr8B7dDSkOuKQwugO68d42s0fuLchgHfNzWsycY05FZS8u+0E0ytjney+BgUgV8bh0nt+gJ98wjhxhpJMrx/ZDtnpFOJb8OMVp3Ij3u26pbWVnCYrYBuOm/ehguLsKcMbJySKz8Rk5bdOfzysHIN/fdTKXnUkg8NnQefxWgV36obja64l4S5BdSxhdtDJoXZ/3ElWk2awS343JH6GguOabbcTX/N0oe8TaKqq/i5R+xpdOXCNRv6pshw8zZx4bL5T+JdyzMbeSPnZRV5MpsUKsSpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5KhXBaTLiY2CO+974O7FSUehhgvKNs3+LGSkZSxsS1g=; b=K/FsbssYXhFQxL/JxZeBl+sgqQx2WtjqmTHKWGMc5tMg5X21pMn8d1PiULJqbGX8fbcFDyLZImQZWPPQVjGfbZF/dmnqdERsx3dkqlMWVefHQ0RuNwatYkYtik+P9q9fa3ql8DJHB0e+ECnrwwQdPxrZiAhyHYpa3mZKdOqb+lAt7tojXc0yAI1PCphM4wETnmvYOYrUu3wNa+Fk5mZJ8G8ae6NSiZ4l0cZD9kHwxeD3cfQgirSihUNgTvFC0zN7/ThKP/Jr8AFbTtSr1LLh6jkm7jnsZfvxtCQg1zacmcmMsrPS69Bq3XSgRWklrkk8HMMWS9TXyICNjD8D9y4w0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6521.namprd11.prod.outlook.com (2603:10b6:510:213::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Mon, 19 Jun 2023 14:20:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 14:20:00 +0000 Date: Mon, 19 Jun 2023 15:19:55 +0100 From: Bruce Richardson To: David Marchand CC: , , Olivier Matz , Dekel Peled , Andrew Rybchenko Subject: Re: [PATCH] mbuf: fix doxygen for distributor metadata Message-ID: References: <20230615134942.3393383-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P302CA0033.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6521:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ead5c50-1e5f-4614-88a4-08db70d0444f X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tdc3KH2+E68y9jiADBQsns6Ywkdg1BrrFSgyfFrucO5/fGdMsg4dM5U5Vs6VEUh44NrPzWZPTJA7r3/+UCJLp8GbzzWM3+WG7+7h2Zqz5C8va9wSxaWxWpOXg35KqNL27uO1BC6mN92QzqGNV6sbhs1WhvpzBP65fz0ski1Ghr9XsZqRca0DAIe5pj5gmmZNCilZtaFM9IUw9wjNOdLtGS5hWoPm9+0e8EIWclleLTlSiHS730ovwWxD+EnOPpAqTZnw9USdR1XqkGaxUPV6HRgiCs0HriFjm5FqTmOoG1K7FYDYDdD8Iy1rjguwT/GOcn56PgzZzXo0Ago03cX54CnnGBOn02Am+TL5eVCq8YEwJeeLHU0Xmtz2vBafJq2NF8pUGPSwQlfP5bDROQeICmkVXQXXfyH/LXts0bNwfskiqDvOosNR0hv0yzQ4DBrjg9ueoMjLmQ0QQD9qwQnv1it1u7JuP7iShWvae6MduyfwEEhXa76RxacISUsAKGHSIiqGmjDu8CgWc/+H5oDlwt8DPcgdLQJkHtl7az3o/e5jlhHL0auI7NwfQGFtRV44 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(39860400002)(366004)(376002)(396003)(451199021)(186003)(8676002)(66946007)(8936002)(66556008)(66476007)(66899021)(5660300002)(54906003)(4326008)(6666004)(6486002)(316002)(38100700002)(478600001)(41300700001)(26005)(53546011)(6512007)(6506007)(6916009)(83380400001)(86362001)(2906002)(44832011)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDVPZVZ5RExweDFycDV2R2RjVllLdG5zWFN2cERNMWdFekNrWjd1a3NyVkpt?= =?utf-8?B?QTg2RUVZem1PZWlZSXAwSGJhQlR3ZU1QQXpKRlg0U0J4VDkrV3FaU2VaU1RZ?= =?utf-8?B?cmJKbytjZTFwRThGUjI5WlNVQTlKUFFYOTAxZzFrODlSSHg4eDdUSUp0ajhB?= =?utf-8?B?dGc2T0YyUzV2WjRkMVhZa2tDQ2VyQit2WG1QOEdkQkp6R05TYnlwNGVuN3BZ?= =?utf-8?B?Zk5ick9HUUcwTUgzNWhDZGlaNDJSeGh1YUVHeHB2V2lnZTA3T3BVT3JTTm4y?= =?utf-8?B?amg3dm9YbVl4YlB1TnZjVnBzTm45dEpMVHNlajBCeTBNVHBEQ1ZBcFVnWXNz?= =?utf-8?B?N1BhVFZBVVV0bnJBYWU4UE8wc1B4YjhaOVl0UldISzUzUk56ZVJSRWNLSmN6?= =?utf-8?B?Z29UbFpvUG5EWUgwUnNqMDFQMDlvaHNILzl3YzFIS1BFOFZSNk9uZUR3NU9S?= =?utf-8?B?QThMZllYdHMyS1orREtiMW5ROEFCUXI4aDkrUEw2ZktuYmZPM2tmd2dtSTZJ?= =?utf-8?B?YWhIQ3JFdG02d3A5ZURYSmN2c2oyMkRQb05NcTIvaGFIOE9XaTFlOEg1L0E0?= =?utf-8?B?ZFJONm43UVh6MEk5THRWdWFEcXQzNkxqam4vNnBZb3RWb3AyRHpNMXltVzVK?= =?utf-8?B?WmRieVNCLzJBdXdyNjRTTmlJdVZpbHo5a1ZVTW15Ujc1cXZjQ2R5VHN5bUNH?= =?utf-8?B?SjFBL2o0T3ZRS0RxV2J5U214RFM1bVZ3ejMySkhiRHlpUWhFNndjLzZ1RCtQ?= =?utf-8?B?QWdveUcxSFNIdThWN0tNVXRzVms4a09UYkIxMHlFVWRsTWdCeElnUVhTQXhF?= =?utf-8?B?UCtEczVxMStIbk5Eci81V2V5NlVtSVc4emU2Rm0yNXhLbFZWMTdZWVhFam5x?= =?utf-8?B?bGQ5UU5SQ2dkMmREdEg0SU1qSkRVR0VWTm1SSjNzK1RKVDcyTFlYR0dWMTZj?= =?utf-8?B?bzNIRndVSFZ5UUJxM0cyQWhSaEorVFBJTjU4bDc3TnVhQzdzZ1NoTyt4ZzJr?= =?utf-8?B?eE5aTGZFWHhUK0M4SEtDaTQzQnR4L1RRaFd1ODA3c2FvbGNQd1ZaZHdwejEr?= =?utf-8?B?Tjk1eDdIWWNlSWlYS1FXZldKOTlqeGQ2Z3ordkVPR1h2ZHE0NmczYWlndHhz?= =?utf-8?B?azJYMjUrNzVxVUlkMHZFcDdJeXN0VGdtL1c2OEg2bnBINUtIeWRZSW1NQlQy?= =?utf-8?B?bitoNk52Mld6Z3VTMjBYL1M5bTZoaXN1dTZkT2NwYVBBWnRlS3pFY3ZNMzFU?= =?utf-8?B?T0w1WUVwVnd6Q3BkREg2eU1JZUw2cGJNSUtVTTNmUDJsK0dCOTd1bTJyVW16?= =?utf-8?B?emhRNW04Wm9LWE10T3JrZGJtRHRCZFkveWc0QUtoUExQUnE3Q0ZuMmtYbWR3?= =?utf-8?B?WXBrNnVTdkRRbGNhZHR3T0l6L24xK1BNc1k5ZDI2OElJdG5sZkJ4c3diUCtF?= =?utf-8?B?bVVZdUZ5Qmh3Q2NhR0gyYWxqc0srVS9sSW5nRjJQcUQ2RDh1SDZpeDRwdDhE?= =?utf-8?B?T0xXT3ppZjJOZE96OVpqWTBxM3MxV0dlNGpHMzV4L080TTloWkpxUXVVekhI?= =?utf-8?B?VmhwWHBxaklZZElwWXBlMW1kdG5QMlFvdUJWMUNCRDRSSEQvdE5mdjM2MlV1?= =?utf-8?B?a214a0JHcktFSVVuOTd0bG9sOTFrTVFZeFdNU3RaY1l0UmhwWjVMNlRvSHFy?= =?utf-8?B?RlR0TFNwZ2VMcHlTNTlUdEtsUHdGWVBlZThFc2s3dk1mRWtJcHFZanZBVHFr?= =?utf-8?B?K2tEb1UxVEp1M2pDRFVHVVhvNXMzUW5WWDN4aDhia2FxTlB6L3E0RGp5TlJx?= =?utf-8?B?S0R5M2J4VnJjRy9Bd1dHcmRSY2l3cm50RXFlUEY5aGpEc3lxayt2aDJEWk1B?= =?utf-8?B?dERBN3U4Y24zNUNhd2R2bHFjL0VJRHlsamNHSzJqYXl0NThEa2ZaMGZwRHhy?= =?utf-8?B?SGp0UTBhTHBUTldEVGEycnZrOHV4Nnd6M2lUTjFzYTVQVUtiYlBZdWpkdFYz?= =?utf-8?B?WkRoZXVFQ1M2VDN5a3doRGlqZ2dUZ0ZaaDlZaHRQUTBUMjVDekVtK0wwL0dj?= =?utf-8?B?VUNydDdtdk9pY1oyc0NHM3Q4UHIvd0g0TFZDYTBIc2ZmN1JmZjAzVXlkc2pU?= =?utf-8?B?WE5YZWJWMlcrcmtyNVdxMVFhMTRTZUY1R1N4dE9aVE5yODJFREZ6S1gvY0Fy?= =?utf-8?B?K1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3ead5c50-1e5f-4614-88a4-08db70d0444f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 14:20:00.7757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hfr2AMBtZyx9esMMhM1AMiv+Q91RWwPHPPlUgCxWFrubWCHRkbahLftt+frpCQl1bGX7bCCa8Zbbp8DVPkDbtGwFPsCq9n1dd1udqeLXFCY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6521 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 19, 2023 at 09:37:09AM +0200, David Marchand wrote: > On Thu, Jun 15, 2023 at 5:15 PM Bruce Richardson > wrote: > > > > On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > > > /**< is for post annotations. > > > > > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand > > > --- > > > lib/mbuf/rte_mbuf_core.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > > > index c692c33ec4..2030b3bef9 100644 > > > --- a/lib/mbuf/rte_mbuf_core.h > > > +++ b/lib/mbuf/rte_mbuf_core.h > > > @@ -584,8 +584,8 @@ struct rte_mbuf { > > > * @see rte_event_eth_tx_adapter_txq_set() > > > */ > > > } txadapter; /**< Eventdev ethdev Tx adapter */ > > > - /**< User defined tags. See rte_distributor_process() */ > > > uint32_t usr; > > > + /**< User defined tags. See rte_distributor_process() */ > > > > Yes, this fixes the issue, but... > > I dislike having the comment on the line under the item in question. I > > think the post-annotation comments should only be used for comments on the > > same line. If the comment is to be on a different line, I think it should > > go on the previous line to the item. I also think this tends to be the > > style used throughout DPDK generally. > > I dislike post annotations (regardless of being on the same line or > not) as it is easy to mix the description of fields in a structure. > But this file has many other usages of this form and, in doubt, I > aligned to them. > > I can send a followup cleanup if you want, is that ok for you? > If this is consistent with what is already done in the file, then I'm ok with it as a fix. Follow-up cleanup is obviously welcome, but doesn't have to be you doing it. Acked-by: Bruce Richardson