From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F46A42CFB; Mon, 19 Jun 2023 16:26:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FEAB40E0F; Mon, 19 Jun 2023 16:26:46 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C5DC140DF8 for ; Mon, 19 Jun 2023 16:26:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687184805; x=1718720805; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=l0qSvn0GyPiMxxmTSOYKWZhBPfF93H8j2YMrqNKLbYI=; b=CjHKpfDwoPfCaSv/6ZzIX1m64SaiKlENgWAfJm3+foA/DBGy2G1MTJ0k WGJM7joYYhHPIgpnX/KN/aFb7oKI99djRk0nptT5Vr6kKc6a1qKVftlRS Fu7QlQT9CrUbQg8Cbdyd8TpRrj1pPSJjwZhImWCP3Wog1kQ83273eMnO+ VdNYsFrJVVGhKwt0ilPedyB9lkzg1Q3KSm0TFLgHh6kR6QTQv0T/VBHZ3 Is2WXB4gk1ohnmaiDFtj9+Y/HD+WsgQ0qZnIK3ug7KzI4yljWn+qN4cFZ NDEvvZHjZetbjW0XcM+pU++MFLGbbk/2f+4n9kQQjJawJMyUYGWZYnS4x A==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="358515301" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="358515301" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:26:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="960445002" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="960445002" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 19 Jun 2023 07:26:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 19 Jun 2023 07:26:35 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 19 Jun 2023 07:26:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 19 Jun 2023 07:26:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 19 Jun 2023 07:26:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X14X1HQGr+7pYESikehV1R4KHHoYBuUWRlTwBDxeuhK2415z/+GSTIZdku6FwW86/TyudFGSooRFcIDLJDW2i+AUHtZDedJ6cEIl/eU4892xfTu7S0mKLLDpo6bT1hdGWvRT4Qg2hqsVcxPiJg7+8QBpD+dIL2WK+TxyUfBRfqgyd2DQlKCyB6jIEcmfyY5hdzwA1vscKz+077OyO65uX8pUq2/pRsJKgja9dN31yt05G9n22P73Oj4RLrZBbdTL486YEVAsAh0r8PSkSmzVawb8tPxZpJBtwNhAvPefNYCL/NIHaAoxO4cykQdAm+xpA75QyC9NEwEDEY2NPpoDcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaTzUw7S3J0WqzVOEYT4hVKcwrQZW1Ou6D+br+PIfPg=; b=hpi4sWhQ/bYYiu0y8ETS3xd+aA0jomjxxrvmtaXlu7uQsX0g510AvWrUMwyeeN6/NAPkT5T1KJIBQEmytTYb2lgcF4l7W6BLtQXsDaFZL8610HWGo8/2HJ4TWIlAOhErHrYLRn2wyfsXbkOHYkAms5l7llw5rXzv9qxCQO9gK0L9cz2bGW1Z75wjGUWhXDQCEf4IkKi4dMx479NyJJfa8w3FtuJr4JWqHJSxOVkCa/AytLPx0pOU3RyXChiZ27IqrEDX2lBIJOqgAmWr6wViQdBgjhYOB8rhWfemlRJYF5xnhONpRG7GVQWeN7PqhAlDT7S9VKYZo38rXubR6s/AFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB6429.namprd11.prod.outlook.com (2603:10b6:8:b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Mon, 19 Jun 2023 14:26:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 14:26:32 +0000 Date: Mon, 19 Jun 2023 15:26:26 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v3] build: select optional libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0324.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB6429:EE_ X-MS-Office365-Filtering-Correlation-Id: 25b8db02-8710-46e8-91cc-08db70d12de5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C6ihAiYOdwPm7RbY2IMHF9b8MQ2Yr4mzB/cFE5Nyi1zh798dtfNuvOiGLGbX6k+Ue+55sJuWtmXwXaALnOpcQFV6OdVsf5Qwk6uGzmi83JfMsi7A7YZ1/CFznMHYMzB9nFVl3Pvr2zube2SedRl4pDe8BJcY8oe/1DdmzBmOaZEu82lZUkODlbH4p+1QLLUVU6ZDYZ04eJJ2kktmE99xlD/08bqIss1HUQXyqCnYqvmwvC15Gv6/nQZ52F0HufKNLR/8oDYtNkkXiPoGmphpVpGHtG14hFE/A7WGaeghzMk6E82eBw+PhO8c51W+a9qBItQBRH/tb8lA+vgJDFvsBqi4Z2DO6Y2+g8+qFjmWOJjThgpAsz48vhXKo6hnC1C1EEcJd1Xd+ld72tEAK1HCZP78eoz4W7od1Jf7r5vAtgxpGtpAZN8i/cTLFq1mc/JoTl1CU6bm5POjJvQ/OlI2tS5wEGDrFwxuawBUJ26TcRTogaPZCirCIbCSeH15QnPA6B58jpoUTdMCRDN1BtALW5+tWNbBg7MfMN0XOWKta/y9EGqGwnulIYG9oVQ/QEFR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39850400004)(366004)(136003)(346002)(376002)(451199021)(82960400001)(83380400001)(86362001)(44832011)(2906002)(5660300002)(4326008)(54906003)(66556008)(186003)(66946007)(8936002)(8676002)(66476007)(26005)(478600001)(38100700002)(41300700001)(53546011)(6916009)(6506007)(6512007)(6486002)(6666004)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJMdHd1L2hsUG9ianRZS296OUQvUWZKU1RnR2ZETkpUeXQrbmNHaFV5TmVa?= =?utf-8?B?SlBLN2RsR3FiaStxcjZnMXduVFdIQThrcXdsN3RlNklJTGZneHBzTnljU3h6?= =?utf-8?B?WWYxU0Zwc3RHNytZNjczTlJmWmZwcVZPWHM0c29nRVlRZGVkKzZwSUFsYXRP?= =?utf-8?B?Q2hWVzB0cmtPUHZEdzVzS0Z6cHFtS1dlckcyUXlMblJtQ0xsTXkvT2QxVFg1?= =?utf-8?B?ODhFZURWNVVkVVh2K0duQmcvdU01T3NYdmhlalJXVmJrdlNIb1RDeDdqOXYw?= =?utf-8?B?M2FjZ0hGNU9CaDFIdlVseG1IN2ZkL2ZVdDVKTTRBKzU4OWZwVE10ckdwYU1F?= =?utf-8?B?eTNhTDZROUJHMy9IdnZ4MGtnbVpmV09oYTlsQVZOVXFwYzdoZUkvcVJhRjJJ?= =?utf-8?B?VjVMTVdVcDVPZklRU3lXam1BZXJnSzlZSTAxUC9JSnY0alJ5V0ovcmRKVHIz?= =?utf-8?B?NEZsd2VWRFZROXVRdmh5TVdxVFFvMGhoblFpWmg2L0svM1NOVmwwdkNYd0U3?= =?utf-8?B?NTJrOXhrZ0tlaElRZWI4cXN5bi9WOHNDVmh2OG9nZGJpWXB1bkxSa1BGdjB6?= =?utf-8?B?RGtsaGQ0WHkzZ3pPSzdHc3JxUnZndVdpdUkyakpYcTczWDNLcE1EZjJaTS9T?= =?utf-8?B?Y3RIOXFYUVBlQWhiOXN5NkJZb3cyb0NOTjhrb1VnM3hGSm9Sc1RIb1NCeXho?= =?utf-8?B?eXUwK1A3OEFWR1RXRjNOQTZSelVTUGQvUDJta1M2UVdZU0U5Z1hybmo5V3RZ?= =?utf-8?B?QVFydUFEcGJaMnBNeVJzVGtKd2VlT2lyS1RFeWdQMjF5UEI4a1JBOGRKUVdl?= =?utf-8?B?alJ6cUl6ek1xK0ZuS21uY09BQm9hbzJpTENOcStzM2NvVFZ6YVcwRzYwRDJI?= =?utf-8?B?Y1o1aVppTnJDOXByRU9xangxemNKU2ZHTHdqQmtrbzJiYk1laFVaSFBtdmEr?= =?utf-8?B?NDFtZFNyekMweHR2bVI0K2NwMFEzNk5EWkRyVnhtQUx3WlNsTmFTdjVmeDVY?= =?utf-8?B?VlZ4d050SUd4OThHRmhVZ3llLzh0UWNpTC9WS29jZ29NZm5Wd2J1elYzZjlD?= =?utf-8?B?STJhbGpEa25abDhRMzgxaitYNDE1NmVEM3REb0JKbk90MTJwMG9oL05tTjVz?= =?utf-8?B?cHRDa09RK1NWN1pwMzliZ0duYjJkQmxna2xCeE9IMGQzZlBNckpIMXlTSnVG?= =?utf-8?B?THdySEZYcUpKZkdqd0xVRG5WOWRueURBeXhMM0JTbkY1cWt0QSswa3BObC81?= =?utf-8?B?TVBsM0JrOXNhNGZ6YTV6Mjh0VGYwTVNFeVVLblMwQjR3eFVaVy90eUdOdzlC?= =?utf-8?B?Z1AwTGROWHhmRzhHQ1lKbG5ENG54YzdiWnRvWW5ZSzFRNUhqb0hSVHBPbDRD?= =?utf-8?B?MEltc0kvK0g5cjMveWkxTUlueStWL1hyRGRsWEsrMlZzVGY3SlArc28vSjlI?= =?utf-8?B?ZEU3cUx0aWJGS1dERmoyZ0VKRXpCMGE5ZjFQS1BNUGRwS0R0VGVqZGg1SHhK?= =?utf-8?B?eTc2VWl4eVNqZEhES2ovblViVW5OMW83S0NqR2VhQVBQTkhzREVra0ZTM0to?= =?utf-8?B?OUFsVlprYXVpZ2JSTUpqNXBTM05xbnh3OExRM0I2aUlSUjVvSnYwTElxK3o2?= =?utf-8?B?bDBPcEkxOEQ5WkcxMjlkdW5pMnVyVmh4bnlUZEVaRkdmUldTelNBSmh5a2xq?= =?utf-8?B?eFBWZU5sVnpBRmF1ZjNHeWduejM0UlEvc3JEU21oQnhkRUU4TDk1NWZPVEcr?= =?utf-8?B?dnZNUk9GQTJwOUNLRVU5OUdtSjhrdEFQQ2dBNHZkbkhWeEhCS2pkeE5CM25U?= =?utf-8?B?eVJ4Qkp5bHN4WEg4ZFRLbk1TVnFoem1wMVMwZm1ZbEhQbXZJQ1dHbjF0dnJz?= =?utf-8?B?QkRHZlJlaVA2M1F6Q2VDYkhoTFlwaHc0M21kc0VLb2hoTjNlNHk1UHFlQWxk?= =?utf-8?B?bHM0dDFBRHcydXlmc291a0pCeHNrOU0xc0M3elRLTElTOVZNVXhpdnpBK3lQ?= =?utf-8?B?UW05NGxKSWp4cFN1STlhNDZvNXk3bEZMOVJDOTNPMzFxSGI5U1FUeU96TUJl?= =?utf-8?B?TzFQM2NKWUphaUwzUm1lR0IrbkI0VkpheDBqM3FxLzRwZUtXekVVYlh5MlQr?= =?utf-8?B?Y0NGRk4zajZ3dU90Umd6UUxxNk1hRnhRMUVvWkgyMDlEdXZMcVJUdURQVjdX?= =?utf-8?B?Unc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 25b8db02-8710-46e8-91cc-08db70d12de5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 14:26:32.7578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EK4dnKZMX3T9WSDx0lHjz1DW8/KauUz6YeFwGqvK8Os0mExedRJmaK604QoIR2gT438wU5P6xOKdwrlgTPtU3CZ+mJPUuYewGOg1DaZzrSE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6429 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > wrote: > > @@ -141,13 +137,25 @@ foreach l:libraries > > deps += ['eal'] > > endif > > > > - if disabled_libs.contains(l) > > + if not enable_libs.contains(l) > > + build = false > > + reason = 'not in enabled libraries build config' > > + elif disable_libs.contains(l) > > build = false > > reason = 'explicitly disabled via build config' > > - if dpdk_libs_deprecated.contains(l) > > + endif > > There is also a change in behavior for current users of the > -Ddisable_libs= configuration (which was used for enabling deprecated > libraries, for example). I notice the change in behaviour for enabling the deprecated libs. Is there any other change in behaviour for current users? > My current solution resides in making disable_libs and enable_libs > options being mutually exclusive (meaning that presence of a value for > enable_libs will ignore any configuration around disable_libs). > > Does it look ok to you? > Do we need to make them mutually exclusive? The current drivers implementation allows them to be used together, I think. /Bruce