From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7300742D06; Tue, 20 Jun 2023 10:36:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A1874068E; Tue, 20 Jun 2023 10:36:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AF89A400D6 for <dev@dpdk.org>; Tue, 20 Jun 2023 10:36:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687250174; x=1718786174; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=F9wbyhX/WhNPQEP0vX8xzU0bc8gSqnRr7sLPalwkFgM=; b=nhiQhrR+D4TmEYbeh/wJpPpqHJz4NVr5+LuxnjaEQjHwO7wCH+AyMbFk 7JVGBJYSOkl1jF50TBBMIwOa5LuXhalPAUvvER4z/SVUs1NIA5vY/mK97 rN0le4ZfgB84stxJfpnhJ0w7YTZLVY+d4XSmWtMfq18hmCD04wFlc74lR mA+NdDRhGzQ7hyQgGpelWOdo0n88y2Caccc8yMjcNF5hqQqBjEnNOivfn mXWtVNwHK8r9wpRC903bIla3ikHJGTfe/7VyzcVplzIi9Tu9Ki5HLy7op nvX/cmBf4Wbrk/25HqxGvTeMon6SAO+NexhhKNrYZA/Kn25tkTh6ZS0AN A==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="389003952" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="389003952" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 01:35:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="743713225" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="743713225" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 20 Jun 2023 01:35:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 01:35:49 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 01:35:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 01:35:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 01:35:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2gtnr5NaLZZsSELLwmeyoGzKT7RWcDAx/dgdiBBtHU9hkvQTEKCUashI/t/5u3tYXb2Co/CzlD/jqazuQScX8NmPAhSd1KevBt10L0UnHEWxOTXnBcjk7ymEkJfVqVolaotdEaMAyx47OBCF93a56wsFvQc3rZ3zmC3vljnSazq034eLNQLb7DXozvlCoKEJ+tluyrLmMoKh2chiy4HT9SPqkIfTBJQmoapUFTsrovntgIejo/4aTM9FDoBnn1UrMelvgNK9v9o/1iZ99iVwMw9wkYAX5gTMhcIor/NLfSSiKMLLg0OT8zYgG/sDB7rkhpeLVzJqTq0PZ8vdMXk4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YcgkfQyUOkvXzM0z6/YXQ/qiEmGIcwfqjypBhSN9Fhk=; b=E8/on0Ajc7aN8K8Db7p7od52FbOMSoZojgblE/OhKILRzQkbQJtBMH6tD2G3sUjBdJUrKGsuaZHLOQwrspzex0RrEpzpxWIfCxsm/Smj/Nvu+oYiD2JA3Xv/n97UW6+BHV3ltqiJSaEQVcfOy8spsojvVnGrECiUisVrwjGo+rmmpA4h46Xf4AgOwGmtQ0H4Otjkxe9xzm4P4DvTSN/0fnIA/ZZzcGGuHTl/kdQkVqYXRBbhubz+wLLXu54BNFqa8Zf43xgRr7OfzWvOmg+6Fd+mFp9jAxN2yUHos313WU7T+k8cQv+DeVqLqVQdV0Uy9jwANu/yZIJBJbHQFfhvqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB7533.namprd11.prod.outlook.com (2603:10b6:806:306::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 08:35:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 08:35:46 +0000 Date: Tue, 20 Jun 2023 09:35:40 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> CC: <dev@dpdk.org>, <thomas@monjalon.net>, <bluca@debian.org>, <tredaelli@redhat.com>, <i.maximets@ovn.org>, <james.r.harris@intel.com>, <mohammed@hawari.fr>, Aaron Conole <aconole@redhat.com>, Michael Santana <maicolgabriel@hotmail.com> Subject: Re: [PATCH v3] build: select optional libraries Message-ID: <ZJFk3N9ooG5ZVRnS@bricha3-MOBL.ger.corp.intel.com> References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> <CAJFAV8y3ejgVUydSvYDM9tPU-zJz+gFJcD3QPHn7V-5nVP5oNA@mail.gmail.com> <ZJBlkqojcvpEwMjJ@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8w8dcH09mQjXuDWHjUPOi-1fbgxyJSxZNasE0tr8G-bWw@mail.gmail.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <CAJFAV8w8dcH09mQjXuDWHjUPOi-1fbgxyJSxZNasE0tr8G-bWw@mail.gmail.com> X-ClientProxiedBy: DB6PR0202CA0028.eurprd02.prod.outlook.com (2603:10a6:4:a5::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: 625c6cc0-fc83-4399-134b-08db716957b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pegVmC2kCoaUI+VCmpWG7C76I+I0bEDJcCxPImjQD/UJtEezKXKprYUwbR2aBa5Ax0B6tQ/m0uOvM4A8lLTiWVen9dmS7hj7BfmaI6hv16355kTeRJqg2LVhLBpERBdCZa5D75Pu0LNu9roG/wNgYUqgC2LQVKBPm8n7R3OtNH9C7mQgQ7CqvyqAptajAjgL8GO4X2STP6idGsZ6JZ/9rTbYcPEfsT+aZLAIsRgVOxd5S3bJDPAbxhDy37mKltxqCyijSM4lAM63GL9Zhnr1WAybLZNH/F/RBiPPdFCo6MqSLJbClxkKDAFdXQwXCvbrR9RCRKDA41iM0EuFzleourIrAnTFQuYc9/iDpMNyOrXVvUpIWm8mvWPhUQlxT+SN1H9P52G0ZV+HBMr/iP1RW2V1mXerQiigCMw6Slguta+fOgTT4jezxExpUmAJmo3konjrl+i1pQ52SJpfh/NVOH5qh4zG4Nts2h04HRMbhoGLRbkbf/cQL2FnaO+esmD8qahVC5nFEaHAYIyOykoK+3ClpEpQUoReArRKN4rkz9nnbIl+6LLpIgPNDj7jdOa5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(366004)(39860400002)(396003)(136003)(451199021)(38100700002)(86362001)(54906003)(8676002)(44832011)(26005)(6512007)(41300700001)(186003)(316002)(4326008)(66946007)(6916009)(66556008)(66476007)(5660300002)(83380400001)(6666004)(53546011)(6506007)(2906002)(82960400001)(8936002)(6486002)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUV6b0V5ZFc2Y3gxSjVDZUNQSlBEUllNckRZbGN1eW9aMFlOTUxhblBqMEVI?= =?utf-8?B?T3UwVThpM1EwRVQ1QTZEdHA4MkIyN0t1RFY2N3FFdzFPR2daWm9FVXdQL21r?= =?utf-8?B?TXJqeFhUVmFPY1lkWXc5NW51NXZBU0I1dklwZGVob2FBVXdXaGVDOW5qdkZa?= =?utf-8?B?YVpvUFg3VmZjempJUkdITnI5UU5EWWdGTHpFcUFuM01UN0VjY21jN25BRUw5?= =?utf-8?B?OTZJRGhZZlRIQ1JyMk9GTjVLcmRkdEtVUmdDOWw4MmhDRlFwVFUrbTVuNlhs?= =?utf-8?B?a1pqVGNtVjZRWHovVTFGbTdNS3AwUEpJbHVuUXFqSWMyenp5S2hac0RwcWM1?= =?utf-8?B?Z3pDUzAzZm5odjZreHpJRjdJYklaN1I3eUdQSzJCeGNBYWVUK3hRUHZIdCsv?= =?utf-8?B?bkNwQWhjZjR4TzNKM1ZndncwMzRZYzJ6N3pETkRMUDFtOXNkb0VHc2c1YXN0?= =?utf-8?B?MTVVc1puNHJKK3RINnh5SFZrOGpmOGpobUQrVEdwbmlvV1VxUG1qWVN6clRF?= =?utf-8?B?RUwwRnUzb2o5Nk8zYk40RUU1V2dvMksxalRHU3hUcERsZ1NKVG5WWSs0UmRU?= =?utf-8?B?YjdxRVhLL0liK1JnS09TcnVQSm8xaTlhdFhqWmJETjdza1YvSmRNME8xTEkr?= =?utf-8?B?dmNsMGwvd29jMFlhNkV0VGNBdWxveXVRRzNUWlBISHhVaXl6TG5OYmpLV3dz?= =?utf-8?B?SG5jWGdaSEE3ZjJyR1lkS0c3RkdGVmhDTjZDT25Vd0swdWRRYWY4dnZnMXRl?= =?utf-8?B?cFdyY2hCWVQxT25xNG9Sb2JRM3M4Yy9xV1VtYmc4b0NvVUdaeHc1cUF1clBO?= =?utf-8?B?MFB1UmRWbnpadVNzckFvd2hJZmtOMWZxVnJBak5tUzRVbEFIaWtiU1JMVHlp?= =?utf-8?B?aWxIUExxYnZrdVVYa2ZzMjcvaWRBbW91dVRlU0puTGNCTXhPRm16bVlqWTFz?= =?utf-8?B?cFJBZlYzNS9tSnNKSzdkZjFlNmtLY1JQQXVpQ3h4TGRaL09zTyttVGVScVNS?= =?utf-8?B?U0prTlEwMlJFcnZqeUE4Y0JLZ3hwN0dKUFNtVU4xUHpuVldJc0NyL2RDdGJQ?= =?utf-8?B?cmVSZm14aGdQME9pUFllTkgxRUZIcGJROHV2dzFZRkFrRUFRcWtxQzd2dDFi?= =?utf-8?B?MnFlZElZa21wKzR4M3BwTTEvRHoyeS84QU14b09KL0J3STBMNXhTZWd4M0JJ?= =?utf-8?B?RnpveGQ0dzVvQ0p3MG03RXg4UTQ0dVVmK2RFN1NiZ0VLY0dka0pSZGFSNmVH?= =?utf-8?B?TkhmaEIyN0xuaTZCaWlrT3Z3U0NCQnhDcVRhVGtaQU9tRWsvTmtmdWFZYlRW?= =?utf-8?B?SGFUbXVqSUFEWThQd3I1THVIUXFMQkZaK2diQmJaN3FpVWkwcU9yYUNiUUFM?= =?utf-8?B?UlY5eXltOWFkRk42SVZ0SVd6RzFxSW1oc0grR0NIMC85NG5kczVMTVpGR1Vh?= =?utf-8?B?bzY5MVZNQ1VRWVA3dE1RK3R4TzFxcStEa1hMQ2FUdW9HSTh0NmFoUUJzbnVl?= =?utf-8?B?anpMYjJiT2w2eUN3UlpEV1VBNnZhQUY0NzNVMU1WL0Nzc2V2eEczYU43RjRS?= =?utf-8?B?VDlQa3lWS2oxSmVhN1E4ektqNWcySVhITlIvU0JJRlhiMjNkRkpyY2lxb3BJ?= =?utf-8?B?cTdoSFN0djhhYlNidGJPQWIzTytFcVNaeVU2MHdhcmU5Mis4M2RmQnpiSkRB?= =?utf-8?B?SGg5ZFhIb0VoVGtZbVlxekdRWmtINzBURlo5NjJjZ3NKTXd1YnJNN1dNc1g3?= =?utf-8?B?VHgweWhXN2ZtRU5qV2FkNDFoajVFaGJmSTNNOGxzRWJheE4rak9jaHlKWGRZ?= =?utf-8?B?cmFIWnM0cFhQMmVmYU5vMkNhb29CNXZsenhRbm9uUHhSb01Va2JYSkVTenJ1?= =?utf-8?B?L2hqdngrSGQwcjFJQ0tyeFhlYStNTzEvZWtDMzlyelZCSUtiUC9YemZQVGFu?= =?utf-8?B?dkV2dXdTVW1FWHErOWEyU0o3a29ET1BjekJPZGUyMkltc3B2MXQ4d0R3OGUz?= =?utf-8?B?M3dDSDJ4ZTZpR040Wm5aZHdUKzVQS29ZVmYveHk2Q2EzWjgxRmFQVytPL2xC?= =?utf-8?B?TDZ6U0h2V25kejNpeW4vNjJVWVlmTE41YWFQQ0VjekltRXhyZmFPOGlMNkNF?= =?utf-8?B?KytnRWhxZmdFNjZ0QmtTRDdGM05qcEdmS3dmaUoxWFpYWXFCbFVUMkVMNGJW?= =?utf-8?B?amc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 625c6cc0-fc83-4399-134b-08db716957b7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 08:35:46.1805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T771Tkgj9cdrXgB8ED7S4EwooPXQLlRwHF/37LIeWG+LCmoSMJmStdKbPrQC7jVG9ZGkoe5TXiRfIm2dwVQA8oJ07P71hHUbsjHe78l8EXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7533 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > > <david.marchand@redhat.com> wrote: > > > > @@ -141,13 +137,25 @@ foreach l:libraries > > > > deps += ['eal'] > > > > endif > > > > > > > > - if disabled_libs.contains(l) > > > > + if not enable_libs.contains(l) > > > > + build = false > > > > + reason = 'not in enabled libraries build config' > > > > + elif disable_libs.contains(l) > > > > build = false > > > > reason = 'explicitly disabled via build config' > > > > - if dpdk_libs_deprecated.contains(l) > > > > + endif > > > > > > There is also a change in behavior for current users of the > > > -Ddisable_libs= configuration (which was used for enabling deprecated > > > libraries, for example). > > > > I notice the change in behaviour for enabling the deprecated libs. Is there > > any other change in behaviour for current users? > > The only change I see, is that this implementation breaks enabling > deprecated libs via disable_libs. > It may break existing developer build directory and maybe some > packaging scripts, this is why I am a bit puzzled. > > Relooking at the disable_libs option current implementation, it seems > backward to pass a disable_libs option when you want to build some > deprecated library. > It is more straightforward to request building libraries via > -Denable_libs=<deprecated_lib> explicitly or -Denable_libs=* > implicitly. > > But again, we may be breaking something for people who relied on this behavior. > That's what I expected, and I think that is ok. I just wanted to check that the change in behaviour was only for the deprecated libs case. > > > > > My current solution resides in making disable_libs and enable_libs > > > options being mutually exclusive (meaning that presence of a value for > > > enable_libs will ignore any configuration around disable_libs). > > > > > > Does it look ok to you? > > > > > Do we need to make them mutually exclusive? The current drivers > > implementation allows them to be used together, I think. > > I would prefer we are consistent with the drivers options. > Yep, I definitely agree. Both drivers and libs should have the same behaviour.