From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D976842D06; Tue, 20 Jun 2023 10:45:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB814068E; Tue, 20 Jun 2023 10:45:12 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7940A400D6 for ; Tue, 20 Jun 2023 10:45:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687250710; x=1718786710; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6/Z6U8Pj+lYurMvpFhRUPf77CzIF8fAqO7Yji3/x6DI=; b=Qh17Bo9FpC/gbnT7LnQWtFfFIQbTolHoDd44WX1rEy+PCTxfV8fEoiCb anynmgXhxKVJ5L+OnXdhLx3KCfr2oO03lcvy+fZJpkBSjkVa8OcNgvU/W K0kBlpX1Z4kLRkp32Z4q0z7jExTGuNNYFmyTUId/MvTqP46cN9127VqxV /nqieoTZ2AOaQCcVDyL8rwoOwgBDg/8YEKcJHODUgCbPZwcWnZP+qnLrw 7xxmwp2+yl2kta/1+H5ZZQC8uyL1LSGQWaNKXtV7HYFrNz6K8hvLN9Ust ybOv4x6i9KiW1lpKALwz6vSXCtRIxKNvn5ZCtmfSMfhhU6sRZ63Nts3Kx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="425759561" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="425759561" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 01:45:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="960700413" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="960700413" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 20 Jun 2023 01:45:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 01:45:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 01:45:07 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 01:45:07 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 01:45:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWC+xgUxC4gDQCIlPXsLSQPUGYghUpFLfx/z01jWTFNIWN2rAcz2DzwiBxe5e8Z9O2OgsmPZwKeMS1fLbVTIxHyz3O9P4CpwBrhgQgJobFzrSyAhnG4QuRpfL0QcW3PIdlbkbRtwK8bZu1Kel+sCylLzAILE+jSPzdlygqo/pjxXAwdShcQYRtTXA85ICXdHbKEvjmEebGzITrYjzv11S0ww77ZhW+frp08H84p2Wd/7ah5ZQVtKv5ZzqL+9pJKXNksPr6oVisV/bgGyO7LPa2THCO1UnYHJiCZqpMefX2Pv4lnnlL2baVy5gj3h1twIa5Kxthkvg9Hrq96Gd8vwAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IyPfbLpFlkECS0iqsoTXpMOqY7AW/CPADz2Y3CK8z+I=; b=kRgz1inG2ctRbJdP2dDX0HWcLEJ3emv0+UTidnxSL8md3wtN0wRMQWOkGr2xmwfgoiFSA+nGtqcAmAUtj1pZ5f6JSni79ZlQrhuRqBAGkZwLvXqaRw/EDMTnsfwNT6cOW0ZYglM5wa0tP69m6YPcMKYWgPgaPdCg+nKhgfbC1lTTG+SqhAASTVqI5ZoNGsx0qWxGa4cCxaCbroiYlKk/SLHNlRhoCEo7g8Ffu+h8OtkW13umDUmZwNDKOhPeUuZSTNRXrJzCqvCMIEDJQvg5IfKYNqe2GE+NCtCNQpt1EoRv0+zJeKQS1cnKk0uCg7potY3y/mC5iWE0Lwf8pqqGjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6953.namprd11.prod.outlook.com (2603:10b6:510:204::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 08:45:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 08:45:04 +0000 Date: Tue, 20 Jun 2023 09:44:58 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v3] build: select optional libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0019.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: e3de72b4-28eb-4909-b298-08db716aa45d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gZLJ7rGzpXMRx10GbzwnXOqYGcNMWqE5eyTiylBXFF4Ko/tIKkTI3XCMZH2/05nYwgxaB8rB0SgMze4qT0mvwjgEaSzgDKzjbD/8vV5KBnIYMkal5KsMc4GDR3skGwssBcq1hBOuD2bUfJ2xQWkAC2Id3N5caQZH1tpDFtT27wDvoRgicp7FfXjTkTNFGNUr/n1A6bgrm0BVXe7hoBSRJF4XoVgRwCSZFVUCUlTkAcPoolLIGdWYpnkp2s4vP4NRBmDhIwuCrk3Em7hjHTctDw7QnaP1v+Pcb5/oOS+V5Z6JClALjh8QQTQC3yJuXA7YlaPJQCujl4wVUKOl6qa3kQmkqHuXP/H651PfC5l8Xz6bE7O5J3J2Y+q838R9dOF49VlGYVhx3a44/YvaCMBD9b4vjoj0+l5gfZJR99hnVz8tYJI3/Cmaf7OKMQCybWfeaaqczBoi97IoxNKQ6z5pqEB+ux/BEKlUcVLKekJZhhscQrzPeP80o/oH9Zt9M+gcpc91wpQlcHQYUYfLPJQP5nL++xZp85RVI5lfmrBhQpuCKSW3alGW7pkRcXFggYLT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(136003)(376002)(39860400002)(396003)(451199021)(6486002)(478600001)(6666004)(83380400001)(54906003)(6512007)(53546011)(26005)(6506007)(186003)(2906002)(44832011)(5660300002)(38100700002)(4326008)(66946007)(316002)(86362001)(82960400001)(8936002)(8676002)(41300700001)(6916009)(66476007)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUNKUGtrVUNwdUxKSmZPMUw0QU9JL3d1Tmg1VFN6Y2hiYWR2ZFptSExHREtE?= =?utf-8?B?YUtoTnpXc09UMVJoNFdnUkR1VVFOeDVTWjRPS2FxZnRFeEd4NzdDL3g1KzdD?= =?utf-8?B?bENvTlptcjhRRmlpRTVlNlU3alo0ckxSN3BOQkp3dXdoWEdLU2NxMmQxU1ls?= =?utf-8?B?ZEE1Z1F1SnFHNklBY2VkZnpPamZoTlgvakpKQVcwc1JtMVVSVVRzWU1ZYmVm?= =?utf-8?B?bTR6YjVZanZPZWdiSGlDQmMrbkxkdjcrT2pSdmZhaDlRZ2FRZE5uTHNzdVZC?= =?utf-8?B?Q0VnM2EzZjREYVUybFN6K3U4UUF2d2R3enRjS1YwbFRHbHhlN3dKVjlnV1hX?= =?utf-8?B?eTU2YzFiTE5pamFvSGtIMUpwcWcwWUNzUDJtSmtzTFdlQTR0QnVyNVcwRzhz?= =?utf-8?B?bVJNMGlpc29haTExSWJJM3hXVGN6OTJydXB4Qm1pSDBBcm4xUE0xV1N4UjJo?= =?utf-8?B?MEVKWEFhVEJRZHJoOUtzc0lQU0NtaVVOcGlyZ20yazZjV0I0RnZ1TkdOdHZC?= =?utf-8?B?Uy9jRjlpaHRQMS9mSitrQmI3UEJUVnBDL2FRTWlmNm5wVzh4WWV1cE4yZ2Er?= =?utf-8?B?UzdNdXhUQUZneDgrSGljQWJXZ3RqaXhYTWw3WHc0SUNYaUVoWkxXSnp6MVNu?= =?utf-8?B?dzhoSVZzR2ptUUoxWTRVdU9Wdy82eUxUK2JIVTM0N0lMb0wvK3RwL09qWThC?= =?utf-8?B?Nmg1Y1ZqWFZubUFNY2JyRHQ3aC9md2RaZ3ZGNXhVamZSOW93T1l1WTRzUmRn?= =?utf-8?B?MGRqZk1JekRwRUJ3N1UxeEU2OGt0Ti9pU3BGYjh0OHRMWTFheldKeDAwbGhn?= =?utf-8?B?SExNL3AxNTdEblg2bjcwZ1RiNFlPUFVjQkRCbVMxanNVdzcxTjFVUTVCWGww?= =?utf-8?B?c3cxZy92aDdwUGdmZlQvVE43dERWSXJhV1ozcHFnbVNtbnFLMkJNTmpVY0Q0?= =?utf-8?B?dzVDQmY5dVBveEd2UTVsbm1GUVFpVUtLZTkvODhiU0JHSXdXcTkwVUdhNjk0?= =?utf-8?B?QmtZNzRvSkpSalRNcDJZY1FMY3ZrWUJKSkdSYjhRVkdwZ3F2TkZNUmlvL296?= =?utf-8?B?aDMzKzVBVklWaTdpQzJIMkdXd0w5WkVuY0x1V2VWSnlDdUNDbTRhMUJ3QnZX?= =?utf-8?B?aURSU3lPK2M2T3NHZ1FNNUpzaXVKNEJEMExNY04valRIV1IyenBYdG5LK3lC?= =?utf-8?B?Si9lbDRVWUZKamwwL1JPZGpXbFJIL05WVkNUVGVaQjVxTGk3OU84R0c1SWlh?= =?utf-8?B?NHI0Rjk5bkhYQ2F5cWlDV2tNVVZ2ZWxuVzdCV2tZcGdJbVJiczNDZUJQaGhQ?= =?utf-8?B?VWFhTmZpRURmSzlKRWNqbzE4eERDZzBXK1l6NlE2MTZqQXRRaG4yS1d1S1Yz?= =?utf-8?B?SmkzVUpDd2NEbFZqNVN1WG1LQ3pnejNnT3RCNHljLzFLMmJ0WVQzMTM3QWpL?= =?utf-8?B?OXl1QVVPcDdBck4vZVhjN3gweFQwcFp1YlNxVWJ4VFlkQkU2blZZcFlxN2h0?= =?utf-8?B?dkI5Y0QweHp6cWp6M0ZBRzh1ZGNRR0g2bGhSRTlacXhJSzRFU2wycEtBS250?= =?utf-8?B?MHNNUHdjNytpbE9CL0dpOTVLc0cyTzlMZVdobFFKY2ZiOWtyQis4bXcrYkVt?= =?utf-8?B?YWFRbEpkbnkweHJabmpyNjJGcHVveURJSkhDY2VvazgwL3RyZDdack5WUDZ6?= =?utf-8?B?QW5qSnBJYVFTZkY2WEl4K0FCdWhFZTR4TWptR0pNZlNZMzlEVktJWTRscEw0?= =?utf-8?B?dTlOQ21pL3NoZ0dqQnZTN2lmdWkrZlhMNGhMWDNYNVlPaXBhTytoL2RyMWlz?= =?utf-8?B?ZkpGOCtxZGQ0MU5yMFpNby80bWZNb2grcE5ESGRMTmx5a0pLb1VweDVIVWlY?= =?utf-8?B?V3RneVg1TWhtNmU0YmVGUTJaN3UxeUFZMG9MaktMNjdjZ3l6ckk5R2NPaUxB?= =?utf-8?B?V0YzY3N3UVNOUmhlb3VPZjhyeXpkbDlKTlBxZ3BjTUdqK0dZaTJ6TWwwajQ1?= =?utf-8?B?UXdBeG5lcUdTRGdoTkNUb2krcFBMdklOcVBOM3MvUUJoY2tDR3dWRDdUZmN5?= =?utf-8?B?SnVDRCtRdG55akxLeHVDZ1Y0SlJWVGkxalZ1OFU0cEtZQTl5TmNhUlQ1QkdD?= =?utf-8?B?c3VOZ3NPQjZmakZBcHptMjFvZGF3Ym5Zek54Q1ZKT21zUitzVUpEZUNUTk9D?= =?utf-8?B?Q2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e3de72b4-28eb-4909-b298-08db716aa45d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 08:45:04.3504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VJzSEdbcGog5bGltFqZbCRtJbgqP5jdEe6O8zFjNNDNKM8nn9hewk5BAISTEuKTtHGVzKSTBsqGgJ3tFY5FQA728W5Qh1MSBY1go1PxWuM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6953 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 10:38:33AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:36 AM Bruce Richardson > wrote: > > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > > > > wrote: > > > > > > @@ -141,13 +137,25 @@ foreach l:libraries > > > > > > deps += ['eal'] > > > > > > endif > > > > > > > > > > > > - if disabled_libs.contains(l) > > > > > > + if not enable_libs.contains(l) > > > > > > + build = false > > > > > > + reason = 'not in enabled libraries build config' > > > > > > + elif disable_libs.contains(l) > > > > > > build = false > > > > > > reason = 'explicitly disabled via build config' > > > > > > - if dpdk_libs_deprecated.contains(l) > > > > > > + endif > > > > > > > > > > There is also a change in behavior for current users of the > > > > > -Ddisable_libs= configuration (which was used for enabling deprecated > > > > > libraries, for example). > > > > > > > > I notice the change in behaviour for enabling the deprecated libs. Is there > > > > any other change in behaviour for current users? > > > > > > The only change I see, is that this implementation breaks enabling > > > deprecated libs via disable_libs. > > > It may break existing developer build directory and maybe some > > > packaging scripts, this is why I am a bit puzzled. > > > > > > Relooking at the disable_libs option current implementation, it seems > > > backward to pass a disable_libs option when you want to build some > > > deprecated library. > > > It is more straightforward to request building libraries via > > > -Denable_libs= explicitly or -Denable_libs=* > > > implicitly. > > > > > > But again, we may be breaking something for people who relied on this behavior. > > > > > > > That's what I expected, and I think that is ok. I just wanted to check that > > the change in behaviour was only for the deprecated libs case. > > Thomas, wdyt? > It requires some release note, at least. > I am assuming this is not targetting this release though, right? Assuming 23.11, we can put in a deprecation note informing of the change ahead of time too. /Bruce