From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF6D42D06; Tue, 20 Jun 2023 11:04:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E40BC4068E; Tue, 20 Jun 2023 11:04:05 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 84541400D6 for ; Tue, 20 Jun 2023 11:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687251844; x=1718787844; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ZbAa4K3hjZ/uSbqlffIgw6afiWl81Kx47Lw2lYjtm2E=; b=Qd13Qs/5xRPniUJuBPAqLj0qYYG1h6MLUacu0Ah5HDsIaI8tatUuKxIT p7HSAbZb1KFzhRL1uw3SvKSJrIXV82cuH7DfpVXhhq/1eUtsMxEoXNCch cgM1QSzRJd5tg/EIoeuOBfwHEKKG5FyhOeYotd5Sh4COPMfYRSonjN9Vc dIIzB7wZJJxKZVE4bfEWGol72xfaFLcNjpjWYbaC8FWplxU0kUTgZC46t 0DWdR4dry2+TGCXVSSomMMhxPtcYqRGIrNpdnLT3+pCVfY/h9LJABajOq eyQnUg056CA4d5fWActTpsIpZoPdKFe7fUroT3nnHKWpUqMkKEHJbHdpv g==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="362349931" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="362349931" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 02:03:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="803874536" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="803874536" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jun 2023 02:03:57 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 02:03:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 02:03:56 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 02:03:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaJ0FzU5KOAawlYObknbWHugFPLzpRhw+wAY52l2IyC1dvopmfLnHMMCEmd49UI5bb1eIV6KpkEeldFepB+r2m4km51xM2HkHj2ExodTrryb5soxIjduuZg8hlHo7Nv1SxRXSm3NgVFGl6I0KT1yXP4dwnVdhD5Pw8U6/R0RjlUm6XZ+rinpInmlWDd566fFU2QHv7crNCzx3n61cp3XU+27d9Q0z/hVg5kfi1jRxOmekfoLIh7830Q3IdIMuN7rLniRji2sy2DFGZRs1hNTbUuxgjzamafn76kw+FHLdbtCqbhykjjmIDUfYN5p5VLqvHT5JwguhNSwyz83RYJiFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PO7rOJGvQWlMQCyztImAzoYDnL2Kp0TxSRAlkSJ00Pk=; b=cd6v6WvcA5g84+K/+VgliBxt4UlRgbf88DAQplf6mJvTRp2ZERy7tvcGgFUa6HvVqwluenkD7NIb+vkoyvi1zpfyKfh5XMruea37ovWDLB8uPzlQX7AVAW3Jq6hInrxrfdnpymdI5xsj2D6eoFGvIl1mFDpNMiCxySQsOjB50omAEnhCLaCyE/1QgLGXEt220FppMdMo7/5eq1+Lyx1iJoFI73gGfaWeQ2SuZ0lZWgf4N9E/ubRDYSkTn2nQ8m19oYBevSWvBvzQfPISCj8gpAG5XUnCiNw7nWyba6Scm8uEC952FwE4y3M5+NmoerYT1hp0Y9JJO3el/E4uDv6u8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7649.namprd11.prod.outlook.com (2603:10b6:8:146::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 09:03:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 09:03:52 +0000 Date: Tue, 20 Jun 2023 10:03:44 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v3] build: select optional libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB3PR08CA0021.eurprd08.prod.outlook.com (2603:10a6:8::34) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7649:EE_ X-MS-Office365-Filtering-Correlation-Id: 17129098-bedf-462e-a5a9-08db716d448a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9fs6IMkHmARH4NpT/B66+XIDwLY1gGbR19ZxO2Ij9STffn8OEiLootaWjKSpqW5/g6V+uvyJOhukBFVKykyClDphWhVKhBfHWjvabcTM0wTtNszqCTN+ikvIwZKnTwrde1kUFad7YHWfBXhXtM5of5owOGo8xHYKr/8aqfPMQKOaELpnspj8ZmdME47uu8RKD0Q0/2n6M75M+VvFxFCUm8OCQUcVx6T8FVYtxe7/kmsMh0HiiJ+oVnsbCtXJLou/0NlQ3BUwGn8A/zf+ADvL4tHwEnBcmZHk9MwhE8hbzyDG3+1wC0jOfEYRrryNFFJMK5RR1sN7brePjsuW9cHi31BLPkCsAn91k501fhybKwY9yi9VWRXHNbKs36cOig3qB9db+nqKxgVP0wU0xZOXyJJ8khxua9zsKLUw9nL/5JHyPzlHGdUFaNzWGIGR+p4Mtg7J09cR67Ijadl63OG78kxmqG3fC4NdX+fyJfAnTMucIIfE4afgfF/Rhr1msPPxuKUGfNrE2Er8yQVjXv0iYhafgY1tTGK12a3DheRPn/507zS+t/Ys+rKwZmk1w1ye X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199021)(2906002)(6512007)(6506007)(26005)(53546011)(186003)(66946007)(6486002)(8676002)(8936002)(66556008)(66476007)(6916009)(41300700001)(316002)(4326008)(478600001)(6666004)(54906003)(5660300002)(44832011)(83380400001)(82960400001)(38100700002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aml6SnpiZnBnSzV5WHlTTjhtYVB4bFJsQU5xSFRQZXpWei9zSEsrUmtQb0dG?= =?utf-8?B?Zys5cy93UFI4d3dMVVhQZDA3cVRjSVB4OVhKbENhQ3dTMkptdE01RmZFb2lH?= =?utf-8?B?cEhLWHB3WmM1VTlnYTROck9obEVVR3hYRWhDN0xOWGg2ek9tYVliSG40RG4z?= =?utf-8?B?Z2NsdDlaekRTSnZJNk1GSkxYTjRtczVad09NaVVWMFNzaVJjUGg1b1J6SXpl?= =?utf-8?B?WGx6VUJXVVVpckZxczRkT2ZVZEJFUVFGSmt5RjlTb2JxcDdxQ3Uza1dUOG5H?= =?utf-8?B?c2F5OXRyeERBczlNOSt0WkQwbTVEY1dQeGRlcS9KRzE4SHUyVWp5RXM1OG14?= =?utf-8?B?eGo4ZGRHQ1ViNzBpSHIzT0sxK0tmb0pGaFoxczR5bllDNU5RbzhOcEV2UVA1?= =?utf-8?B?bzgyRHpiYmx2Q3B2cVlyem1lZHhvZmxhL0lSMUhGSWZ5OU5VNnh1aVhVTkdm?= =?utf-8?B?NFBJUCtBRTQxSGxVK0VDZi9pRUxXWkdqVGVJMzkzVFhZWDJEMXBvRFVWajlr?= =?utf-8?B?cTZYRnk4UzNETGF4dXJvL0RFMytteXVDeGNubG5FWTNkRjVUMHl3ckMvMzdE?= =?utf-8?B?WTkzTHdNeVQyRnpyeFJ6YzhpKzc1YVcrcXlIR0xVTU10YWVQbjFsSWVlVEZl?= =?utf-8?B?R1R2VWxaT3RGRWNHc3R6WVY2Tkg3b3AvQW5JVlNwSjdKa0p1RGJ4UVZzWlhM?= =?utf-8?B?MkdHY1gwNFIyM1FxR0xTVWl2U29ZallKL3Myb1AzQ1JYZ3d2OTVuOE5GYlpE?= =?utf-8?B?R0dNZWJpbndBNVgzMERlVjFIdktmcUEyN1AyUG43SEN5bm5lc0ZSeDlNVkts?= =?utf-8?B?elQ5V09la1oxVlp4bm9KR1puY3lDaWg0NlFMVXpVL3Y0TzRFWm9EOHVUMmxB?= =?utf-8?B?bEdZUHhoT0xZVUh1MjBUYlYyMHZLd1pHREdhY0I2eDBmV1JNYnhCbXZsZXds?= =?utf-8?B?dUZNZS9IQ1p6a05tdENqRE82RmxJVjl5emNkMDNDSUNpZkRWTzMrbXh0aDJB?= =?utf-8?B?eldCYlllUlg4R1RnbU1hUThMWEdIRFlzYjlyQUdGalhORkNNYy9uQlA3YmFr?= =?utf-8?B?clpBekIvWVZIT2M0eXViVU1pRndldkxFUkRtRWsrZktMVEl6Zm1sMHVRNkF2?= =?utf-8?B?R1VaN2d0SC9waVZVdUU1eW1aaHlidXFhUUxnb3JScXZlcmJNbU1hci9jZGww?= =?utf-8?B?UDltcjJBcU5tblJWc25VN1pWOUVpUGQ3TXpOVFhEV3FqR2ZuVG83QjZlNk9j?= =?utf-8?B?TWR1d0lveGJ4TnlQeWwzcEtyWGFOQit1VkNWVXYyd0IrT1hrSHV4cGpDK3dJ?= =?utf-8?B?QkJuNVZkNVdkVGNwdm1OOFZVb0ptbjNrZzUzUnRibmNFbzRKUWxHSDdibzl2?= =?utf-8?B?Z1ZuM3V1Y1h6WXQ3ZG95eHBTaHZDSGVnZWltWlRRRDJaQzBUdEFZdTBZVTc2?= =?utf-8?B?ODIxVm5mTWhWTXM2OEc2MUtPeGdYaG9pc093RzR2M3pKSXgzazdEaDRBN3lZ?= =?utf-8?B?L0J4VFVIcGxRN3F0K3N4aGQrUnA3ckNzemthcWdKenhtYkZJc2l0Tk82K3E5?= =?utf-8?B?Mnl3RHRKQmZiQmliNnROb3dlQ095L05HRUYxMVhwOXV0aW5RcUYzY1hIQ2Zq?= =?utf-8?B?Z2NheEx4TVRIV01WNWh6dkFndGREYlhXdFQydXdjQVNXRmk1Uko4aTM2MDFm?= =?utf-8?B?OWlsWkl0bER4ZUw3VXNlU1JUSm1RRS9pOUxGRVB5VFNHcVdOckxGaDRLZS9k?= =?utf-8?B?ZEJQVFVRbzA2aEhZYWlqU2g2dm9RY2lCeHVlUWF4SGx2MENXNEJQQ0RjNHRi?= =?utf-8?B?OTcvaVN6WTR5UnJSNWpyK2pQdjN2bTBwZUlMY1V4YXl0RFdadUs4akViMmU2?= =?utf-8?B?KzRYblY3VzZoRithSzlqNzVaaEI3N0NjSytKY2pqZkl4VnptMEtTN2dWRDU1?= =?utf-8?B?bG1kcVA1NHFXOWdSck5tVWFCWWJFL1JDcGNTSjVkUXhkT3d1MFNGcmJzRkJq?= =?utf-8?B?ZXl3OVQ5N3o5NzR0bDhRSDFhbnBFQkMzcXI5eXZ0NkJNQmNDSkVGM2pDbEQ3?= =?utf-8?B?NmlPMnl0bEZoUWlPNDdMa29YeTFFbGlUbjExNWc2a0lWWk9xdkptWUhpQXlR?= =?utf-8?B?VkZ4Y3BteC9HRUdlTWV1Q2ROZitMZEFRalZ1SGp5UXptUzNEZGVDMTIzYkFL?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 17129098-bedf-462e-a5a9-08db716d448a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 09:03:52.0837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h31PdYRkgWaQbZ8Poc6dYDaTaOZK2K0uG+9PImGvgjNX2rAz6antLRvAg7sE/crCp0bCvETPo+l9WrQhjyob41RPUuJfmY8NOjgeg5LTYkI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7649 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > wrote: > > > > > > I notice the change in behaviour for enabling the deprecated libs. Is there > > > > > > any other change in behaviour for current users? > > > > > > > > > > The only change I see, is that this implementation breaks enabling > > > > > deprecated libs via disable_libs. > > > > > It may break existing developer build directory and maybe some > > > > > packaging scripts, this is why I am a bit puzzled. > > > > > > > > > > Relooking at the disable_libs option current implementation, it seems > > > > > backward to pass a disable_libs option when you want to build some > > > > > deprecated library. > > > > > It is more straightforward to request building libraries via > > > > > -Denable_libs= explicitly or -Denable_libs=* > > > > > implicitly. > > > > > > > > > > But again, we may be breaking something for people who relied on this behavior. > > > > > > > > > > > > > That's what I expected, and I think that is ok. I just wanted to check that > > > > the change in behaviour was only for the deprecated libs case. > > > > > > Thomas, wdyt? > > > It requires some release note, at least. > > > > > I am assuming this is not targetting this release though, right? Assuming > > 23.11, we can put in a deprecation note informing of the change ahead of > > time too. > > I was hoping to get it in this release. > But I am fine with postponing and announcing the change beforehand. > Given the fact that we are likely changing behaviour, and the fact that the deprecated libs makes it more complicated than the drivers one (since we have always on, default on and default off cases to consider), I think it's best we don't rush this. /Bruce