From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6AE342D09; Tue, 20 Jun 2023 16:41:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C74B4068E; Tue, 20 Jun 2023 16:41:14 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1345F400D6 for ; Tue, 20 Jun 2023 16:41:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687272073; x=1718808073; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=F0Os0TBFCgMsgFwN/b9J7nWY9DoQFq6zFUkbB3JO1c4=; b=ml6ooTERLjDEqMWrzNbojHPZ3LuknrfOy7HhZGVsWhs4Mc9CZxq+c24Z bT4ppzURba9vtk5t/PeZfhVQVteyuMWyw3mQU6eYxU2KME6EeW3QfXNfU CendvuAjq4dRHLdxeQaG3Qqjega4spKWUvhkMbYdK4QEYmRWHO6etlHYs bB7WRHfO0/vlp4uyrGIlLyjEhuB/AfBFrJbmoO4HFTv5nbHZVPu+iQBgy 9Vc/zf5ytqneon3Qf7fweiO1rEhDyb+VDqzO3IZpFI9MWY4vEXKR/oi3k yAklayRcGBIPqZEdBWX1hugjlTxg2yxYnBAUMGm11JJOGQReVdbtKti2V A==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="425832077" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="425832077" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 07:41:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="779453141" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="779453141" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 20 Jun 2023 07:41:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 07:41:08 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 07:41:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 07:41:08 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 07:41:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgSntjvILJLa4u2pWFsmS1MH7lo+1d+fZ8zTnBC2R/zDxB2pi0oZnxPFmawxibJS42/x5ME3SPI4GlMOHGbmTk9ZR8akFbeb2Y0eU0bj8Nq10oJplLo1hfMglKg8MoO2DlSkt2t+LqGNRtIUBJCfCwB4QVjioWoJVjP/L582VWrpwY7fazErruSUqAWG/OxwPdxGamha7Jd9wLPxwy0K7dzRFRxmz6rX+Mt9JVsy4n4yPfmS2wnLfADPDnfN5TgejzSm9nD/6ROVluKFfH8cS43PSBmPWB9iOQCSvsZ9mBKMuaq5FJe5ZxUjYHu2rhHKgcv9CDEgrOIfm/UCSZTvBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6mBYBhcAaM4MHOYAoxKUsH57pg4Mn7qmY6M6JjxHke8=; b=OUpBLedX/ZsfLtwmbZ6xvS/gS5UtQunwvvDtzwI8CdSCogyZCf48JDtbckEVbQRJ/28l1hEVVffBzY47I0m0EYIuGyHZQpYWHKtsVAgpWZeeoI3BZUuPLRVhsHMyDSAKGLcntlhPfUxDfnTv0UUl4dKkWyZhIiP5eGqoDpqI/vuTuV2QycwRPAlr890/EhwxhXIeOzdB57hSu0cRlRFhC4Elo+gXKZ+t479+T9EbYhVn/FXQxhhlEG74Fn1bPEZL8kW8/cigg1QmJziw20Wj0mccCkLGdIVXepl/5k7htJMK9eYHbTIAq4PfXKyiW7peG05h9XtE2dvj31KIjHxNHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8060.namprd11.prod.outlook.com (2603:10b6:510:24f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 14:41:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 14:41:03 +0000 Date: Tue, 20 Jun 2023 15:40:56 +0100 From: Bruce Richardson To: Thomas Monjalon CC: David Marchand , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v3] build: select optional libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <23115010.6Emhk5qWAg@thomas> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23115010.6Emhk5qWAg@thomas> X-ClientProxiedBy: DB6PR07CA0063.eurprd07.prod.outlook.com (2603:10a6:6:2a::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8060:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f19bb8a-e61d-4fe3-1616-08db719c5f14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ric8xZ1Ef6LWkf5RxmwyS1AfQIm8WbEdHHTXeSrcuIyFuVdnmlZTuJowROif4tFEdCozcX7xc9ISgqkmKQeEh33hvFs+t3a26jRYgkhrIjFNH16DSnEDF49KEmaQAGA8hKePWuIdCss6SUrGsU47TuSpHQdlaoIly1MWamxyV0D62SUyIHHaXKiLRvCEcAkSpdMEYUIjjz+mymUSQxIkNFeXwwqtb5jDfL6bNa3hRMZK9MiagRl+dmNysfthm6BrvoTAxsO0TW7vEMaRKb3nkpErsUaXXTXZ0aRYaEjBYBix2Srqe0dhvtvyk/i6XZHK8BQegOlebk+QwmJVr+NtV0btVw0QTZXXxScdiHN55gIx0V3PM83woo6CZYqMkQbt+ye8qFwqWdcsnN5WS9wMC5VKh3hCT+jAj+psjQ5QBtU+GuMWWlw6z1C/EgZK2HldPm0bsjeD5o1e/qgwfrkA+2Amsiagaz1N6WlkYX9u51O4s4YtTXVkM5j+xgkCv/rFvuJ/h7zCIltq/AzApflpp/80SWZW0uYPLHQIDcrpXRQyRFE7LfZM9WSnxMc03Fdx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199021)(41300700001)(5660300002)(44832011)(8936002)(8676002)(2906002)(86362001)(26005)(6512007)(53546011)(6506007)(54906003)(186003)(478600001)(6666004)(6486002)(66946007)(66556008)(6916009)(66476007)(4326008)(38100700002)(316002)(82960400001)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG41MFU0RVZYT3BpeFp3SVRVZW4wcFlpMlJaOFpKeWxOam1LTGZoV294MUpC?= =?utf-8?B?R214ekkwZGlWOUdjd2NuMWZhZHEvM2YxOHZoSnJEVU9rMHVIS1VtWVJxZERn?= =?utf-8?B?ZzQrNk1CajA1dGM0R1F0UXZyZXM4T2lncEhhODZpZGJCd1NXL25pZk1rV0Jp?= =?utf-8?B?eHA0TFlkSHRpYjM0OEprRjJlU2ZYR2pibDcyblBwazc1aFYvS1BkZ2F6b2dm?= =?utf-8?B?c3JSbmpiUWRyNklZZ25oR0lpVzI5Nk9NMGwvY2FoaHhYa3JDL3dNTVd3dzFM?= =?utf-8?B?UkJxNkFYWGF0TmZLaXArdU1SenVhdHFXdWIxTnNNYSt0cmhmMGpOUGdSczhm?= =?utf-8?B?c2hCSzZIeFZtd0dNdDhUWm5FZEFmOGpLUEtadmlVd2MzTlUwcFc5aXFWanQx?= =?utf-8?B?ME5CUEJEcndaSGFmMUd3Mmh3NjFmTlZwKzF5ZWR1c2NiT2F3SFBBUFAyaXNu?= =?utf-8?B?QmZkRUVKVjc5ZlFWbTZ5cmx5QTVwcjlzdEdCTFJhK3lyVGRabDVZVTVGVW9o?= =?utf-8?B?UytnZ09iRWZlSzd1L2dGQ0tTZmM3S091N3JqN2NWc09JVUJWREtXNHJ4bnlR?= =?utf-8?B?b1hzWElQY2xJVVRTeEhMK3lBQjZJcTJBbFVPUTFSN3ozb0NpMDJ0ZVVvMm5x?= =?utf-8?B?L1kxelZQVUM2SmE5YUFwMjArRVJhWitEVGFSdXB3b3NVOWVrNjFjdjZlYVpH?= =?utf-8?B?NVRkbVhlMEFhVHljUWtuNnRBbjhEREpRQXpvc0t0MHNGYTNrSWd5MGpIdTNx?= =?utf-8?B?ZUx2YThtUUNlbnR1UEhFUWM5dXhZVytaQzVKNDN0TStZa2l3WHp0KzB6bkpk?= =?utf-8?B?WFhWOTlIYWdwMjZzeXp5dFBFZkJsM01vL1Rsd3czVjczbzhvWmRBTzZicTdm?= =?utf-8?B?UFAyUHIwYnpjM0p2Nmtrc1ZFMjhoZi9yZGQzcnVPMjVoaXZ0RnYwTHZ2ckUy?= =?utf-8?B?QkFwSGRaZ093NHhVamt3ZjNsOGt3VEcrSmxvOCsrd1ZyVlJycDlYNTVYMUZR?= =?utf-8?B?R2lFQWt6cVZLZTkzTGNlL1NveXRnN2tRQVB0b3JyMmdTcnZ5M2hJZDdrbWZF?= =?utf-8?B?QzRIazA1OGd4OWhQUFJZM1luWkpmUFpGU2h1T3FCVkozcVNSUjg2VllWNWxT?= =?utf-8?B?YkRmMDA2dDJkRG1sOGtaQ2dGditPQ2lBaWQzK3IzMG9JKzVkSzhhTGNIWVpR?= =?utf-8?B?WjkrTjNLeDhsbzRSRWZmaXpMSEFtUlJQNlY1Sm1uRmgxc1ZaZVF4cUU1UWN3?= =?utf-8?B?THBtTTErZzMweWx4SEVPcHVQZGdGaWNXSkU1bFZuMnZ0YVBmSlJJRnlVYWdJ?= =?utf-8?B?MldmYnNJNXZGdERGbnNIbUNLckkxbHhkNlN0Q0tHVTdYZzdxOWhxNVRMT0o1?= =?utf-8?B?QkZkY0MwWGZ6Nm1lTlZGUjJJUFdNRTVnU0IvVThQVmtOL280d0ZrUm1wbENN?= =?utf-8?B?SDh5djhWL0xlQWxpK1dFK3REVTI4aTdvZmFlYWxtdDNrRFVXOE52eFFNTXI4?= =?utf-8?B?YldxbzVzbVZCeCtVTFlKMm0xcTVRMXYrVm5ROFRJY24zcjlhZjc0eFNhLzkv?= =?utf-8?B?WGlIN1NMbzhKTlY3SGxaMzVLZ29PZ1NrTjNDMkM0SGwwRG9RY2ZMTGpwOTNm?= =?utf-8?B?clV4T2J3Zm5xNC92L3BqV1VkdWN0ZXBKamU3NVJtRGlMbFY2S1IwRThyY0do?= =?utf-8?B?THdzcm1lQk5CRE01dWV6blRMTGRLUzI2dWJpb2I2VDFLUjA5eFplYmlzdEhK?= =?utf-8?B?T2MxcXFkRmh3R3FoWVI5Zk43bktMUzFvQlZJRTZEUzFnK3ZCSzdrN1VYZmVC?= =?utf-8?B?Y3VzTjFZa1Q4bjFLRGtrN3BXVmpBWTF0RTNrOTFTekV5U0c3U2pOT05pdGpI?= =?utf-8?B?UlhPQUZqK0pLMlBpNjhMNGxBSUMrcmJQVHl0S2J1ZGQ0a1JEKzFDSzVkc3R2?= =?utf-8?B?cDZFbmRTWHhteW1FaG9KRzBaWkIxNnRHVnMydFdnaEJ5VkJCMlhaN3hURTVQ?= =?utf-8?B?WXJJOUlDMDl6S1ZzdjNwRG9VQXBrUGU3U1BYa0R4N3BpMzVlUmNzL0F6R3VS?= =?utf-8?B?SmIxci9jN2ZGOEV0MkFJb25INkkyRFhET2FqYm9yeHpvUWJWVytrU3Z1OHdH?= =?utf-8?B?Tkc3d050L1IzRVpNT0EwUHVhOWlMb3ZKbnA3S291bmZYbVY4STBzMm5BOHZU?= =?utf-8?B?N2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1f19bb8a-e61d-4fe3-1616-08db719c5f14 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 14:41:02.9642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kF66a2GjegMTbKGovn+PNZZRYdiXXoDPVYbHnQaFLliQuRazC/H7LGM6jZ/c9LJhhkTXZ2b3RXFLAyFhlRG/xnMjPYzOk9wRJRQJmM55/IA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8060 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > 20/06/2023 11:03, Bruce Richardson: > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > > wrote: > > > > > > > > I notice the change in behaviour for enabling the deprecated libs. Is there > > > > > > > > any other change in behaviour for current users? > > > > > > > > > > > > > > The only change I see, is that this implementation breaks enabling > > > > > > > deprecated libs via disable_libs. > > > > > > > It may break existing developer build directory and maybe some > > > > > > > packaging scripts, this is why I am a bit puzzled. > > > > > > > > > > > > > > Relooking at the disable_libs option current implementation, it seems > > > > > > > backward to pass a disable_libs option when you want to build some > > > > > > > deprecated library. > > > > > > > It is more straightforward to request building libraries via > > > > > > > -Denable_libs= explicitly or -Denable_libs=* > > > > > > > implicitly. > > > > > > > > > > > > > > But again, we may be breaking something for people who relied on this behavior. > > > > > > > > > > > > > > > > > > > That's what I expected, and I think that is ok. I just wanted to check that > > > > > > the change in behaviour was only for the deprecated libs case. > > > > > > > > > > Thomas, wdyt? > > > > > It requires some release note, at least. > > > > > > > > > I am assuming this is not targetting this release though, right? Assuming > > > > 23.11, we can put in a deprecation note informing of the change ahead of > > > > time too. > > > > > > I was hoping to get it in this release. > > > But I am fine with postponing and announcing the change beforehand. > > > > > Given the fact that we are likely changing behaviour, and the fact that the > > deprecated libs makes it more complicated than the drivers one (since we > > have always on, default on and default off cases to consider), I think it's > > best we don't rush this. > > I'm not sure what is the best behaviour. > I tend to think such options should be simple to understand > with only 3 cases: > - no option -> default > - enable option -> only core mandatory and listed libraries > - disable option -> all but the listed libraries > It looks simpler to forbid having both enable and disable libraries. > > Would you be open to change the behaviour of the drivers options? > Yes, no issue there. I don't see a problem with disallowing having both enable and disable options set.