From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 986B142D22; Thu, 22 Jun 2023 10:50:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85D5740EE1; Thu, 22 Jun 2023 10:50:27 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0AF46406B8 for ; Thu, 22 Jun 2023 10:50:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687423826; x=1718959826; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=070l58Prn1oGBZSP54Pl5hM/gLAaW07wEzdi74Y18hM=; b=UTXq1nNa2/vyOtr1OEjdeqcxFDSKvpUeYkXRdUcFM3BELrqpxH/1v6no KB/Szn1tDt2UQ8slaQOCK39rQFrgDl6YHjB/TB0Q2e8ymUjd6HwJbEisV RSysn3kUsUnaLvhwCVg20A1IYbl1vNopRh6h4rKnw9T/FSXpC6JBrQv27 gT3zOKzx8wLSsyV9lrePSIXgpmOpqqBgviOIS4OZg0MtFpSsUaG6lIrHQ uwTO7jF6GuTghWvspZa51mK4bJ9CKaVf7Ubr2aAMLF/uoriUFhV/d3NqX yuJ8rYU3qTMFMK22tQLzrMvVMnUIfbqDoMM0ujRHP3MOH5DlLvuZSYLHN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="359292318" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="359292318" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 01:50:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="780147377" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="780147377" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 22 Jun 2023 01:50:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 22 Jun 2023 01:50:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 22 Jun 2023 01:50:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 22 Jun 2023 01:50:23 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 22 Jun 2023 01:50:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oBhd9DtY+ivHlxlRn4mcLVGyUmnJp2gOF9EQDrUhpu+qAQ+B9MBHTS+tYbBgSNinj31iLczZB5w8u/HUs46SfrQrOrZS4OUkrq+r4snqDs3cGFCJPvZY9nY79bn0+cfiMIjA4BShHK6WYG7A71QeAfBNbP6y6HvsBz5TtqIae76UWiRxprg861cGr4SnpdNiksU8N9hzDZpevi2s2aAsASjEgmiu0YNDNL7p6TCzDonn1kapDAEro7/1nvoRvxNnkP7qkgIAbmZdI0ietPWtIuqVS3e0r0OW59dMswP91XsY1Zyyknt3t0oKhPW/3JsoQR6KBtGQVFjTWgar+2KahA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ir5nmzSf5ixpdyC/X657sm8VzARc2/amyFAzDEsMOMI=; b=aSMjrjIMX7dp7nmqDwD2HAnUWJCsWqXPuwLFvkeNQ0jnl7fPDDrKeit8OnNTUkwo0R05U4QgAZNPIYUTCJOK5439DGyl8ZNROTSvTkN4H7Mbd40llj4tY/Q6wLD1CEfVDdmIbGA2SJq5wa/+O0dBUOgFDerv27Y22QuqsjcrfNTwulfHUTAxJ7pXavbgoQQGOJGFwpIlFkR3+WOytLZdYJ5S5Os8vdMPQC/zpGCJlIncJiyEnDQSMaetV4NjPP7igawBtHb3GTCEGVm8GGwnRcwMvVxVXYBjPfhIhg9/CI/UMdyQ1gK6ANhGsHlMZgYFg2RTMqP1UiD3t6m+JuNf/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB8377.namprd11.prod.outlook.com (2603:10b6:208:487::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 22 Jun 2023 08:50:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6521.024; Thu, 22 Jun 2023 08:50:19 +0000 Date: Thu, 22 Jun 2023 09:50:12 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v4 3/4] build: select deprecated libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230621170058.2740340-1-david.marchand@redhat.com> <20230621170058.2740340-4-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB3PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:8::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB8377:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a5377a8-9c27-450a-01e8-08db72fdb50b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8RjrIXSmV2DS3RJnaaAyTzc85RMmKv8LifDVG/jvg2lhgQ38OJ7sI38WG/DS9bTB3qe46jckoiQnJxzzlg3rSxy06y65XuA37npPkojbE7T2kajwauLahDHg2GGfr3nczRKmbA/xIwybr60QiEkck+xbpAJi9rempUlDOkx/UypNX+8dIZxjPdhBsI9VCf1quEfWk5Lr7wcX3RvbbrNwVX8Pqfq2946IgIDe75KkGBNAOe8nm8Wwl9T4M8b/pgLZQIYkc0jtX65U/OggJ3MoOtHUPlLtMLEKIR2H1WgV9UGzMExF2AFjLuZlgvSVdK+IXN+g6kLC92WX3OBQPsfBZF6lZupeuwvufYvOFhNJNkfSWlQHw8Z4u5OY92x309TOuDKE4kAfqRQdeq1sRLRie2NtCitaoQHwXJRHCXfyHGMO6OpSuqWD20o7jehi+FCMpPfEJF/5QjZaFaefMhWCHM61aIBCD44+J8qhEUglRtjF1lxl9T3iFPjL6EdMaAAcwMfbyyXSHh44Emhx5ZjeWYgblE6rFxsTUrBd7HWFztO+askJsuKcIJ/+WIHoRS3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(6486002)(6666004)(54906003)(478600001)(82960400001)(86362001)(2906002)(26005)(186003)(6506007)(6512007)(6916009)(4326008)(66556008)(66476007)(66946007)(8936002)(38100700002)(316002)(41300700001)(8676002)(5660300002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/XNiw5y0IKgmBDIJvNcDt/1Nq84MCv6TmL9UCcgm920aTR1ZMCt8F5qaCvnf?= =?us-ascii?Q?+BzDDINxeQau+dYG42DQIeiSc030ZPEOZw/r3EjfpNjtSDxlQI+n4xIKIE3r?= =?us-ascii?Q?HcgEADWqv4BuMmLDF6qhdyoV1Y7WoUwUDAhl3LVlX96/duvjTMCSNqE7Mvp1?= =?us-ascii?Q?He24jkoGLxnCi1TOsHMGE//DlUYOhQOJKVPF411ZjdfprKmudjYiVCtfWb6f?= =?us-ascii?Q?iufHmK0n5kxZOSHkVWtwWTAP6cAgTfM3dZMEgu2aGWICUd4tRCrddPLpTcPL?= =?us-ascii?Q?BmZXJH8yAFpQkod67FLxxfLpNdF6g9Em0rh8Mn3LLVw8eyH6VhZfuyjr538N?= =?us-ascii?Q?BXvXy9mZWl+Qv4s8XXUzF2Z0r9quyTYB/IyW7k5eRRJnddvfXNVJ8U81SuuU?= =?us-ascii?Q?FPYd7GniSf1l1hg+5xy1V4FSeRtX9BjdJBgLAmZa7gvQnBcg/WIHFqpt3IAG?= =?us-ascii?Q?YW0M6bGGUTwgTYcq3FA4HjDn4GdffjcvUbYE4iERjFar2jjat6wOZMstkYoS?= =?us-ascii?Q?YNtsk3pk01662MQUTb/44aVDePTNS2XH9QSPy1B8Cjtc5JVTlX+yVZN9MvXc?= =?us-ascii?Q?MVWjbI6eZfV3GY3+m2wvI8jGZkEDc5ydrtPw9ShaQWwNhBpRqmGuL5PnrSfJ?= =?us-ascii?Q?OKKr/AOeoNw5/NarNBBpZWFv7qEwye6gYw8PKQGX1SbQqIZT/c3QqdATeK8L?= =?us-ascii?Q?HQOtqcxSFestM+wjOfRgm3kM5MyuXkMbcd2TniSj6zbAW6/06BctdavfTmRQ?= =?us-ascii?Q?uNhgNr1Jbidt+LZR93BvB2MiYUKs74emQ7lqDegMp7xhvvsA9PWIp2yNDRFw?= =?us-ascii?Q?CtXwxac5AlusxcBLrFKhfX6U/pbl9mSNTxKpAXocU4vdcuy3+ArTVbwpyiwA?= =?us-ascii?Q?5Q4Dj2F3zVy6S1RVkAU13ePHrB2Nrfq7Kqu0PAERlEo7MQ5fRSTvjzezVGce?= =?us-ascii?Q?ctajoHHeKkBsR95UDj9Wuy2GX9Id45IKdQ+DfvQkDqa/+97i7wEj9I+HzmO9?= =?us-ascii?Q?PSGUaLkbRXvsHV/n7nSsX+rssea4P6KSBjOXn9qv39ikYkhlxL+DksSKVk95?= =?us-ascii?Q?bT9iQS4Z9hLiGLviNBv0CBI9dZj6QlfxE1a2TZVIxMpb3SJOU9Y2JXGjoXKY?= =?us-ascii?Q?ZEhX5zL13/i7bt/o1fd6nsl87YGEveFvu/MIGbhdabrPmlSSqESwFuVU5BCh?= =?us-ascii?Q?P10BYO23Fglkz27RJenTs5hAtG5Oe3AJ18Yuvd5MjYIUeNRZ10qmq9Ej9Mfy?= =?us-ascii?Q?Gn8hB0uFD0owkWsklWJverrsruQ9SkdQlQSQL1RkLZXC5x9xLICCj0Sn0uNc?= =?us-ascii?Q?hBxE6Htu34/pYDMte5RijfMiFeWQeIGQl4u1XzBnWcu4A/emG+vnLOZGdrqI?= =?us-ascii?Q?8A2RvGOrCij6GEdxLdJiws1ctTsrJ60P1dOJP1tjiMClemi0Su5WdqHsHrub?= =?us-ascii?Q?fAY8o4ZOqdrSE5gycAbndpYzeUZRi1Ax8Gr5fHCRmvWnYePAFecImb5oj25W?= =?us-ascii?Q?LxakT6PlkW3FO5pW8jy45IQUagVYaY+Dr8FERjxEB6SgUaln4VmhWEB7kFeO?= =?us-ascii?Q?CokDZ2J7cRoGSJsWA6EtG5M3krJcCupn2e1/f3Dt3mYpsuh41wW5dMx3fbdA?= =?us-ascii?Q?jw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5377a8-9c27-450a-01e8-08db72fdb50b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 08:50:19.3953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WqtU5+DGnALYbEt5ftw2qxjJvWkH86Ce2Y0DnQY5s6hRwxxZVss8fYjqh78wPRmNYA+QU6P1N8+hw9kDGki5JNSGmdJUXzKm+eMBggdDgQE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8377 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 22, 2023 at 09:43:18AM +0100, Bruce Richardson wrote: > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > Rework deprecated libraries selection by introducing a new configuration > > option. > > > > This breaks existing configurations that were relying on disable_libs='' > > for enabling deprecated libraries. > > On the other hand, it will make enabling optional libraries more > > straightforward by taking the deprecated libraries out of the picture. > > > > Signed-off-by: David Marchand > > This gives us a single on/off value for the deprecated libs. So if you > wants to build only a single deprecated lib, you need to turn on this > option and then use "disable_libs/enable_libs" option to then selectively > pick which of the deprecated libs you actually want. Is that the expected > behaviour? Just checking that we don't want this to be a list too. > The patch is fine itself though, so: Acked-by: Bruce Richardson