From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE37942D2F; Fri, 23 Jun 2023 13:19:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 377B142C4D; Fri, 23 Jun 2023 13:19:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id C2A8C406B8 for ; Fri, 23 Jun 2023 13:19:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687519152; x=1719055152; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=t+vCxtBazMZxuqg4IF9S6dBZrqZT9CJ5waBu6sMo6KA=; b=bPLk5gKHgz8yB4zvnKykYPGcFzZAkK/QSht6T+9XyRDArK9lcKxbACBM nltXhwPoRu+OJNlV4sUgxf1pIIyIe1+WnKXAkRuqiS4EkgiMPNQmrFvuO 72g64Eu1KeVKbkxsn+8lT1ueriTJz2xW3xxOoHGw2f5YgWp4OmEmp3g5c +cTq/8DUnBD6ZCxo95PW9Tuqu4JubCBfO7uacGht3mW4ZJy/Sotu0CkN9 QOCoHni2BDG0xiU+1h7ycSjrVUvZeZiDcxlRJuWKeP7sSY9VIb6TDYxVw ucGM+uzt7ObVmgMxPQXCe0B87Qdz3d1Es9E4jWZx29GuALKUYups41wgp g==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="360769666" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="360769666" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 04:19:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="692638853" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="692638853" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 23 Jun 2023 04:19:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 23 Jun 2023 04:19:10 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 23 Jun 2023 04:19:10 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 23 Jun 2023 04:19:10 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 23 Jun 2023 04:19:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ab9zLksWhNi+xlsWn7pQnKq/FYE/yNF7qMf6KfibtaroCQ+RdpofPhOIXBV5OAyVtvv8NbtYtdrer3XOCpbcBeKNDTPHm6sOEVnDsqSFNuE54nAUj1rSIe/0G1mzruftEQJUtYxqvXNx4SOxonQbFI430aSb6Y9CtVCBdWlP01wfd80A6PC3iPyld4n7RdkB31kN5Hrsh61atdSVGAaL97jomV+mmDaOYzF9XUZ80t2lQaeVPZD1Z/2M+1B8AWki9AgaNMt9rjT1W8VhL3PPSVXAJT44tX79aLj0mA6JxLQOjVQMaA3htZFD22rNNVoGThvkmy2R84lh1RTRDtJIQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IKuk+k9tqnn94idZN0+Y5NxFo4Om6P6W+PAZ8bkrR0A=; b=MReYW/Q/8spAMWXLPqda5sWlhqtk2pKHOJ9d+i8+nkCuIgeoiSb6Z1KIB0yJTTgM35E1FaS/5CztA3HvwD2ib1zJH0RN6cQ84V1ZOsu46bg6Jpe3Z48c9P6ksZkwqR0gQs5AfiRTICKTrJnWbi0MYxJp0iu5ROYiNhH+Kj1uFYNQeUfBQ5EK8Nq5kNthqHOpJpDEg57YoV5MHXr4GJ5HmkDzgwSTIf9hmVAi5eYMP90VpdtT7ZN0BeRgaUD3Mu768t7mkPgLnFV4fMznHHUFkbDyhJSlyaDMhzmrMYTRh/hL6tQLTJHnuBHeHD1IAG6sn3BE+kB7Ew+ydu/KiHFrtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5356.namprd11.prod.outlook.com (2603:10b6:408:11d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 23 Jun 2023 11:19:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 11:19:07 +0000 Date: Fri, 23 Jun 2023 12:19:00 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: David Marchand , , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v4 3/4] build: select deprecated libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230621170058.2740340-1-david.marchand@redhat.com> <20230621170058.2740340-4-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87A0A@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87A0A@smartserver.smartshare.dk> X-ClientProxiedBy: DB6PR0301CA0072.eurprd03.prod.outlook.com (2603:10a6:6:30::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5356:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e1f028a-e95c-4cae-6117-08db73dba8f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bku7JbjCPIPKUEdE1ETM0I+VKp2E5PXYw1wiTnyOFROTtaLaLTBPoVt2L81iwDe4f2NFqswRR0iomJBN0ws0j9U0UkuiHttSFWmxe3ZzfxYVOnvLzO57ginBcCkoiVszPbhjab4FSKWJSEYKPZmC7St/pSDgyvKYLBCvLQXHL1Zp6CU576gzCDtGVFNXMn5OTrevadyFBCySSaB3m5cJ0tvvpRmyxA4+mqrL9gvT7EuxFXyipWuQvcQ3BnMb9kvh6prL7CJwZZ4dcIgy5RpEX4gnnUHqhIZyqCPl4bFT/nA7YmQ5j2w/UQf2HjLc8fVD/GCQxCIQoAW08wgzs0VYAGiouh6VLUpZgd4ZJxPpWxWdCb+CWJZoXeTqmJnV1+r36k8Wrs/vP9QCk3Ky3efaV+3XJU0GDpmZyidv40wsPB25hbZhBYohke38wi5AK3+XIVJpuk8oTysjbP01yzsvDUEo4aATqoXPLR0o9VtDmPz4lMmGwDhMZ74vvhwtKaOdquKaBCIHhDm3kdxBCbvV/RFhWgR4CmWMV7vX8Khk0brwKr5D2iEtZn0hjglwpSZG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199021)(2906002)(6486002)(82960400001)(38100700002)(6666004)(83380400001)(6512007)(53546011)(6506007)(186003)(26005)(66574015)(41300700001)(86362001)(54906003)(478600001)(316002)(66946007)(66556008)(66476007)(4326008)(6916009)(7416002)(5660300002)(8676002)(8936002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3VTaytwMnBrRFhaUjgxNnNLWlRMK29zR0VkTDFRTE8xQzZveUFkTTFmTFpI?= =?utf-8?B?NWl0NnR5MmhtRnB4V1ZQbStVQ2pWVjdmcnRxTERMdGp3TFcrOW04bzNkbnF6?= =?utf-8?B?M25kem1Qd0tlckR0NHJKZVk3bUhZMWlRMnEzcVhCdW9zN1N3MFVPOE4rSGZM?= =?utf-8?B?V2grQ2JlajNFQkVDdFRtRUNSQUpmZVhUWWlnbmdCRkhOSHdCUUc5TzNaSHZG?= =?utf-8?B?RksySVp1bGpJS3QrVGFXWFc2QUlkQkNxeGxGTzQvOXpldzZVL2J2RCtEanhl?= =?utf-8?B?cWsra0ZMSjNuVG56cHJCK3VxYW1QZUxDVThLbnlic211Z2JIaGRlUitqRkQw?= =?utf-8?B?REpZdUxDTFQrVjJPd1ZCa3RDV2x1RWdhcVczc0VienpBSWtLaERyVmNjNnVR?= =?utf-8?B?NjFrVmI3cDYzL0owUVcyVmlZdHBwOVQ2dHFXLzdNYy9zcjBBMTY3alpsU1Fh?= =?utf-8?B?L3VVOU55Njl5SnhvZlZjVkMvMlB3NUNta09RSWZyY2x2MFYyVHNrN0hGV1pG?= =?utf-8?B?TlpMQTlYYWVlR0FIY2dyaEthdHA4aFByZ1VxeGhZcGN5MExIclplZWlFS2V2?= =?utf-8?B?YnlvUys5eUhaSy9SQ0hHVEZCZmdieHluUStzQzQ0SGlBOGdCY2lZYzl5WUkw?= =?utf-8?B?ZDIxMW5jcmlOYkJSdEVUWGZoUGJ6WGttb3RWYTNPbDlrMEpYS00zYlA1NXBq?= =?utf-8?B?dXNJd3U4ZHlZLy9PNktCUGNXV1hid0lFODdyT1VmOUlvdTFZdWF2VDBac2h3?= =?utf-8?B?dlFHd3BlWTZEVmpjK2lmeEVZUGxzNTJUWnlKbGdYRVdhMjFKclFmZjJYNWYw?= =?utf-8?B?bldHaWk5bXVaSGFmWWxwWk5DN1B3bE15d2czQXRqUWNWWHhpYU9pelNhTGhq?= =?utf-8?B?N1llOEgrWXByak9SNWViKzdtODF1eGs4SkpjdTlEMFJGRk9TSTlMS0laSkR6?= =?utf-8?B?aTA1dHI0WXJwWk50WDNXbEowckhxSm5kcDJpS24wM2U2Y0MxNDIwOTBpKzlZ?= =?utf-8?B?T3BEK0JlaVRUVEJjczNKWWpCWFNXK3ZjKy9VbHBnTGlmMEZPdTR3dmhKR0hW?= =?utf-8?B?OFpOTWg0c1BwMzJYdjUvTHoya1ZHdFRGWVB3d1BmR0pmTHlnSmMvQXlzSGdq?= =?utf-8?B?UXh5UnFZaTdKa3lsOUZOTW9vU04yZGZhSnJ1aEZFQ2ltdmJIeVlXNkZLaHRa?= =?utf-8?B?RVN2VGowYXQ1azdpMkE5bVdTOTBzeFhWY3c2SEIrcFd1bzVWa3ZqdG1HdGxX?= =?utf-8?B?K0JvSytFM29kVHZUUkNhL1U1MFplTERDa2lnYzBDTDRyOFhEQVllSWZVeGVT?= =?utf-8?B?VzI0cnVlUlZRT0lxY3g1ZHlSaGJiaFRRN2ZzTGxaN2RnbDhURGtGUUlWVWtH?= =?utf-8?B?aFNVTWhrdjJhbGsySFZPeXFaZ3I2V3hibHhNWkg1bU9Lajd5Ym4zNkUvckxP?= =?utf-8?B?VFNkRzdsMkFlYzBVeVowSWpBSGJJWUNUL3kwWUluQ20rRVhUZURxUjFqZEty?= =?utf-8?B?UituWGp6MXhSbEZxUXhwZ1RJbzZSMVhUWGQ1dG44dTdMbzNoNExTeWFmU0pl?= =?utf-8?B?WkdRWFVseVNSMmFTc2FxclovZ1FRUGVwb0V1UFVsbUovTGpTUlEvUncrUGFM?= =?utf-8?B?aE4rZHF4ejdiTlRMMFdwTkI0ajBjc0hDRlN4c2F1bjJ6WVR0QTAxdEVYL0ZH?= =?utf-8?B?QXVrd3F0NmxscFd3elVPc1BKUld6UGkwbXJ2OU5BbjhYMDhueGFVdmN0ZnJz?= =?utf-8?B?NUxXNEMyWHVwRDNGeWtxNmpyQjdVRU5tTlZHK21LNEkwemRLZVozZHJsYjZM?= =?utf-8?B?dzhkdzA5MU9vWEtlTVdsOVpxM3R5bG1iaEFXNkJPRE43UkR6ZncrT1Y0QXBh?= =?utf-8?B?TkZhek9xeGdaMjJkSlIxTVpxSlNHbXpWbDNlUFpLOXMzVzFqanVFUnZxYlhO?= =?utf-8?B?R3JCM2RLbE5DSkswUnZ4dm5iVFdiTGZqb2RrUUlOU2l2UnR4RG9lUGpNaGV4?= =?utf-8?B?MGJpMCtUZms0M3F0RFlLQmFnNmVxUHVuc1pvdUtCUHM3cGN2QnpHa21ONWdt?= =?utf-8?B?eWtGS1NwcjNrenlqRVBPL1FJNFVOenVBaE8rcWVSb0ZYTjIvbzNJeFVhc3ZT?= =?utf-8?B?Ulpkcmd6eFNhd0pQa09oUDhES3kvN3FWTm9HSVBHQ05vaHNVK25QL3FGTlNV?= =?utf-8?B?M2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e1f028a-e95c-4cae-6117-08db73dba8f4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 11:19:07.4755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MDQfEGqtCsPE4JCPSFra0hZKicci7ttEqHHKDJOprtuCOg6/LSpzdOAm+P4hLofYZPuz6M9UOIZorxWWr3LrApKerHgig5nCqkf6/F4ZhWU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5356 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 01:15:00PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Friday, 23 June 2023 13.04 > > > > On Fri, Jun 23, 2023 at 11:35:29AM +0200, David Marchand wrote: > > > Hello Bruce, > > > > > > On Thu, Jun 22, 2023 at 10:43 AM Bruce Richardson > > > wrote: > > > > > > > > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > > > > Rework deprecated libraries selection by introducing a new configuration > > > > > option. > > > > > > > > > > This breaks existing configurations that were relying on disable_libs='' > > > > > for enabling deprecated libraries. > > > > > On the other hand, it will make enabling optional libraries more > > > > > straightforward by taking the deprecated libraries out of the picture. > > > > > > > > > > Signed-off-by: David Marchand > > > > > > > > This gives us a single on/off value for the deprecated libs. So if you > > > > wants to build only a single deprecated lib, you need to turn on this > > > > option and then use "disable_libs/enable_libs" option to then selectively > > > > pick which of the deprecated libs you actually want. Is that the expected > > > > behaviour? Just checking that we don't want this to be a list too. > > > > > > Yes, I wanted a single unified filtering stage. > > > > > > But I think your suggestion is easier to use. > > > > Slightly easier for the simple case. > > > > > > > > - That would make it simpler for people who simply want to enable kni, > > > as you mentionned before: > > > $ meson setup plop -Denable_deprecated_libs=kni > > > > > > But I would make this list not overlap with the disable/enable_libs > > > options evaluation. > > > Otherwise, in the case of a enable_libs user, the user would have to > > > set kni in both lists, which is not that great: > > > $ meson setup plop -Denable_deprecated_libs=kni -Denable_libs=kni,vhost > > > > > > Instead, I would make it so the config is done as: > > > $ meson setup plop -Denable_deprecated_libs=kni -Denable_libs=vhost > > > > > > Is this what you had in mind? > > > > > I'm not sure myself what I had in mind, just asking if it had been > > considered as much as anything else. > > > > Having them not-overlap would seem to be necessary to provide a meaningful > > interface. > > > > > > > > - I don't have a usage for this, but if we go with separating > > > deprecated and "normal" optional libs filtering, should I introduce a > > > disable_deprecated_libs too? > > > > > > > That would give us *way* to many options. I think for the sake of simplicity > > we probably are as well to just go with what you are proposing in this set. > > Since we only have two deprecated libraries - and hopefully never many more - > > the benefit of the list for that setting is probably minimal. I'm keen to > > avoid too much complexity if we can manage it. > > I strongly agree with Bruce about avoiding too many options. Here's an idea: > > How about just having the disable/enable_libs options, and by default omit the deprecated libs. > > Then, the deprecated libs can be enabled by using the enable_libs option. > That was the original suggestion and implementation. The trouble is that if you specify, for example, -Denable_libs=kni, you have just disabled every other optional library in DPDK, since the enable_libs option switches DPDK to "allowlist"-only mode. > Do we have special treatment for deprecated drivers? > Its the best solution we have come up with so far to work around the above problem. /Bruce