From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 714C442D2F; Fri, 23 Jun 2023 13:04:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B2D540EE4; Fri, 23 Jun 2023 13:04:31 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DBFA140E09 for ; Fri, 23 Jun 2023 13:04:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687518270; x=1719054270; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=OeEg++WdT3RQmpYl4t14iuzr2zGgv3Gk89JRxtQW5bo=; b=FvQ+A4rzX+XsHnQ730wf5aS962viVWYpIoanZ3Z5Cn3Bx1TWCwiyu0mL oEb01k4fND2EEmMaiodoHycksMJ7IHVx6CaXik903v8RWOQCfY0wyBZR5 j6lV84G2o0fQDAl0qaqmfXuYwrjn+IzIBnzfAh7PIrOgGrH9ZqpghlCB9 OAmNg3G1IGYaOwTQIcEpnvqh4uVS29We5tEUa4ffH9vLlijbyu4McDDzL 4y+TUuVaDmzkGbHmSG87k4kYLmdOtGgVKN2DvPDNjDzshP4vbT+Py1omv WUimEHsD4ij8qVdJj/ldmGloazhfVVWrfDHF9o5qwHVlS21tLULybxzuX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="390697258" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="390697258" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 04:04:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="805164557" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="805164557" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jun 2023 04:04:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 23 Jun 2023 04:04:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 23 Jun 2023 04:04:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 23 Jun 2023 04:04:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoSeQRIQ0QeTa8clgchfz06BpYk+rbwmgA+cZrTFDoFkyiCZTI+iDX3w5FQ9QdxbHIXh7Qvb55dDGqvqBmrmy7dJqw3dnFca7GtVmxzd6eC8KnO/E75JrWsCBKPnR6Hb8/ZATakgickgLIQQwqV9PShRY2vATgkXwtY/XFz1gWLHjzd70vZV73P4bXZ+jl0lwMaE2zDuCT4hDciI8Mh0eWoeDIcEX0leiGsnnyrdGIanEyAj3LNEN9mSDSLQgd9oSN+h70jo4qERnQNyqR2NAX/2oG1ygAhIgy9oON8q71BkG421s9V431qyxXB6aOv9cf5IKz59YCLbGNBlsB/72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFT+FbljuhLxuAarB09kTpOEWTup5XVnSuld5zvBigk=; b=L3sak6/vG37IoIy2pyRho2qssDjVE444P6pzHwC8yGW/ZaPpcT4dJc3BLen6eObyUCoph+DW6+Tt6EMbOIuYNZe+eOFGgFygEO8ejaW2DuKsnYNTKPkb+UYyJnSvo9pzRe2T/Ot5AC14MDJpC41+HRdn6AvKb9Me1KZKy0X6hXZg6jABydbJNxD+ujSMUfic5jAkfvsRxqxOxyafq7ul7uu6mbUmQCAPoOx5LEcX61yN8m+S4GQJpFw2gXJaIhFgJ7NB1EeEQ3dti/N+Q1chceLWXh0WkJXVo96bktBQ8zJ95QFbWJqDgzeE987YL8HTcrg4NKbRHaquS3I2R6wTcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 11:04:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 11:04:24 +0000 Date: Fri, 23 Jun 2023 12:04:14 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , Aaron Conole , Michael Santana Subject: Re: [PATCH v4 3/4] build: select deprecated libraries Message-ID: References: <20211117112847.7362-6-david.marchand@redhat.com> <20230621170058.2740340-1-david.marchand@redhat.com> <20230621170058.2740340-4-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:10:110::37) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4981:EE_ X-MS-Office365-Filtering-Correlation-Id: 340c7e3e-2e6f-44bc-5ae0-08db73d99a29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YshsavU3+m7IKhLpAqwYxzsLWH/LEsi5x0vuPT6f4Wn7uBdIyjhk63PrSDJTmjnFV/sngZeh4ySJl165WWUyqNXYB44wH9ZxGJU55Nfhg6YE0Lx0Mb+ZuJgxOksqe8AKKxVlGCcxfh5yenw/MnTbg1A+5GUt9LIvTVZ+KM59+wrgNrSXeD8gzB3Sc1soKJKyikuzBeDLcOhFo8ct6cezfmdgfPViXBlrHVOfMd8nP1UfjdUAAL82Q0HzczvOKvVv+c9dAHLMPqQwkJKT5qty0raQBYLkZuVZbaVYxNlE5BmOaghG4EnHR6784n2JFRCMxA6KoIYsECNRPqU5imnktVbBR6AjlwYL4V418GyqT+aXKYWL/RIjB+utsXwiQHtbZbFD+vsfDTgA8qnpx/CYUaI+BR99UZQhNuPk5Sqx+02glZ3EEyptHvagYW/SAwIGqPHD8FFYtTb82ahhlnEJlMfCvqA3w48eXytHTSYppt10rPwshn7+0+clrV/KE+sya0bbmkc6LTB0rC5nX8wgqvnQprm3lX8/8p+qEfEt5y7xfKmAHYV1NPGdkt0CQYZN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199021)(186003)(26005)(6512007)(8936002)(8676002)(41300700001)(478600001)(38100700002)(316002)(54906003)(82960400001)(66556008)(66946007)(66476007)(6916009)(4326008)(6666004)(6506007)(44832011)(6486002)(2906002)(5660300002)(86362001)(53546011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnhERHNRUHFSUHZDSkxVS1dSNTlZclh5VXQyZ29Vc1ZoWUhnKzBpamxpaThV?= =?utf-8?B?V0ZhbGZwaFBiRG90bDRGNStxZU0yZmpYY1pRczJZMlp4V0VnY0RPb3ZMQSty?= =?utf-8?B?ejNwUnVwRGNkNXc0akllbjljdnl6MXpEa2h1aEFxcStzNUhqY2FEditteFpX?= =?utf-8?B?UXZYcXRxeWFSYXNmc2VNcDNteWliR0NPTUg3cFYyVjFBNVdWejFNTXBWYW50?= =?utf-8?B?UWw0ZzJlNm0yMTArOFh0S1VWYkZjUEw2ZTJQbVg0YllEbVpoOTJSczRTcU5W?= =?utf-8?B?Q28zL3Rkcm1uNjJNc3F4aXFVdjRKdWdVenFXdWQvaXF2aEViWU5oZHRvTXll?= =?utf-8?B?YWtCWWZxOVMxQUx4UEUxUVlvbTlkMTBqSldreG5EdUNjaUZDRktmei9Lcjk5?= =?utf-8?B?ME5naHBKdFlBQ0FKY3c0Y08ydjdycjk3VmZ0N2lwZ3QwbVRtL2EwZXg3NzVp?= =?utf-8?B?ajdDbFZYd0dNeHhUZXNqcGhGSDEvNWFoL2FmbWdHWVR6bWpRSlEvdVFlSGdJ?= =?utf-8?B?MlpKVml3LzBKc01oUm9xY2p6Qll3V1FTNXdHcnVnRVRQRWljYllXOWtQTTc2?= =?utf-8?B?K1VMc3Q2aUFzZ1A3WVBmcy9KdFNXTDJuL0pUOTJwSTJTVUNXaGZ6L0Z0Tk1y?= =?utf-8?B?TTcrRjFvZlA4Wm5lbUFDTFh4N2o2SkVzMC9kMVNZS2xTQUZJT1h3TE82Qkty?= =?utf-8?B?eEtnWldhc2laaGxaWTlOeTU2TDRMWldEWUxlaU0yUVRPRjlWbHZZc1g1S243?= =?utf-8?B?UUtBbUNkaVlkMk9kdE9aVC9UdEdaczJOMUR2SDlsaDYwSTFGd042NTJQZDZt?= =?utf-8?B?ajR3UkZ6REtCTmQyL2R0VFlpanJORjd3aU9FUm4xNTFXbEgrWFhnQ2R6bE1C?= =?utf-8?B?ZUFYeGljWnhVWXdNRE9YQ3J4SEhJV2VpQUZjTGtLeHJGT2hrSHdhMGYyaFJz?= =?utf-8?B?M1d4TnkvRlNwRlAvR3Y0T2NDZmVobmU1WkErWWQxbStsQmtKbnV4Y0VvV2pq?= =?utf-8?B?L09Nakd6dmsyODg4dXAzMmRJM29udmIzRkQxKzlMUC9GRXI5L2lGcW9pQjhF?= =?utf-8?B?V1RMMTFTaUdqd0xFZTVQNStqbFlMVkRHalgzVVgrd3dTNFFpdlUxamFFSzJt?= =?utf-8?B?Y0ZTM2tsNDJnT2o1VFcxclZNWHVOUTkzUC9UNkZjNjlnb0ZhN2JJdGlBTExv?= =?utf-8?B?NzVZaU5SdUNOVHVNbTVUbm5BV3JibUJSWGs5by9QSGVPaGxxMFExN2NXQU5C?= =?utf-8?B?UWpCdlNVU2tpaEpjYm8wV0IxWWpvOGxDY3JJK213elowM2xhM3VXUkZkZ0tM?= =?utf-8?B?MVVTb1ZwdW10SDRRRUlMYXRmTmZDNFlSd2h3enpBbEZ0U0Z6MURXZ3c1TkFx?= =?utf-8?B?QVBCamt2S2txYVlKcHpNRTU1Z2t5QjlaYlFFVU1xaC9zZ2RhS3FEajdLU2RB?= =?utf-8?B?V1djTTUvSE9sN1JKYUJ3eFhlMWY2amczTTFlUDNMSi95Q2dZT0VhSmFlbHNO?= =?utf-8?B?Ym85dGlkbjgyTU9ZT2JDMHRweERQUVRLSWJDQ2VhME5jTndtUWJSNlZ2a3FU?= =?utf-8?B?UzZvaVJqY2xUeVZCakt0aTRkc0J5VWNMaForTkx6Sm5uYThQaDFNZlhsT1FG?= =?utf-8?B?QnIwckhwL2Y5NExSUUdmUldaaGxpUHhNQzRrMUVuTWxXU2dSS0VURnpkOEFs?= =?utf-8?B?bzZNRHRSUEtlVVFGK0x6ZzlRSS9uSml2UCsrTlZ3eFF3WnZBWkprVVlRNGo5?= =?utf-8?B?VXkyeGQ0VWliQ1ZzLy9paVJTQzEvZTg4OGtTUjJqc0dPRExPcTIzNFJrelVU?= =?utf-8?B?UTdMaytrdVRlMUlEUHRsOWVkeEJxQXptSU44aWJSa3R6V2NNU0hXa1J1cHl3?= =?utf-8?B?SkJPVUthVG9QSzhoMnFNVmNXSmhQREE4ZXp5cUNaSURXQ0F3Vk90c2xuVTBn?= =?utf-8?B?b0V6dThlUjE1SmdxUEt2dk8yRm93TG45dkVLVE5ZQ2J5MmF4dlNYVHEvMFA3?= =?utf-8?B?UU9FVFBZMlk5SmdoTlhYdzVrODJsVC9SSGp5Q0VMcEYwbCs5MEFKejBWMXpi?= =?utf-8?B?ck5QcXFvckVMSGNBbGxlTStUNHl0a2lZWkIzZHl2bk16Y3F3MWNvQ0xZNzNQ?= =?utf-8?B?RGhwK21ROEVjVXNDcUVwdFNraWdKZmJBS2FqWnJucTY3dGpvNXJGTFlaSC9R?= =?utf-8?B?Rnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 340c7e3e-2e6f-44bc-5ae0-08db73d99a29 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 11:04:23.7157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Cj412+13HP8DQQxTKnFgLe+ckT3EBN2Q0n6g4wamaijW3k1XK/GjCnljohUoWuWDHDP+msB69fYS7eSZB/LwBkOgGptCkUYmDphhHFJbeU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 11:35:29AM +0200, David Marchand wrote: > Hello Bruce, > > On Thu, Jun 22, 2023 at 10:43 AM Bruce Richardson > wrote: > > > > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > > Rework deprecated libraries selection by introducing a new configuration > > > option. > > > > > > This breaks existing configurations that were relying on disable_libs='' > > > for enabling deprecated libraries. > > > On the other hand, it will make enabling optional libraries more > > > straightforward by taking the deprecated libraries out of the picture. > > > > > > Signed-off-by: David Marchand > > > > This gives us a single on/off value for the deprecated libs. So if you > > wants to build only a single deprecated lib, you need to turn on this > > option and then use "disable_libs/enable_libs" option to then selectively > > pick which of the deprecated libs you actually want. Is that the expected > > behaviour? Just checking that we don't want this to be a list too. > > Yes, I wanted a single unified filtering stage. > > But I think your suggestion is easier to use. Slightly easier for the simple case. > > - That would make it simpler for people who simply want to enable kni, > as you mentionned before: > $ meson setup plop -Denable_deprecated_libs=kni > > But I would make this list not overlap with the disable/enable_libs > options evaluation. > Otherwise, in the case of a enable_libs user, the user would have to > set kni in both lists, which is not that great: > $ meson setup plop -Denable_deprecated_libs=kni -Denable_libs=kni,vhost > > Instead, I would make it so the config is done as: > $ meson setup plop -Denable_deprecated_libs=kni -Denable_libs=vhost > > Is this what you had in mind? > I'm not sure myself what I had in mind, just asking if it had been considered as much as anything else. Having them not-overlap would seem to be necessary to provide a meaningful interface. > > - I don't have a usage for this, but if we go with separating > deprecated and "normal" optional libs filtering, should I introduce a > disable_deprecated_libs too? > That would give us *way* to many options. I think for the sake of simplicity we probably are as well to just go with what you are proposing in this set. Since we only have two deprecated libraries - and hopefully never many more - the benefit of the list for that setting is probably minimal. I'm keen to avoid too much complexity if we can manage it.