From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E95042D2F; Fri, 23 Jun 2023 13:08:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A0A440EE4; Fri, 23 Jun 2023 13:08:41 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 6ED2740E09 for ; Fri, 23 Jun 2023 13:08:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687518519; x=1719054519; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=OdYREBAK+xMx1xQdHRHrPllFSCHpfpy78HEvznBAKOY=; b=IebWRQjucnhwagCJlmOhtOzQbe5AFVjCV8LMu/CuAGxOSFWYQ7Y0mONK 5WEM9pdUnRjgE72T+Mr7F0sVBRTUuJEwYiq8MV0hZ+gajqxm60s0hHd+r DHxSR3CZZtHlqT4TUDFlbGQuQij4oG+/Sm0GqbCH+gI0UY0rD6yZnPLlG p0sWY/oo29mAmsjglUbnc0eQGKl+LkxHl0RfvitZDsjaQ4y+eamA17vr1 Gi7dsBmq5i5ZP6vL9sE1scQq4dIPUS5IdnR63MMsdaJdpg/shJD0Pjgvf uWGRv01S2vZHAq5g/1AxLfRNLEMVUpbTkPBof0NaOMoL2920g713VFspE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="426725765" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="426725765" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 04:08:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="744965431" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="744965431" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 23 Jun 2023 04:08:38 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 23 Jun 2023 04:08:37 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 23 Jun 2023 04:08:36 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 23 Jun 2023 04:08:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 23 Jun 2023 04:08:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AZmsopl2LmFqCRCRR16vhVwb2//JMhyYfP85cEY3Pa9XVVHgvV708tsys0Sn9mUOJlH8vrPPvyJndYf1usrbKpXH8JWd/viNDkuRfYZW91l0lcfxcfyGbp3URt6UaG3xQdhMVBbOZJrg3gtkDjMwuJnecKXYf6Yyf5Ff4yCFHApEIxd88gVOJD6WDt70qB7+zeCSTYHSPfTZWrVUA3jeLy4s++BoQKz9CrPcSoW9BuVsAsB9SIBVPqg0KKGmBbDgkFlM0nvY9IWK77ipGPhqotpUDnAoSvbGufUYQqjgAzdDhHYO5kOypqq9ygXn4DRDit1S0oLf2GB6GtacUZ+jJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MwNn6RMisGYNRxHe6Ed16gEsu6VcdNtUTE2ZPZQG2Oo=; b=EezqOV9wOcVaQ1NrCH96HHzstc7wgu79DSdEe/rdvepe8jwuDt6i5uUutpusdRxcn1mnhKi5JShGzJiMZgQqFqh9Jm+Ar7+xihk0jmDcnBWAa7TFzlnRgLJ/zAJT3oI6UrCUOJmZ7Ry8CAvgyC0KKTv58rv5gf3HgdvgjvAZJnf4yd6S52xObTat+fRSE3Eaquuml6YBq6xD2DXmyU3Lji94U/Bs7B3kz7wFHY8EFGaeIEhNhjJvs8fO/TNg4T1pynremRTuWJTJs3E845FwiZDTq/pqaYCkt4YDyonUvAl0MB/d8dMq5h/Ownp3fDZKVqmrMqOrMg2+A7rY59/+Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 11:08:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 11:08:33 +0000 Date: Fri, 23 Jun 2023 12:08:28 +0100 From: Bruce Richardson To: David Marchand CC: , Aaron Conole , Michael Santana , Thomas Monjalon Subject: Re: [PATCH v2 0/7] expand list of optional libraries Message-ID: References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230622150522.3228294-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:10:100::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4981:EE_ X-MS-Office365-Filtering-Correlation-Id: aa81fe2f-6a67-47f7-0ec8-08db73da2efa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PHkQsI3lp4ohKJwI0GUvWPGBhkogGdJ+IFKdrAPgrhmfMZfKVSpjV7mnzbvsHDTcFqGgLfWzjrb9GpcUIxRmCSe4ilbJkJWBq/QfSfYplO4vmUgCn/T4rTNAJFuJp46+wsEhjRychykMgah+jKvQ/o0WuUzU+eajn74V9EsUjsAVfnQraRZLZB4J1+HycGFELOw94mGyt+paCZykj5jXQwxFouXP7eRu2xEq+WJ7zZMWH6o1ZA8NBmm/2YtPCV1CeQJYvgmyOOEXFq0vQ/qXFp0inBJAbP2CeHXOO1oDEc/oghhtjs+xK1aCQlkNr5qX1p/H4tOzWYpp9tb249R/++8w+jIdIq5sQ+648V1i8CxeUow2EUeXYrXwGBCRcYnwtdIuAq9qDDGALT9e7XcSQcq8cUI3GIZ4qJApbeYPRoYFOfVbM9ovMWKw4aWwS0NAVb+CrkLpWs6OW1xniSaVoZhyFh0NOcrQORzT+aP3uqfyaH+rYCEP+AV/h5j0DzMHtllaxe8W9SISTbAiesZ9GvvVLSzYcppbolN6YGdAYKLIssE6tFch5cfyZi26e7F1aJFmB0neyv1Evx0DToiZ0A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199021)(186003)(26005)(6512007)(8936002)(8676002)(41300700001)(478600001)(38100700002)(316002)(54906003)(82960400001)(66556008)(66946007)(66476007)(6916009)(4326008)(6666004)(6506007)(44832011)(6486002)(2906002)(966005)(5660300002)(86362001)(83380400001)(53546011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blY0cjFYWE5wcHVMZkFTcVloNXFMZEU1YlRYYS95RW94cUF1REVEQzZqSTRB?= =?utf-8?B?MDFYRFdveENldnpVd21wYnhJSEY1K2hPbXQrSG00MkxDRGF3UjhvNDdwOVhJ?= =?utf-8?B?Q1FoSHdTaEhSVmdTbVRVclRqVG10RHRMNkdXeGFCQ3NNUnIwRnJqa3dIWWU5?= =?utf-8?B?S3UyRGFZa0JvMS9SaUpzUnpRSzJWV0hZNW9saFltY3JTQnZyYTJ6UzdwMWxu?= =?utf-8?B?S0VVYzcyWjRiVkgzb3REalYzUlNOcks4L3BINGtiTlY3OUNpZGF1Y2hIaS94?= =?utf-8?B?VlBBOXV5OVVoOVduK2NSZHFzR3dLVHdSTkQwazhSZFBsQ0dtUVpFaldQKysw?= =?utf-8?B?cWZuRTNBS011aWRWZ0grZGVsTzQxdGtWdVEvZTJGM1FUc1VVVjlpcXdQNTZu?= =?utf-8?B?MlpZNlRLMnJHcWpYUWxVbGR2dng2NHI5ZGM2NHJzTHY0WStFRGZtNzZZOEJ1?= =?utf-8?B?aHpacVpCeWkxK2FCdjYvMThOY29nR1B1UmFURXVHdjN1TXkrcWVVRTg3NkIx?= =?utf-8?B?bE9EUUk0b2svY2V2cFVyWlFzM3pRWUQ5SE5objUySm9NQ01zcEpNa1pFWkt6?= =?utf-8?B?Rm10Y1RsbEJhNU14TmZ1RlRQd2F4NGJEZ2cyamdscDZrSmQ5N0hndm56YUlq?= =?utf-8?B?andCY01LTHNyNEdPWkF5ZkZsYTF0S0xKNFNrRm1aeUFQc2pNR0YzL2R1bzVB?= =?utf-8?B?aG5iNWJnRzNNckY0TnA2Z0s1eDhrU3gyYzdxbHFQS01ZYS80ZVhiN3BnUEs2?= =?utf-8?B?eU1zdkVKM1NhYmNBeVd4WmhndEFLTFdBV2hteHVuaFluNEdTaytiSEMxVmRE?= =?utf-8?B?dGhoWHZ1T3hBM2RmekIwWDBLSjR0a3VxMTJBcnRsRW9FNG9MK1Q4TlgxSnRE?= =?utf-8?B?eGViWHhtaWVUekY2b041M2d2Ny85Ynp0OHdHVGsyUlZyUnJpUVU4MktBeW9L?= =?utf-8?B?UlJHaUlRVmI3L1VKMlp3eGRSRUIxdDJzTVlWMUxVM2ExdEdhaVFYajIyTHRO?= =?utf-8?B?TWd2d0dMV1BNZ2JVUTE1NHh2cUI5Zk1lNGRGSDZVcC9RZERPSUFiL0VHSldy?= =?utf-8?B?NHArcWZtZHc2WmlxMzk3czh0Y0pQSW1za1NJV2RUenFyL1p4V1BPallwMER1?= =?utf-8?B?aUZoTDJROVZxY1ladGxMMytOanJJR0hyZldsNzNjNzMxcG8rNXlETXhDTThC?= =?utf-8?B?REZCdnpnMVliSHlDcHNDVmpTWEVpNXdZMWRCVmIvaXBLS1V1YU04dFJkS2pn?= =?utf-8?B?bWNWcEVJRDNiUFpNOUdielNheThXTEtPRzlNRkR1dnF6TytFaFQ0ODI5WkV6?= =?utf-8?B?UVNYYnBTSnpwajlvT0E0UWd3alBkUkJFeVJNOFlaMGpqbDlzclZzbTBLbE83?= =?utf-8?B?SDFWSDFuVHBvNkEyWGJGUlFzTjF6MmE4SkVXczhwaTVwa0Q4NXBaYzRKOGh4?= =?utf-8?B?Y25PVS9DVlpjV2o0OVFTd0M4dzV3dW8zSGZvZWZ0S0RqRUNUQmx5RkNUNTNh?= =?utf-8?B?cEFHZ09iOVp4bTFPQ25tSTFVYW1RNXRiUTVvSXBNY0NuTUlnTmw5cVFpeXd3?= =?utf-8?B?U3MwdkRtZ0JLYUlGdG1EazZHYVNTTHdLOUdCKzlrZTV2NHRSSzVvUm53cEl6?= =?utf-8?B?U3NhU1ZWN0dWdVRIeERsZUFMWEdtbHQrclIzSkVYU1hkaVZOT1U0OEtJcFZh?= =?utf-8?B?RDdaYk9LNHNNeU5jd0RYRlpBV2RkQllrUDlLY2xyMVpucXo4TDZ0cGRJUmRB?= =?utf-8?B?ZXVsMGcyOXlDdEhXUUt2L0V0R094aGdhK2JybHZJdmtGMzU1NjBEekd3R25K?= =?utf-8?B?WUx5UUZacytFR0ZFRTZQaG1oVGhqUVBLclNpVGRtaUJ3by93Zkk5T0JCUlBz?= =?utf-8?B?SkhqcHdNTms3RGs5bk1qTC9RNjVzSFJmL3lIbmRoYjEvaXZkdTlPem1OYXBJ?= =?utf-8?B?NnBiRG9DanpQdlJWVHdLRFdDMnZCMHRvbVR1blRVZHFJeFJaL2loWVIyQVJx?= =?utf-8?B?dnBXL1lOMkVWVHB1RW83Q0VyaldyNE1MbUJYMFBCS21oYzl4WG5iMjd0czRR?= =?utf-8?B?L0JHWFR6cmdCWENvdlFNMGRWN3lvTTQ2QkwrSm03NEhVQkZvQnk1dTRGbHJF?= =?utf-8?B?ajJKVC8zWll6ak9vZUZmaVZhWU5iVy9XSVByOFloL0NmZGlRQXlscjBTcExW?= =?utf-8?B?RlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: aa81fe2f-6a67-47f7-0ec8-08db73da2efa X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 11:08:33.3369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SBPrgXPvVXPhzDcrZHa9sjhCYWnIHXqMR9pN1CA4pgkJQOuhPAkEFXz2x5hvG8l95BmKFEs/UOsEjVK2Pl1ktSWZYOl4sX0NixClTGSj0jU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 12:31:10PM +0200, David Marchand wrote: > On Fri, Jun 23, 2023 at 12:25 PM David Marchand > wrote: > > > > On Thu, Jun 22, 2023 at 5:13 PM Bruce Richardson > > wrote: > > > > > > DPDK still has many libraries which cannot be disabled as part of a > > > build. With the ongoing work to make it easier to only build a subset > > > of the libraries in DPDK, we can also work to expand the list of > > > libraries which can be enabled/disabled as desired. > > > > > > This patch addresses a number of the "low-hanging fruit" libraries, > > > where only the unit test builds need minor changes to support > > > making the library optional. The rest of the build system is already > > > well set up for selective disabling of libraries. > > > > > > For better support of enabling components, especially those more > > > integrated into DPDK unit tests, rework of the test meson.build file > > > is likely needed. For example, it could probably be better rewritten > > > to use a dictionary of files and the dependencies of each file, and > > > the unit test commands each provides. However, such rework is a > > > significant effort, and outside the scope of this patchset. > > > > > > V2: fix checkpatch issues, since checkpatch doesn't like empty commit > > > messages (even if the title is pretty self-explanatory!) > > > > > > Bruce Richardson (7): > > > build: make most device classes optional > > > build: make membership library optional > > > build: make bpf library optional > > > build: make efd library optional > > > build: make distributor library optional > > > build: make fragmentation library optional > > > build: make reorder library optional > > > > > > app/test/meson.build | 81 +++++++++++++++++++++++++++----------------- > > > lib/meson.build | 13 +++++++ > > > 2 files changed, 63 insertions(+), 31 deletions(-) > > > > There is a trivial conflict on the main repo (after lib/graph change), > > so the CI did not run this v2 revision. > > I've already rebased and preparing a v3 > > The v1 looked fine but there was a strange error in Intel report: > > http://mails.dpdk.org/archives/test-report/2023-June/415672.html > > Hum, we did not receive the ovsrobot report on v1 (not sure why), but > looking at it manually, we have one failure too: > https://github.com/ovsrobot/dpdk/actions/runs/5346924872/jobs/9694636520#step:18:219 > > This is because we ask for the l3fwd example but its dependencies are disabled. > Spotted this too, and working on a solution. Three options I considered: 1. keep eventdev as mandatory 2. don't build l3fwd as part of examples list (or build only with eventdev) 3. make eventdev an optional dependency of l3fwd. I've gone for the latter (#3), which, though likely the more complicated change is probably the best one. L3fwd is such a commonly referenced app, I think it should be buildable in all configs, and I also think requiring eventdev in all cases seems wrong. V3 coming soon....