From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2979C42E3C; Mon, 10 Jul 2023 14:19:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA73340C35; Mon, 10 Jul 2023 14:19:54 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2090.outbound.protection.outlook.com [40.107.243.90]) by mails.dpdk.org (Postfix) with ESMTP id DE59440698 for ; Mon, 10 Jul 2023 14:19:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hz6uGJUilCgsCxQsN9W+NgL4OSC0eme5I/Il2gt9tz8H+/BjMJsJVev0Hd137Iww/wV0oNHvExQpXwfDCsJZQlarDavp+5b1YMsvWXPafcyRiOaxHMr4XrNt0aL/o2VeF9/uVLOYPA/f3GG6E4I9w1HxDZ0hvc5J+SfZQuWFQrF4UwjR4wiYI25d9XllYUQy3YQl62654etE3aiqiCuGEII4YPB4EpHaINVgpgIhRoJZak7LDFR/4qpdOxhhp7J9oVBqEZI0Aewg7cNOf/9p+C5WE5MdalbXbx2JMXHWbykxKxVUN+sHYD7qCCT0Hcd1ES8R+F2dz6YMSWLCqPOCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pph+ANvjTPY2AdEsyvgq3ttE2xM5DqEMzLxNNGInYJQ=; b=h45tTZFi3szTvmK49bVkxVfelTPP5/5NHNZsNuQeJTHJVo7Sdg6Ky4mBmB54IcLz+0zpO98BCHawfTLsJuFVyeY+83w/wON2H5qO/mhoHP/0QbAe4iKBnnEy2daQ3bliZLWoCtI6jcbcouSAjO8OcIao+Pym3RKcoReYLEalOO13ZaqW7neUay8C2kcs62Rf+69OM9RTzxaCBi8EqQme+l1jnxND8xHq6/RQz9JJ7uaBp7X9AQlUIdR7xKkVZYnpG1vae6lyTJJyk3VDq7YhFye6ix+RN8do29BuSTthf2X8KVcY6pMivKKu4EJi3VhpE61a7y/f2hKtVdVoC9kHpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pph+ANvjTPY2AdEsyvgq3ttE2xM5DqEMzLxNNGInYJQ=; b=ke/1f1l0/STcJX+O31mrGQEDTBgwHq0YyW3ZJaNpjs6w9kRxiTZ1dw9yNtDKnvEzym5S+qq1WUtyM+Kid+EQWavchCdIq7yW/Fo+yjvbyC49LLOI/R7cVbgA39KxRN9I1ID/A9g12AtcNiNx1naAwyCrlmdNMFNvtWaLVTXSoq0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) by SN4PR13MB5789.namprd13.prod.outlook.com (2603:10b6:806:218::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 12:19:49 +0000 Received: from BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::5ae7:eda4:3881:4f4f]) by BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::5ae7:eda4:3881:4f4f%4]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 12:19:48 +0000 Date: Mon, 10 Jul 2023 14:19:37 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Stephen Hemminger Cc: dev@dpdk.org, Chaoyong He Subject: Re: [PATCH v5 05/11] net/nfp: use rte_pktmbuf_mtod_offset Message-ID: References: <20230505174813.133894-1-stephen@networkplumber.org> <20230708015718.75565-1-stephen@networkplumber.org> <20230708015718.75565-6-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230708015718.75565-6-stephen@networkplumber.org> X-ClientProxiedBy: GV3P280CA0005.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::19) To BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4804:EE_|SN4PR13MB5789:EE_ X-MS-Office365-Filtering-Correlation-Id: 8792f4e8-785a-4d50-b3c8-08db813ff44e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6azIXT/3lAqHmj/UFrTiupklOtJJgSaMTvlPh0oKV7cMjxJJYJUNcimHZ8u2kMFVWMTiYCtnwdP8lN+ADGgE8EuwcyMXb0bxLr3nIXxmmHFeN2l7LWEXy1EyKPYP3wfJoibzIqFOeIbBuHMdlPLAIM3A/6iV1sv4mJa82MW8SOTqkaDYQ3NDwyv64/92jzyTWFn512EaVZtJlbJrD16FOZxEuffX3PAXSw27kZCHF8uzyGm9FwwUiRZWbOUAQj3Sk6kzSOYe6y3xIeiAhQ4F3SUGai97oasl5AZavqxQHuuKNcEEpKcgmHn86Xz2n/nGz+exxrJwn4cFPwn5WZDv0Ej3Fc6hbxvPUzcf5jydKA/DcWkzwz3Ld+TxLXM03c6vN6E3HNN/hxlTSr96WUROuKaLZlTRgcld5FMVN5IbhCeVXbdyIC1Em7shH6Z+kqb3qXeMusUwdrYHFGfdwW+hb+f0o7SD8YMHPJ76ihGZ/ly1czXPk6XV99bmoyKQvYpSbH4DsQ3y7HSR0hXH+MH2+u/Wk7UfsmFvJ1xOgLnvVN/YoWcamxNV4bmvqS8g2lwxcEXFbyDPU/1p+3VGXJGevzksuCWoKJBPFzuEjGYbwikX8YtQbeO0pAfY14az7cIsKxHuhzNcGVcZbcs39ey/I1y7XMwcYdVjEoRNq/+q+3o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39840400004)(346002)(136003)(366004)(376002)(451199021)(38350700002)(38100700002)(86362001)(6666004)(6486002)(52116002)(107886003)(26005)(6506007)(53546011)(186003)(6512007)(9686003)(5660300002)(2906002)(316002)(66556008)(66946007)(66476007)(478600001)(8676002)(8936002)(83380400001)(4326008)(6916009)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnBoK1FYU0xxcTV5Y0pINEpPL2lpbGFEcGhuaFR4djN4eUN1YzE4cFNDaVYz?= =?utf-8?B?ZGQ5L2E0aW1LWEpUQWc4OHBkNFMyaVZWNyt3Z2h3TzFDMmdjUTdMK3g4MUda?= =?utf-8?B?czBjbVBGMStaUFdLRGxGYXZXVHhlVW51bi80K1BDcjd5UytwMktHNldmQno3?= =?utf-8?B?enhaWFdFZHlORVdFMVNSUTB5SUdiNjVlQnZiWWJaSTFBZnVvTUlKN1E5NFJ0?= =?utf-8?B?blVZMUpnNUtmbTJTeW8xdXJVRjZOY3phMGFFK0kyMTk2cFJxTXQvM2kyNEd2?= =?utf-8?B?M28yTEJTNkdrTDMwTEVkNmxrcGpsWVJpNDZ6OVlYZDFsRm9GVlFPRS9qNEhI?= =?utf-8?B?ZFR4cG1icFRrWVk4NVhzVlRIck9RZzBMK0E4NmgydnJ1MlZPWnhxbHdSOVlt?= =?utf-8?B?dko0VDl6TDh5ZkJuZVp4aFZEUDA0MHMyRmVLVkR1eG54N2FYcS9FVnF4UGU3?= =?utf-8?B?OG5hbVFtRWNOODJoa2NzMlBKMy8wQlp0SGRRWEtoL2VTVDc3VXF1MXVOaTRx?= =?utf-8?B?Vy9ZZTVNWHlDNk5iM0V3Y1R4TmgrV0Y0WE1sWFlSb1lDZnJnNVF4WVRlTkNj?= =?utf-8?B?cFQ1R3dZVGREbkRhZ1h4M3BqVXhlL1FpVGZreWRpSUc2Tk1HaXZ5WDRHdjJw?= =?utf-8?B?dEhiUjNVdmFwNEZZNjBMZVNwMEJML21uVHphV25sMG91ZjRoS0RDcnVLVWxB?= =?utf-8?B?eWtkbGllcjZtMmRhdWs3YnRSTnJTbUtqZkVoUTMvSzE3Nm01Ni9ZUlB0TnUy?= =?utf-8?B?LzJXYlJsSDlZRjRETnBYR0dweHBQZU4xdlc1ZEFLRWY0Y1IwaEx1STY2ajR6?= =?utf-8?B?c0pPbStyckc2L3FRZXB2NG9udDJFOHJGdTlEbDVEeGdIVjVSa0VlcENJQ2x5?= =?utf-8?B?S2k4c2N6OVhDMUZQN0RzVWJUS3dYSTgzOWxyVEpOVUZMZi9jNEdveWdqL0Uz?= =?utf-8?B?ZmUxQjgrUms0VSt3TUMyUWVzdlBUclc5d0VxclJHSmtubWNObTl2dWEvRERI?= =?utf-8?B?eXc1bUxHUzcxZ0gwTWFaekRqWWpFZmN1aDJVcUdpTG1jV3R6YWdrblZsdGJz?= =?utf-8?B?VW1HS0luTm9YdmZ3NG82QXYrSzk3b1lrVFlpVHNFVnVka1BFbytKejlaNis2?= =?utf-8?B?OTZVS0tmSm00WVR2WGh3Vk1OakJPeVc2cEduMkI2L1VOTTZiTHlNUjN2MkxC?= =?utf-8?B?YnV3NncvNmRSR0Y3VDAvN3FhTEk0N0tCbEh2dmZmL1JqYVBPVFdMenBET3o5?= =?utf-8?B?SnB6Mmk3NHFRajFDRCtYK3YxL1VZY1hGczdMaEYzcUJYNTZ3UDVMcnFVZjVC?= =?utf-8?B?UEVNMS9WV3FWYktRbHdjR3dLdTFWT0VUOThqekZ6L1Z4WWhSU2t6MENkb3J5?= =?utf-8?B?TFFwdkhlQzVJY1hLSTh5WXFzdWw0S1kxQmI1RnllRzBRUlQxYksxaXd0Vllx?= =?utf-8?B?d0lpbk5tWEVqbGxBZTNrVU5UTGV4RVhTM1JueXpRRXdPQ0NxclB3QWtCS2Zy?= =?utf-8?B?YmtDZW1nKy96VktLemZOeGJrUHFHcnIrZHZUZlFvNzBzNGtmeEw3WW1WSUgy?= =?utf-8?B?c1ZwOXR2cTgxTDFnLzZXTlFCZ205TmV2cDBkbFJCaGxiVmJwc0d5RUprbFBx?= =?utf-8?B?Uk42YXZTK3o3N1NTQlZzSTJWZHJKckZoSTNOamoycUJudHU0bHBhdHFVTFdQ?= =?utf-8?B?aW5hNWJnOWFqcXBIemJuTllFSTlzcm1ZTDAyM2pNWVJyNURaSkhMY3Z2OHdn?= =?utf-8?B?NlYrYlphZk53ak1MZFMwUTNraS82Rk85aTFpNE80QnlrZEZhb2Zzc2Q0Ulpo?= =?utf-8?B?aTc2N2pTMVlRbGE3MUpTSUpUV0lIRWZlQ1hmQjh2bWZFKzBDWnZBRWg2dGp0?= =?utf-8?B?OFdQNDg4Vmt6MFdpTWluRER5RjRhYTY5aVZUcldDVFIzMVNEbjZnTTdDM2J1?= =?utf-8?B?R2haTkozOHp1dENGUGpweFQrZUxrTWdkdnZDdjNKV3RLSDE3azE0V1RITDN5?= =?utf-8?B?cXBKZ3pJZk5wRnBVektFSEVyQ1dLRG1mbUJub1I0L2JJckM1L3grRjQ5UjYx?= =?utf-8?B?OEJlaGFaU2ZrNlRoendTN1dldlhpdlhtaER0ZjhrNkw4TGdvQjc1QkRZSkdP?= =?utf-8?B?RG1zZTRXWTljd3JuTkdFRm5UZVhhWUdTYlNONzZobm1yQ2thaUtqaXg2cnRX?= =?utf-8?B?WXc9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8792f4e8-785a-4d50-b3c8-08db813ff44e X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4804.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 12:19:48.6173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0ksU1CD9OQz3297desE9V9ucHJNxyLnaFB7Oz/Ejx7tc+5ox9u3CM7fVwHMW0BMX1WkO0I/USN8tR5gMa7Aeh93cY3DnmdDVPg5Edj24IB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5789 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023-07-07 18:57:12 -0700, Stephen Hemminger wrote: > Replace explicit packet offset computations with rte_pktmbuf_mtod_offset(). > > Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/flower/nfp_flower_cmsg.h | 3 ++- > drivers/net/nfp/flower/nfp_flower_ctrl.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.h b/drivers/net/nfp/flower/nfp_flower_cmsg.h > index f643d54d39a4..787a38dc9aa0 100644 > --- a/drivers/net/nfp/flower/nfp_flower_cmsg.h > +++ b/drivers/net/nfp/flower/nfp_flower_cmsg.h > @@ -381,7 +381,8 @@ enum nfp_flower_cmsg_port_vnic_type { > static inline char* > nfp_flower_cmsg_get_data(struct rte_mbuf *m) > { > - return rte_pktmbuf_mtod(m, char *) + 4 + 4 + NFP_FLOWER_CMSG_HLEN; > + return rte_pktmbuf_mtod_offset(m, char *, > + 4 + 4 + NFP_FLOWER_CMSG_HLEN); > } > > /* > diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c b/drivers/net/nfp/flower/nfp_flower_ctrl.c > index 4cb2c2f99e04..18823a97887d 100644 > --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c > +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c > @@ -389,7 +389,7 @@ nfp_flower_cmsg_rx_stats(struct nfp_flow_priv *flow_priv, > uint32_t ctx_id; > struct nfp_flower_stats_frame *stats; > > - msg = rte_pktmbuf_mtod(mbuf, char *) + NFP_FLOWER_CMSG_HLEN; > + msg = rte_pktmbuf_mtod_offset(mbuf, char *, NFP_FLOWER_CMSG_HLEN); > msg_len = mbuf->data_len - NFP_FLOWER_CMSG_HLEN; > count = msg_len / sizeof(struct nfp_flower_stats_frame); > > @@ -412,7 +412,7 @@ nfp_flower_cmsg_rx_qos_stats(struct nfp_mtr_priv *mtr_priv, > struct nfp_mtr *mtr; > struct nfp_mtr_stats_reply *mtr_stats; > > - msg = rte_pktmbuf_mtod(mbuf, char *) + NFP_FLOWER_CMSG_HLEN; > + msg = rte_pktmbuf_mtod_offset(mbuf, char *, NFP_FLOWER_CMSG_HLEN); > > mtr_stats = (struct nfp_mtr_stats_reply *)msg; > profile_id = rte_be_to_cpu_32(mtr_stats->head.profile_id); > -- > 2.39.2 > -- Kind Regards, Niklas Söderlund