From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4303D42E9C; Mon, 17 Jul 2023 15:19:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30AA740E25; Mon, 17 Jul 2023 15:19:14 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 6884840698 for ; Mon, 17 Jul 2023 15:19:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689599952; x=1721135952; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=i7mlEfL6FnI/NvpmrWgHN9bqKLVZSYL/zBEshSWOaeQ=; b=N45Dy+NCZLcXX+e2qHUeDOXMJkgBk6d6AwBTi/+56mPrJ8RV9SFTJL+N Ohp+4IMPjObzzZChzqg8wSjxvjBpTBs9QLJM32+czyCqvJDztjOSzq1Bg Xhs9CDdIPZSbyz/KaEaILlxYlCLtIyoPZ7s1vCd42yEDb9XO5vK9SmUEW FsNiaNXT0MghTDPTGRA6UNMIwwaRzwcXFAaMWpYOkn6dHZfzFMpfabMx5 3S9amPw3yX/OUK+h51l2+WOm/lACeV7PfqNR8DwsLTRrp4eG6sTCw+CC+ P2swIRCUHMxUh1cJBAokONNfxEpQO3blKM4BksHtsxVrEv72lOvEiw9s7 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="396756146" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="396756146" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 06:19:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="700496277" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="700496277" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2023 06:19:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 06:19:10 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 06:19:10 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 17 Jul 2023 06:19:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z90QbmBKP/U3eg1bvRpNFJNzebct5qGL65NC6QxV1o+fynI1yHmyM/Wgj67LGbU3OSU6ON5kGESHSm8vsSfg0Uzo/9O0E+PXW4wsFBlbRJJxW9ntfTHRnscOzA4wj6Tmrz70vwfLzsdVMoT8TVrIEYxnrxPfQNpn8Ep7nyDIKZVQ6l9j0yiLeHPneRuGzkIyam2L1/96mjL+m4ys3WPglZyo5AOV4LFtBO5wHkVflsjoMbsd7och8a35V8ILNrPrJVEUl8b5M16c+saJX3o5/KPulk9jIuscf/nbT5IqinqXrCVju0xnPFhh74gPR55+GHMkuQ3FeqZIdTwbleGL/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CVK6MZwsHfIzcnVE78a8ffV7xRfQ1H8XNI3wdZtHsXU=; b=LQk5t/iDiBtza0bxeTUeV75TpBs6GJhmJR7sJc716T0bEBOZQ6Ie8El9vyIJhnBVOt7MtE9t8192TSgu/v1Wosfsmz/MS0uBNQIHbb3iewfT7mnb+giPLE+RCF6VkostbIMoAmBaD2O0aka/HXahG1blesPH07UYQIKSIeUKoW1QwR2/hbiCRQmObTy3+LQs4QNvvn5b81JTKpa1e2zV4JBqwpvz7JrGDWE7y5lE1BxUP9qjTmbQ+dLiCTcDGhLukUBghj/C/wX8udUew76L5A4b/9gMYx0hJVSQrzFi9ZqLOIh3L9vbqiVMJNoMO2Yut5JUYXZLbB6wG/r+TAcV+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6538.namprd11.prod.outlook.com (2603:10b6:208:3a2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 13:19:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 13:19:07 +0000 Date: Mon, 17 Jul 2023 14:19:01 +0100 From: Bruce Richardson To: Konstantin Ananyev CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Subject: Re: [PATCH v4 8/9] build: make fragmentation library optional Message-ID: References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> <20230623150708.2203918-9-bruce.richardson@intel.com> <6a58c9ad-baf1-2dde-6c0c-35d058ba1061@yandex.ru> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a58c9ad-baf1-2dde-6c0c-35d058ba1061@yandex.ru> X-ClientProxiedBy: DUZPR01CA0293.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6538:EE_ X-MS-Office365-Filtering-Correlation-Id: 879de261-f721-45ba-c1a6-08db86c8666b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cWsKmegO1bmQfqO4QJiuqZUbMiEyHMrUb1ExuLIvyAN3nZyPSox8oIVj92Ss1EnKza7GwHA5quZOPdfmXHnTiUbBmSqll2LbX0YjPPtsXo99LDqwC1eGQwpltPfbx4OgxYNQw0tQKCSP++V6V/hY43vKz3jMYMIycwYOiQObtIFFaekipb1vCRGFQTyKRDXbocOQB1jmjTny4J/C/qLsV0YRByOLfmqAtmtOyUC1f/PLIkW7ySoj9R/iN1ZxG19vlwHAzSY9Kvu2SRRh7PeXt4PPR8nCmhWjKYVzog7aR88TejmxsSC3cB7FMbEqDjO0jHyVsmGH20KZroLzvDQkghaJyNxVnDcApO9mFYoNjb7Xou5i+5vxafOBW2E/RZDJVhCvwUAMu97YToXLBlbgJ+/JqBGUBhMO1+HKOBEhK4Vts/6Le//pCw7qMrqxDKc+BEwuppti7P3S1EnW/kh1dh7MMnp5Nf7kLWrO8YX0BpS9IbJEtJCi6827Q4kub5rFi7iXPtvVsHkmB8WoDvIZ6uYzRPxCj3rHXIhZApgf3+U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39850400004)(376002)(346002)(136003)(396003)(366004)(451199021)(2906002)(38100700002)(6512007)(82960400001)(966005)(83380400001)(186003)(26005)(6506007)(5660300002)(86362001)(8676002)(44832011)(478600001)(6666004)(6486002)(4326008)(316002)(41300700001)(8936002)(66946007)(6916009)(66556008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXFzYyt0QmNadEJtcDBOQ2RySFZsYmY5dUZYK3F0S0tWQVR4QUVJQ05PWlA4?= =?utf-8?B?dGZkQjNzQVdyU2RlK1dIYmlXMWdUY2V3d1U5dUZmTTVSc1FsMEozNlBhZm5Z?= =?utf-8?B?VnVhb3ZidnBaQUdjaGdnL2NJN3ZCRFRZWm9UUGFlWWxDZG1aZzd4MUd1Q2FW?= =?utf-8?B?VEZLaFYxSFpJdVIrVjBHL0QvZVo5bG5aTk5ibGhpNkZMTk4yWkltLzNPSmx2?= =?utf-8?B?b0puZEZYS3dYSENWRUpTcU5QV1E2YTRTQ3pKNnhjQUVnYWh0WXNmd2FGSy8x?= =?utf-8?B?U0t5d0NmOXFKanN2ODc0R2ZCdEQ4VUVYcG1zSXVYczBtZmpOcjVzcU1LT2VI?= =?utf-8?B?V055TkJxTFJlVjE2ZGdBM2xBMzNZKzV4UHc2cXBNS1o5S0FkWEVOZEpYNDJp?= =?utf-8?B?OG44VW9HdjdrZ2YxWmZFQmJmQXJHemF0eTdGcDZIUXF3dFVvU3VZR3RkREZZ?= =?utf-8?B?R2YzbFJUeEJvYWZtSEt6TjVxYWltbkVMblR1Y1Npd3dGRlA5ZSt3aEplZU1y?= =?utf-8?B?M0RwMmRsOEtUNS9nTlMrcVpyRmFkOHJxOTVuSzdvaXgrdzlYTWd0SUxRN2py?= =?utf-8?B?Y1NlUEV6aXZxbTZ4ZEl3enVFM0Q3M2MySjQxcVFoeWVaQzA1MEVxL29rNjYy?= =?utf-8?B?TElEdHFxcHpiUTd4TWJnL1JnSitnb055NHdmYy9tVWI4QkxVdjRyV2ZZNXpT?= =?utf-8?B?RlRmanBydEVTYlFncTZFNWZKSndRSEtLSVhVRnVYS0VUZGNIRGQ1dk1iaVl3?= =?utf-8?B?QUhrRFd5R0FUeHRkTzNBTGxJN0oxZ3RkTkNLS3lxbEE1MXI1VW9yalVDRlNQ?= =?utf-8?B?cVFycFg3UHdFVzBZY0c2QWJDVVlzV3psK1pwMlVPQVBzRS8vY3JiWDVzZVZz?= =?utf-8?B?RnRhajlsaVlRajZqTnltaXRYSWFXZWs3T1NNUmZMS1YzOENjSmRvZVZpVCtR?= =?utf-8?B?dXg3bFROZTBCZjRNaSsxQ2o5cU56M2ROSG5wNHlkTE5LMEhIMDU2VEJVQnJ2?= =?utf-8?B?SlRjUmdPRURiQXYvcGYzZnJhTXYwRlQrNUY0Q1g2WXZ2MGR1dUZXQ2tBbW43?= =?utf-8?B?azhoaTNhMFRla3BWejR3eHFhY1BONXgwbHVCZHkzWUJJTHJ4amZ6c3lzYk4r?= =?utf-8?B?QkJiaFhPTFcrcWhFYTBxL2o1RU5INWZFdGtSK013Z1JORE0xcEdmU3Nia2kr?= =?utf-8?B?R3kyc1BQZ3RKUjBaa3BKZFpsQ1lOeVpHbXVTRXJoTnlQdzAzU2hXenRudk55?= =?utf-8?B?WEZIYWoyZ3kvdmg0aXJLTGttblNHTVRqTTVsaU9uUFdVc1J6MkxBTEVzS3lS?= =?utf-8?B?VkM5RzBaV3RhSDJnemxQTnc1UEFTcnpDOVdjeWtYOXE2REgxY2hFcDdsc3RW?= =?utf-8?B?bEltOThWei84L0tCVTM1SHo3Y3UrS1F1NGRMeHI3T1ZuZ0ZVNGUvL21sdWRP?= =?utf-8?B?WlY1T2dKODNaa1pqRG1RL2pvNHVNbm1GUEk0Mi9TY1RsNTJESFFNcWlhTzU0?= =?utf-8?B?bnZMeHZ1a2pod2U1d0U5ajNyMEJJWG5zNWRrOExkZ3VPbzFvZ3E2TlpRWkpQ?= =?utf-8?B?cHdoc1dBZm5MTVJzQS91UXdFQnF4Y2t4b2tkTVZ3eGhEc05xdUF3SkhHck1Z?= =?utf-8?B?NXQybUZzeHR6SEJ6STBTYllLUk9pVFpVT2Z4UUZsb051UWhqNkJTK2JLQUlD?= =?utf-8?B?K0NxdXdrZ0w0Mm9GTS9ydm1iRGFzUWgrYjByRkhSUTdzS2w2azlqeEtkSTA2?= =?utf-8?B?NWhzZ2tzVy91QzVYQVJNQlFGV2pNM2M4aFE5RGxuVXZRbGNjb3BLRVlwZjg4?= =?utf-8?B?WjUzZHpEOURnSEk0ZVhyVEJYQWhEOUdKeVpSUXpQbW9mVmZCQWU0RG1vQm52?= =?utf-8?B?RThKdThkcHFzRGpsZWg2RWJZOGVNQWhSOTZMMUo2Smx4eGZrNm9EanFkSmcw?= =?utf-8?B?Tjd4eG1oS1QrMksvY1NiYjRmUUlaU0pDdE1Wb1M4S3IxSHVTbWNDSHVpVXgw?= =?utf-8?B?Vm5EM1h5Z01YaVhEVlRWcDdSNW8reFNWU3dyN2RnQk1LT0cyT1puc0pPbldi?= =?utf-8?B?WU1QbENtNmc4SEtDZnZWeWFKRi9xK2IyRVhNOWc2MDQ1VERFS3dUZ2d6OWhL?= =?utf-8?B?cklVSlBNOXc3K1JJYWtsK2Q1VmUzT2JNbW1IYklKMEhaTVNtL0dseTBZYzB5?= =?utf-8?B?U2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 879de261-f721-45ba-c1a6-08db86c8666b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 13:19:07.5257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kh4A0SkPVRO8YeOQOUHgIB6Kb0q/Pl+pYVFfuyJJzR5uaQhh5yYcePOCBKklYfN7SF6c5qomtV4q/KD83ArzbcrO8wktEhvzaKxG1/XxpdI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6538 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 27, 2023 at 10:32:55AM +0100, Konstantin Ananyev wrote: > 23/06/2023 16:07, Bruce Richardson пишет: > > This library is not essential for most DPDK uses, so mark it as optional > > in the build config. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Morten Brørup > > --- > > app/test/meson.build | 6 ++++-- > > lib/meson.build | 1 + > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 0a971997a5..2e447e3402 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -56,7 +56,6 @@ test_sources = files( > > 'test_hash_perf.c', > > 'test_hash_readwrite_lf_perf.c', > > 'test_interrupts.c', > > - 'test_ipfrag.c', > > 'test_ipsec.c', > > 'test_ipsec_sad.c', > > 'test_ipsec_perf.c', > > @@ -173,7 +172,6 @@ fast_tests = [ > > ['func_reentrancy_autotest', false, true], > > ['hash_autotest', true, true], > > ['interrupt_autotest', true, true], > > - ['ipfrag_autotest', false, true], > > ['lcores_autotest', true, true], > > ['logs_autotest', true, true], > > ['lpm_autotest', true, true], > > @@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH') > > test_sources += 'test_graph_perf.c' > > perf_test_names += 'graph_perf_autotest' > > endif > > +if dpdk_conf.has('RTE_LIB_IP_FRAG') > > + test_sources += 'test_ipfrag.c' > > + fast_tests += [['ipfrag_autotest', false, true]] > > AFAIK, there is a new patch in flight to add new ip_frag perf autotest: > http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavatula@marvell.com/ > Probably need to be synced with these changes too.. > Yep, it would. I'm working on and off in the background to try and improve the way we manage dependencies for tests, as right now it's a bit of mess, if I'm honest. It's very condition-based and error prone.