From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF0FB42FB1; Tue, 1 Aug 2023 12:19:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6825240F16; Tue, 1 Aug 2023 12:19:56 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0135B40A89 for ; Tue, 1 Aug 2023 12:19:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690885194; x=1722421194; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=e2HeNlSvNsIO/ArZ4thE+4iSuRY9QJy2QuSrLCMbaoc=; b=KarlRZybqY9+C6S801xDW48hhjH5LvnPgJcPgA74dFbuygV9KZ8gigv0 I0qYWVzwTB31Ryt1DC1GFFoy0a5Y3YZ2k96+0A1S7aEv1q4k/IZ+V85yv owRiKquNQL06USzNHc7DP1rx3JwzWS6JWv4u0nK1pWz0W8Sbna8a1sGVt Cxnj3TuhVZSNOgYX8W/MyZOp3PZ92YO4q3KegA0d+dS5RNCGjZogZ0+Sk JXF6sGIGVn4boaSCUY/4uQo2/PuS0NCp24Ymfg2Iwv+S9+9nZHX0QUQ3v nVqapddNnjf5PsLGReTZ+ShQEE5Onb70rNicgnBUjiPmRZMHS047dTqwh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="348853793" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="348853793" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 03:19:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="852405861" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="852405861" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 01 Aug 2023 03:19:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:19:52 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:19:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 03:19:51 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 03:19:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9e5It/EjQlqRdkUyhC19FmGkFfMexfKzztndIImoPoQPfcf06rGlvX65wWNlzVWtT4oPktwQtCDgXrlCIQYsqzP36amuw2irDHpWgXjTyyQpfQVmfvQcqEhk3f/NPyF5SO2KPcCsi3LngkQ1RhKR3LLsgqUBDdghzrYyOlTsEhuBa9MwFo+ndNN7EnvL3Qz59glQH8xOoEaLRIKV+OCdVuN5aFQM+NhGzU7mBLpdSDYpAD+5MD1jNUuQcpl6X3TKagS/NeAtJuUbOOUyykOlEVv5x/ZeZi+enJBuvReuPNv31F+i2AHu/pmJxYF673pZcGYzfnMtzutXwtO7N3j4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rrMtZK3S63OpbumNhGL7omYxKQdNKeU9km5RMg0FQcA=; b=G6Js9qrQ2EpIauYdEe097aHAySM9thzTf46qugR5jjiAvnE5ug5Ah0FBYQ5ucflERIwk6r7//CvzEYz+pyB3luu/RhgZ09VP20Go7oIWScopRI6Lu61MVib6+aAPz9pVWsiqh/PqqdP2BWxsU80bAjrqvYn+Pyla7iElL7hy6lHMFvQlSkFFB/aR1ksWtHwMRUTBhEIc4r2XfE55arqKRcFg9h+bDJsysV+9W3H+1sHGZQsnJ10Hg2Vo5EbEfG2+HagqCozFQ+y0MvCbheYLwIA/SDxTB1ljG6HEFgx660gbqFO/o2GQvqdzBsDtOWH7ypqRuANYXLyb9AJBr1HztA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7998.namprd11.prod.outlook.com (2603:10b6:8:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 10:19:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 10:19:50 +0000 Date: Tue, 1 Aug 2023 11:19:43 +0100 From: Bruce Richardson To: Patrick Robb CC: Tyler Retzlaff , , Morten =?iso-8859-1?Q?Br=F8rup?= , , Subject: Re: [PATCH v3] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731165810.3086571-1-bruce.richardson@intel.com> <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR04CA0013.eurprd04.prod.outlook.com (2603:10a6:10:110::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7998:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c5f665f-642d-4906-7409-08db9278d683 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NgkM0oDeT+MmhRhU5VZMDaEw340g5NbGX1gjjP+2S3RgK345kt4I/u90vEKk0decqsfSPDD/ipLMBymBymKpdHbdRQbtxyA9S5EY2Q2V/LEfhXBQ3nId9Dj1jnvZ56m59nEMrF4PR92E/TFDo5R5yRmP0joQt/Z3WoKQr/ouSrfS/gxOrHyCG9qU//UtQ1AeT578KVcx2XId+4fAnnWTgDq4Dt+RqOblL3OGm++1hTKU0eRjIAvQPFoxwmAOBuk6hBH1ZUp0WixHQi7+isYFI1oWNfOZnIo6SLs0moGwpSq4YivZZWmX9qFkXM3HtwcZHv+ofo/9+/8TSSChVAcbzyEu6WpIR10dhpZTV6t/85q2P0rNb0S+A6bfVmn5ZjmzOTlgjcNIHh4Kx8YjptRDvkl2Rp3xKuy8xEAKCx28RlB0nXjZ78iZ59x6i1Tia7+JYl8Fzk+4ttd4qXrVan3tS881yVeLpZ4kjOY68TAUZ2xvaRDEfgUjrihevFS9aaKGj3BU8DMiZKFrXLH49VLsmDzhFCCEOEtxRJCiHZAdi11MDWA1+Kmy7GSgMEshJQiZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199021)(6916009)(4326008)(83380400001)(2906002)(186003)(316002)(44832011)(38100700002)(478600001)(41300700001)(15650500001)(86362001)(6512007)(54906003)(82960400001)(5660300002)(66476007)(66946007)(66556008)(6506007)(26005)(6666004)(8676002)(8936002)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5TcvOeEeDBeZJdHHpiyl1orlO3BQhXxneUO2vvj1qKassdgb6p5TkrCgb8jQ?= =?us-ascii?Q?zWr6BjI83CFIED2QANC7PKqkUVIclnUPZxpnzYjClaR2bfUq0+bJImjB1nlZ?= =?us-ascii?Q?Xqgf0BkDPk+hXhdT62L1g1S6R0DqCu2C3KfC0FF5GY1R2+BmJ8vhbo2tYbV2?= =?us-ascii?Q?6HZBddEeNpsVTZs+bQq8VUYvnIKcYHxlkGS2benAybF2wwzlrar5ByDy0cqi?= =?us-ascii?Q?0B0IVK0FdiHlWuFfoHqrWEQ0axrkaCjKth0Ev3d01B5GCtFPBwQ54OtxJyIY?= =?us-ascii?Q?j8Cu6RHrkEy8BdETIurjQcER221JyuiPr0jjlgnRpubOuSQzX2jKxJ/CRnfS?= =?us-ascii?Q?CRyQnCXsHPCAmeb1l65ROAknNwAdUNuTClL31X4ymgRQu8r4ho8uLOdY+IPC?= =?us-ascii?Q?+QsSsvnowjvMl16JMZz6cpPsP9J4k2UIZQPqpJBa+tm0qXvPoUKbT8YXRwtk?= =?us-ascii?Q?iFxYllcF+Glm59YpccrKzpnZRcIplMGBoH7THMV2sHykcV8tjn1yuOVl8G0Q?= =?us-ascii?Q?TXReuK8dG86bmVt5fJfhOqpNW5cwt9At8CaK8/GdE9xnMvrbYze/NlEUjf0j?= =?us-ascii?Q?tPGBj5ox3H0gAHezkxYLZZYsN2aaEtQHIh8+oQ6Bl0nhFw8xqpz2lt7ntIgn?= =?us-ascii?Q?7YZnLgqDFGz5KM8aVuuDkZoBfFiP0UoDziRfYEsVseHyYUpF2Y1dAC/YlLPb?= =?us-ascii?Q?SV7QMWz/2Ld7qIHYAKzturtbd4j4MnaBlp/h//5lEA0EMDoFMrOel6eP5wPu?= =?us-ascii?Q?myqzIRQotc8VGCuvfvhqnkOpZLio3xIn+23M+LYgNZiE31BohNhmwOEKKi8S?= =?us-ascii?Q?abn7v1KkvDYPa6ID11+4nyPMD5P3xKAyb4nHGe15h1ADbsGD9GlPyafHJ1M5?= =?us-ascii?Q?d0tJkBAoX5mh8WZWPSguDCMKFDmcHjDg9XKgvQeDQoBFi6kQDXysRo6nW7tk?= =?us-ascii?Q?POMf1436VJCyMeTNQ1mgfDWREaLauhOWZ2nk7cMMRagVw41zsC3u9k9BFDpf?= =?us-ascii?Q?6jNO189OXej15jc5p/If3MKS+HhtxLpQrK+AoqxeaxdojGqyJ6qu1Oub9ZyV?= =?us-ascii?Q?fsPh+fhj7NIeEy2RsfRXvKV4jzZ3M9sobGEZ7uoWjK9taGKpXEtbO9JeVR3J?= =?us-ascii?Q?wA3JMr7UCjMBr7Urshbg2Ny60dnjLUM5JavkG9cUBcyxvmqx4gppG3X9hP1G?= =?us-ascii?Q?8JK7/r4MRPRNGloRUItX2i21AdC5XdRr6Z6sK6CkH7dULnpu36rXGwXywOY+?= =?us-ascii?Q?ekxITbSHrD/oFe+FiWtmf1INaBo5OLdHDbpXLBpk/i/UijQ3srfBn4D4FoTW?= =?us-ascii?Q?mCI7S8k0/UZQxK8oqmOPlzHuC4GTiKS/9bzvG/kzU/1rjhDoJJFLB9v6q49n?= =?us-ascii?Q?kexLJN586uHDjRl0aocrhHrXVhxVHydP2NO2m4tsOzDXZyLTA9x6NDoozDKw?= =?us-ascii?Q?tooe4GEMfv1NdAOK+xMOFh6EirUWuJ9RPa/tPrD9F4UGOqRPc2M6c1qWHpyV?= =?us-ascii?Q?Xyg7D61j0NWzafyRw/uJ8Pk+NCPhpK2e58Kozb4osff5syaKrZ4qNxVKd7Uv?= =?us-ascii?Q?6k+nTFA8OZROTE6nTRnY6OkGyX7eG4kndb/4iIk1pcCnSP3qXn9xMVbRR/Y8?= =?us-ascii?Q?Vg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c5f665f-642d-4906-7409-08db9278d683 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:19:49.7848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Opj/IHtyv58gRZBnPBX1ocCqOvb2fDKhNHJEZhom0i1MWwPoy+3VrJ3n6dzpwaWBepMQ+bwxyeOfF+4VSLaqKfLTB6MFnVv48Zv6YdNsaz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7998 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > Hi Bruce, > I see some failures for this series for our Ubuntu 20.04 containers. > And, our DTS testbeds which are on ubuntu 20.04 are skipping running > testsuites because they can't compile DPDK. So, that's why it has some > missing results for a couple of the Intel NICs. For context, I'll paste > below where the compile job terminates in one of our containerized > compile test runs. The GCC in use here is version 9.4, so it meets the > requirements as described in your patch as far as I can tell. I'll > check it out more tomorrow to see whether it's an infra failure, like > some missing dependencies. Please let me know if we expect to have no > issues with 20.04 or if this is anticipated. > Thanks! > [1638/2730] Generating symbol file > 'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'. > [1639/2730] Compiling C object > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'. > FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o > ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers > -I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev > -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include > -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include > -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common > -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf > -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring > -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > -I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always > -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror > -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation > -std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE > -D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4 > -MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c > ../drivers/net/mlx4/mlx4.c > In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27, > from ../drivers/net/mlx4/mlx4.c:49: > ../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct > mlx4_wqe_lso_seg' > 111 | struct mlx4_wqe_lso_seg { > | ^~~~~~~~~~~~~~~~ > In file included from ../drivers/net/mlx4/mlx4_glue.h:16, > from ../drivers/net/mlx4/mlx4.c:46: > /usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here > 410 | struct mlx4_wqe_lso_seg { > | ^~~~~~~~~~~~~~~~ > ninja: build stopped: subcommand failed. Hi again, I've attempted to reproduce this on my Ubuntu 20.04 VM and failed, everything seems to build ok. Looking through the logs, though, there does appear to be a difference in the configurations in the two cases. I suspect my Ubuntu has an updated verbs package compared to the image you are using. In the log of the failed build, I see: Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: NO Configuring mlx4_autoconf.h using configuration While building in my VM, I have: Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached) Configuring mlx4_autoconf.h using configuration So my verbs mlx4 header has got a different set of definitions to those in the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package version "28.0-1ubuntu1" Can the CI image be updated to latest 20.04 packages? /Bruce