From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15F9D42FB1; Tue, 1 Aug 2023 12:39:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02ED040F16; Tue, 1 Aug 2023 12:39:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 28B5740A89 for ; Tue, 1 Aug 2023 12:39:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690886357; x=1722422357; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Jnn4/Ob1BWAgiJmu69L/R1ig1dnzf2ktQ9Hs0kIS6b0=; b=J3rzEIzYYNhaTSXLJeCO0alT2DCJVI5HKQSe+oye9eWUThvBO14f9OhC 63yc7iihwVagf68JXk9KUpSz2oDN55zxOZ2/lc7WPMUuA2xg7mZ8izAbv YL0dGDsTMPzRv+E4E4uy0a6xPR8zEpcizkVtLJZOgYte7bqQBHslZaUV9 87KcZFudJM9URxu3yQCFQoqSBnlEBpqrQ8oCVrZrGcgk2LSazxTCXvJal 3BxctUEjs05CN438LGZ9YOGGYU5dmFuDzF0uVoPzkXVbysGhHLBbDSrBq AHSEdOc6V0M6wX/1by34gOt5fq0/xqOZvD88fbrAYPRJwnjICSzZnJAF9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="400214092" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="400214092" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 03:39:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722442922" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722442922" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 03:39:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:39:15 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:39:15 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 03:39:15 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 03:39:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InqA13MARhjBY0rkHlPSvTgCC9n/dGTRvs8ELJw2DYK6qRU6rsxyP68GtAfW2cY1P2aGfyG84Mr3uSYLCxCmBUv24JvrenUAeE8fkfV5u8rpqtjFn7DPFfdIwnaWbl4Xy08TuvlRZcjqRNBeaddgs6QDvJVEnszTB9QoE5N9gEFDQi9fVCFvLh4XLujPWMMgGNgo7qXhnJ5Of0O2HEjinHDGMANVLQzoO5wQ7UpV4/95jyfM7yAX93DH3uqCmVY/0mOW2JsUnJrVllWntIQZgn32zuoDSU2pUJUauTsOQVLL8Q1UDqvm9W7h/hFEsQgLRboYy/f48lJfSAbzgbxTNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rGwjqPYWWF2a3/t6OJFLWjb8Bp0EYNx3fWxbTfXxqqE=; b=IFo440qroLUevsSYGYBgXzpCXiVu4I+sX2EQAaSd4COdvFwsmZrVn4QiozY65okzIMxWjnDMO+PIdLBPW5fwpAzQRssFNOE1PyfVPX5BhTxmtSv/prWSVvrCWRruzOopiVcWOGHfKrAqG8jUIObspA5S6fUvzeFEMnJTtovYom38Bp6UdGkLppfZoslGzdENfmrXcgj4BxlWHzFHBiwIfNUaZb6z6sfpdHBFdaaGWJbdDajgvY5HBPhKHgxtICLqF+j1WogdxYplxF5O6cQRZ6epm0Xx5AUVReSfyw6hPPjl8dcl9YcCIKh55IWZRylfTR5EU7y3MbXAnn8ojUh+kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4552.namprd11.prod.outlook.com (2603:10b6:208:263::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 10:39:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 10:39:13 +0000 Date: Tue, 1 Aug 2023 11:39:06 +0100 From: Bruce Richardson To: David Marchand CC: Patrick Robb , Tyler Retzlaff , , Morten =?iso-8859-1?Q?Br=F8rup?= , Subject: Re: [PATCH v3] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731165810.3086571-1-bruce.richardson@intel.com> <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0132.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4552:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dfc93a1-66df-46cd-6554-08db927b8c38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g38uTSkwW3+LrfJ/JhUPMCIT6a7eO16z/aX8dqoMguwqZth+4YZeiASPJ3qXdcAbd5RkZZinkmVT//kVopTpQ2v2RtE9I5w1S2mEg9njJkVNPAkNtHZmeNH0xQcqR8vaVqj5k4CJn146pt8hVAWfM5NNs1F98F+NqjafkoxS3m6xgwoHrS9QcSW1xb97UalHl3SSaZZMTW9prvHxulEoN1VVefx5dTtAtO8qXBocA1KLh4KCR94fQapNQdtubGEV6ISXuC2vRipNbdeLA0zmQ7I3mh2KIYdTWVj4fhPbZe/e5JnbW9ZiDybejazivt3n/LMZQa8Ih9JBeoSkGPnh0AW9k9Z05zKt1gXFnqAArSZBftCniY4iCbBaCi0u/oMpPiqj30pgWaIfNMN7AkykOLkEHFSerbcdGMFRA99Wpqti8eZzm5GT/L0LWAwLjtFPH2EYOqfL2vXb4eNTe6/870hpPmKcbExjLyO9mFhECFgjlho3OOiWs9FTpeeaokY+9MxLn2EeGKjBsRQpyspN4AJ0cRUHteqwNt6Sw8QjkFGT5Y0lbw/HBgqAAOPR8GcO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(136003)(366004)(346002)(39860400002)(451199021)(38100700002)(6506007)(5660300002)(53546011)(4326008)(6916009)(66946007)(66476007)(66556008)(82960400001)(54906003)(6512007)(478600001)(15650500001)(2906002)(8936002)(8676002)(6486002)(41300700001)(186003)(316002)(86362001)(6666004)(26005)(44832011)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3d6NWhjcVlPd2w5Nk02QzZFNlNBM1RPaDNUTWtUWWlXd1FsMWlHSDJrS3o3?= =?utf-8?B?alpicmkrZWM3dFJpcDRDL2NEZmFKUHJSSXoyTmpRL3c2a3BPZXN3UjRRU1RX?= =?utf-8?B?d0JXWG84b296ZU5Uc1RTTU9IU0hyL2ZkUFpkYjRIbUlONjlqemttb0VCYjJ1?= =?utf-8?B?YUJhNXIxRFVZQXc1WVdKUEMxbG8vMkkxdEc1b0tndmpYekdwWWJRc3lWZHNH?= =?utf-8?B?bnJGekRRdjM2SkhuUXd3eGxFdVFQeGoyMXI4Y0YrdENiVkRFMWw3eVB2L3pR?= =?utf-8?B?OVRGWGRDQnlWTDNqd1F6T3htK2pPYlVsVkdLTGExSmlnbW9DcjFvbElBREts?= =?utf-8?B?UVF6emhaT3FuQnB3Z2xBUHlUYVpmU2h6SGQ0bUk4RU41V2J1bk0zZ3J4Unds?= =?utf-8?B?M2lPbWxDc2cyUEx6RlpTaWZiTUU1TzR5cmVsaVRpSko3Z2t0SDB1VVI0RVlU?= =?utf-8?B?U3gvUXVJeWo2VWExR3IwbkNSWGlzbklGWUhzUVlqOEgyeVREblJjYm12eXJW?= =?utf-8?B?UFlJNlRlK2I0M1JwZExHUm5Fc0xpVUNSWUJBdzJHcE5VaXRGSWZ0QzZQT294?= =?utf-8?B?cHdKemdXbHZZT29vQzlwNSs2T2JsajRsaU5zMGRsRzc2d042TWovc3lUMGll?= =?utf-8?B?YUt5T0VWVkRrK1Q4QjBzdjlsR29KRTVDaDhzMUZNTDdMNTZIMzZoL3BmclRx?= =?utf-8?B?bWpIU1h1ZDJac2hKakphY3dkZURoWUR4Y282Ris3SzdTYnZ3S0U4dU93YTdh?= =?utf-8?B?bnlCbXZKUG5Ka0gxd2QyVnh2eVBabDBCWUFXdi9NdE9ibUtNSjZWWXAvZ0xr?= =?utf-8?B?cFR1b01EMnROM0dteUxVYlZnOThFQUNSVUZhb3ZQNUNVcDd1SWlZMVIwRG1x?= =?utf-8?B?NTQ3SVY1eWk4MnZ3VDNwM1g4eEJxb3ZYTEJueWphTEhpTkhMTnNpQ3l2c1VS?= =?utf-8?B?YTdtbE9jUmZWMlgzYU44eVkvMlhDVzFYK2ZOZlJ1OUFzVGZTM3l6b0NSOFZH?= =?utf-8?B?NVRSd2JNR2Ewc05JOW9UV3FQelVpbUZlaFJlL0ZrdFpNUFNmUXJGNWEzVFZ3?= =?utf-8?B?YjlpTHovSlhjOGtpaXZ2SEVrY2hnZGhROGpoOGs4RnZLY3E4cGFYQXBzdVJi?= =?utf-8?B?TlBMVkd0T0oweDVnVE5ZU2lDRlVGRGRCYndSQUdCYXFMcWtkdmtjZXpGSUVG?= =?utf-8?B?aStRZ0t6TUhxMDNzZm9NaVdONXFUTjBFNkdiT2EyclJ3cjJXRW05S1N0NFJM?= =?utf-8?B?cUV2TFgyUXA2V0J6S1QvWERpM2M3eUZ3TzFZS3MvckJGOHNvdjh0b2dObEFR?= =?utf-8?B?dEF6TUxXdlpLNkljOXl1d1B2YjRhN3RLTW1qK0NpLzhSelUwS0tyQzZqdFEr?= =?utf-8?B?QnJXSTVSak04Szg2TjNJUkRxSFhaVDZsWE1XMWVVZGNJRGhLMzd1NnA3Qndo?= =?utf-8?B?dXVrWDc5WURmOVdVY2czcmUwYm81WDllUzF4d0UwTkVINHg5WVNhQXp4aHRZ?= =?utf-8?B?Q0lzOXRjZGJZZndoemd1TkFrOHQ0UEUwTjNnRzJTUXdyd0RiYzdlZWVIb3Zm?= =?utf-8?B?NUR4ajRZTjJnanVSM1NVZWZnSjJwM2g1cTVOR2pSQ2tsQXpPWFlJb2dFdE5y?= =?utf-8?B?b05UYlVubU1iK0hTdENZcVc1ODg3WVo0b2prZ2p3Lzg5R0h2VzhZS2VxVWgz?= =?utf-8?B?QTZvdVgvbVN6OEdiMDRQN2JNTVdwY05sM294amlGYXc1eXpGeU01VXlucVpM?= =?utf-8?B?RnRsbHBsWW4rRWd5TkVzajB4anZjWE1DSGVyeTZJWFpVTzRZTHR4ZGJQLzFv?= =?utf-8?B?S0JZUGkrNXptZ3BFekhOY3J4Y0ZBWEhxcmd4T0ZHcTBlQklpYWZtL05odGJ6?= =?utf-8?B?cU9hc3I5eUU5N0JKVmU3aG9NZWNIampmanlXS2hjTFpoeUg4WjljU0g4QStN?= =?utf-8?B?d1ZvT2E4STJRc2l4SEhRUTJOQ3F6dmJrbTZyNWhGUFhCNFNGYnVoQVRpV0JF?= =?utf-8?B?ZmFPekx2NkNyck5YZUltUXlsTzNWbEdEM01vSlVwVkVkL0xBNk5RRkxDV3Zk?= =?utf-8?B?UjVKRHBmd204QjJNMzFEVjlOR3B0SkhOdzJTNjczdW5KWWs3VUFmUzVneWt0?= =?utf-8?B?UEIzYU5oRmJyQzB3Y1RVQ1JhZlZtMTF5TEI3dGN6YVVBVzJYaTdQdExiUXR3?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7dfc93a1-66df-46cd-6554-08db927b8c38 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:39:13.6297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u9GSFDtQBQSYdz//Lj4ISlNA9qP0la3adIRMSDbc2gI/CvJvhpLmuPZ9Ufs6kcVrOmhqPdUQKZQpb64+KW2o0yCL+ZiWSoTavqbeBB3l9xw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4552 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson > wrote: > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > > Hi Bruce, > > > I see some failures for this series for our Ubuntu 20.04 containers. > > > > Hi again, > > > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed, > > everything seems to build ok. > > > > Looking through the logs, though, there does appear to be a difference in > > the configurations in the two cases. I suspect my Ubuntu has an updated > > verbs package compared to the image you are using. In the log of the failed > > build, I see: > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > > Configuring mlx4_autoconf.h using configuration > > > > While building in my VM, I have: > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached) > > Configuring mlx4_autoconf.h using configuration > > > > So my verbs mlx4 header has got a different set of definitions to those in > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package > > version "28.0-1ubuntu1" > > > > Can the CI image be updated to latest 20.04 packages? > > > > /Bruce > > > > I can reproduce the issue seen at UNH, with a 20.04.6 container and > the same libibverbs as you: > ii libibverbs-dev:amd64 28.0-1ubuntu1 > amd64 Development files for the libibverbs library > > So I suspect something is different in container images.. > > Pasting the (hopefully) relevant meson logs: > > Running compile: > Working directory: /root/dpdk/build/meson-private/tmp0ovvvd9g > Command line: ccache cc -I/usr/include/libnl3 > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c > -D_FILE_OFFSET_BITS=64 -O0 -std=c11 > > Code: > #include > void bar(void) { > struct mlx4_wqe_lso_seg foo; > foo.mss_hdr_size; > > }; > Compiler stdout: > > Compiler stderr: > In file included from /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c:1: > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t' > 176 | off_t uar_mmap_offset; > | ^~~~~ > > Checking whether type "struct mlx4_wqe_lso_seg" has member > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > Thanks. I'll dig some more.