Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote:
> On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote:
> > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > >
> > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > > >    Hi Bruce,
> > > >    I see some failures for this series for our Ubuntu 20.04 containers.
> <snip>
> > >
> > > Hi again,
> > >
> > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > > everything seems to build ok.
> > >
> > > Looking through the logs, though, there does appear to be a difference in
> > > the configurations in the two cases. I suspect my Ubuntu has an updated
> > > verbs package compared to the image you are using. In the log of the failed
> > > build, I see:
> > >
> > >         Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > >         Configuring mlx4_autoconf.h using configuration
> > >
> > > While building in my VM, I have:
> > >
> > >         Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > >         Configuring mlx4_autoconf.h using configuration
> > >
> > > So my verbs mlx4 header has got a different set of definitions to those in
> > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
> > > version "28.0-1ubuntu1"
> > >
> > > Can the CI image be updated to latest 20.04 packages?
> > >
> > > /Bruce
> > >
> > 
> > I can reproduce the issue seen at UNH, with a 20.04.6 container and
> > the same libibverbs as you:
> > ii  libibverbs-dev:amd64               28.0-1ubuntu1
> >   amd64        Development files for the libibverbs library
> > 
> > So I suspect something is different in container images..
> > 
> > Pasting the (hopefully) relevant meson logs:
> > 
> > Running compile:
> > Working directory:  /root/dpdk/build/meson-private/tmp0ovvvd9g
> > Command line:  ccache cc -I/usr/include/libnl3
> > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o
> > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c
> > -D_FILE_OFFSET_BITS=64 -O0 -std=c11
> > 
> > Code:
> >  #include <infiniband/mlx4dv.h>
> >         void bar(void) {
> >             struct mlx4_wqe_lso_seg foo;
> >             foo.mss_hdr_size;
> > 
> >         };
> > Compiler stdout:
> > 
> > Compiler stderr:
> >  In file included from /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c:1:
> > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t'
> >   176 |  off_t   uar_mmap_offset;
> >       |  ^~~~~
> > 
> > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > 
> Thanks. I'll dig some more.

I think the meson version may be the culprit here. In my meson log I don't
see the -std=c11 flag appended to the test compilation command.

Let me downgrade my meson version and see if I can reproduce.

/Bruce