From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA1C342FB2; Tue, 1 Aug 2023 15:08:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F0F040F16; Tue, 1 Aug 2023 15:08:58 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 13CDB40A89 for ; Tue, 1 Aug 2023 15:08:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690895336; x=1722431336; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3lNI+Gi3xgEfqZuEFnWhbmJRqMuTNHKJ0UiRTamxoEc=; b=FR+yigtjaTeUE/3dAVqWo+jsDGpoK8Pdi27UNwGttj4v+Plth0y/VdT9 fAFVa8TYNV6cPUJC7MaNw+TgA/PJraOUjVIZbFVwCxL4/VE5ehc+EqFop kzIBG4xhJL00hn+9la804eEMPTg0klKzJWy9QTbrbUJVdP0h4glHYUf6/ mYGzPjnL5DT1IBy3Na6Mx4E/QgcTBc3eTmTqPlrKg8Gy6hHPs05bG6Q96 7U6qgdYXYG1FfSpeAJzM6UPtWGAkqM+9wLE02vbE8DFybNJCz548O4bcA HISbU1LzAt294rLieCWFDVRJHqQ1eT23UXL8cJ37xV7BkVFWPOh68QI4B Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="348884258" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="348884258" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 06:03:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="731969294" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="731969294" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 01 Aug 2023 06:03:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 06:03:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 06:03:54 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 06:03:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bf1LaBVR8ihj7AGO1AWexfkFDcLmU99ShBbnUP9YmODD6QUMjb1tN2UV1a8WFFxdzPnc93UiOBHhHLbUyUnJFlGSWc7JxbuB4WPVuntu8x419fBHWjVBR9mNbng7eSOlxvoIMpcOpEarFXSR2vwFOrtHjBhTXTUEML3Q2Sx9D0mzrLUsEUhANiphBtdrkiMVo3sowNPTMSD/dBN/ONxinzuYyWt+GTK60XpJJLVv74pDsS4rq6NNSG5fnDWMDVmc1O1Sis+eBNNeCCC1m7/J9ezlgUoj5eiEAaJ3Roi+qP9Zemad2GG31LFkHBmdVVhZzd+8Mzj7h9PaL7I41WFDTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HCYNbAblZ/0hoLnqIlDcVwIhJ592zU4bJPnK7RAYkqY=; b=QJAQTgBBHmBj6ELnzj09ZH+YGqgicq35SxxOANwEugpVIWTVp7+tUVILW/KeuF7eDlSko8F8INvJ5KbjIMU8HiI6Z3d2ddYrVX+stCPzg9kvhiFlEEzWsVLb0xa1s/AqylPSK3+gP8HHOxP9I94hLjrtHi5e3g7f9MpN7/Rc1NcWY3KYLbkzYVrSaoZN6PYXXRPitcpGTdomFDiTEvXOZB1eQjhNToLo2Cy6Y8rTODcX1JmOFu9FnFRjIls+LBao9nC8FqnpKqUqPwVuyMe+wJw1gnhEHhPQjvHqu547R2TvfUmLmcsKDJpW2B9bqDQNg0X0vdmbapES1nzvXtvFrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7498.namprd11.prod.outlook.com (2603:10b6:510:276::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:03:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 13:03:51 +0000 Date: Tue, 1 Aug 2023 14:03:43 +0100 From: Bruce Richardson To: Ali Alnubani CC: David Marchand , Patrick Robb , Tyler Retzlaff , "dev@dpdk.org" , Morten =?iso-8859-1?Q?Br=F8rup?= , "NBU-Contact-Thomas Monjalon (EXTERNAL)" Subject: Re: [PATCH v3] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731165810.3086571-1-bruce.richardson@intel.com> <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0076.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: ed1c5adf-fca8-4cb2-a84d-08db928fc076 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oZxHSpljeO7YgGeu3aFjh+cmxDJbEcys3NAwMFfI/qCX14F0Ie1bC+d2o27KkillSoIXITr5uQznL/cpFj2em40Cuq1HmYkgKu/mLNi+prWJs+4zLjOS6xFSqMsIxNFKl9bf1YKbTwN3aWLKylD3PcWYloXbajfxeKUXiz10N6IZL54xtk2HkdJfGybevMnDIcfkIT9xUsy/jOuGnLLZfYYcxK6K7uLCoHzWmXpU1rpnquPIDG8JV5lunhk5s/VT+Xiw0ezO+1EmY7kZlxEnUNqlU8kh5uweQikztumpG8vrXM7X6lHsK2txkT1VjO5ewUowWSFaJhH575Isppkbpzkys656qn88g2lq3bNYACNMnX7+tnXlBaXZW9w7VnXIg+fGkzjaI9PVJgwZ8h2FIjxjsao3RXTy5rp8kFEiqJaRv+HIJaXACBddxqYpGWo7XjCLzBzQB1gaPg2cOCVcT9+RC4Z445UtT1HImuFXBdBQ3mBvv4nsf1gCmDS4vUsD5btjv64nNoibak+/4ojvU9fEAZlu7qlMtP7CzJdOBYA4uGZEDoxI89RYLAzG6hpf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199021)(2906002)(4326008)(6916009)(83380400001)(66574015)(186003)(316002)(44832011)(38100700002)(41300700001)(15650500001)(478600001)(86362001)(6512007)(54906003)(82960400001)(5660300002)(66476007)(66946007)(66556008)(53546011)(6506007)(26005)(6666004)(8936002)(8676002)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTZBVDNmdmhaYWovRXIxd0QvWm1CTGpHNVYwWGVqK29mM0Y2eUcrTEJucGJy?= =?utf-8?B?RkQ5U2dWMGVzYlloR29mRFh4dTJiajlrUXNZckExQStLaERNK2dKcHZpUzRo?= =?utf-8?B?N2pqdDFnVzhISERCVWY0QStFWjhRUXNERWhiVDBWa0ErZ2RUb0RMS0VIQ2pM?= =?utf-8?B?ODNpMG0rN0syU0lZbDlvQWQxN0s4bThZdmVBbVloZHpmRG4va0N6R004WmE0?= =?utf-8?B?bEx3SkdwTmpvaHFGSGI1aEVoang1eGR3a0g2cHhLZGZsdkRndkdqbGtKZXhD?= =?utf-8?B?c1lkYkVKdU45allMNXplcWM0RHhLWjlTRlYrd3N0T3FFYXN4VGlnUlJJNHIx?= =?utf-8?B?Qm9zd0lGc25wMWdNNDAzM2N2Mm1zMWs0aURVeE4vWE5XbUJwbngxVlZnblZP?= =?utf-8?B?d2JIdW1GL0hvQWozWVJuNkl5NWw0SG8wNWRRTDlLdDYzTGRJYldXcmtvWW5B?= =?utf-8?B?dGg5aGMwcnRiWmhxbVE3RlRETENHNUcxNWdIcWR2UlJPUXI5T3U4RElCbVh5?= =?utf-8?B?TXd2UTdrSHpBTHBBYTR6VlQ4eGRJd3ZJZzFVSVo4eXBYaTNOT3U5MFE5Szc4?= =?utf-8?B?WGVwRUdQMDRNNUczbTRndjM3cWEva0wzMWtUbmdTUWVVQ1V5dnQ1TjNjZ3Zu?= =?utf-8?B?cGRhOHZob0V2aWdHSll6OENDQUFXODN4WWVBVVhxN2x5dG8rd3N6U044V0tp?= =?utf-8?B?S2JFUEQ4VC9lWEZGZTVoa0dqampsUFJBcndpNVpGUWsyYlZNRzBVZVRsaWNs?= =?utf-8?B?TjNtcGZ0MGUzczN5Y21Fa0dNRDQvdEE2VXR1SGpEUXZGeHREZWRtWkc2Znhz?= =?utf-8?B?anNVdGlSR3VXbE8zUlVGbzZmc2F0TlczVkZrWGIzT0ZWYVZtRGUwdGJkSzdI?= =?utf-8?B?VFN4ZktRWkdVYUFnZGlyR0JtNm9KOWtqOC9VNVpFR2hmS1M4dUVIYkJBWXNW?= =?utf-8?B?OVlJbmpWM2dCdUdPaTVudDlkdkpkQmhFVzNxM2NSWEdaYTVCOHJhNnl4eC9o?= =?utf-8?B?aG9oU09iWmlRT0VlY25Nd211WStObm41MDNkbVZhanV6ZnkxZ3IwY1VwNEk0?= =?utf-8?B?VXZVUXZ5YjFRL2ZONm1HVGp1QnlzclBHbHpldC81dm50V2QvcHpUakc5Zjl3?= =?utf-8?B?UDNDREY3RnVmWG52bHU4QzlSam10Vk1KWkZVbUdyWkxYTWJab0FzUnRvVDNl?= =?utf-8?B?MjU3L2pKOXZtOElsZmhScGs4TkkvR2VHUGQ0TjBDVEdBMjF3aW9KQVRvQVFW?= =?utf-8?B?V2pFNTE0RzIwa3RQWThHTk56S3dzei9mYk9ZNlR2bkF2VXZ0U2tyU3VYRFBF?= =?utf-8?B?SjdEKzVjSWFFNHkwOFdvNXRDQXl0d0xRSWRPMEhnMzY3S0hZanQyUGdTZUNO?= =?utf-8?B?Z0lSaHNBaWpuSVdoYi9wMDh2R0IralVjSER5Vm13elI5NitWMTVHV2NkSUZx?= =?utf-8?B?ZHNsYkgrbDZvbzJobGxGaUk0WjYyN1JsaUE0ME1HejBsQXdOdFkrSEtTMklB?= =?utf-8?B?WnVKb21XcTRBeG1JRXQ2ZmxJY2szL1FSUmkyZDNoQi82WGg4NUJtSmxxbC9R?= =?utf-8?B?UlQzY0ZtTlJTSGhFM3EreFQ0M2U2eWVRY0liM3N2QlhaZjByYmV0U0tZbWZu?= =?utf-8?B?STZ1Vm43YWNxUnVXNlBCTG9zcll2WEZpUmgxSnRsY2dRSFpyQUVBblBqNE4x?= =?utf-8?B?T1BjTHBUeEFoWHZkbjVabHRoSnkwQ0R6NDhkd01HTVdMMUlhajRPTlQ2QnN6?= =?utf-8?B?OGIzak9Db1ZSc2JtNnBmS1VZSnNpL3hBbWhCYytJZXZZRWtsUmVFMEw4cVlF?= =?utf-8?B?bnFRdEZGQ3lkTHJSWDBHczN3MEVKTGFMaHUzeU10TVdaQ2xBUnRFVVhZdHR3?= =?utf-8?B?K1k5WXBjZElVQW5OUThNSXRWMy90c3ZiaDRJRU8vYmpDTFY1VzF2ellQYmF2?= =?utf-8?B?WmJEZUVHajFxcWpGY3ZEcUlhUFZwblkva2Jicy9pdFlyR2lMbE42aXV4REFt?= =?utf-8?B?Vk15em41cUhOUDVRNjJvKzB4Z1JJdW1nNHM2NVNzOE4yUkNYbWFSU2xkeGVM?= =?utf-8?B?ekhWZ3UyRlRMZUlCZlV2ZHcyUGJ1ZDJtQVFPNld6NU9GZEhpMFZReUlBWStH?= =?utf-8?B?UE9kZ3A2bG5xbGFmeHMxRU05VC81MVl5dHZVQW5BVXFkN0JuWVFJSVdicml5?= =?utf-8?B?TVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ed1c5adf-fca8-4cb2-a84d-08db928fc076 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:03:51.2690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kMZNkMlfIEjlWYYyeQpApgCC/QGYNCGP8G+g2W84UcNu+N5TIOHyJZKhV1jVRUvVAku1i1MmtrJog/Ia6K/KUsab8DCrmIrsu7rwDNuQ0z4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7498 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 01, 2023 at 12:42:36PM +0000, Ali Alnubani wrote: > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, August 1, 2023 1:51 PM > > To: David Marchand > > Cc: Patrick Robb ; Tyler Retzlaff > > ; dev@dpdk.org; Morten Brørup > > ; NBU-Contact-Thomas Monjalon > > (EXTERNAL) > > Subject: Re: [PATCH v3] build: update DPDK to use C11 standard > > > > On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote: > > > On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote: > > > > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson > > > > wrote: > > > > > > > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > > > > > Hi Bruce, > > > > > > I see some failures for this series for our Ubuntu 20.04 containers. > > > > > > > > > > > > > Hi again, > > > > > > > > > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed, > > > > > everything seems to build ok. > > > > > > > > > > Looking through the logs, though, there does appear to be a difference in > > > > > the configurations in the two cases. I suspect my Ubuntu has an updated > > > > > verbs package compared to the image you are using. In the log of the > > failed > > > > > build, I see: > > > > > > > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > > > > > Configuring mlx4_autoconf.h using configuration > > > > > > > > > > While building in my VM, I have: > > > > > > > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member > > "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached) > > > > > Configuring mlx4_autoconf.h using configuration > > > > > > > > > > So my verbs mlx4 header has got a different set of definitions to those in > > > > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev > > package > > > > > version "28.0-1ubuntu1" > > > > > > > > > > Can the CI image be updated to latest 20.04 packages? > > > > > > > > > > /Bruce > > > > > > > > > > > > > I can reproduce the issue seen at UNH, with a 20.04.6 container and > > > > the same libibverbs as you: > > > > ii libibverbs-dev:amd64 28.0-1ubuntu1 > > > > amd64 Development files for the libibverbs library > > > > > > > > So I suspect something is different in container images.. > > > > > > > > Pasting the (hopefully) relevant meson logs: > > > > > > > > Running compile: > > > > Working directory: /root/dpdk/build/meson-private/tmp0ovvvd9g > > > > Command line: ccache cc -I/usr/include/libnl3 > > > > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o > > > > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c > > > > -D_FILE_OFFSET_BITS=64 -O0 -std=c11 > > > > > > > > Code: > > > > #include > > > > void bar(void) { > > > > struct mlx4_wqe_lso_seg foo; > > > > foo.mss_hdr_size; > > > > > > > > }; > > > > Compiler stdout: > > > > > > > > Compiler stderr: > > > > In file included from /root/dpdk/build/meson- > > private/tmp0ovvvd9g/testfile.c:1: > > > > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t' > > > > 176 | off_t uar_mmap_offset; > > > > | ^~~~~ > > > > > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member > > > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > > > > > > > Thanks. I'll dig some more. > > > > I think the meson version may be the culprit here. In my meson log I don't > > see the -std=c11 flag appended to the test compilation command. > > > > Let me downgrade my meson version and see if I can reproduce. > > > > /Bruce > > Hello, > > I see two other build failures. > > On Ubuntu 20.04 with clang 10 and rdma-core v47.0 (built from source), I see errors similar to these: > > drivers/common/mlx5/linux/mlx5_glue.h:58:6: error: redefinition of 'mlx5_ib_uapi_flow_action_packet_reformat_type' > [..] > drivers/common/mlx5/linux/mlx5_glue.h:59:6: error: redefinition of 'mlx5_ib_uapi_flow_table_type' > [..] > drivers/common/mlx5/linux/mlx5_glue.h:121:2: error: redefinition of enumerator 'MLX5DV_DR_ACTION_DEST_REFORMAT' > [..] > I believe I have a fix for these. The checks for the various structure members need the driver "cflags" passed as args to the check, as the std=c11 means that some things like off_t type are no longer defined (off_t is posix) > On Ubuntu 20.04 while cross compiling for ppc64le with powerpc64le-linux-gnu-gcc 9.4, I see: > > [..] > lib/acl/acl_run_altivec.h:44:16: error: two or more data types in declaration specifiers > [..] > lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec types is invalid > [..] > error: incompatible types when assigning to type '__vector unsigned char' {aka '__vector(16) unsigned char'} from type '__vector __bool int' {aka '__vector(4) __bool int'} > [..] > lib/acl/acl_run_altivec.h:66:4: error: invalid parameter combination for AltiVec intrinsic '__builtin_vec_sel' > [..] > This I still need to investigate. In the meantime, I'll do a new version to see if the Ubuntu 20.04 issues with the mlx drivers goes away with my fix. /Bruce