From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D8E042FB2; Tue, 1 Aug 2023 15:29:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9924F40F16; Tue, 1 Aug 2023 15:29:33 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C73E740A89 for ; Tue, 1 Aug 2023 15:29:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690896571; x=1722432571; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kwkghhLjYtoIX/HKr4mHx0BvT3swhCVGVDq86GEt1Vg=; b=C0k/xZXYlA05R4su/+b/QEnwVrWmFfD7Zn0k7Q+JHHk29ioTZQKtasd1 UBBW+1zRqpFsw2AAVBMuQ5LhrdrT9DVyrWHwRVXw8blO1Mm5ynlu/D1P4 3B04xhtEmsuP+CTq3Tjbxu5Emm6D+4OGzifAEU6Z8GPtSwgj5piiEuQbe DMM0smnsdtg2A4OB1o0gqaR5WBc4Mbc4yfIsR46bh/HAICqgHJ+7QkA27 TVjT0Dq7a8Q4fH0fIrC7r3WXZytyjeHM2rAWqYpESchdt7Y9MV5F9iP+s McjiXOZl9xCuGZdlE7PjLPn9xD2/3rrDDiMOu221Tc1uY4nersXkFiv1m w==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="354223607" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="354223607" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 06:29:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="794187836" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="794187836" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2023 06:29:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 06:29:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 06:29:30 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 06:29:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4CQL5zl4TnDM+3ddgsj09BaDOr9eStqOuqOVLjoKXhTyJQD3kjbtRNkzeqCAdrKFLrVDDYu10MpjhDMX456NXhwvI1ISicJuGfZDuLhZXQJiHG4ENe85+M5pn1eP7/uEqYB6R0SxvWVoBiEOBOWTw8QsypFKIXu2XcUOmsuRyLnVD7L1wcyr9rtF3Y+RCFXDUEy1FNy09DuZloMcci1ho1RtrntcW6j0D2JPUq4TEWzjEVIXLej7EIevNPHkP98HUKke8xZiI+LuFscoIMYo09VM/GibrzVd/yE34Aok2TOG6Xlo6rBx7TxhV2mlViCLLzrM1LmQvFZhKbs8CVGMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/zmgG3nGfOjotTtNi0Ti+JNgY/mzKeA8Ox2L5vw2ov0=; b=KriM9aiw4QaLXSV7tceOTZascUduLlcRkSMdmQZwlxGIYpFBWODAM2lTkvCAtZiMz8+SG8X9NsvaPHz6ZnVH6/CP6iWuea64L5zF3R41KvQDB+C3HwjwtOxU0YPWX7l8Tnss/n3mg6S2BaiBClyNdLo8O0UgcRQZaolathY4bMb4XcsxCYHmFy8J6kF7bJyTK4P7pG6jSXP/vhHBr9J4F2Q0G5cCGhrr9Q8DVQjx8wZcQ7Yl4ClLL6WiP3MqSdTyR4cVJU8DdUxcmjaevjy+H6b9gfZN/DWmGx7jSq4g3awQVh7ZGmkJBfEojQX7fWd1u6/xQ9+hN3heJ0hUUs6N/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5337.namprd11.prod.outlook.com (2603:10b6:408:136::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:29:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 13:29:28 +0000 Date: Tue, 1 Aug 2023 14:29:21 +0100 From: Bruce Richardson To: David Marchand CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Thomas Monjalon , Ali Alnubani , Raslan Darawsheh Subject: Re: [PATCH v4] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230801131549.323733-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0273.eurprd04.prod.outlook.com (2603:10a6:10:28c::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5337:EE_ X-MS-Office365-Filtering-Correlation-Id: b0e50a78-11f7-4363-d9ed-08db9293547d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yBhzc8jU8/GdqOi7Tw0B//+Vk1U3q3lL2LHk/CH3Ue6m+q2OpfLHKlSZZF/9Gw/DzN6kCJ6uKrrB+0sybP3iG1WsASqavE0sQVkcqfb1WIFkr5joka6u3z7xSO1S2CdfdWdzfaewpAImDuiGWBWcJDbgfjbDguVQI6fpKPhXBVwrQGCsekXL/6YFa2biLwY4JfdQr8CuKrUeuK3ruvzX6IvT29orKKmUIW8BF+JuEyV7ogYbJjvYsi4QaCXl1QL2wEoX4oXjq3jPUAb9Rmz8TmbMYUPvhlNWVWeg3ZhRaP0UIx5iBY2RMunt9NLWTLt2Vf5lniWEXJUQWorvsWJGjNXJo4QzrwKJdPiE01Hp3FvO4PxNyr5oCOtrulVTk8SKIwrg2bVR97Cr7BnOSR+eAaevFQ+4xXl7msol7vJJtos5yh8qiPWYtK+B8uFHvQk+0Md6zeli2yttkcewnRlnASAd5tFQK39EBsOznN3TD+vGgY+4MI4k6hMfOgove6dKExH77xaNWBU0T9jnxTO7nDQR/24hE9ZaFKAR4PNYXTozvSQXsBtK8kBRQxqqNOfYq8+eTGZgQhOROLW7MtvYzntZkzln4JdJElMKazPqJcqMFrKpdDmNkcFxD/MIIT3uckKM3E1Om2UOp1DJTgdCLA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(376002)(366004)(136003)(39860400002)(451199021)(66946007)(66476007)(66556008)(4326008)(6916009)(316002)(6486002)(6666004)(6512007)(966005)(54906003)(478600001)(186003)(53546011)(6506007)(26005)(44832011)(2906002)(86362001)(82960400001)(41300700001)(38100700002)(5660300002)(8676002)(8936002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWpXQ0N6ZVd5ZG95WTFmVG1sKzdDRnQ0RERseHhWT0lIWk0wRFZpNmF1eStE?= =?utf-8?B?amg1SDVoNmtTdXJycUh2eG5KcDZUd0hTaTU1QlVYUFQ1K1lOeGU4RnpCdlE1?= =?utf-8?B?T1djTytLdHJUZ0s3UGlOMWY1NXFRMzJvd2hUVjlFRkNUcVFtUXNoNlNiNW1U?= =?utf-8?B?RWNYa2xIbmhKMlFkSityRUtUdCt2VngrSkk5MnkzeGhFa2NzdGlabldRVG5D?= =?utf-8?B?Ym9RZHFFdHBqM2FUUjN0dSthNys4SUNXdjM5S2NScTQ1dXVYV2F0b2UrQ1o5?= =?utf-8?B?dDJpcTlxSjVkK2VJUmRxRUVsU1lwd2NJaUN6TmdISkxaQXlEMG5vb0RGL0Vv?= =?utf-8?B?c1VDbkE2OUNWMXJMVGtINUQzanBqcFBsVStFdFArYUkzWUpZa1VScVYyQmNr?= =?utf-8?B?VC9wMnd3UXpMTFhZT3RLbXRFZjNUYWRvbXFweUdtTzZIZ3FaVXBlaC9ZM3Mz?= =?utf-8?B?dW1UcWlyQStZREluTEdSVDVXRmxwcDN5NHBFcWZESDU4a0lDYXk3WmNzbGVN?= =?utf-8?B?bjAzU2ZuOHFRTWhSblNUZ1M5S2pzY3VzdkZVUm9sRHRQNTQrdi82WEIvRWV6?= =?utf-8?B?NGZ2amM4UDN3MGhjK2hxVy96NHVUcE52eEJjZmdzcHQyRmZxZGo0Q0V6dWUr?= =?utf-8?B?SUkveGNNbm5qQm00RHgrRm96bFNkdFVLYjh0Qi8ybUtBU1RWZHoxVlh2ZnYz?= =?utf-8?B?UlAvTi9qM0tTME9BYm1vQ3k3dDRNUUNOSXFOSVd6M05hVWlHRlBUYUZyMXgz?= =?utf-8?B?eTRWendtOE9EMlY2azVucUVNRmZCWlg2YnpnakxmNm9vUXppYjVDR3lwci9o?= =?utf-8?B?MHl1RWtOSk5MOTFvVDlDSVkrUVZjY0RDc1p5NHFmd25kaTFMcHgvR1hlTFJm?= =?utf-8?B?NVUrTlZJYnVORlk4UzNIUWlaR3NHNkJKR0Y3NllhOFpRbmxPMStJRlRBOVo0?= =?utf-8?B?ZEpQdTFRTTBwdFVPNnlJVGxYQ1haWjBBb2p4UkV6ZVFTMjM5bWFHbmtPTkxq?= =?utf-8?B?TjFoZ3d0Umx5djlWSCszOWlEcDZYdmZHK2RkMy9CWGNuVVpaTVcxZ1RTVkhz?= =?utf-8?B?Y3haRCtPbm9YVjFLZDBFUUpZbzZSNWlMMVFMUjVNZExKY1B4MUtGWEM4TCtV?= =?utf-8?B?c05xT1BZMXlsbUNxOWNyRFdJNjNQUk1CbVc4WlAxV2l5VmNydDBKSmtYWnEy?= =?utf-8?B?MTJ3ODZDNTRoSHNPUzlZQ2ErYlFrazRtbXJqcElWUVZhT2VJai8ycENzOUtx?= =?utf-8?B?R2h0QmwyNHNZQUZxRlphM3dneTU3SDlsYzRhdUF6WkM1MHJ0SUNrSkxFd1dw?= =?utf-8?B?T2tVNENxYTNhV3RVQ05VTTVYNVdRR0lFT2I2Z2NlcWNRS0dQNWxDZ0JTcjYv?= =?utf-8?B?OUZERkFLY3FiMkZaQlNxQTJ1cDZmTFVqaGNJTzRmem4rcHBoVGJ5WUxBTmJO?= =?utf-8?B?a2x0aFlqTWN2RmlKM3lhMHBWRTcvbStjYzdFYVh0YmIxdmtUcmxOaGdYVE9P?= =?utf-8?B?WFVrT1JTSFhsRWlwT1ZscVl6ekFwcjN2TUc1aHc0eU01Sm9idlVGclRQRlpQ?= =?utf-8?B?YXY5Y05vZGE1ZHZZNFp3YVhXbWpYYnJiUm94QU5tajRVUTN6Vkhud0NORlZF?= =?utf-8?B?VWFuR0tpbFZhYXlDOC9uS0JUWXdlSUpRVGU1RU1OYXVCakk0bkE0STQ5SHZi?= =?utf-8?B?WGNENW12YWRvQnVacmhIcGUxUlhSUHZEVFNZYThtYm5JdncxQ3BiUXN0c1Fq?= =?utf-8?B?OXBKbTlVcnBKZnRocGxHcXpoclRZM2grRVJVb3B0aVl1QXdKR2Y3YytvUFNE?= =?utf-8?B?UmNMS2lIczh3elNZUUM0MzBySktXYlZ2eGpaN0lhSlRPQStuNldDUTAzMHNX?= =?utf-8?B?ZGJMNnlRSHR3c3pqWHhiUE5DbGxIWGc0bG9EMVphd0l1c2NwWGI2UHFsQVZj?= =?utf-8?B?NGtCaTlJZHhGOThqblllYjF2MTRBSTUyNHNpTDJiWjhXK0ZTRCtDengzQW9V?= =?utf-8?B?NTZraGRSUVV3WGdWT2EreUFkREVmLzJMRDBHOXpTQnRxYzhwTW9SOHNOUWJQ?= =?utf-8?B?STZOOW5zek5hejNHaWxKUURuMjR4WmtJWmhCcm9nTi9LWGVjS3BKbXVQZGwv?= =?utf-8?B?QXgwQ1A2bThFRzZMT1RFbTRlMHFvdzJaaTh3d2pNZkExQXh2QmtLMjFYUy9Q?= =?utf-8?B?NlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b0e50a78-11f7-4363-d9ed-08db9293547d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:29:28.0475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZRURz8qmm8wc7y49wY6M8M9U/cUqxf2G0ggCyNMrNtJ+WPSMf0n/aP9uY/SxqsR+6hYPemvvm26FI5qfntbktlnAD6Rf5Ae6tDb5q4o87SU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5337 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson > wrote: > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > compiler and will use the C11 standard in all builds. > > > > Forcing use of the C standard, rather than the standard with > > GNU extensions, means that some posix definitions which are not in > > the C standard are unavailable by default. We fix this by ensuring > > the correct defines or cflags are passed to the components that > > need them. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Morten Brørup > > Acked-by: Tyler Retzlaff > > --- > > V4: > > * pass cflags to the structure and definition checks in mlx* drivers > > to ensure posix definitions - as well as C-standard ones - are > > available. > > With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container. > However, I think the mlx4dv.h includes are probably faulty: as this > header is using off_t, it should include sys/types.h in the first > place. > https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4dv.h#L36 > > This had been fixed in the mlx5 header in some rdma-core change in the > past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5 > Even if that were fixed, I still think the correct behaviour in our build here is to test the structures using the same flags as will be used to build the final lib. /Bruce