From: Bruce Richardson <bruce.richardson@intel.com>
To: <dev@dpdk.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"David Christensen" <drc@linux.vnet.ibm.com>
Subject: Re: [PATCH v5] build: update DPDK to use C11 standard
Date: Wed, 2 Aug 2023 13:35:56 +0100 [thread overview]
Message-ID: <ZMpNrBfWRpCyWQNw@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230802123134.370199-1-bruce.richardson@intel.com>
On Wed, Aug 02, 2023 at 01:31:34PM +0100, Bruce Richardson wrote:
> As previously announced, DPDK 23.11 will require a C11 supporting
> compiler and will use the C11 standard in all builds.
>
> Forcing use of the C standard, rather than the standard with
> GNU extensions, means that some posix definitions which are not in
> the C standard are unavailable by default. We fix this by ensuring
> the correct defines or cflags are passed to the components that
> need them.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> V5:
> * Fix build issues with bool type in altivec code, due to bool type
> being in C11. Use __bool for altivec-specific version instead.
>
Just a note on the altivec builds: from my testing on latest ubuntu with
"powerpc64le-linux-gnu-gcc (Ubuntu 12.3.0-1ubuntu1~23.04)", there are quite
a few warnings/errors building the current DPDK mainline. This patch
doesn't fix any of those errors, but neither does it add any new ones,
as far as I can see! However, we may need some more PPC fixes and updated
CI coverage to catch these issues sooner in future.
/Bruce
next prev parent reply other threads:[~2023-08-02 12:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 10:38 [PATCH] " Bruce Richardson
2023-07-31 10:51 ` Morten Brørup
2023-07-31 15:58 ` [PATCH v2] " Bruce Richardson
2023-07-31 16:24 ` Tyler Retzlaff
2023-07-31 16:42 ` Tyler Retzlaff
2023-07-31 16:58 ` [PATCH v3] " Bruce Richardson
2023-07-31 17:05 ` Tyler Retzlaff
2023-08-01 0:39 ` Patrick Robb
2023-08-01 9:20 ` Bruce Richardson
2023-08-01 10:19 ` Bruce Richardson
2023-08-01 10:35 ` David Marchand
2023-08-01 10:39 ` Bruce Richardson
2023-08-01 10:50 ` Bruce Richardson
2023-08-01 12:42 ` Ali Alnubani
2023-08-01 13:03 ` Bruce Richardson
2023-08-01 13:22 ` Bruce Richardson
2023-08-01 13:47 ` Ali Alnubani
2023-08-01 14:00 ` Bruce Richardson
2023-08-02 10:10 ` Bruce Richardson
2023-08-01 10:37 ` Thomas Monjalon
2023-08-01 14:00 ` Ali Alnubani
2023-08-01 13:15 ` [PATCH v4] " Bruce Richardson
2023-08-01 13:24 ` David Marchand
2023-08-01 13:29 ` Bruce Richardson
2023-08-01 13:34 ` David Marchand
2023-08-01 15:47 ` Ali Alnubani
2023-08-01 15:50 ` Bruce Richardson
2023-08-01 16:20 ` Tyler Retzlaff
2023-08-01 20:12 ` Patrick Robb
2023-08-02 6:32 ` David Marchand
2023-08-02 13:40 ` Patrick Robb
2023-08-03 9:21 ` David Marchand
2023-08-02 12:31 ` [PATCH v5] " Bruce Richardson
2023-08-02 12:35 ` Bruce Richardson [this message]
2023-08-03 12:38 ` Ali Alnubani
2023-08-03 13:36 ` David Marchand
2023-08-10 13:34 ` Thomas Monjalon
2023-08-10 14:48 ` Stephen Hemminger
2023-08-10 16:35 ` Bruce Richardson
2023-08-10 16:49 ` Thomas Monjalon
2023-08-10 17:02 ` Stephen Hemminger
2023-08-10 18:17 ` Morten Brørup
2023-08-10 22:34 ` Tyler Retzlaff
2023-08-11 8:52 ` Bruce Richardson
2023-08-11 10:12 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMpNrBfWRpCyWQNw@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).